Skip to contentSkip to conversation

directfb: add host-directfb target for directfb-csource

PATCH New Sven Neumann 2 participants 8 messages Oct 2, 2009 – Oct 3, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 directfb: add host-directfb target for directfb-csource

directfb-csource is a code generation tool that may be needed to build other packages. Add host-directfb target that installs directfb-csource in the host_dir.

---
 package/directfb/directfb.mk |   52 ++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 52 insertions(+), 0 deletions(-)
package/directfb/directfb.mk +52 -0
index 5fc8868..d6b6bdc 100644
@@ -147,3 +147,55 @@ DIRECTFB_CONF_OPT = \
 DIRECTFB_DEPENDENCIES = uclibc $(DIRECTFB_DEP) freetype $(DIRECTFB_FUSION)
 
 $(eval $(call AUTOTARGETS,package,directfb))
+
+
+# directfb-csource for the host
+
+DIRECTFB_HOST_DIR:=$(BUILD_DIR)/directfb-$(DIRECTFB_VERSION)-host
+DIRECTFB_HOST_BINARY:=$(HOST_DIR)/usr/bin/directfb-csource
+
+$(DL_DIR)/$(DIRECTFB_SOURCE):
+	$(call DOWNLOAD,$(DIRECTFB_SITE),$(DIRECTFB_SOURCE))
+
+$(STAMP_DIR)/host_directfb_unpacked: $(DL_DIR)/$(DIRECTFB_SOURCE)
+	mkdir -p $(DIRECTFB_HOST_DIR)
+	$(INFLATE$(suffix $(DIRECTFB_SOURCE))) $< | \
+		$(TAR) $(TAR_STRIP_COMPONENTS)=1 -C $(DIRECTFB_HOST_DIR) $(TAR_OPTIONS) -
+	touch $@
+
+$(STAMP_DIR)/host_directfb_configured: $(STAMP_DIR)/host_directfb_unpacked $(STAMP_DIR)/host_pkgconfig_installed
+	(cd $(DIRECTFB_HOST_DIR); rm -rf config.cache; \
+		$(HOST_CONFIGURE_OPTS) \
+		CFLAGS="$(HOST_CFLAGS)" \
+		LDFLAGS="$(HOST_LDFLAGS)" \
+		./configure \
+		--prefix="$(HOST_DIR)/usr" \
+		--sysconfdir="$(HOST_DIR)/etc" \
+		--enable-shared \
+		--disable-static \
+		--disable-debug \
+		--disable-multi \
+		--with-gfxdrivers=none \
+		--with-inputdrivers=none \
+	)
+	touch $@
+
+$(STAMP_DIR)/host_directfb_compiled: $(STAMP_DIR)/host_directfb_configured
+	$(MAKE) -C $(DIRECTFB_HOST_DIR)/tools directfb-csource
+	touch $@
+
+$(STAMP_DIR)/host_directfb_installed: $(STAMP_DIR)/host_directfb_compiled
+	$(INSTALL) -m 0755 $(DIRECTFB_HOST_DIR)/tools/directfb-csource $(HOST_DIR)/usr/bin
+	touch $@
+
+host-directfb: $(STAMP_DIR)/host_directfb_installed
+
+host-directfb-source: directfb-source
+
+host-directfb-clean:
+	rm -f $(addprefix $(STAMP_DIR)/host_directfb_,unpacked configured compiled installed)
+	rm -f $(HOST_DIR)/usr/bin/directfb-csource
+	-$(MAKE) -C $(DIRECTFB_HOST_DIR)/tools clean
+
+host-directfb-dirclean:
+	rm -rf $(DIRECTFB_HOST_DIR)
Signature · 1 line
1.6.0.4
#1 lore raw

PATCH 1/1 directfb: add host-directfb target for directfb-csource

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Sven" == Sven Neumann <[email protected]> writes:

Sven> directfb-csource is a code generation tool that may be needed to build Sven> other packages. Add host-directfb target that installs directfb-csource Sven> in the host_dir.

What exactly needs this? I prefer to not add unused stuff. Could we wait until there's an actual use for this?

Sven> +$(STAMP_DIR)/host_directfb_installed: $(STAMP_DIR)/host_directfb_compiled
Sven> + $(INSTALL) -m 0755 $(DIRECTFB_HOST_DIR)/tools/directfb-csource $(HOST_DIR)/usr/bin

Is directfb-csource the only thing we could ever imagine other packages needing? What about the headers/libs for some other host tool?

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 directfb: add host-directfb target for directfb-csource

Quoted 8 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Sven" == Sven Neumann <[email protected]> writes:

Sven> directfb-csource is a code generation tool that may be needed to build Sven> other packages. Add host-directfb target that installs directfb-csource Sven> in the host_dir.

What exactly needs this? I prefer to not add unused stuff. Could we wait until there's an actual use for this?

directfb-csource is very similar to gdk-pixbuf-csource. It creates header files from images so that they can easily be embedded into the binary. I do make use of this in one of our packages. At some point I even plan to release this code under the LGPL, but for now its closed.

Of course I would prefer if the change could be upstream in buildroot, but if you don't want to add it, then we can maintain it in our branch.

Quoted 5 lines

Sven> +$(STAMP_DIR)/host_directfb_installed: $(STAMP_DIR)/host_directfb_compiled
Sven> + $(INSTALL) -m 0755 $(DIRECTFB_HOST_DIR)/tools/directfb-csource $(HOST_DIR)/usr/bin

Is directfb-csource the only thing we could ever imagine other packages needing? What about the headers/libs for some other host tool?

The other tools are actually useful on the target, but not likely useful on the host. directfb-csource is the only code-generation tool in there.

Sven

#3 lore raw

PATCH 1/1 directfb: add host-directfb target for directfb-csource

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Sven" == Sven Neumann <[email protected]> writes:

Hi,

Quoted 2 lines
Quoted 2 lines

What exactly needs this? I prefer to not add unused stuff. Could we wait until there's an actual use for this?

Sven> directfb-csource is very similar to gdk-pixbuf-csource. It creates Sven> header files from images so that they can easily be embedded into the Sven> binary. I do make use of this in one of our packages. At some point I Sven> even plan to release this code under the LGPL, but for now its closed.

Sven> Of course I would prefer if the change could be upstream in buildroot, Sven> but if you don't want to add it, then we can maintain it in our branch.

Ok, fine by me - Could you please send a patch against upstream git though?

git am -s3 /tmp/dir.patch
Applying: directfb: add host-directfb target for directfb-csource
error: patch failed: package/directfb/directfb.mk:147
error: package/directfb/directfb.mk: patch does not apply
fatal: sha1 information is lacking or useless (package/directfb/directfb.mk). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge.

Quoted 3 lines
Quoted 3 lines

Is directfb-csource the only thing we could ever imagine other packages needing? What about the headers/libs for some other host tool?

Sven> The other tools are actually useful on the target, but not likely Sven> useful on the host. directfb-csource is the only code-generation Sven> tool in there.

Ok, I was more thinking about headers/libs, if something we would need to compile for the host uses directfb, but we can add than when/if we need it.

Signature · 1 line
Bye, Peter Korsgaard
#4 lore raw

PATCH 1/1 directfb: add host-directfb target for directfb-csource

Quoted 5 lines · Peter Korsgaard

Sven> Of course I would prefer if the change could be upstream in buildroot, Sven> but if you don't want to add it, then we can maintain it in our branch.

Ok, fine by me - Could you please send a patch against upstream git though?

Sorry. It is about time that I bring our branch back in sync with upstream buildroot...

Sven

#5 lore raw

PATCH 1/1 directfb: add host-directfb target for directfb-csource

In reply to Peter Korsgaard

directfb-csource is a code generation tool that may be needed to build other packages. Add host-directfb target that installs directfb-csource in the host_dir.

---
 package/directfb/directfb.mk |   52 ++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 52 insertions(+), 0 deletions(-)
package/directfb/directfb.mk +52 -0
index 409f791..4175753 100644
@@ -150,3 +150,55 @@ DIRECTFB_CONF_OPT = \
 DIRECTFB_DEPENDENCIES = $(DIRECTFB_DEP) freetype $(DIRECTFB_FUSION)
 
 $(eval $(call AUTOTARGETS,package,directfb))
+
+
+# directfb-csource for the host
+
+DIRECTFB_HOST_DIR:=$(BUILD_DIR)/directfb-$(DIRECTFB_VERSION)-host
+DIRECTFB_HOST_BINARY:=$(HOST_DIR)/usr/bin/directfb-csource
+
+$(DL_DIR)/$(DIRECTFB_SOURCE):
+        $(call DOWNLOAD,$(DIRECTFB_SITE),$(DIRECTFB_SOURCE))
+
+$(STAMP_DIR)/host_directfb_unpacked: $(DL_DIR)/$(DIRECTFB_SOURCE)
+        mkdir -p $(DIRECTFB_HOST_DIR)
+        $(INFLATE$(suffix $(DIRECTFB_SOURCE))) $< | \
+                $(TAR) $(TAR_STRIP_COMPONENTS)=1 -C $(DIRECTFB_HOST_DIR) $(TAR_OPTIONS) -
+        touch $@
+
+$(STAMP_DIR)/host_directfb_configured: $(STAMP_DIR)/host_directfb_unpacked $(STAMP_DIR)/host_pkgconfig_installed
+        (cd $(DIRECTFB_HOST_DIR); rm -rf config.cache; \
+                $(HOST_CONFIGURE_OPTS) \
+                CFLAGS="$(HOST_CFLAGS)" \
+                LDFLAGS="$(HOST_LDFLAGS)" \
+                ./configure \
+                --prefix="$(HOST_DIR)/usr" \
+                --sysconfdir="$(HOST_DIR)/etc" \
+                --enable-shared \
+                --disable-static \
+                --disable-debug \
+                --disable-multi \
+                --with-gfxdrivers=none \
+                --with-inputdrivers=none \
+        )
+        touch $@
+
+$(STAMP_DIR)/host_directfb_compiled: $(STAMP_DIR)/host_directfb_configured
+        $(MAKE) -C $(DIRECTFB_HOST_DIR)/tools directfb-csource
+        touch $@
+
+$(STAMP_DIR)/host_directfb_installed: $(STAMP_DIR)/host_directfb_compiled
+        $(INSTALL) -m 0755 $(DIRECTFB_HOST_DIR)/tools/directfb-csource $(HOST_DIR)/usr/bin
+        touch $@
+
+host-directfb: $(STAMP_DIR)/host_directfb_installed
+
+host-directfb-source: directfb-source
+
+host-directfb-clean:
+        rm -f $(addprefix $(STAMP_DIR)/host_directfb_,unpacked configured compiled installed)
+        rm -f $(HOST_DIR)/usr/bin/directfb-csource
+        -$(MAKE) -C $(DIRECTFB_HOST_DIR)/tools clean
+
+host-directfb-dirclean:
+        rm -rf $(DIRECTFB_HOST_DIR)
Signature · 1 line
1.6.0.4
#6 lore raw

PATCH 1/1 directfb: add host-directfb target for directfb-csource

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Sven" == Sven Neumann <[email protected]> writes:

Sven> directfb-csource is a code generation tool that may be needed to build Sven> other packages. Add host-directfb target that installs directfb-csource Sven> in the host_dir.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#7 lore raw

PATCH 1/1 directfb: add host-directfb target for directfb-csource

In reply to Sven Neumann
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Sven" == Sven Neumann <[email protected]> writes:

Hi,

Sven> directfb-csource is a code generation tool that may be needed to build Sven> other packages. Add host-directfb target that installs directfb-csource Sven> in the host_dir.

Sven> +DIRECTFB_HOST_DIR:=$(BUILD_DIR)/directfb-$(DIRECTFB_VERSION)-host Sven> +DIRECTFB_HOST_BINARY:=$(HOST_DIR)/usr/bin/directfb-csource Sven> +
Sven> +$(DL_DIR)/$(DIRECTFB_SOURCE):
Sven> + $(call DOWNLOAD,$(DIRECTFB_SITE),$(DIRECTFB_SOURCE))

Hmm, this somehow had tabs replaced by spaces - How did that happen? git send-email normally doesn't do stuff like that.

Anyway, fixed now.

Signature · 1 line
Bye, Peter Korsgaard