Skip to contentSkip to conversation

reiserfs: possible null pointer dereference during resize

PATCH New Dmitriy Monakhov 1 participant 1 message Feb 20, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 reiserfs: possible null pointer dereference during resize

sb_read may return NULL, let's explicitly check it.
If so free new bitmap blocks array, after this we may safely exit as it done above during bitmap allocation.

-------------

fs/reiserfs/resize.c +4 -0
index 3156847..976cc78 100644
@@ -131,6 +131,10 @@ int reiserfs_resize(struct super_block *s, unsigned long block_count_new)
 			/* don't use read_bitmap_block since it will cache
 			 * the uninitialized bitmap */
 			bh = sb_bread(s, i * s->s_blocksize * 8);
+			if (!bh) {
+				vfree(bitmap);
+				return -EIO;
+			}
 			memset(bh->b_data, 0, sb_blocksize(sb));
 			reiserfs_test_and_set_le_bit(0, bh->b_data);
 			reiserfs_cache_bitmap_metadata(s, bh, bitmap + i);