Skip to contentSkip to conversation

cleanup iosapic.c

PATCH In review Satoru Takeuchi 2 participants 4 messages Mar 24, 2006 – Mar 27, 2006

lore
Share & tools
lore
#0 lore raw

cover cleanup iosapic.c

Hi,

These patches clean up arch/ia64/kernel/iosapic.c. The changes are as follows:

- [PATCH 1/2] correct some messages and fixes some some minor typos.

- [PATCH 2/2] simplify some condition checks.

For more specifc information, please refer to the header of each patch. These patches are against 2.6.16. I tested them on Tiger4.

Thanks,
Satoru Takeuchi

#1 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Satoru" = Satoru Takeuchi <[email protected]> writes:

Satoru> Hi, These patches clean up arch/ia64/kernel/iosapic.c. The Satoru> changes are as follows:

Satoru> - [PATCH 1/2] correct some messages and fixes some some minor Satoru> typos.

Hi Satoru,

When you are in there fixing those types of issues, it would be nice if you also fixed the parts you are touching to comply with codingstyle at the same time (80 columns and tab indentation). Not a big thing, just seemed a good time to resolve it.

Cheers,
Jes

#2 lore raw
In reply to Satoru Takeuchi

Hi Jes,

At 24 Mar 2006 05:26:02 -0500,

Quoted 11 lines · Jes Sorensen
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

"Satoru" = Satoru Takeuchi <[email protected]> writes:

Satoru> Hi, These patches clean up arch/ia64/kernel/iosapic.c. The Satoru> changes are as follows:

Satoru> - [PATCH 1/2] correct some messages and fixes some some minor Satoru> typos.

Hi Satoru,

Quoted 7 lines

When you are in there fixing those types of issues, it would be nice if you also fixed the parts you are touching to comply with codingstyle at the same time (80 columns and tab indentation). Not a big thing, just seemed a good time to resolve it.

Cheers,
Jes

OK, I fixed as you said. New patch is here.

These patches clean up arch/ia64/kernel/iosapic.c. The changes are as follows:

- [PATCH 1/2] correct some messages and fixes some minor things.

- [PATCH 2/2] simplify some condition checks.

For more specifc information, please refer to the header of each patch. These patches are against 2.6.16. I tested them on Tiger4.

Thanks,
Satoru Takeuchi

#3 lore raw
In reply to Satoru Takeuchi
Quoted 6 lines · Satoru Takeuchi

OK, I fixed as you said. New patch is here.

These patches clean up arch/ia64/kernel/iosapic.c. The changes are as follows:

- [PATCH 1/2] correct some messages and fixes some minor things.

Looks good to me!

Cheers,
Jes