board: ti: Add support for BeaglePlay
v3 cover board: ti: Add support for BeaglePlay
Add support for BeaglePlay - rev 3
Boot log: https://gist.github.com/nmenon/3e99b44380873263e39ba4d84788db89
Full series(including dependencies) can be found at:
https://github.com/nmenon/fix-k3-dt-u-boot/commits/beagleplay-v3
Caveats:
* I have kept networking out of picture for now as it is still in debug (See
https://github.com/nmenon/fix-k3-dt-u-boot/commits/beagleplay-v3-enet-debug
if anyone is interested)
Changes since V2:
* I have rebased to latest next branch
bdc682437a67 (origin/next) Merge branch '2023-08-14-assorted-general-updates' into next
* Uses config fragments by default.
* Updated MAINTAINER file as well
V2: https://lore.kernel.org/u-boot/[email protected]/
V1: https://lore.kernel.org/all/[email protected]/
Nishanth Menon (3):
arm: dts: k3-am625-sk-binman: Add labels for unsigned binary
board: ti: am62x: Add am62x_beagleplay_* defconfigs
doc: board: ti: Add BeaglePlay documentation
Robert Nelson (1):
arm: dts: Add k3-am625-beagleplay
arch/arm/dts/Makefile | 2 + .../dts/k3-am625-beagleplay-ddr4-1600MTs.dtsi | 2195 +++++++++++++++++ arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 172 ++ arch/arm/dts/k3-am625-beagleplay.dts | 758 ++++++ arch/arm/dts/k3-am625-r5-beagleplay.dts | 87 + arch/arm/dts/k3-am625-sk-binman.dtsi | 4 +- board/ti/am62x/MAINTAINERS | 7 + board/ti/am62x/beagleplay_a53.config | 20 + board/ti/am62x/beagleplay_r5.config | 11 + doc/board/ti/am62x_beagleplay.rst | 121 + doc/board/ti/k3.rst | 1 + 11 files changed, 3376 insertions(+), 2 deletions(-) create mode 100644 arch/arm/dts/k3-am625-beagleplay-ddr4-1600MTs.dtsi create mode 100644 arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi create mode 100644 arch/arm/dts/k3-am625-beagleplay.dts create mode 100644 arch/arm/dts/k3-am625-r5-beagleplay.dts create mode 100644 board/ti/am62x/beagleplay_a53.config create mode 100644 board/ti/am62x/beagleplay_r5.config create mode 100644 doc/board/ti/am62x_beagleplay.rst
Signature · 1 line
2.40.0
PATCH v3 1/4 arm: dts: k3-am625-sk-binman: Add labels for unsigned binary
Add labels for unsigned binary to permit over-ride.
---
NOTE: We can refactor this once the template solution comes online later on
Changes since V2: None
V2: https://lore.kernel.org/u-boot/[email protected]/
V1: https://lore.kernel.org/all/[email protected]/
arch/arm/dts/k3-am625-sk-binman.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/dts/k3-am625-sk-binman.dtsi +2 -2
@@ -389,7 +389,7 @@ type = "flat_dt"; arch = "arm"; compression = "none"; - blob { + spl_am625_sk_dtb_unsigned: blob { filename = SPL_AM625_SK_DTB; }; };
@@ -438,7 +438,7 @@ type = "flat_dt"; arch = "arm"; compression = "none"; - blob { + am625_sk_dtb_unsigned: blob { filename = AM625_SK_DTB; }; hash {
Signature · 1 line
2.40.0
PATCH v3 2/4 arm: dts: Add k3-am625-beagleplay
In reply to Nishanth MenonFrom: Robert Nelson <[email protected]>
BeagleBoard.org BeaglePlay is an easy to use, affordable open source hardware single board computer based on the Texas Instruments AM625 SoC that allows you to create connected devices that work even at long distances using IEEE 802.15.4g LR-WPAN and IEEE 802.3cg 10Base-T1L. Expansion is provided over open standards based mikroBUS, Grove and QWIIC headers among other interfaces.
This board family can be identified by the 24c32 eeprom:
[aa 55 33 ee 01 37 00 10 2e 00 42 45 41 47 4c 45 |.U3..7....BEAGLE|] [50 4c 41 59 2d 41 30 2d 00 00 30 32 30 30 37 38 |PLAY-A0-..020078|]
https://beagleplay.org/
https://git.beagleboard.org/beagleplay/beagleplay
baseline of base device tree is v6.5-rc1.
---
Changes since V2:
* Add to MAINTAINERS file
V2: https://lore.kernel.org/u-boot/[email protected]/
V1: https://lore.kernel.org/all/[email protected]/
arch/arm/dts/Makefile | 2 + .../dts/k3-am625-beagleplay-ddr4-1600MTs.dtsi | 2195 +++++++++++++++++ arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 172 ++ arch/arm/dts/k3-am625-beagleplay.dts | 758 ++++++ arch/arm/dts/k3-am625-r5-beagleplay.dts | 87 + board/ti/am62x/MAINTAINERS | 7 + 6 files changed, 3221 insertions(+) create mode 100644 arch/arm/dts/k3-am625-beagleplay-ddr4-1600MTs.dtsi create mode 100644 arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi create mode 100644 arch/arm/dts/k3-am625-beagleplay.dts create mode 100644 arch/arm/dts/k3-am625-r5-beagleplay.dts
arch/arm/dts/Makefile +2 -0
@@ -1320,6 +1320,8 @@ dtb-$(CONFIG_SOC_K3_AM642) += k3-am642-evm.dtb \ dtb-$(CONFIG_SOC_K3_AM625) += k3-am625-sk.dtb \ k3-am625-r5-sk.dtb \ + k3-am625-beagleplay.dtb \ + k3-am625-r5-beagleplay.dtb \ k3-am625-verdin-wifi-dev.dtb \ k3-am625-verdin-r5.dtb
arch/arm/dts/k3-am625-beagleplay-ddr4-1600MTs.dtsi new file +2195 -0
2,195 lines not on this page · raw message
arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi new file +172 -0
172 lines not on this page · raw message
arch/arm/dts/k3-am625-beagleplay.dts new file +758 -0
625 lines not on this page · raw message
arch/arm/dts/k3-am625-r5-beagleplay.dts new file +87 -0
87 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.40.0
Part of the diff is not shown here. View the raw message.
PATCH v3 3/4 board: ti: am62x: Add am62x_beagleplay_* defconfigs
In reply to Nishanth MenonAdd defconfig fragments for am625 based beagleplay
---
Changes since V2:
* Switch entirely to config fragments.
V2: https://lore.kernel.org/u-boot/[email protected]/
V1: https://lore.kernel.org/all/[email protected]/
board/ti/am62x/beagleplay_a53.config | 20 ++++++++++++++++++++ board/ti/am62x/beagleplay_r5.config | 11 +++++++++++ 2 files changed, 31 insertions(+) create mode 100644 board/ti/am62x/beagleplay_a53.config create mode 100644 board/ti/am62x/beagleplay_r5.config
board/ti/am62x/beagleplay_a53.config new file +20 -0
@@ -0,0 +1,20 @@ +# Defconfig fragment to apply on top of am62x_evm_a53_defconfig + +CONFIG_DEFAULT_DEVICE_TREE="k3-am625-beagleplay" +CONFIG_OF_LIST="k3-am625-beagleplay" +CONFIG_SPL_OF_LIST="k3-am625-beagleplay" +CONFIG_BOOTCOMMAND="run findfdt; run envboot; run distro_bootcmd" +CONFIG_EXT4_WRITE=y +CONFIG_LZO=y +CONFIG_AUTOBOOT_KEYED=y +CONFIG_AUTOBOOT_PROMPT="Press SPACE to abort autoboot in %d seconds\n" +CONFIG_AUTOBOOT_DELAY_STR="d" +CONFIG_AUTOBOOT_STOP_STR=" " +# Uses Realtek phy rather than TI phy +CONFIG_PHY_TI_DP83867=n +CONFIG_PHY_REALTEK=y +# No SPI flash on Beagleplay +CONFIG_SPI=n +CONFIG_SPI_FLASH=n +CONFIG_SPL_DM_SPI_FLASH=n +CONFIG_SPL_SPI_FLASH_SUPPORT=n
board/ti/am62x/beagleplay_r5.config new file +11 -0
@@ -0,0 +1,11 @@ +# Defconfig fragment to apply on top of: +# am62x_evm_r5_defconfig +# +CONFIG_DEFAULT_DEVICE_TREE="k3-am625-r5-beagleplay" +CONFIG_OF_LIST="k3-am625-r5-beagleplay" +CONFIG_SPL_OF_LIST="k3-am625-r5-beagleplay" +# No SPI flash on Beagleplay +CONFIG_SPI=n +CONFIG_SPI_FLASH=n +CONFIG_SPL_DM_SPI_FLASH=n +CONFIG_SPL_SPI_FLASH_SUPPORT=n
Signature · 1 line
2.40.0
PATCH v3 4/4 doc: board: ti: Add BeaglePlay documentation
In reply to Nishanth MenonAdd base documentation for BeaglePlay
---
Changes since V2:
* Update build instructions for config fragments
* Minor link look and feel fixups.
V2: https://lore.kernel.org/u-boot/[email protected]/
V1: https://lore.kernel.org/all/[email protected]/
doc/board/ti/am62x_beagleplay.rst | 121 ++++++++++++++++++++++++++++++ doc/board/ti/k3.rst | 1 + 2 files changed, 122 insertions(+) create mode 100644 doc/board/ti/am62x_beagleplay.rst
doc/board/ti/am62x_beagleplay.rst new file +121 -0
@@ -0,0 +1,121 @@ +.. SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause +.. sectionauthor:: Nishanth Menon <[email protected]> + +AM62x Beagleboard.org Beagleplay +================================ + +Introduction: +------------- + +BeagleBoard.org BeaglePlay is an easy to use, affordable open source +hardware single board computer based on the Texas Instruments AM625 +SoC that allows you to create connected devices that work even at long +distances using IEEE 802.15.4g LR-WPAN and IEEE 802.3cg 10Base-T1L. +Expansion is provided over open standards based mikroBUS, Grove and +QWIIC headers among other interfaces. + +Further information can be found at: + +* Product Page: https://beagleplay.org/ +* Hardware documentation: https://git.beagleboard.org/beagleplay/beagleplay + +Boot Flow: +---------- +Below is the pictorial representation of boot flow: + +.. image:: img/boot_diagram_k3_current.svg + +- On this platform, 'TI Foundational Security' (TIFS) functions as the + security enclave master while 'Device Manager' (DM), also known as the + 'TISCI server' in "TI terminology", offers all the essential services. + The A53/M4F (Aux core) sends requests to TIFS/DM to accomplish these + services, as illustrated in the diagram above. + +Sources: +-------- +.. include:: k3.rst + :start-after: .. k3_rst_include_start_boot_sources + :end-before: .. k3_rst_include_end_boot_sources + +Build procedure: +---------------- +0. Setup the environment variables: + +.. include:: k3.rst + :start-after: .. k3_rst_include_start_common_env_vars_desc + :end-before: .. k3_rst_include_end_common_env_vars_desc + +.. include:: k3.rst + :start-after: .. k3_rst_include_start_board_env_vars_desc + :end-before: .. k3_rst_include_end_board_env_vars_desc + +Set the variables corresponding to this platform: + +.. include:: k3.rst + :start-after: .. k3_rst_include_start_common_env_vars_defn + :end-before: .. k3_rst_include_end_common_env_vars_defn +.. code-block:: bash + + $ export UBOOT_CFG_CORTEXR="am62x_evm_r5_defconfig beagleplay_r5.config" + $ export UBOOT_CFG_CORTEXA="am62x_evm_a53_defconfig beagleplay_a53.config" + $ export TFA_BOARD=lite + $ # we dont use any extra TFA parameters + $ unset TFA_EXTRA_ARGS + $ export OPTEE_PLATFORM=k3-am62x + $ export OPTEE_EXTRA_ARGS="CFG_WITH_SOFTWARE_PRNG=y" + +.. include:: am62x_sk.rst + :start-after: .. am62x_evm_rst_include_start_build_steps + :end-before: .. am62x_evm_rst_include_end_build_steps + +Target Images +-------------- +Copy the below images to an SD card and boot: + +* tiboot3-am62x-gp-evm.bin from R5 build as tiboot3.bin +* tispl.bin_unsigned from Cortex-A build as tispl.bin +* u-boot.img_unsigned from Cortex-A build as uboot.img + +Image formats: +-------------- + +- tiboot3.bin + +.. image:: img/multi_cert_tiboot3.bin.svg + +- tispl.bin + +.. image:: img/dm_tispl.bin.svg + +A53 SPL DDR Memory Layout +------------------------- + +.. include:: am62x_sk.rst + :start-after: .. am62x_evm_rst_include_start_ddr_mem_layout + :end-before: .. am62x_evm_rst_include_end_ddr_mem_layout + +Switch Setting for Boot Mode +---------------------------- + +The boot time option is configured via "USR" button on the board. +See `Beagleplay Schematics <https://git.beagleboard.org/beagleplay/beagleplay/-/blob/main/BeaglePlay_sch.pdf>`_ +for details. + +.. list-table:: Boot Modes + :widths: 16 16 16 + :header-rows: 1 + + * - USR Switch Position + - Primary Boot + - Secondary Boot + + * - Not Pressed + - eMMC + - UART + + * - Pressed + - SD/MMC File System (FS) mode + - USB Device Firmware Upgrade (DFU) mode + +To switch to SD card boot mode, hold the USR button while powering on +with Type-C power supply, then release when power LED lights up.
doc/board/ti/k3.rst +1 -0
@@ -30,6 +30,7 @@ K3 Based SoCs .. toctree:: :maxdepth: 1 + am62x_beagleplay am62x_sk ../toradex/verdin-am62 am65x_evm
Signature · 1 line
2.40.0
Quoted 22 lines · Nishanth Menon
Add support for BeaglePlay - rev 3
Boot log: https://gist.github.com/nmenon/3e99b44380873263e39ba4d84788db89
Full series(including dependencies) can be found at:
https://github.com/nmenon/fix-k3-dt-u-boot/commits/beagleplay-v3Caveats:
* I have kept networking out of picture for now as it is still in debug (See
https://github.com/nmenon/fix-k3-dt-u-boot/commits/beagleplay-v3-enet-debug
if anyone is interested)Changes since V2:
* I have rebased to latest next branch
bdc682437a67(origin/next) Merge branch '2023-08-14-assorted-general-updates' into next
* Uses config fragments by default.
* Updated MAINTAINER file as wellV2: https://lore.kernel.org/u-boot/[email protected]/
V1: https://lore.kernel.org/all/[email protected]/
Quoted 7 lines
Nishanth Menon (3):
arm: dts: k3-am625-sk-binman: Add labels for unsigned binary
board: ti: am62x: Add am62x_beagleplay_* defconfigs
doc: board: ti: Add BeaglePlay documentationRobert Nelson (1):
arm: dts: Add k3-am625-beagleplay
I tried these series on top of next on my beagleplay with the intention of booting U-Boot from eMMC.
Base commit: 7e6e40c57233 ("Merge tag 'v2023.10-rc3' into next")
I can't get this to boot. Seems to be stuck in the r5 spl.
Boot log is:
U-Boot SPL 2023.10-rc3-01591-ga4f9ddf99438 (Aug 22 2023 - 17:11:47 +0200) SYSFW ABI: 3.1 (firmware rev 0x0009 '9.0.5--v09.00.05 (Kool Koala)') SPL initial stack usage: 13400 bytes
Trying to boot from MMC1mmc_load_image_raw_sector: mmc block read error
Partition 1 invalid on device 0spl_register_fat_device: fat register err - -1spl_load_image_fat: error reading image tispl.bin, err - -1
SPL: failed to boot from all boot devices
### ERROR ### Please RESET the board ###
It seems that when we try to find tispl.bin, we read from the mmc0boot0 hw partition instead of from the user partition.
Per my understanding, BeaglePlay has the following (simplified) boot flow:
1. boot rom loads tiboot3 from mmc0boot0
2. tiboot3 loads tispl.bin from mmc(user), first partition (on a FAT filesystem)
3. tispl loads u-boot.img from mmc(user), first partition (on a FAT filesystem)
With the folllowing diff, I can boot all the way to U-Boot proper:
board/ti/am62x/beagleplay_a53.config +4 -0
@@ -18,3 +18,8 @@ CONFIG_SPI=n CONFIG_SPI_FLASH=n CONFIG_SPL_DM_SPI_FLASH=n CONFIG_SPL_SPI_FLASH_SUPPORT=n + +CONFIG_SUPPORT_EMMC_BOOT=y +CONFIG_SUPPORT_EMMC_BOOT_OVERRIDE_PART_CONFIG=y +CONFIG_SYS_MMCSD_RAW_MODE_EMMC_BOOT_PARTITION=0
board/ti/am62x/beagleplay_r5.config +4 -0
@@ -9,3 +9,8 @@ CONFIG_SPI=n CONFIG_SPI_FLASH=n CONFIG_SPL_DM_SPI_FLASH=n CONFIG_SPL_SPI_FLASH_SUPPORT=n + +CONFIG_SUPPORT_EMMC_BOOT=y +CONFIG_SUPPORT_EMMC_BOOT_OVERRIDE_PART_CONFIG=y +CONFIG_SYS_MMCSD_RAW_MODE_EMMC_BOOT_PARTITION=0
The above is probably not the proper way of doing things, but it seems to resolve my booting issue.
Quoted 23 lines
arch/arm/dts/Makefile | 2 + .../dts/k3-am625-beagleplay-ddr4-1600MTs.dtsi | 2195 +++++++++++++++++ arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 172 ++ arch/arm/dts/k3-am625-beagleplay.dts | 758 ++++++ arch/arm/dts/k3-am625-r5-beagleplay.dts | 87 + arch/arm/dts/k3-am625-sk-binman.dtsi | 4 +- board/ti/am62x/MAINTAINERS | 7 + board/ti/am62x/beagleplay_a53.config | 20 + board/ti/am62x/beagleplay_r5.config | 11 + doc/board/ti/am62x_beagleplay.rst | 121 + doc/board/ti/k3.rst | 1 + 11 files changed, 3376 insertions(+), 2 deletions(-) create mode 100644 arch/arm/dts/k3-am625-beagleplay-ddr4-1600MTs.dtsi create mode 100644 arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi create mode 100644 arch/arm/dts/k3-am625-beagleplay.dts create mode 100644 arch/arm/dts/k3-am625-r5-beagleplay.dts create mode 100644 board/ti/am62x/beagleplay_a53.config create mode 100644 board/ti/am62x/beagleplay_r5.config create mode 100644 doc/board/ti/am62x_beagleplay.rstSignature · 1 line
2.40.0
Quoted 52 lines · Mattijs Korpershoek
Quoted 22 lines · Nishanth Menon
Add support for BeaglePlay - rev 3
Boot log: https://gist.github.com/nmenon/3e99b44380873263e39ba4d84788db89
Full series(including dependencies) can be found at:
https://github.com/nmenon/fix-k3-dt-u-boot/commits/beagleplay-v3Caveats:
* I have kept networking out of picture for now as it is still in debug (See
https://github.com/nmenon/fix-k3-dt-u-boot/commits/beagleplay-v3-enet-debug
if anyone is interested)Changes since V2:
* I have rebased to latest next branch
bdc682437a67(origin/next) Merge branch '2023-08-14-assorted-general-updates' into next
* Uses config fragments by default.
* Updated MAINTAINER file as wellV2: https://lore.kernel.org/u-boot/[email protected]/
V1: https://lore.kernel.org/all/[email protected]/Quoted 7 lines
Nishanth Menon (3):
arm: dts: k3-am625-sk-binman: Add labels for unsigned binary
board: ti: am62x: Add am62x_beagleplay_* defconfigs
doc: board: ti: Add BeaglePlay documentationRobert Nelson (1):
arm: dts: Add k3-am625-beagleplayI tried these series on top of next on my beagleplay with the intention of booting U-Boot from eMMC.
Base commit:
7e6e40c57233("Merge tag 'v2023.10-rc3' into next")I can't get this to boot. Seems to be stuck in the r5 spl.
Boot log is:
U-Boot SPL 2023.10-rc3-01591-ga4f9ddf99438 (Aug 22 2023 - 17:11:47 +0200) SYSFW ABI: 3.1 (firmware rev
0x0009'9.0.5--v09.00.05 (Kool Koala)') SPL initial stack usage: 13400 bytes
Trying to boot from MMC1mmc_load_image_raw_sector: mmc block read error
Partition 1 invalid on device 0spl_register_fat_device: fat register err - -1spl_load_image_fat: error reading image tispl.bin, err - -1
SPL: failed to boot from all boot devices
### ERROR ### Please RESET the board ###
Quoted 5 lines
It seems that when we try to find tispl.bin, we read from the mmc0boot0 hw partition instead of from the user partition.
Per my understanding, BeaglePlay has the following (simplified) boot flow:
Thanks Mattijs, we have been discussing this in our discord channel, and I have a new version I am working on. will fix it up and send it later today - fixing some other pending documentation aspects atm.
Signature · 3 lines
Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
Quoted 53 lines · Nishanth Menon
Quoted 52 lines · Mattijs Korpershoek
Quoted 22 lines · Nishanth Menon
Add support for BeaglePlay - rev 3
Boot log: https://gist.github.com/nmenon/3e99b44380873263e39ba4d84788db89
Full series(including dependencies) can be found at:
https://github.com/nmenon/fix-k3-dt-u-boot/commits/beagleplay-v3Caveats:
* I have kept networking out of picture for now as it is still in debug (See
https://github.com/nmenon/fix-k3-dt-u-boot/commits/beagleplay-v3-enet-debug
if anyone is interested)Changes since V2:
* I have rebased to latest next branch
bdc682437a67(origin/next) Merge branch '2023-08-14-assorted-general-updates' into next
* Uses config fragments by default.
* Updated MAINTAINER file as wellV2: https://lore.kernel.org/u-boot/[email protected]/
V1: https://lore.kernel.org/all/[email protected]/Quoted 7 lines
Nishanth Menon (3):
arm: dts: k3-am625-sk-binman: Add labels for unsigned binary
board: ti: am62x: Add am62x_beagleplay_* defconfigs
doc: board: ti: Add BeaglePlay documentationRobert Nelson (1):
arm: dts: Add k3-am625-beagleplayI tried these series on top of next on my beagleplay with the intention of booting U-Boot from eMMC.
Base commit:
7e6e40c57233("Merge tag 'v2023.10-rc3' into next")I can't get this to boot. Seems to be stuck in the r5 spl.
Boot log is:
U-Boot SPL 2023.10-rc3-01591-ga4f9ddf99438 (Aug 22 2023 - 17:11:47 +0200) SYSFW ABI: 3.1 (firmware rev
0x0009'9.0.5--v09.00.05 (Kool Koala)') SPL initial stack usage: 13400 bytes
Trying to boot from MMC1mmc_load_image_raw_sector: mmc block read error
Partition 1 invalid on device 0spl_register_fat_device: fat register err - -1spl_load_image_fat: error reading image tispl.bin, err - -1
SPL: failed to boot from all boot devices
### ERROR ### Please RESET the board ###
Quoted 7 lines
Quoted 5 lines
It seems that when we try to find tispl.bin, we read from the mmc0boot0 hw partition instead of from the user partition.
Per my understanding, BeaglePlay has the following (simplified) boot flow:
Thanks Mattijs, we have been discussing this in our discord channel, and
Indeed I saw some things on discord around this but wanted to notice a broader audience (via the U-Boot list) that booting from eMMC was not working for some folks.
Quoted 2 lines
I have a new version I am working on. will fix it up and send it later today - fixing some other pending documentation aspects atm.
Looking forward to give it a try !
If it's not too much to ask, please cc me on the v4 series.
Thank you.
Quoted 5 lines
Signature · 4 lines
-- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D