Skip to contentSkip to conversation

package/libical: fix CVE-2016-9584

PATCH New Fabrice Fontaine 3 participants 3 messages Mar 28, 2020 – Apr 7, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/libical: fix CVE-2016-9584

libical allows remote attackers to cause a denial of service (use-after-free) and possibly read heap memory via a crafted ics file.

---
 ...ype_from_string-copy-the-reqstattype.patch | 27 +++++++++++++++++++
 package/libical/libical.mk                    |  3 +++
 2 files changed, 30 insertions(+)
 create mode 100644 package/libical/0002-icaltypes-c-icalreqstattype_from_string-copy-the-reqstattype.patch
package/libical/0002-icaltypes-c-icalreqstattype_from_string-copy-the-reqstattype.patch new file +27 -0
new file mode 100644
index 0000000000..0d74835e44
@@ -0,0 +1,27 @@
+From 6b9438d746cec6e4e632d78c5244f4be6314d1c9 Mon Sep 17 00:00:00 2001
+From: Allen Winter <[email protected]>
+Date: Sun, 28 May 2017 12:51:10 -0400
+Subject: [PATCH] icaltypes.c - icalreqstattype_from_string(), copy the
+ reqstattype's debug string into its own memory in the ring buffer.
+
+Issue#253
+Signed-off-by: Fabrice Fontaine <[email protected]>
+[Retrieved (and backported) from:
+https://github.com/libical/libical/commit/6b9438d746cec6e4e632d78c5244f4be6314d1c9]
+---
+ src/libical/icaltypes.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/libical/icaltypes.c b/src/libical/icaltypes.c
+index 70c50d29..85c33545 100644
+--- a/src/libical/icaltypes.c
++++ b/src/libical/icaltypes.c
+@@ -140,7 +140,7 @@ struct icalreqstattype icalreqstattype_from_string(const char *str)
+ 
+   p2 = strchr(p1+1,';');
+   if (p2 != 0 && *p2 != 0){
+-    stat.debug = p2+1;
++    stat.debug = icalmemory_tmp_copy(p2+1);
+   } 
+ 
+   return stat;
package/libical/libical.mk +3 -0
index 7125aa8b19..f9a266026e 100644
@@ -10,6 +10,9 @@ LIBICAL_INSTALL_STAGING = YES
 LIBICAL_LICENSE = MPL-1.0 or LGPL-2.1
 LIBICAL_LICENSE_FILES = LICENSE
 
+# 0002-icaltypes-c-icalreqstattype_from_string-copy-the-reqstattype.patch
+LIBICAL_IGNORE_CVES += CVE-2016-9584
+
 # building without this option is broken, it is used by
 # Gentoo/alpinelinux as well
 LIBICAL_CONF_OPTS = -DSHARED_ONLY=true
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 package/libical: fix CVE-2016-9584

Quoted 9 lines · On Sat, 28 Mar 2020 10:36:47 +0100 Fabrice Fontaine…

libical allows remote attackers to cause a denial of service (use-after-free) and possibly read heap memory via a crafted ics file.

---
 ...ype_from_string-copy-the-reqstattype.patch | 27 +++++++++++++++++++
 package/libical/libical.mk                    |  3 +++
 2 files changed, 30 insertions(+)
 create mode 100644 package/libical/0002-icaltypes-c-icalreqstattype_from_string-copy-the-reqstattype.patch

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/libical: fix CVE-2016-9584

In reply to Fabrice Fontaine
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

libical allows remote attackers to cause a denial of service (use-after-free) and possibly read heap memory via a crafted ics file.

Committed to 2019.02.x, 2019.11.x and 2020.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard