Skip to contentSkip to conversation

package/easy-rsa: select the appropriate option for openssl binary

PATCH New Thomas Petazzoni 2 participants 3 messages Dec 13, 2019 – Dec 23, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/easy-rsa: select the appropriate option for openssl binary

Since openssl was converted to a virtual package, BR2_PACKAGE_OPENSSL_BIN no longer exists: it was renamed to BR2_PACKAGE_LIBOPENSSL_BIN, but easy-rsa was not changed accordingly.

easy-rsa needs to take into account the two providers of openssl, and select the appropriate suboptions depending on which openssl implementation was chosen.

Ideally, we would probably need a more elaborate option that ensures easy-rsa doesn't have to know the details of which openssl implementation is selected, but practically speaking with just two providers of openssl at the moment, the proposed solution is good enough.

---
 package/easy-rsa/Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/easy-rsa/Config.in +2 -1
index 883d679e98..56db64a590 100644
@@ -1,7 +1,8 @@
 config BR2_PACKAGE_EASY_RSA
 	bool "easy-rsa"
 	select BR2_PACKAGE_OPENSSL # runtime
-	select BR2_PACKAGE_OPENSSL_BIN
+	select BR2_PACKAGE_LIBOPENSSL_BIN if BR2_PACKAGE_LIBOPENSSL
+	select BR2_PACKAGE_LIBRESSL_BIN if BR2_PACKAGE_LIBRESSL
 	help
 	  Simple shell based CA utility
 
Signature · 1 line
2.23.0
#1 lore raw

PATCH 1/1 package/easy-rsa: select the appropriate option for openssl binary

Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Since openssl was converted to a virtual package, BR2_PACKAGE_OPENSSL_BIN no longer exists: it was renamed to BR2_PACKAGE_LIBOPENSSL_BIN, but easy-rsa was not changed accordingly.

easy-rsa needs to take into account the two providers of openssl, and select the appropriate suboptions depending on which openssl implementation was chosen.

Quoted 5 lines

Ideally, we would probably need a more elaborate option that ensures easy-rsa doesn't have to know the details of which openssl implementation is selected, but practically speaking with just two providers of openssl at the moment, the proposed solution is good enough.

Agreed.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 package/easy-rsa: select the appropriate option for openssl binary

In reply to Thomas Petazzoni
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Since openssl was converted to a virtual package, BR2_PACKAGE_OPENSSL_BIN no longer exists: it was renamed to BR2_PACKAGE_LIBOPENSSL_BIN, but easy-rsa was not changed accordingly.

easy-rsa needs to take into account the two providers of openssl, and select the appropriate suboptions depending on which openssl implementation was chosen.

Quoted 7 lines

Ideally, we would probably need a more elaborate option that ensures easy-rsa doesn't have to know the details of which openssl implementation is selected, but practically speaking with just two providers of openssl at the moment, the proposed solution is good enough.

Committed to 2019.02.x and 2019.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard