ath10k: Prevent active scans on potential unusable channels
PATCH 1/1 ath10k: Prevent active scans on potential unusable channels
The QCA4019 hw1.0 firmware 10.4-3.2.1-00050 and 10.4-3.5.3-00053 (and most likely all other) seem to ignore the WMI_CHAN_FLAG_DFS flag during the scan. This results in transmission (probe requests) on channels which are not "available" for transmissions.
Since the firmware is closed source and nothing can be done from our side to fix the problem in it, the driver has to work around this problem. The WMI_CHAN_FLAG_PASSIVE seems to be interpreted by the firmware to not scan actively on a channel unless an AP was detected on it. Simple probe requests will then be transmitted by the STA on the channel.
ath10k must therefore also use this flag when it queues a radar channel for scanning. This should reduce the chance of an active scan when the channel might be "unusable" for transmissions.
---
Cc: Simon Wunderlich <[email protected]>
Cc: Marek Puzyniak <[email protected]>
--- drivers/net/wireless/ath/ath10k/mac.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/net/wireless/ath/ath10k/mac.c +7 -0
@@ -3085,6 +3085,13 @@ static int ath10k_update_channel_list(struct ath10k *ar) passive = channel->flags &IEEE80211_CHAN_NO_IR ; ch->passive = passive; +/* the firmware is ignoring the "radar" flag of the +* channel and is scanning actively using Probe Requests +* on "Radar detection"/DFS channels which are not +* marked as "available" +*/ + ch->passive |= ch->chan_radar; + ch->freq = channel->center_freq; ch->band_center_freq1 = channel->center_freq; ch->min_power =0 ;
Signature · 7 lines
2.11.0 _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 11 lines · Sven Eckelmann
The QCA4019 hw1.0 firmware 10.4-3.2.1-00050 and 10.4-3.5.3-00053 (and most likely all other) seem to ignore the
WMI_CHAN_FLAG_DFSflag during the scan. This results in transmission (probe requests) on channels which are not "available" for transmissions.Since the firmware is closed source and nothing can be done from our side to fix the problem in it, the driver has to work around this problem. The
WMI_CHAN_FLAG_PASSIVEseems to be interpreted by the firmware to not scan actively on a channel unless an AP was detected on it. Simple probe requests will then be transmitted by the STA on the channel.
Quoted 6 lines
ath10k must therefore also use this flag when it queues a radar channel for scanning. This should reduce the chance of an active scan when the channel might be "unusable" for transmissions.
Fixes e8a50f8ba44b ("ath10k: introduce DFS implementation")Signed-off-by Sven Eckelmann <[email protected]>
You didn't CC linux-wireless so I don't see this in patchwork. Can you resend, please?
Signature · 6 lines
Kalle Valo _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
On Donnerstag, 26. Juli 2018 16:47:00 CEST Kalle Valo wrote:
[...]
Quoted 5 lines
Quoted 2 lines
Fixes e8a50f8ba44b ("ath10k: introduce DFS implementation")Signed-off-by Sven Eckelmann <[email protected]>You didn't CC linux-wireless so I don't see this in patchwork. Can you resend, please?
In that case, you should maybe think about stopping the ath10k patchwork:
https://patchwork.kernel.org/patch/10516691/
Kind regards,
Sven
_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 10 lines · Sven Eckelmann
On Donnerstag, 26. Juli 2018 16:47:00 CEST Kalle Valo wrote:
[...]Quoted 5 lines
Quoted 2 lines
Fixes e8a50f8ba44b ("ath10k: introduce DFS implementation")Signed-off-by Sven Eckelmann <[email protected]>You didn't CC linux-wireless so I don't see this in patchwork. Can you resend, please?
In that case, you should maybe think about stopping the ath10k patchwork:
https://patchwork.kernel.org/patch/10516691/
Sure, but how to do that? I can't find any functionality from the UI. And I don't want to fully delete it as lots of old emails refer to it.
Signature · 6 lines
Kalle Valo _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 7 lines · On Donnerstag, 26. Juli 2018 17:22:31 CEST Kalle Valo wrote:
Quoted 5 lines · Sven Eckelmann
On Donnerstag, 26. Juli 2018 16:47:00 CEST Kalle Valo wrote:
[...]Quoted 3 lines
Quoted 2 lines
Fixes e8a50f8ba44b ("ath10k: introduce DFS implementation")Signed-off-by Sven Eckelmann <[email protected]>
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
You didn't CC linux-wireless so I don't see this in patchwork. Can you resend, please?
In that case, you should maybe think about stopping the ath10k patchwork:
https://patchwork.kernel.org/patch/10516691/Sure, but how to do that? I can't find any functionality from the UI. And I don't want to fully delete it as lots of old emails refer to it.
Yes, this is a problem.
Kind regards,
Sven
_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k