Skip to contentSkip to conversation

drm/i915/gen9: Remove WaEnableYV12BugFixInHalfSliceChicken7

PATCH Superseded Arkadiusz Hiler 3 participants 6 messages Oct 18, 2016

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/gen9: Remove WaEnableYV12BugFixInHalfSliceChicken7

Dropping WA because it was for early steppings.

It is fixed in newer preproduction and all production revisions.

Cc Michal Winiarski <[email protected]>
---
 drivers/gpu/drm/i915/intel_ringbuffer.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/i915/intel_ringbuffer.c +0 -2
index e107455..32786ba 100644
@@ -849,10 +849,8 @@ static int gen9_init_workarounds(struct intel_engine_cs *engine)
 		 */
 	}
 
-	/* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl */
 	/* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl */
 	WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
-			  GEN9_ENABLE_YV12_BUGFIX |
 			  GEN9_ENABLE_GPGPU_PREEMPTION);
 
 	/* Wa4x4STCOptimizationDisable:skl,bxt,kbl */
Signature · 5 lines
2.7.4
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 4 lines · Arkadiusz Hiler

Dropping WA because it was for early steppings.

It is fixed in newer preproduction and all production revisions.

We have used References tag to point to a relevant document that has more information. Like for this, it should be:

References: HSD#2126385

From there I did figure out that this should be from skl:C0 onwards.

So based on that, we need this wa still.

-Mika

Quoted 27 lines
Cc Michal Winiarski <[email protected]>
---
 drivers/gpu/drm/i915/intel_ringbuffer.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/i915/intel_ringbuffer.c +0 -2
index e107455..32786ba 100644
@@ -849,10 +849,8 @@ static int gen9_init_workarounds(struct intel_engine_cs *engine)
 		 */
 	}
 
-	/* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl */
 	/* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl */
 	WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
-			  GEN9_ENABLE_YV12_BUGFIX |
 			  GEN9_ENABLE_GPGPU_PREEMPTION);
 
 	/* Wa4x4STCOptimizationDisable:skl,bxt,kbl */
Signature · 5 lines
2.7.4
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by
#2 lore raw
Quoted 7 lines · Mika Kuoppala
Quoted 4 lines · Arkadiusz Hiler

Dropping WA because it was for early steppings.

It is fixed in newer preproduction and all production revisions.

Quoted 8 lines

We have used References tag to point to a relevant document that has more information. Like for this, it should be:

References: HSD#2126385

From there I did figure out that this should be from skl:C0 onwards.

So based on that, we need this wa still.

I fell victim of out-of-date/conflicting information. Arkadiusz kindly pointed me to the correct sources and cleared the confusion. I am convinced we can drop this workaround.

Quoted 24 lines

-Mika

Quoted 20 lines
Cc Michal Winiarski <[email protected]>
---
 drivers/gpu/drm/i915/intel_ringbuffer.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/i915/intel_ringbuffer.c +0 -2
index e107455..32786ba 100644
@@ -849,10 +849,8 @@ static int gen9_init_workarounds(struct intel_engine_cs *engine)
 		 */
 	}
 
-	/* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl */
 	/* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl */
 	WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
-			  GEN9_ENABLE_YV12_BUGFIX |
 			  GEN9_ENABLE_GPGPU_PREEMPTION);
 
Quoted 11 lines
Quoted 7 lines
drivers/gpu/drm/i915/intel_ringbuffer.c +0 -0
 	/* Wa4x4STCOptimizationDisable:skl,bxt,kbl */
Signature · 5 lines
2.7.4
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
Quoted 14 lines · Mika Kuoppala
Quoted 12 lines · Mika Kuoppala
Quoted 4 lines · Arkadiusz Hiler

Dropping WA because it was for early steppings.

It is fixed in newer preproduction and all production revisions.

We have used References tag to point to a relevant document that has more information. Like for this, it should be:

References: HSD#2126385

Quoted 7 lines
Quoted 3 lines

From there I did figure out that this should be from skl:C0 onwards.

So based on that, we need this wa still.

I fell victim of out-of-date/conflicting information. Arkadiusz kindly pointed me to the correct sources and cleared the confusion. I am convinced we can drop this workaround.

So documentation link / hint to clear the confusion? -Chris

Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#4 lore raw
Quoted 17 lines · Chris Wilson
Quoted 16 lines · Mika Kuoppala
Quoted 14 lines · Mika Kuoppala
Quoted 4 lines · Arkadiusz Hiler

Dropping WA because it was for early steppings.

It is fixed in newer preproduction and all production revisions.

We have used References tag to point to a relevant document that has more information. Like for this, it should be:

References: HSD#2126385

From there I did figure out that this should be from skl:C0 onwards.

Quoted 7 lines
Quoted 5 lines
Quoted 1 line

So based on that, we need this wa still.

I fell victim of out-of-date/conflicting information. Arkadiusz kindly pointed me to the correct sources and cleared the confusion. I am convinced we can drop this workaround.

So documentation link / hint to clear the confusion?

Wa database had FROM_C0 and hsd,bspec has UNTIL_B0. -Mika

Quoted 4 lines

-Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

PATCH v2 1/1 drm/i915/gen9: Remove WaEnableYV12BugFixInHalfSliceChicken7

In reply to Arkadiusz Hiler

Dropping WA because it was for early steppings.

It is fixed in newer preproduction and all production revisions.

v2: add references, updated commit message

References: HSD#2126385, HSD#2131381, BSID#0764

Cc Mika Kuoppala <[email protected]>
Cc Chris Wilson <[email protected]>
Cc Michal Winiarski <[email protected]>
---
 drivers/gpu/drm/i915/intel_ringbuffer.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/i915/intel_ringbuffer.c +0 -2
index e107455..32786ba 100644
@@ -849,10 +849,8 @@ static int gen9_init_workarounds(struct intel_engine_cs *engine)
 		 */
 	}
 
-	/* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl */
 	/* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl */
 	WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
-			  GEN9_ENABLE_YV12_BUGFIX |
 			  GEN9_ENABLE_GPGPU_PREEMPTION);
 
 	/* Wa4x4STCOptimizationDisable:skl,bxt,kbl */
Signature · 5 lines
2.7.4
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx