Skip to contentSkip to conversation

disable reboot by ctrl-alt-del

PATCH New lothar felten 4 participants 6 messages Jan 3, 2016 – Jan 4, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 disable reboot by ctrl-alt-del

From: lf <[email protected]>

Most embedded systems do not have a keyboard.
If a keyboard is attached afterwards (e.g. to an accessible USB host port) this allows the user to reboot the system by pressing Ctrl-Alt-Del, which might not be desired.

---
 package/busybox/inittab  | 2 +-
 package/sysvinit/inittab | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/busybox/inittab +1 -1
index 24d9199..3f49f6b 100644
@@ -27,7 +27,7 @@
 #ttyS0::respawn:/sbin/getty -L ttyS0 115200 vt100 # GENERIC_SERIAL
 
 # Stuff to do for the 3-finger salute
-::ctrlaltdel:/sbin/reboot
+#::ctrlaltdel:/sbin/reboot
 
 # Stuff to do before rebooting
 ::shutdown:/etc/init.d/rcK
package/sysvinit/inittab +1 -1
index fc0c9b5..27eb4a6 100644
@@ -15,7 +15,7 @@ si6::sysinit:/etc/init.d/rcS
 # S0:1:respawn:/sbin/getty -L ttyS0 115200 vt100 # GENERIC_SERIAL
 
 # Stuff to do for the 3-finger salute
-ca::ctrlaltdel:/sbin/reboot
+#ca::ctrlaltdel:/sbin/reboot
 
 # Stuff to do before rebooting
 shd0:06:wait:/etc/init.d/rcK
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 disable reboot by ctrl-alt-del

Lothar, All,

On 2016-01-03 23:00 +0100, lothar felten spake thusly:

Quoted 1 line

From: lf <[email protected]>

Be sure to configure your git with your real name, so authorship matches your SoB line, below.

Quoted 6 lines

Most embedded systems do not have a keyboard.
If a keyboard is attached afterwards (e.g. to an accessible USB host port) this allows the user to reboot the system by pressing Ctrl-Alt-Del, which might not be desired.

Except for the authorship that should be a real, full name:

Thanks!

Regards,
Yann E. MORIN.

Quoted 38 lines
---
 package/busybox/inittab  | 2 +-
 package/sysvinit/inittab | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/busybox/inittab +1 -1
index 24d9199..3f49f6b 100644
@@ -27,7 +27,7 @@
 #ttyS0::respawn:/sbin/getty -L ttyS0 115200 vt100 # GENERIC_SERIAL
 
 # Stuff to do for the 3-finger salute
-::ctrlaltdel:/sbin/reboot
+#::ctrlaltdel:/sbin/reboot
 
 # Stuff to do before rebooting
 ::shutdown:/etc/init.d/rcK
package/sysvinit/inittab +1 -1
index fc0c9b5..27eb4a6 100644
@@ -15,7 +15,7 @@ si6::sysinit:/etc/init.d/rcS
 # S0:1:respawn:/sbin/getty -L ttyS0 115200 vt100 # GENERIC_SERIAL
 
 # Stuff to do for the 3-finger salute
-ca::ctrlaltdel:/sbin/reboot
+#ca::ctrlaltdel:/sbin/reboot
 
 # Stuff to do before rebooting
 shd0:06:wait:/etc/init.d/rcK
Signature · 6 lines
1.9.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 disable reboot by ctrl-alt-del

In reply to lothar felten
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"lothar" == lothar felten <[email protected]> writes:

From: lf <[email protected]>

Most embedded systems do not have a keyboard.
If a keyboard is attached afterwards (e.g. to an accessible USB host port) this allows the user to reboot the system by pressing Ctrl-Alt-Del, which might not be desired.

Committed with the authorship fixed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 1/1 disable reboot by ctrl-alt-del

In reply to lothar felten

Hello,

Quoted 8 lines · lothar felten

From: lf <[email protected]>

Most embedded systems do not have a keyboard.
If a keyboard is attached afterwards (e.g. to an accessible USB host port) this allows the user to reboot the system by pressing Ctrl-Alt-Del, which might not be desired.

Thanks Lothar for your contribution. Your patch has already been committed, so I hadn't had the time to give my opinion.

My opinion is quite different than the one from Yann and Peter however:
I believe your customization of the ctrl-alt-del behavior is really a detail, which can very easily be overridden in a post-build script and therefore does not deserve an additional Config.in option. If we start adding Config.in options for every possible customization of the inittab, we will have gazillions of options to solve very specific use cases.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#4 lore raw

PATCH 1/1 disable reboot by ctrl-alt-del

Quoted 16 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hello,

Quoted 8 lines · lothar felten

From: lf <[email protected]>

Most embedded systems do not have a keyboard.
If a keyboard is attached afterwards (e.g. to an accessible USB host port) this allows the user to reboot the system by pressing Ctrl-Alt-Del, which might not be desired.

Thanks Lothar for your contribution. Your patch has already been committed, so I hadn't had the time to give my opinion.

Quoted 7 lines

My opinion is quite different than the one from Yann and Peter however:
I believe your customization of the ctrl-alt-del behavior is really a detail, which can very easily be overridden in a post-build script and therefore does not deserve an additional Config.in option. If we start adding Config.in options for every possible customization of the inittab, we will have gazillions of options to solve very specific use cases.

Ehh, I think we all agree. This commit didn't add a configuration option, it simply changed our default behavior to NOT do anything when ctrl-alt-del is pressed (which is imho a better default).

Signature · 2 lines
Venlig hilsen,
Peter Korsgaard 
#5 lore raw

PATCH 1/1 disable reboot by ctrl-alt-del

Hello,

Quoted 3 lines · Peter Korsgaard

Ehh, I think we all agree. This commit didn't add a configuration option, it simply changed our default behavior to NOT do anything when ctrl-alt-del is pressed (which is imho a better default).

Ah, my bad. I had in mind the previous patch from Lothar, i.e "added option to enable or disable reboot on ctrl-alt-del". Indeed his new patch, which you committed, does not add a new option, which is perfectly fine.

Sorry for the noise. That's what happens when you don't read e-mails in the right order.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com