Skip to contentSkip to conversation

liquid-dsp: fix powerpc/altivec build failures

PATCH New Gustavo Zacarias 3 participants 3 messages Nov 10, 2015 – Nov 11, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 liquid-dsp: fix powerpc/altivec build failures

When a powerpc target is detected the build system tries to force altivec support but that's wrong:

Not every powerpc processor has altivec instruction support.

It's using the removed/deprecated -faltivec compiler directive when it should be using -maltivec instead.

Even if the above conditions are corrected the altivec codepath fails to build properly.

So just disable altivec in general using the standard --enable-simdoverride configure option. Fixes:

http://autobuild.buildroot.net/results/e1b/e1b6cf76a7a4ae754a928d211e779e9381198f48/

---
 package/liquid-dsp/liquid-dsp.mk | 5 +++++
 1 file changed, 5 insertions(+)
package/liquid-dsp/liquid-dsp.mk +5 -0
index 8bb8d54..e7bb686 100644
@@ -34,6 +34,11 @@ ifeq ($(BR2_PACKAGE_FFTW_PRECISION_SINGLE),y)
 LIQUID_DSP_LDFLAGS += -lfftw3f
 endif
 
+# disable altivec, it has build issues
+ifeq ($(BR2_powerpc)$(BR2_powerpc64),y)
+LIQUID_DSP_CONF_OPTS += --enable-simdoverride
+endif
+
 ifeq ($(BR2_PACKAGE_FFTW_PRECISION_DOUBLE),y)
 LIQUID_DSP_LDFLAGS += -lfftw3
 endif
Signature · 1 line
2.4.10
#1 lore raw

PATCH 1/1 liquid-dsp: fix powerpc/altivec build failures

Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Gustavo" == Gustavo Zacarias <[email protected]> writes:

When a powerpc target is detected the build system tries to force altivec support but that's wrong:

Not every powerpc processor has altivec instruction support.

It's using the removed/deprecated -faltivec compiler directive when it should be using -maltivec instead.

Quoted 7 lines

Even if the above conditions are corrected the altivec codepath fails to build properly.

So just disable altivec in general using the standard --enable-simdoverride configure option. Fixes:

http://autobuild.buildroot.net/results/e1b/e1b6cf76a7a4ae754a928d211e779e9381198f48/

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 liquid-dsp: fix powerpc/altivec build failures

In reply to Gustavo Zacarias

Dear Gustavo Zacarias,

Quoted 11 lines · Gustavo Zacarias

When a powerpc target is detected the build system tries to force altivec support but that's wrong:

Not every powerpc processor has altivec instruction support.

It's using the removed/deprecated -faltivec compiler directive when it should be using -maltivec instead.

Even if the above conditions are corrected the altivec codepath fails to build properly.

Quoted 6 lines

So just disable altivec in general using the standard --enable-simdoverride configure option. Fixes:

http://autobuild.buildroot.net/results/e1b/e1b6cf76a7a4ae754a928d211e779e9381198f48/

Thanks for fixing this! Could you also report the problem to the upstream project?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com