Skip to contentSkip to conversation

perf: Add support for Linux 3.13

PATCH New Mischa Jonker 3 participants 4 messages Jan 28, 2014 – Jul 18, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 perf: Add support for Linux 3.13

The Makefile has been renamed to Makefile.perf; so now we check both Makefiles to support 3.7 - 3.12 and 3.13 - beyond.

---
 package/perf/perf.mk |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/perf/perf.mk +1 -1
index d7898d0..ffe18bc 100644
@@ -35,7 +35,7 @@ define PERF_BUILD_CMDS
 		exit 1 ; \
 	fi
 	$(Q)if test "$(BR2_PACKAGE_ELFUTILS)" = "" ; then \
-		if ! grep -q NO_LIBELF $(LINUX_DIR)/tools/perf/Makefile ; then \
+		if ! grep -q NO_LIBELF $(LINUX_DIR)/tools/perf/Makefile $(LINUX_DIR)/tools/perf/Makefile.perf ; then \
 			echo "The perf tool in your kernel cannot be built without libelf." ; \
 			echo "Either upgrade your kernel to >= 3.7, or enable the elfutils package." ; \
 			exit 1 ; \
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/2 perf: Add support for Linux 3.13

Quoted 15 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Mischa" == Mischa Jonker <[email protected]> writes:

The Makefile has been renamed to Makefile.perf; so now we check both Makefiles to support 3.7 - 3.12 and 3.13 - beyond.

---
 package/perf/perf.mk |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/perf/perf.mk +0 -0
index d7898d0..ffe18bc 100644

package/perf/perf.mk define PERF_BUILD_CMDS · line 38

Quoted 5 lines
package/perf/perf.mk +1 -1
@@ -35,7 +35,7 @@ define PERF_BUILD_CMDS
 		exit 1 ; \
 	fi
 	$(Q)if test "$(BR2_PACKAGE_ELFUTILS)" = "" ; then \
-		if ! grep -q NO_LIBELF $(LINUX_DIR)/tools/perf/Makefile ; then \
+		if ! grep -q NO_LIBELF $(LINUX_DIR)/tools/perf/Makefile $(LINUX_DIR)/tools/perf/Makefile.perf ; then \

Hmm, does that really work? I would expect grep to error out when either Makefile or Makefile.perf isn't available.

What about simply checking Makefile* instead?

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/2 perf: Add support for Linux 3.13

Hi Mischa,

Quoted 24 lines · Peter Korsgaard
Quoted 15 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Mischa" == Mischa Jonker <[email protected]> writes:

The Makefile has been renamed to Makefile.perf; so now we check both Makefiles to support 3.7 - 3.12 and 3.13 - beyond.

---
 package/perf/perf.mk |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/perf/perf.mk +0 -0
index d7898d0..ffe18bc 100644

package/perf/perf.mk define PERF_BUILD_CMDS · line 38

Quoted 5 lines
package/perf/perf.mk +1 -1
@@ -35,7 +35,7 @@ define PERF_BUILD_CMDS
             exit 1 ; \
     fi
     $(Q)if test "$(BR2_PACKAGE_ELFUTILS)" = "" ; then \
-            if ! grep -q NO_LIBELF $(LINUX_DIR)/tools/perf/Makefile ; then \
+            if ! grep -q NO_LIBELF $(LINUX_DIR)/tools/perf/Makefile $(LINUX_DIR)/tools/perf/Makefile.perf ; then \

Hmm, does that really work? I would expect grep to error out when either Makefile or Makefile.perf isn't available.

Quoted 1 line

What about simply checking Makefile* instead?

Care to rebase this patch, and double-check the comment of Peter? In the mean time, another change to this area was done to support 3.10+ kernels.

Thanks,
Thomas

#3 lore raw

PATCH 1/2 perf: Add support for Linux 3.13

Anton,

Since Mischa is no longer working at synopsis, could you have a look at the below mail?

Quoted 24 lines · Thomas De Schampheleire

Hi Mischa,

Quoted 21 lines · Peter Korsgaard
Quoted 20 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Mischa" == Mischa Jonker <[email protected]> writes:

The Makefile has been renamed to Makefile.perf; so now we check both Makefiles to support 3.7 - 3.12 and 3.13 - beyond.

---
 package/perf/perf.mk |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/perf/perf.mk +1 -1
index d7898d0..ffe18bc 100644
@@ -35,7 +35,7 @@ define PERF_BUILD_CMDS
             exit 1 ; \
     fi
     $(Q)if test "$(BR2_PACKAGE_ELFUTILS)" = "" ; then \
-            if ! grep -q NO_LIBELF $(LINUX_DIR)/tools/perf/Makefile ; then \
+            if ! grep -q NO_LIBELF $(LINUX_DIR)/tools/perf/Makefile $(LINUX_DIR)/tools/perf/Makefile.perf ; then \
Quoted 7 lines
Quoted 4 lines

Hmm, does that really work? I would expect grep to error out when either Makefile or Makefile.perf isn't available.

What about simply checking Makefile* instead?

Care to rebase this patch, and double-check the comment of Peter? In the mean time, another change to this area was done to support 3.10+ kernels.

Thanks,
Thomas