wayland: disable on avr32
PATCH 1/1 wayland: disable on avr32
From: Simon Dawson <[email protected]>
The epoll_create1, timerfd_create and timerfd_settime syscalls are not available on avr32. Fixes build failures such as the following.
http://autobuild.buildroot.net/results/43b/43b3df5978782034279604abde8fe5d46c441344/
--- package/gstreamer1/gst1-plugins-bad/Config.in | 1 + package/wayland/Config.in | 2 ++ package/weston/Config.in | 2 ++ 3 files changed, 5 insertions(+)
package/gstreamer1/gst1-plugins-bad/Config.in +1 -0
@@ -358,6 +358,7 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_DIRECTFB config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WAYLAND bool "wayland" + depends on !BR2_avr32 # wayland depends on BR2_TOOLCHAIN_HAS_THREADS # wayland select BR2_PACKAGE_WAYLAND help
package/wayland/Config.in +2 -0
@@ -1,5 +1,6 @@ config BR2_PACKAGE_WAYLAND bool "wayland" + depends on !BR2_avr32 # no epoll_create1, timerfd_create or timerfd_settime depends on BR2_TOOLCHAIN_HAS_THREADS select BR2_PACKAGE_LIBFFI select BR2_PACKAGE_EXPAT
@@ -11,4 +12,5 @@ config BR2_PACKAGE_WAYLAND http://wayland.freedesktop.org/ comment "wayland needs a toolchain w/ threads" + depends on !BR2_avr32 depends on !BR2_TOOLCHAIN_HAS_THREADS
package/weston/Config.in +2 -0
@@ -1,4 +1,5 @@ comment "weston needs udev and a toolchain w/ threads" + depends on !BR2_avr32 depends on !BR2_PACKAGE_UDEV || !BR2_TOOLCHAIN_HAS_THREADS config BR2_PACKAGE_WESTON
@@ -11,6 +12,7 @@ config BR2_PACKAGE_WESTON select BR2_PACKAGE_JPEG select BR2_PACKAGE_MTDEV depends on BR2_PACKAGE_UDEV + depends on !BR2_avr32 # wayland depends on BR2_TOOLCHAIN_HAS_THREADS # wayland # Runtime dependency select BR2_PACKAGE_XKEYBOARD_CONFIG
Signature · 1 line
1.8.3.2
PATCH 1/1 wayland: disable on avr32
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"spdawson" == spdawson <[email protected]> writes:
From: Simon Dawson <[email protected]>
Theepoll_create1,timerfd_createandtimerfd_settimesyscalls are not available on avr32. Fixes build failures such as the following.http://autobuild.buildroot.net/results/43b/43b3df5978782034279604abde8fe5d46c441344/
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 wayland: disable on avr32
In reply to spdawson at gmail.comHi,
Quoted 19 lines · On Sat, Nov 16, 2013 at 10:58 AM, <[email protected]> wrote:
From: Simon Dawson <[email protected]>
The
epoll_create1,timerfd_createandtimerfd_settimesyscalls are not available on avr32. Fixes build failures such as the following.http://autobuild.buildroot.net/results/43b/43b3df5978782034279604abde8fe5d46c441344/
Signed-off-by Simon Dawson <[email protected]>--- package/gstreamer1/gst1-plugins-bad/Config.in | 1 + package/wayland/Config.in | 2 ++ package/weston/Config.in | 2 ++ 3 files changed, 5 insertions(+)package/gstreamer1/gst1-plugins-bad/Config.in +0
-0
package/gstreamer1/gst1-plugins-bad/Config.in config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_DIRECTFB · line 364
Quoted 7 lines
package/gstreamer1/gst1-plugins-bad/Config.in +1
-0@@ -358,6 +358,7 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_DIRECTFB config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WAYLAND bool "wayland" + depends on !BR2_avr32 # wayland depends on BR2_TOOLCHAIN_HAS_THREADS # wayland select BR2_PACKAGE_WAYLAND help
It seems that several gstreamer plugins lack the necessary comments, e.g. for thread support.
Normally, the avr32 dependency would also have been added to such comments...
I'll add that to my todo list for comments cleanup, but someone else is free to take it of course...
Best regards,
Thomas
PATCH 1/1 wayland: disable on avr32
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas De Schampheleire <[email protected]> writes:
Hi,
Quoted 9 lines
Quoted 6 lines
config
BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WAYLANDbool "wayland"
+ depends on !BR2_avr32 # wayland
depends onBR2_TOOLCHAIN_HAS_THREADS# wayland selectBR2_PACKAGE_WAYLAND
helpIt seems that several gstreamer plugins lack the necessary comments, e.g. for thread support.
Yes. Do notice that gstreamer itself needs threads, so it doesn't really matter much.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 wayland: disable on avr32
Quoted 11 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas De Schampheleire <[email protected]> writes:
Hi,
Quoted 6 lines
Quoted 6 lines
config
BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WAYLANDbool "wayland"
+ depends on !BR2_avr32 # wayland
depends onBR2_TOOLCHAIN_HAS_THREADS# wayland selectBR2_PACKAGE_WAYLAND
help
Quoted 5 lines
Quoted 2 lines
It seems that several gstreamer plugins lack the necessary comments, e.g. for thread support.
Yes. Do notice that gstreamer itself needs threads, so it doesn't really matter much.
This then boils down to the question whether we replicate the dependencies/and comments in such case or not. There is another thread where this action was asked, I'll bump it in a second, then we can have the discussion there...
Best regards,
Thomas