dropwatch: fix avr32 build failure
PATCH 1/1 dropwatch: fix avr32 build failure
From: Simon Dawson <[email protected]>
On avr32, dropwatch needs libiberty to avoid build failures such as
http://autobuild.buildroot.net/results/cd5/cd5e22fb5c9b0fc5d396bc85a5e253a1a65054da/
Also test built on ARM.
--- package/dropwatch/dropwatch-04-avr32-build.patch | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 package/dropwatch/dropwatch-04-avr32-build.patch
package/dropwatch/dropwatch-04-avr32-build.patch new file +17 -0
@@ -0,0 +1,17 @@ +On avr32, dropwatch needs libiberty to avoid build failures such as + + http://autobuild.buildroot.net/results/cd5/cd5e22fb5c9b0fc5d396bc85a5e253a1a65054da/ + +Signed-off-by: Simon Dawson <[email protected]> + +diff -Nurp a/src/Makefile b/src/Makefile +--- a/src/Makefile 2013-11-03 09:22:16.713210025 +0000 ++++ b/src/Makefile 2013-11-03 09:22:59.465126490 +0000 +@@ -1,6 +1,6 @@ + all: dropwatch + CFLAGS+=-c -g -D_GNU_SOURCE -Wall `pkg-config --cflags libnl-3.0` +-LDFLAGS=-lbfd -lreadline -lnl-3 -lnl-genl-3 ++LDFLAGS=-lbfd -liberty -lreadline -lnl-3 -lnl-genl-3 + OBJFILES := main.o lookup.o\ + lookup_bfd.o lookup_kas.o +
Signature · 1 line
1.8.3.2
PATCH 1/1 dropwatch: fix avr32 build failure
Quoted 25 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"spdawson" == spdawson <[email protected]> writes:
From: Simon Dawson <[email protected]>
On avr32, dropwatch needs libiberty to avoid build failures such ashttp://autobuild.buildroot.net/results/cd5/cd5e22fb5c9b0fc5d396bc85a5e253a1a65054da/
Also test built on ARM.
Signed-off-by Simon Dawson <[email protected]>--- package/dropwatch/dropwatch-04-avr32-build.patch | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 package/dropwatch/dropwatch-04-avr32-build.patchpackage/dropwatch/dropwatch-04-avr32-build.patch new file +4
-0@@ -0,0 +1,17 @@ +On avr32, dropwatch needs libiberty to avoid build failures such as + + http://autobuild.buildroot.net/results/cd5/cd5e22fb5c9b0fc5d396bc85a5e253a1a65054da/ +
package/dropwatch/dropwatch-04-avr32-build.patch line 14
Quoted 10 lines
package/dropwatch/dropwatch-04-avr32-build.patch new file +10
-0+Signed-off-by: Simon Dawson <[email protected]> + +diff -Nurp a/src/Makefile b/src/Makefile +--- a/src/Makefile 2013-11-03 09:22:16.713210025 +0000 ++++ b/src/Makefile 2013-11-03 09:22:59.465126490 +0000 +@@ -1,6 +1,6 @@ + all: dropwatch + CFLAGS+=-c -g -D_GNU_SOURCE -Wall `pkg-config --cflags libnl-3.0` +-LDFLAGS=-lbfd -lreadline -lnl-3 -lnl-genl-3 ++LDFLAGS=-lbfd -liberty -lreadline -lnl-3 -lnl-genl-3
I think you need to adjust the BR2_NEEDS_GETTEXT_IF_LOCALE condition in dropwatch.mk as well, and it would probably be better to handle it in dropwatch.mk for both cases instead of this patch + override.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 dropwatch: fix avr32 build failure
Thanks for the feedback Peter.
Quoted 3 lines · Peter Korsgaard
I think you need to adjust the
BR2_NEEDS_GETTEXT_IF_LOCALEcondition in dropwatch.mk as well, and it would probably be better to handle it in dropwatch.mk for both cases instead of this patch + override.
Okay. Will rework the patch.
Simon.