Skip to contentSkip to conversation

add Gstreamer 1.X for gst-omx support

PATCH Superseded Spenser Gilliland 3 participants 21 messages May 15, 2013 – May 26, 2013

v6 of 12 Superseded Latest is v12 →

lore
Share & tools
lore
#0 lore raw

v6 cover add Gstreamer 1.X for gst-omx support

This patch adds gst-omx support to buildroot. Thus, making it possible to use gstreamer applications which utilize hardware acceleration on OpenMAX supported systems.

To add gst-omx, libglib2 is bumped to 2.36.1 and gstreamer1 is added.

In addition, the patches include the libvpx library and enablement in gstreamer. This is meant to give an example of how to add support in the future.

v5 -> v6:
- Combined libglib patches to allow git-bisect
- added libopenmax virtual package for gst-omx (and future omx packages)

v4 -> v5:
- added gst-omx as a new package
- combined glib bump to 2.36.1 with gstreamer 1.x and gst-omx (libglib 2.32.1 is required for gstreamer 1.X)

v3 -> v4:
- uses new style if/endif syntax and removes depends properties for config elements in gstreamer1

v2 -> v3:
- fixes issues found while building with all/none plugins enabled
- change naming from gst-plugins-<blah>1 to gst1-plugins-<blah>
- options which require currently unpackged libraries are disabled

v1 -> v2:
- completed patch by adding good/bad/ugly plguins.

Spenser Gilliland (10):
libglib2: Bump libglib2 to 2.36.1
gstreamer1: Add gstreamer version 1.0.7 package
gst1-plugins-base: add gstreamer1 base plugins
gst1-plugins-good: add gstreamer1 good plugins
gst1-plugins-bad: add gstreamer1 bad plugins
gst1-plugins-ugly: add gstreamer1 ugly plugins
libvpx: new package libvpx
gst1-plugins-good: add libvpx support
libopenmax: Add libopenmax virtual package
gst-omx: add gst-omx package

 package/glib-networking/glib-networking.mk         |    4 +-
 package/glibmm/glibmm.mk                           |    2 +-
 ...b2-make-codegen-python2-python3-compliant.patch |  192 ------
 package/libglib2/libglib2-no-tests.patch           |  117 ----
 package/libglib2/libglib2.mk                       |   10 +-
 package/multimedia/Config.in                       |    7 +
 package/multimedia/gst-omx/Config.in               |   11 +
 package/multimedia/gst-omx/gst-omx.mk              |    9 +
 package/multimedia/gst1-plugins-bad/Config.in      |  325 ++++++++++
 .../gst1-plugins-bad/gst1-plugins-bad.mk           |  654 ++++++++++++++++++++
 package/multimedia/gst1-plugins-base/Config.in     |  106 ++++
 .../gst1-plugins-base/gst1-plugins-base.mk         |  201 ++++++
 package/multimedia/gst1-plugins-good/Config.in     |  217 +++++++
 .../gst1-plugins-good/gst1-plugins-good.mk         |  406 ++++++++++++
 package/multimedia/gst1-plugins-ugly/Config.in     |   49 ++
 .../gst1-plugins-ugly/gst1-plugins-ugly.mk         |   89 +++
 package/multimedia/gstreamer1/Config.in            |   38 ++
 package/multimedia/gstreamer1/gstreamer1.mk        |   36 ++
 package/multimedia/libvpx/Config.in                |    6 +
 package/multimedia/libvpx/libvpx.mk                |   52 ++
 package/opengl/Config.in                           |    3 +
 package/opengl/libopenmax/libopenmax.mk            |   24 +
 22 files changed, 2242 insertions(+), 316 deletions(-)
 delete mode 100644 package/libglib2/libglib2-make-codegen-python2-python3-compliant.patch
 delete mode 100644 package/libglib2/libglib2-no-tests.patch
 create mode 100644 package/multimedia/gst-omx/Config.in
 create mode 100644 package/multimedia/gst-omx/gst-omx.mk
 create mode 100644 package/multimedia/gst1-plugins-bad/Config.in
 create mode 100644 package/multimedia/gst1-plugins-bad/gst1-plugins-bad.mk
 create mode 100644 package/multimedia/gst1-plugins-base/Config.in
 create mode 100644 package/multimedia/gst1-plugins-base/gst1-plugins-base.mk
 create mode 100644 package/multimedia/gst1-plugins-good/Config.in
 create mode 100644 package/multimedia/gst1-plugins-good/gst1-plugins-good.mk
 create mode 100644 package/multimedia/gst1-plugins-ugly/Config.in
 create mode 100644 package/multimedia/gst1-plugins-ugly/gst1-plugins-ugly.mk
 create mode 100644 package/multimedia/gstreamer1/Config.in
 create mode 100644 package/multimedia/gstreamer1/gstreamer1.mk
 create mode 100644 package/multimedia/libvpx/Config.in
 create mode 100644 package/multimedia/libvpx/libvpx.mk
 create mode 100644 package/opengl/libopenmax/libopenmax.mk
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH v6 1/10 libglib2: Bump libglib2 to 2.36.1

This patch bumps libglib2 to version 2.36.1. In addition this bumps glibmm and glib-networking to 2.36.1.

---
 package/glib-networking/glib-networking.mk         |    4 +-
 package/glibmm/glibmm.mk                           |    2 +-
 ...b2-make-codegen-python2-python3-compliant.patch |  192 --------------------
 package/libglib2/libglib2-no-tests.patch           |  117 ------------
 package/libglib2/libglib2.mk                       |   10 +-
 5 files changed, 9 insertions(+), 316 deletions(-)
 delete mode 100644 package/libglib2/libglib2-make-codegen-python2-python3-compliant.patch
 delete mode 100644 package/libglib2/libglib2-no-tests.patch
package/glib-networking/glib-networking.mk +2 -2
index 4812fd6..40a1e99 100644
@@ -4,8 +4,8 @@
 #
 #############################################################
 
-GLIB_NETWORKING_MAJOR_VERSION = 2.30
-GLIB_NETWORKING_MINOR_VERSION = 2
+GLIB_NETWORKING_MAJOR_VERSION = 2.36
+GLIB_NETWORKING_MINOR_VERSION = 1
 GLIB_NETWORKING_VERSION = $(GLIB_NETWORKING_MAJOR_VERSION).$(GLIB_NETWORKING_MINOR_VERSION)
 GLIB_NETWORKING_SITE = http://ftp.gnome.org/pub/gnome/sources/glib-networking/$(GLIB_NETWORKING_MAJOR_VERSION)
 GLIB_NETWORKING_SOURCE = glib-networking-$(GLIB_NETWORKING_VERSION).tar.xz
package/glibmm/glibmm.mk +1 -1
index abd8b6c..d8f6239 100644
@@ -4,7 +4,7 @@
 #
 #############################################################
 
-GLIBMM_VERSION_MAJOR = 2.30
+GLIBMM_VERSION_MAJOR = 2.36
 GLIBMM_VERSION_MINOR = 1
 GLIBMM_VERSION = $(GLIBMM_VERSION_MAJOR).$(GLIBMM_VERSION_MINOR)
 GLIBMM_LICENSE = LGPLv2.1+ (library), GPLv2+ (tools)
package/libglib2/libglib2-make-codegen-python2-python3-compliant.patch deleted +0 -192

192 lines not on this page · raw message

package/libglib2/libglib2-no-tests.patch deleted +0 -117

117 lines not on this page · raw message

package/libglib2/libglib2.mk +6 -4
index d78e8ec..ee9f470 100644
@@ -3,8 +3,8 @@
 # libglib2
 #
 #############################################################
-LIBGLIB2_VERSION_MAJOR = 2.30
-LIBGLIB2_VERSION_MINOR = 3
+LIBGLIB2_VERSION_MAJOR = 2.36
+LIBGLIB2_VERSION_MINOR = 1
 LIBGLIB2_VERSION = $(LIBGLIB2_VERSION_MAJOR).$(LIBGLIB2_VERSION_MINOR)
 LIBGLIB2_SOURCE = glib-$(LIBGLIB2_VERSION).tar.xz
 LIBGLIB2_SITE = http://ftp.gnome.org/pub/gnome/sources/glib/$(LIBGLIB2_VERSION_MAJOR)
@@ -44,6 +44,8 @@ LIBGLIB2_CONF_ENV = \
 		ac_cv_path_GLIB_GENMARSHAL=$(HOST_DIR)/usr/bin/glib-genmarshal ac_cv_prog_F77=no \
 		ac_cv_func_posix_getgrgid_r=no glib_cv_long_long_format=ll \
 		ac_cv_func_printf_unix98=yes ac_cv_func_vsnprintf_c99=yes \
+		ac_cv_func_newlocale=no ac_cv_func_uselocale=no \
+		ac_cv_func_strtod_l=no ac_cv_func_strtoll_l=no ac_cv_func_strtoull_l=no \
 		gt_cv_c_wchar_t=$(if $(BR2_USE_WCHAR),yes,no)
 
 # old uClibc versions don't provide qsort_r
@@ -64,9 +66,9 @@ HOST_LIBGLIB2_CONF_OPT = \
 		--disable-dtrace \
 		--disable-systemtap \
 		--disable-gcov \
-		--disable-tests
+		--disable-modular-tests
 
-LIBGLIB2_CONF_OPT += --disable-tests
+LIBGLIB2_CONF_OPT += --disable-modular-tests
 
 LIBGLIB2_DEPENDENCIES = host-pkgconf host-libglib2 libffi zlib $(if $(BR2_NEEDS_GETTEXT),gettext) host-gettext
 
Signature · 1 line
1.7.9.5
#2 lore raw

PATCH v6 2/10 gstreamer1: Add gstreamer version 1.0.7 package

In reply to Spenser Gilliland

This patch adds the gstreamer version 1.x series to buildroot.

---
 package/multimedia/Config.in                |    1 +
 package/multimedia/gstreamer1/Config.in     |   38 +++++++++++++++++++++++++++
 package/multimedia/gstreamer1/gstreamer1.mk |   36 +++++++++++++++++++++++++
 3 files changed, 75 insertions(+)
 create mode 100644 package/multimedia/gstreamer1/Config.in
 create mode 100644 package/multimedia/gstreamer1/gstreamer1.mk
package/multimedia/Config.in +1 -0
index 931e6d3..f6a5fd7 100644
@@ -6,6 +6,7 @@ source "package/multimedia/faad2/Config.in"
 source "package/multimedia/flac/Config.in"
 source "package/multimedia/ffmpeg/Config.in"
 source "package/multimedia/gstreamer/Config.in"
+source "package/multimedia/gstreamer1/Config.in"
 source "package/multimedia/gst-ffmpeg/Config.in"
 source "package/multimedia/gst-dsp/Config.in"
 source "package/multimedia/gst-fsl-plugins/Config.in"
package/multimedia/gstreamer1/Config.in new file +38 -0
new file mode 100644
index 0000000..c627eb7
@@ -0,0 +1,38 @@
+config BR2_PACKAGE_GSTREAMER1
+	bool "gstreamer1"
+	depends on BR2_USE_WCHAR # glib2
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	select BR2_PACKAGE_LIBGLIB2
+	help
+	  GStreamer is an open source multimedia framework.
+
+	  http://gstreamer.freedesktop.org/
+
+comment "gstreamer requires a toolchain with WCHAR and threads support"
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
+
+if BR2_PACKAGE_GSTREAMER1
+
+config BR2_PACKAGE_GSTREAMER1_GST_DEBUG
+	bool "enable gst-debug trace support"
+	default y
+	help
+	  Enable support for the gst-debug tracing functionality in gstreamer.
+	  This has limited CPU overhead, but does increase the rootfs size
+	  somewhat.
+
+config BR2_PACKAGE_GSTREAMER1_PLUGIN_REGISTRY
+	bool "enable plugin registry"
+	default y
+	help
+	  Enable support for the GStreamer plugin registry. This may increase
+	  the launch-time for a GStreamer application.
+
+config BR2_PACKAGE_GSTREAMER1_INSTALL_TOOLS
+	bool "install gst-launch gst-inspect"
+	default y
+	help
+	  Install the gst-launch and gst-inspect tools. This will take up
+	  additional space on the target
+
+endif
package/multimedia/gstreamer1/gstreamer1.mk new file +36 -0
new file mode 100644
index 0000000..7abdc09
@@ -0,0 +1,36 @@
+#############################################################
+#
+# gstreamer1
+#
+#############################################################
+
+GSTREAMER1_VERSION = 1.0.7
+GSTREAMER1_SOURCE = gstreamer-$(GSTREAMER1_VERSION).tar.xz
+GSTREAMER1_SITE = http://gstreamer.freedesktop.org/src/gstreamer
+GSTREAMER1_INSTALL_STAGING = YES
+
+# Checking if unaligned memory access works correctly cannot be done when cross
+# compiling. For the following architectures there is no information available
+# in the configure script.
+ifeq ($(BR2_avr32),y)
+GSTREAMER1_CONF_ENV = as_cv_unaligned_access=no
+endif
+ifeq ($(BR2_aarch64),y)
+GSTREAMER1_CONF_ENV = as_cv_unaligned_access=yes
+endif
+
+GSTREAMER1_CONF_OPT = \
+		--disable-examples \
+		--disable-tests \
+		--disable-failing-tests \
+		--disable-debug \
+		--disable-valgrind \
+		--disable-benchmarks \
+		--disable-check \
+		$(if $(BR2_PACKAGE_GSTREAMER1_GST_DEBUG),,--disable-gst-debug) \
+		$(if $(BR2_PACKAGE_GSTREAMER1_PLUGIN_REGISTRY),,--disable-registry) \
+		$(if $(BR2_PACKAGE_GSTREAMER1_INSTALL_TOOLS),,--disable-tools) \
+
+GSTREAMER1_DEPENDENCIES = libglib2 host-pkgconf host-bison host-flex
+
+$(eval $(autotools-package))
Signature · 1 line
1.7.9.5
#3 lore raw

PATCH v6 3/10 gst1-plugins-base: add gstreamer1 base plugins

In reply to Spenser Gilliland

Adds gstreamer 1.X base plugins.

---
 package/multimedia/Config.in                       |    1 +
 package/multimedia/gst1-plugins-base/Config.in     |  106 +++++++++++
 .../gst1-plugins-base/gst1-plugins-base.mk         |  201 ++++++++++++++++++++
 3 files changed, 308 insertions(+)
 create mode 100644 package/multimedia/gst1-plugins-base/Config.in
 create mode 100644 package/multimedia/gst1-plugins-base/gst1-plugins-base.mk
package/multimedia/Config.in +1 -0
index f6a5fd7..e851187 100644
@@ -12,6 +12,7 @@ source "package/multimedia/gst-dsp/Config.in"
 source "package/multimedia/gst-fsl-plugins/Config.in"
 source "package/multimedia/gst-omapfb/Config.in"
 source "package/multimedia/gst-plugins-base/Config.in"
+source "package/multimedia/gst1-plugins-base/Config.in"
 source "package/multimedia/gst-plugins-good/Config.in"
 source "package/multimedia/gst-plugins-bad/Config.in"
 source "package/multimedia/gst-plugins-ugly/Config.in"
package/multimedia/gst1-plugins-base/Config.in new file +106 -0

106 lines not on this page · raw message

package/multimedia/gst1-plugins-base/gst1-plugins-base.mk new file +201 -0

201 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#4 lore raw

PATCH v6 4/10 gst1-plugins-good: add gstreamer1 good plugins

In reply to Spenser Gilliland

Adds gstreamer 1.X good plugins.

---
 package/multimedia/Config.in                       |    1 +
 package/multimedia/gst1-plugins-good/Config.in     |  213 +++++++++++
 .../gst1-plugins-good/gst1-plugins-good.mk         |  400 ++++++++++++++++++++
 3 files changed, 614 insertions(+)
 create mode 100644 package/multimedia/gst1-plugins-good/Config.in
 create mode 100644 package/multimedia/gst1-plugins-good/gst1-plugins-good.mk
package/multimedia/Config.in +1 -0
index e851187..725a7b2 100644
@@ -14,6 +14,7 @@ source "package/multimedia/gst-omapfb/Config.in"
 source "package/multimedia/gst-plugins-base/Config.in"
 source "package/multimedia/gst1-plugins-base/Config.in"
 source "package/multimedia/gst-plugins-good/Config.in"
+source "package/multimedia/gst1-plugins-good/Config.in"
 source "package/multimedia/gst-plugins-bad/Config.in"
 source "package/multimedia/gst-plugins-ugly/Config.in"
 source "package/multimedia/lame/Config.in"
package/multimedia/gst1-plugins-good/Config.in new file +213 -0

213 lines not on this page · raw message

package/multimedia/gst1-plugins-good/gst1-plugins-good.mk new file +400 -0

400 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#5 lore raw

PATCH v6 5/10 gst1-plugins-bad: add gstreamer1 bad plugins

In reply to Spenser Gilliland

Adds gstreamer 1.X bad plugins

---
 package/multimedia/Config.in                       |    1 +
 package/multimedia/gst1-plugins-bad/Config.in      |  325 ++++++++++
 .../gst1-plugins-bad/gst1-plugins-bad.mk           |  654 ++++++++++++++++++++
 3 files changed, 980 insertions(+)
 create mode 100644 package/multimedia/gst1-plugins-bad/Config.in
 create mode 100644 package/multimedia/gst1-plugins-bad/gst1-plugins-bad.mk
package/multimedia/Config.in +1 -0
index 725a7b2..ecdef5c 100644
@@ -16,6 +16,7 @@ source "package/multimedia/gst1-plugins-base/Config.in"
 source "package/multimedia/gst-plugins-good/Config.in"
 source "package/multimedia/gst1-plugins-good/Config.in"
 source "package/multimedia/gst-plugins-bad/Config.in"
+source "package/multimedia/gst1-plugins-bad/Config.in"
 source "package/multimedia/gst-plugins-ugly/Config.in"
 source "package/multimedia/lame/Config.in"
 source "package/multimedia/madplay/Config.in"
package/multimedia/gst1-plugins-bad/Config.in new file +325 -0

325 lines not on this page · raw message

package/multimedia/gst1-plugins-bad/gst1-plugins-bad.mk new file +654 -0

654 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#6 lore raw

PATCH v6 6/10 gst1-plugins-ugly: add gstreamer1 ugly plugins

In reply to Spenser Gilliland

Adds gstreamer 1.X ugly plugins

---
 package/multimedia/Config.in                       |    1 +
 package/multimedia/gst1-plugins-ugly/Config.in     |   49 +++++++++++
 .../gst1-plugins-ugly/gst1-plugins-ugly.mk         |   89 ++++++++++++++++++++
 3 files changed, 139 insertions(+)
 create mode 100644 package/multimedia/gst1-plugins-ugly/Config.in
 create mode 100644 package/multimedia/gst1-plugins-ugly/gst1-plugins-ugly.mk
package/multimedia/Config.in +1 -0
index ecdef5c..d0594b9 100644
@@ -18,6 +18,7 @@ source "package/multimedia/gst1-plugins-good/Config.in"
 source "package/multimedia/gst-plugins-bad/Config.in"
 source "package/multimedia/gst1-plugins-bad/Config.in"
 source "package/multimedia/gst-plugins-ugly/Config.in"
+source "package/multimedia/gst1-plugins-ugly/Config.in"
 source "package/multimedia/lame/Config.in"
 source "package/multimedia/madplay/Config.in"
 source "package/multimedia/mpd/Config.in"
package/multimedia/gst1-plugins-ugly/Config.in new file +49 -0

49 lines not on this page · raw message

package/multimedia/gst1-plugins-ugly/gst1-plugins-ugly.mk new file +89 -0

89 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#7 lore raw

PATCH v6 7/10 libvpx: new package libvpx

In reply to Spenser Gilliland

adds webm multimedia support and the VP8 encoder/decoder library.

http://www.webmproject.org/

---
 package/multimedia/Config.in        |    1 +
 package/multimedia/libvpx/Config.in |    6 ++++
 package/multimedia/libvpx/libvpx.mk |   52 +++++++++++++++++++++++++++++++++++
 3 files changed, 59 insertions(+)
 create mode 100644 package/multimedia/libvpx/Config.in
 create mode 100644 package/multimedia/libvpx/libvpx.mk
package/multimedia/Config.in +1 -0
index d0594b9..a0927e9 100644
@@ -20,6 +20,7 @@ source "package/multimedia/gst1-plugins-bad/Config.in"
 source "package/multimedia/gst-plugins-ugly/Config.in"
 source "package/multimedia/gst1-plugins-ugly/Config.in"
 source "package/multimedia/lame/Config.in"
+source "package/multimedia/libvpx/Config.in"
 source "package/multimedia/madplay/Config.in"
 source "package/multimedia/mpd/Config.in"
 source "package/multimedia/mpg123/Config.in"
package/multimedia/libvpx/Config.in new file +6 -0
new file mode 100644
index 0000000..2327971
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_LIBVPX
+	bool "libvpx"
+	help
+	  a high-quality, open video format that's freely available to everyone.
+
+	  http://webmproject.org
package/multimedia/libvpx/libvpx.mk new file +52 -0

52 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#8 lore raw

PATCH v6 7/10 libvpx: new package libvpx

Dear Spenser Gilliland,

Quoted 8 lines · Spenser Gilliland
package/multimedia/libvpx/libvpx.mk new file +5 -0
@@ -0,0 +1,52 @@
+#############################################################
+#
+# libvpx
+#
+#############################################################

package/multimedia/libvpx/libvpx.mk line 15

Quoted 10 lines
package/multimedia/libvpx/libvpx.mk new file +10 -0
+
+LIBVPX_VERSION = v1.2.0
+LIBVPX_SITE = http://git.chromium.org/webm/libvpx.git
+LIBVPX_SITE_METHOD = git
+
+LIBVPX_INSTALL_STAGING = YES
+LIBVPX_LICENSE = BSD-3c 
+LIBVPX_LICENSE_FILES = LICENSE PATENTS 
+
+LIBVPX_INSTALL_STAGING = YES

Already set a few lines above.

package/multimedia/libvpx/libvpx.mk line 18

Quoted 3 lines
package/multimedia/libvpx/libvpx.mk new file +3 -0
+
+LIBVPX_CONF_ENV = \
+	LD=$$CC \

This sounds strange. The target compiler is $(TARGET_CC), and should be used with quotes to be compiled with ccache, so, probably:

	LD="$(TARGET_CC)"

And an explanation above that says why it is needed (i.e, LD being used by the libvpx build system as a compiler).

Quoted 10 lines
package/multimedia/libvpx/libvpx.mk new file +10 -0
+	CROSS=$(GNU_TARGET_NAME)
+
+LIBVPX_CONF_OPT = \
+	--disable-examples \
+	--disable-docs \
+	--disable-unit-tests
+
+define LIBVPX_CONFIGURE_CMDS
+	(cd $(LIBVPX_SRCDIR) && rm -rf config.cache && \
+	$(TARGET_CONFIGURE_OPTS) \

package/multimedia/libvpx/libvpx.mk line 38

Quoted 10 lines
package/multimedia/libvpx/libvpx.mk new file +10 -0
+	$(TARGET_CONFIGURE_ARGS) \
+	$(LIBVPX_CONF_ENV) \
+	./configure \
+		--target=generic-gnu \
+		--enable-pic \
+		--prefix=/usr \
+		$(SHARED_STATIC_LIBS_OPTS) \
+		$(LIBVPX_CONF_OPT) \
+	)
+endef

Please add a comment somewhere that allows us to remember that you're not using autotools-package because this 'configure' script is not an autotools one, but some hand-written thing.

Thanks!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#9 lore raw

PATCH v6 8/10 gst1-plugins-good: add libvpx support

In reply to Spenser Gilliland

adds libvpx support to gst1-plugins-good

---
 package/multimedia/gst1-plugins-good/Config.in     |    4 ++++
 .../gst1-plugins-good/gst1-plugins-good.mk         |   10 ++++++++--
 2 files changed, 12 insertions(+), 2 deletions(-)
package/multimedia/gst1-plugins-good/Config.in +4 -0
index c339a45..7653ec4 100644
@@ -206,6 +206,10 @@ config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_SPEEX
 	bool "speex"
 	select BR2_PACKAGE_SPEEX
 
+config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_VPX
+	bool "vpx (webm)"
+	select BR2_PACKAGE_LIBVPX
+
 config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_WAVPACK
 	bool "wavpack (*.wv audio)"
 	select BR2_PACKAGE_WAVPACK
package/multimedia/gst1-plugins-good/gst1-plugins-good.mk +8 -2
index 15e3b0e..297bb5e 100644
@@ -27,8 +27,7 @@ GST1_PLUGINS_GOOD_CONF_OPT += \
 		--disable-jack \
 		--disable-libdv \
 		--disable-dv1394 \
-		--disable-taglib \
-		--disable-vpx
+		--disable-taglib
 
 GST1_PLUGINS_GOOD_DEPENDENCIES = gstreamer1 gst1-plugins-base
 
@@ -390,6 +389,13 @@ else
 GST1_PLUGINS_GOOD_CONF_OPT += --disable-speex
 endif
 
+ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_VPX),y)
+GST1_PLUGINS_GOOD_CONF_OPT += --enable-vpx
+GST1_PLUGINS_GOOD_DEPENDENCIES += libvpx
+else
+GST1_PLUGINS_GOOD_CONF_OPT += --disable-vpx
+endif
+
 ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_WAVPACK),y)
 GST1_PLUGINS_GOOD_CONF_OPT += --enable-wavpack
 GST1_PLUGINS_GOOD_DEPENDENCIES += wavpack
Signature · 1 line
1.7.9.5
#10 lore raw

PATCH v6 9/10 libopenmax: Add libopenmax virtual package

In reply to Spenser Gilliland

this adds the libopenmax virtual package for hardware based video acceleration

---
 package/opengl/Config.in                |    3 +++
 package/opengl/libopenmax/libopenmax.mk |   24 ++++++++++++++++++++++++
 2 files changed, 27 insertions(+)
 create mode 100644 package/opengl/libopenmax/libopenmax.mk
package/opengl/Config.in +3 -0
index 81616f9..1636807 100644
@@ -6,3 +6,6 @@ config BR2_PACKAGE_HAS_OPENGL_ES
 
 config BR2_PACKAGE_HAS_OPENVG
 	bool
+
+config BR2_PACKAGE_HAS_OPENMAX
+	bool
package/opengl/libopenmax/libopenmax.mk new file +24 -0
new file mode 100644
index 0000000..dc29370
@@ -0,0 +1,24 @@
+#############################################################
+#
+# Virtual package for libopenmax
+#
+#############################################################
+
+LIBOPENMAX_SOURCE =
+
+ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
+LIBOPENMAX_DEPENDENCIES += rpi-userland
+endif
+
+ifeq ($(BR2_PACKAGE_BELLAGIO),y)
+LIBOPENMAX_DEPENDENCIES += bellagio
+endif
+
+ifeq ($(LIBOPENMAX_DEPENDENCIES),y)
+define LIBOPENMAX_CONFIGURE_CMDS
+	echo "No libopenmax implementation selected. Configuration error."
+	exit 1
+endef
+endif
+
+$(eval $(generic-package))
Signature · 1 line
1.7.9.5
#11 lore raw

PATCH v6 9/10 libopenmax: Add libopenmax virtual package

Dear Spenser Gilliland,

package/opengl/Config.in config BR2_PACKAGE_HAS_OPENGL_ES · line 11

Quoted 11 lines · Spenser Gilliland
package/opengl/Config.in +3 -0
index 81616f9..1636807 100644
@@ -6,3 +6,6 @@ config BR2_PACKAGE_HAS_OPENGL_ES
 
 config BR2_PACKAGE_HAS_OPENVG
 	bool
+
+config BR2_PACKAGE_HAS_OPENMAX
+	bool

I'm starting to wonder if those virtual packages shouldn't be separated from each other, and named virtual-<something>, i.e:

package/virtual-opengl/
package/virtual-openvg/
package/virtual-egl/
package/virtual-openmax/

but ok, that's certainly a different work. This current patch series is already long enough.

package/opengl/Config.in

Quoted 3 lines
package/opengl/Config.in +3 -0
+ifeq ($(BR2_PACKAGE_BELLAGIO),y)
+LIBOPENMAX_DEPENDENCIES += bellagio
+endif

Unless I missed something, there is no bellagio package in Buildroot for now, so this chunk should only be added once bellagio is added.

Thanks,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#12 lore raw

PATCH v6 9/10 libopenmax: Add libopenmax virtual package

Thomas,

Quoted 10 lines

I'm starting to wonder if those virtual packages shouldn't be separated from each other, and named virtual-<something>, i.e:

package/virtual-opengl/
package/virtual-openvg/
package/virtual-egl/
package/virtual-openmax/

but ok, that's certainly a different work. This current patch series is already long enough.

I agree that a change like you suggested would be better but it's probably best left for another patch series due to the required changes being quite large.

Quoted 6 lines

package/opengl/libopenmax/libopenmax.mk line 15

Quoted 3 lines
package/opengl/libopenmax/libopenmax.mk new file +3 -0
+ifeq ($(BR2_PACKAGE_BELLAGIO),y)
+LIBOPENMAX_DEPENDENCIES += bellagio
+endif

Unless I missed something, there is no bellagio package in Buildroot for now, so this chunk should only be added once bellagio is added.

It's in package/multimedia/bellagio.

Thanks,
Spenser

--
Spenser Gilliland
Computer Engineer
Doctoral Candidate

#13 lore raw

PATCH v6 9/10 libopenmax: Add libopenmax virtual package

Dear Spenser Gilliland,

Quoted 6 lines · Spenser Gilliland
Quoted 2 lines

but ok, that's certainly a different work. This current patch series is already long enough.

I agree that a change like you suggested would be better but it's probably best left for another patch series due to the required changes being quite large.

Agreed, I'm fine with getting this part of your patch as is, and later on, do some followup improvements. Especially since all those packages and options have no effect on the configurations people may be creating, some it doesn't cause any compatibility issue if we move things around or rename those hidden kconfig options.

Quoted 8 lines
Quoted 6 lines

package/opengl/libopenmax/libopenmax.mk line 15

Quoted 3 lines
package/opengl/libopenmax/libopenmax.mk new file +3 -0
+ifeq ($(BR2_PACKAGE_BELLAGIO),y)
+LIBOPENMAX_DEPENDENCIES += bellagio
+endif

Unless I missed something, there is no bellagio package in Buildroot for now, so this chunk should only be added once bellagio is added.

It's in package/multimedia/bellagio.

Argh, my bad. Stupid packages in subdirectories. I didn't remember having bellagio, so I checked by doing package/bell<tab><tab>, and nothing showed up, making me -incorrectly- conclude that this package didn't exist.

Sorry for the noise on this one.

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#14 lore raw

PATCH v6 9/10 libopenmax: Add libopenmax virtual package

Thomas,

Quoted 4 lines

Argh, my bad. Stupid packages in subdirectories. I didn't remember having bellagio, so I checked by doing package/bell<tab><tab>, and nothing showed up, making me -incorrectly- conclude that this package didn't exist.

If we were to do a cleanup. I'd actually argue that the entire multimedia directory needs to go away. Gstreamer/gstreamer1 would need their own directories but everything else could be in the root. However, this is not really in scope for the patch series at hand.

Spenser

--
Spenser Gilliland
Computer Engineer
Doctoral Candidate

#15 lore raw

PATCH v6 9/10 libopenmax: Add libopenmax virtual package

Dear Spenser Gilliland,

Quoted 3 lines · Spenser Gilliland

If we were to do a cleanup. I'd actually argue that the entire multimedia directory needs to go away. Gstreamer/gstreamer1 would need their own directories but everything else could be in the root.

Right. Peter also like to have everything at the root, so I believe he will most likely not object to such a move.

Quoted 1 line

However, this is not really in scope for the patch series at hand.

Definitely.

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#16 lore raw

PATCH v6 9/10 libopenmax: Add libopenmax virtual package

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hi,

Quoted 3 lines
Quoted 3 lines

If we were to do a cleanup. I'd actually argue that the entire multimedia directory needs to go away. Gstreamer/gstreamer1 would need their own directories but everything else could be in the root.

Thomas> Right. Peter also like to have everything at the root, so I Thomas> believe he will most likely not object to such a move.

Indeed. I tend to make the same mistake as Thomas and only look directly under package/ ;)

Signature · 1 line
Bye, Peter Korsgaard
#17 lore raw

PATCH v6 10/10 gst-omx: add gst-omx package

In reply to Spenser Gilliland

gst-omx enables OpenMAX based accelerated video decode.

---
 package/multimedia/Config.in          |    1 +
 package/multimedia/gst-omx/Config.in  |   11 +++++++++++
 package/multimedia/gst-omx/gst-omx.mk |    9 +++++++++
 3 files changed, 21 insertions(+)
 create mode 100644 package/multimedia/gst-omx/Config.in
 create mode 100644 package/multimedia/gst-omx/gst-omx.mk
package/multimedia/Config.in +1 -0
index a0927e9..68dfa13 100644
@@ -11,6 +11,7 @@ source "package/multimedia/gst-ffmpeg/Config.in"
 source "package/multimedia/gst-dsp/Config.in"
 source "package/multimedia/gst-fsl-plugins/Config.in"
 source "package/multimedia/gst-omapfb/Config.in"
+source "package/multimedia/gst-omx/Config.in"
 source "package/multimedia/gst-plugins-base/Config.in"
 source "package/multimedia/gst1-plugins-base/Config.in"
 source "package/multimedia/gst-plugins-good/Config.in"
package/multimedia/gst-omx/Config.in new file +11 -0
new file mode 100644
index 0000000..789454c
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_GST_OMX
+	bool "gst-omx"
+	depends on BR2_PACKAGE_HAS_OPENMAX
+	select BR2_PACKAGE_GST1_PLUGINS_BASE
+	help
+	  GStreamer plug-in to use OpenMAX API.
+
+	  http://cgit.freedesktop.org/gstreamer/gst-omx
+
+comment "gst-omx requires a OpenMAX implementation please select rpi-userland or bellagio"
+	depends on BR2_PACKAGE_GSTREAMER1 && ! BR2_PACKAGE_HAS_OPENMAX
package/multimedia/gst-omx/gst-omx.mk new file +9 -0
new file mode 100644
index 0000000..7f54900
@@ -0,0 +1,9 @@
+GST_OMX_VERSION=1.0.0
+GST_OMX_SOURCE=gst-omx-$(GST_OMX_VERSION).tar.xz
+GST_OMX_SITE=http://gstreamer.freedesktop.org/src/gst-omx/
+GST_OMX_DEPENDENCIES = gstreamer1 gst1-plugins-base libopenmax
+GST_OMX_LICENSE = LGPLv2.1
+GST_OMX_LICENSE_FILE = COPYING
+GST_OMX_INSTALL_STAGING = YES
+
+$(eval $(autotools-package))
Signature · 1 line
1.7.9.5
#18 lore raw

PATCH v6 10/10 gst-omx: add gst-omx package

Dear Spenser Gilliland,

Quoted 3 lines · Spenser Gilliland

gst-omx enables OpenMAX based accelerated video decode.

One question: it would be good to mention, in your cover letter, on which platform this was tested. Was it tested on RPi? With what command line/tool?

package/multimedia/gst-omx/Config.in line 11

Quoted 2 lines
package/multimedia/gst-omx/Config.in new file +2 -0
+comment "gst-omx requires a OpenMAX implementation please select rpi-userland or bellagio"
+	depends on BR2_PACKAGE_GSTREAMER1 && ! BR2_PACKAGE_HAS_OPENMAX

I'm not sure it's reasonable to list the available OpenMAX implementations. So I'd just stick with "gst-omx requires an OpenMAX implementation".

No space between ! and BR2_PACKAGE_HAS_OPENMAX.

package/multimedia/gst-omx/gst-omx.mk

Quoted 6 lines
package/multimedia/gst-omx/gst-omx.mk new file +0 -0
new file mode 100644
index 0000000..7f54900
@@ -0,0 +1,9 @@

The usual (and useless, but conventional) comment header is missing.

package/multimedia/gst-omx/gst-omx.mk line 3

Quoted 3 lines
package/multimedia/gst-omx/gst-omx.mk new file +3 -0
+GST_OMX_VERSION=1.0.0
+GST_OMX_SOURCE=gst-omx-$(GST_OMX_VERSION).tar.xz
+GST_OMX_SITE=http://gstreamer.freedesktop.org/src/gst-omx/

Spaces before and after =.

package/multimedia/gst-omx/gst-omx.mk line 9

Quoted 6 lines
package/multimedia/gst-omx/gst-omx.mk new file +6 -0
+GST_OMX_DEPENDENCIES = gstreamer1 gst1-plugins-base libopenmax
+GST_OMX_LICENSE = LGPLv2.1
+GST_OMX_LICENSE_FILE = COPYING
+GST_OMX_INSTALL_STAGING = YES
+
+$(eval $(autotools-package))

Not sure here: do we have a reason to install this to the staging/ space? I thought it was only installing a plugin, and not a library against which other things would be linked with.

Apparently, the other gst1-plugins-* packages that you submitted don't install to staging, unless I missed it (which may very be possible, I only had a quick look).

Thanks!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#19 lore raw

PATCH v6 10/10 gst-omx: add gst-omx package

Thomas,

Quoted 3 lines

One question: it would be good to mention, in your cover letter, on which platform this was tested. Was it tested on RPi? With what command line/tool?

I'll add this info to the cover letter. It was tested with gst-launch.

Quoted 8 lines

package/multimedia/gst-omx/Config.in line 11

Quoted 2 lines
package/multimedia/gst-omx/Config.in new file +2 -0
+comment "gst-omx requires a OpenMAX implementation please select rpi-userland or bellagio"
+     depends on BR2_PACKAGE_GSTREAMER1 && ! BR2_PACKAGE_HAS_OPENMAX

I'm not sure it's reasonable to list the available OpenMAX implementations. So I'd just stick with "gst-omx requires an OpenMAX implementation".

No space between ! and BR2_PACKAGE_HAS_OPENMAX.

Fixed.

Quoted 9 lines

package/multimedia/gst-omx/gst-omx.mk

Quoted 6 lines
package/multimedia/gst-omx/gst-omx.mk new file +0 -0
new file mode 100644
index 0000000..7f54900
@@ -0,0 +1,9 @@

The usual (and useless, but conventional) comment header is missing.

Quoted 5 lines

package/multimedia/gst-omx/gst-omx.mk line 3

Quoted 3 lines
package/multimedia/gst-omx/gst-omx.mk new file +3 -0
+GST_OMX_VERSION=1.0.0
+GST_OMX_SOURCE=gst-omx-$(GST_OMX_VERSION).tar.xz
+GST_OMX_SITE=http://gstreamer.freedesktop.org/src/gst-omx/

Spaces before and after =.

Fixed.

Quoted 10 lines

package/multimedia/gst-omx/gst-omx.mk line 9

Quoted 6 lines
package/multimedia/gst-omx/gst-omx.mk new file +6 -0
+GST_OMX_DEPENDENCIES = gstreamer1 gst1-plugins-base libopenmax
+GST_OMX_LICENSE = LGPLv2.1
+GST_OMX_LICENSE_FILE = COPYING
+GST_OMX_INSTALL_STAGING = YES
+
+$(eval $(autotools-package))

Not sure here: do we have a reason to install this to the staging/ space? I thought it was only installing a plugin, and not a library against which other things would be linked with.

Not required in staging dir. I've removed the line from the latest version.

I'm going to wait another couple days before I sent another version just in case more reviews come in. If you want to see the changes in the meantime take a look at the rpi branch on my github buildroot clone at https://github.com/Spenser309/buildroot/commits/rpi .

Thanks,
Spenser

--
Spenser Gilliland
Computer Engineer
Doctoral Candidate

#20 lore raw

PATCH v6 10/10 gst-omx: add gst-omx package

Dear Spenser Gilliland,

Quoted 5 lines · Spenser Gilliland
Quoted 3 lines

One question: it would be good to mention, in your cover letter, on which platform this was tested. Was it tested on RPi? With what command line/tool?

I'll add this info to the cover letter. It was tested with gst-launch.

Ok. Since your branch is named rpi, I suppose it has been tested on the Rasberry Pi. Have you build tested the thing against Bellagio? Can you clarify for me which hardware platforms does Bellagio support? Or maybe it's a purely software implementation of OpenMAX, a little bit like the software rasterizer of Mesa is a pure software implementation of OpenGL ?

And, yes, having the details on how to test this will be useful for other users of the Rasberry Pi who may want to test your patches (and hopefully add their Tested-by).

Also, I'm pretty sure we should find a way to collect this information of how a package can be used/tested. Should it be in the main documentation? A per-package readme.txt when it makes sense? In the help text of the package kconfig option?

Quoted 4 lines

I'm going to wait another couple days before I sent another version just in case more reviews come in. If you want to see the changes in the meantime take a look at the rpi branch on my github buildroot clone at https://github.com/Spenser309/buildroot/commits/rpi .

Ok, thanks, sounds good.

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com