Skip to contentSkip to conversation

intel/aub: Actually run BLT batches on the blit ring.

PATCH In review Kenneth Graunke 2 participants 2 messages Jan 13, 2013 – Jan 14, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 intel/aub: Actually run BLT batches on the blit ring.

We didn't set the ring flag for BLT batches, so they got run on the render ring. Shenanigans ensued, especially when we sent commands that were only valid on the BLT ring.

Cc Paul Berry <[email protected]>
Cc Eric Anholt <[email protected]>
---
 intel/intel_bufmgr_gem.c | 2 ++
 1 file changed, 2 insertions(+)
intel/intel_bufmgr_gem.c +2 -0
index 512bc6f..32afd73 100644
@@ -2010,6 +2010,8 @@ aub_build_dump_ringbuffer(drm_intel_bufmgr_gem *bufmgr_gem,
 
 	if (ring_flag == I915_EXEC_BSD)
 		ring = AUB_TRACE_TYPE_RING_PRB1;
+	else if (ring_flag == I915_EXEC_BLT)
+		ring = AUB_TRACE_TYPE_RING_PRB2;
 
 	/* Make a ring buffer to execute our batchbuffer. */
 	memset(ringbuffer, 0, sizeof(ringbuffer));
Signature · 1 line
1.8.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Kenneth Graunke

We didn't set the ring flag for BLT batches, so they got run on the render ring. Shenanigans ensued, especially when we sent commands that were only valid on the BLT ring.

How did we get much anything to run in fulsim without this? Are there more commands available in the BLT ring than we thought, or have we just not been testing apps that use blits?

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx