Skip to contentSkip to conversation

linux: drop LDFLAGS override

PATCH New Mike Frysinger 3 participants 3 messages Nov 17, 2010 – Dec 7, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 linux: drop LDFLAGS override

The current linux code overrides LDFLAGS that the kernel itself might be setting up. Looking at the history, there doesn't seem to be any reason for this override. It was added in ea8b1fa6a60705 without any logic.

---
 linux/linux.mk |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
linux/linux.mk +0 -1
index 17c4b48..67b68ce 100644
@@ -31,7 +31,6 @@ LINUX26_MAKE_FLAGS = \
 	ARCH=$(KERNEL_ARCH) \
 	INSTALL_MOD_PATH=$(TARGET_DIR) \
 	CROSS_COMPILE=$(TARGET_CROSS) \
-	LDFLAGS="$(TARGET_LDFLAGS)" \
 	LZMA="$(LZMA)"
 ifneq ($(LINUX26_SOURCE_DIR),$(LINUX26_BUILD_DIR))
 LINUX26_MAKE_FLAGS += O="$(LINUX26_BUILD_DIR)"
Signature · 1 line
1.7.3.2
#1 lore raw

PATCH 1/1 linux: drop LDFLAGS override

Quoted 6 lines · On Wed, 17 Nov 2010 04:11:18 -0500 Mike Frysinger <[email protected]> wrote:

The current linux code overrides LDFLAGS that the kernel itself might be setting up. Looking at the history, there doesn't seem to be any reason for this override. It was added in ea8b1fa6a60705 without any logic.

The code in linux/linux.mk was more or less loosely inspired from the old Linux compilation code, which (I checked) already had this LDFLAGS thing, from the very beginning (commit 453dca995ee437b2f6fc3e0a6e4e2b4317346dae from october 2007). Obviously, I don't see why passing TARGET_LDFLAGS is needed, so:

Regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 1/1 linux: drop LDFLAGS override

In reply to Mike Frysinger
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Mike" == Mike Frysinger <[email protected]> writes:

Mike> The current linux code overrides LDFLAGS that the kernel itself might be Mike> setting up. Looking at the history, there doesn't seem to be any reason Mike> for this override. It was added in ea8b1fa6a60705 without any logic.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard