Skip to contentSkip to conversation

USB OHCI driver: Add NEC's PCI OHCI module ID

PATCH New David Saada 5 participants 12 messages Sep 16, 2007 – Oct 14, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 USB OHCI driver: Add NEC's PCI OHCI module ID

Description: Add NEC's PCI OHCI module ID to the USB OHCI driver

diff -purN usb_ohci.c.orig usb_ohci.c

usb_ohci.c 2007-09-16 09:52:06.146578000 +0200 renamed from usb_ohci.c.orig 2007-09-11 15:59:55.780415000 +0300 +0 -0
@@ -93,6 +93,7 @@

#ifdef CONFIG_PCI_OHCI

static struct pci_device_id ohci_pci_ids[] = {
       {0x10b9, 0x5237},       /* ULI1575 PCI OHCI module ids */
+       {0x1033, 0x0035},       /* NEC PCI OHCI module ids */
       /* Please add supported PCI OHCI controller ids here */
       {0, 0}
};
Signature · 2 lines
View this message in context: http://www.nabble.com/-PATCH--USB-OHCI-driver%3A-Add-NEC%27s-PCI-OHCI-module-ID-tf4450412.html#a12697486
Sent from the Uboot - Users mailing list archive at Nabble.com.
#1 lore raw

PATCH 1/1 USB OHCI driver: Add NEC's PCI OHCI module ID

Dear David,

Quoted 5 lines · David Saada

Description: Add NEC's PCI OHCI module ID to the USB OHCI driver

diff -purN usb_ohci.c.orig usb_ohci.c

I guess this is against drivers/usb_ohci.c, right?

Best regards

Markus Klotzbuecher

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de

#2 lore raw

PATCH 1/1 USB OHCI driver: Add NEC's PCI OHCI module ID

In reply to David Saada
Quoted 10 lines · In message <[email protected]> you wrote:

Description: Add NEC's PCI OHCI module ID to the USB OHCI driver

diff -purN usb_ohci.c.orig usb_ohci.c

usb_ohci.c 2007-09-16 09:52:06.146578000 +0200 line 99

Quoted 7 lines
usb_ohci.c 2007-09-16 09:52:06.146578000 +0200 renamed from usb_ohci.c.orig 2007-09-11 15:59:55.780415000 +0300 +1 -0
@@ -93,6 +93,7 @@
 #ifdef CONFIG_PCI_OHCI
 static struct pci_device_id ohci_pci_ids[] = {
       {0x10b9, 0x5237},       /* ULI1575 PCI OHCI module ids */
+       {0x1033, 0x0035},       /* NEC PCI OHCI module ids */
       /* Please add supported PCI OHCI controller ids here */
       {0, 0}
 };

Please use TABs for indentation - please clean up and resubmit.

#3 lore raw

PATCH 1/1 USB OHCI driver: Add NEC's PCI OHCI module ID

Patch resubmitted. I hope the tabs are ok now - please tell me if not (I post via the Nabble forum).

Description: Add NEC's PCI OHCI module ID to the USB OHCI driver

diff -purN drivers/usb_ohci.c.orig drivers/usb_ohci.c

usb_ohci.c renamed from usb_ohci.c.orig +1 -0
@@ -93,6 +93,7 @@
 #ifdef CONFIG_PCI_OHCI
 static struct pci_device_id ohci_pci_ids[] = {
 	{0x10b9, 0x5237},	/* ULI1575 PCI OHCI module ids */
+	{0x1033, 0x0035},	/* NEC PCI OHCI module ids */
 	/* Please add supported PCI OHCI controller ids here */
	{0, 0}

};

Signature · 2 lines
View this message in context: http://www.nabble.com/-PATCH--USB-OHCI-driver%3A-Add-NEC%27s-PCI-OHCI-module-ID-tf4450412.html#a12734121
Sent from the Uboot - Users mailing list archive at Nabble.com.
#4 lore raw

PATCH 1/1 USB OHCI driver: Add NEC's PCI OHCI module ID

Quoted 2 lines · David Saada

Patch resubmitted. I hope the tabs are ok now - please tell me if not (I post via the Nabble forum).

Thanks, patch added to USB Custodian repo.

Best regards

Markus Klotzbuecher

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de

#5 lore raw

PATCH 1/1 USB OHCI driver: Add NEC's PCI OHCI module ID

Quoted 7 lines · In message <[email protected]> you wrote:
Quoted 2 lines · David Saada

Patch resubmitted. I hope the tabs are ok now - please tell me if not (I post via the Nabble forum).

Thanks, patch added to USB Custodian repo.

Should that go into 1.3.0?

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Sometimes, too long is too long.                          - Joe Crowe
#6 lore raw

[U-Boot-Users] [USB] Pull Request: git://www.denx.de/git/u-boot-usb.git

Hi Wolfgang,

Quoted 10 lines · Wolfgang Denk
Quoted 7 lines · In message <[email protected]> you wrote:
Quoted 2 lines · David Saada

Patch resubmitted. I hope the tabs are ok now - please tell me if not (I post via the Nabble forum).

Thanks, patch added to USB Custodian repo.

Should that go into 1.3.0?

Yes please:

The following changes since commit 67c31036acaaaa992fc346cc89db0909a7e733c4:
Wolfgang Denk (1):
TQM8xx[LM]: Fix broken environment alignment.

are available in the git repository at:

git://www.denx.de/git/u-boot-usb.git master

David Saada (1):
Description: Add NEC's PCI OHCI module ID to the USB OHCI driver

Markus Klotzbuecher (1):
Merge with git://www.denx.de/git/u-boot.git

 drivers/usb_ohci.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Viele Gr??e / Best regards

Markus Klotzb?cher

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de

#7 lore raw

[U-Boot-Users] [USB] Pull Request: git://www.denx.de/git/u-boot-usb.git

Quoted 9 lines · In message <[email protected]> you wrote:

The following changes since commit 67c31036acaaaa992fc346cc89db0909a7e733c4:
Wolfgang Denk (1):
TQM8xx[LM]: Fix broken environment alignment.

are available in the git repository at:

git://www.denx.de/git/u-boot-usb.git master

Merged. Thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If I ever needed a brain transplant, I'd choose a teenager's  because
I'd want a brain that had never been used.
#8 lore raw

[U-Boot-Users] [Microblaze] Pull Request: git://www.denx.de/git/u-boot-microblaze.git merge branch

Please pull from git://denx.de/git/u-boot-microblaze.git merge

Thanks
Michal Simek

The following changes since commit b90c045f035c3cc9b5d2edaed6048dfb74e40763:
Michal Simek (1):
synchronizition with mainline

are found in the git repository at:

git://www.denx.de/git/u-boot.git

Michal Simek (8):
[FIX] repair MFSL commands
[FIX] repair email address
[FIX] resolve problem with cpu without barrel shifter Add support for design without interrupt controller Change macro name for UartLite
[FIX] Email reparation & Copyright
[FIX] change sets of commands
[FIX] change command handling and removing code violation

 common/cmd_mfsl.c          |   16 ++++++------
 cpu/microblaze/cache.c     |    2 +-
 cpu/microblaze/start.S     |    6 +---
 cpu/microblaze/timer.c     |    7 +++++
 drivers/serial_xuartlite.c |    2 +-
 include/configs/ml401.h    |   53 
+++++++++++++++++++++----------------------
 include/configs/suzaku.h   |   19 +++++++--------
 include/configs/xupv2p.h   |    3 +-
 lib_microblaze/time.c      |    8 ++++++
 9 files changed, 64 insertions(+), 52 deletions(-) 
#9 lore raw

[U-Boot-Users] [Microblaze] Pull Request: git://www.denx.de/git/u-boot-microblaze.git merge branch

Quoted 1 line · In message <001101c7fe27$252a5760$0200a8c0@monstrone> you wrote:

Please pull from git://denx.de/git/u-boot-microblaze.git merge

Please don't do that. Please put the stuff for me to merge in the master branch.

I'll make an exception this time, but only this time.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
God is real, unless declared integer.
#10 lore raw

[U-Boot-Users] [Microblaze] Pull Request: git://www.denx.de/git/u-boot-microblaze.git merge branch

Quoted 5 lines · Wolfgang Denk
Quoted 1 line · In message <001101c7fe27$252a5760$0200a8c0@monstrone> you wrote:

Please pull from git://denx.de/git/u-boot-microblaze.git merge

Please don't do that. Please put the stuff for me to merge in the master branch.

Really? It's perfectly reasonable for custodians to have multiple branches and to request for you to pull from a specific one. This becomes especially true with the adoption of the merge window process.
For instance, I have two branches on the 5xxx tree; one for bugfixes
to be merged immediately and another for stuff queued up for the next window.

Besides, when someone uses git-request-pull (like Michal did) it's a pretty trivial cut/paste to use git-pull to bring it into your branch.
It's not like it causes you extra work. :-)

Cheers,
g.

Signature · 4 lines
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely at secretlab.ca
(403) 399-0195
#11 lore raw

[U-Boot-Users] [Microblaze] Pull Request: git://www.denx.de/git/u-boot-microblaze.git merge branch

Quoted 3 lines · In message <[email protected]> you…

Really? It's perfectly reasonable for custodians to have multiple branches and to request for you to pull from a specific one. This

It is definitely perfectly reasonable to have multiple branches (otherwise we might go back to CVS - shudder).

But if you want to make life easy for me, then always use the same one (ideally simply master) to request the poull from.

THis allows me to set up all the custodian repos as remote tracking branches in one remotes.<group>. This allows me to get a quick overview. If you use several branches for oulling, it's pretty likely that I miss the correct branch name in your pull request and do the wrong thing.

Quoted 4 lines

becomes especially true with the adoption of the merge window process.
For instance, I have two branches on the 5xxx tree; one for bugfixes
to be merged immediately and another for stuff queued up for the next window.

You could merge the bugfixes branch into master immediately and the other one when the next window opens?

Quoted 2 lines

Besides, when someone uses git-request-pull (like Michal did) it's a pretty trivial cut/paste to use git-pull to bring it into your branch.

I don't pull immediately. I first fetch it into a local tracking branch so I can review it more easily before merging it.

Quoted 1 line

It's not like it causes you extra work. :-)

That's exactly the problem: it *does* cause more work.

Maybe my usage of git is sub-optimal, I'm just learning. But it seems to work pretty efficiet to me... If you have better ideas I'd appreciate all tips and tricks...

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
CAUTION:  The Mass of This Product Contains the Energy Equivalent  of
85 Million Tons of TNT per Net Ounce of Weight.