Skip to contentSkip to conversation

freevxfs: possible null pointer dereference fix

PATCH In review Dmitriy Monakhov 2 participants 2 messages Feb 20, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 freevxfs: possible null pointer dereference fix

sb_read may return NULL, so let's explicitly check it.

-------------

fs/freevxfs/vxfs_bmap.c +1 -1
index 2d71128..f86fd3c 100644
@@ -137,7 +137,7 @@ vxfs_bmap_indir(struct inode *ip, long indir, int size, long block)
 
 		bp = sb_bread(ip->i_sb,
 				indir + (i / VXFS_TYPED_PER_BLOCK(ip->i_sb)));
-		if (!buffer_mapped(bp))
+		if (!bp || !buffer_mapped(bp))
 			return 0;
 
 		typ = ((struct vxfs_typed *)bp->b_data) +
fs/freevxfs/vxfs_inode.c +1 -1
index 098a915..d1f7c5b 100644
@@ -99,7 +99,7 @@ vxfs_blkiget(struct super_block *sbp, u_long extent, ino_t ino)
 	offset = ((ino % (sbp->s_blocksize / VXFS_ISIZE)) * VXFS_ISIZE);
 	bp = sb_bread(sbp, block);
 
-	if (buffer_mapped(bp)) {
+	if (bp && buffer_mapped(bp)) {
 		struct vxfs_inode_info	*vip;
 		struct vxfs_dinode	*dip;