package/rtl8188eu: bump version to fix build failure with linux >= 6.0.0
PATCH 1/2 package/rtl8188eu: bump version to fix build failure with linux >= 6.0.0
Fixes:
http://autobuild.buildroot.org/results/550/550640296a92826f6f04d2344adde75c3025ea35/
--- package/rtl8188eu/rtl8188eu.hash | 2 +- package/rtl8188eu/rtl8188eu.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
package/rtl8188eu/rtl8188eu.hash +1 -1
@@ -1,3 +1,3 @@ # Locally computed -sha256 6bc46a13b20a2ed121844e51fd690216b2ab3b1faa1af8d9501090026ca9bd22 rtl8188eu-903b6fcb821465fe9c63e83416080df70c1c3c90.tar.gz +sha256 2f333604b39745a003b4a3c87bda3adcc0efd68100dff4aa3b54ae7992fc0143 rtl8188eu-77c1b083c5eb8336a2381aee20add496d1c96b51.tar.gz sha256 af8067302947c01fd9eee72befa54c7e3ef8a48fecde7fd71277f2290b2bf0f7 COPYING
package/rtl8188eu/rtl8188eu.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -RTL8188EU_VERSION = 903b6fcb821465fe9c63e83416080df70c1c3c90 +RTL8188EU_VERSION = 77c1b083c5eb8336a2381aee20add496d1c96b51 RTL8188EU_SITE = $(call github,lwfinger,rtl8188eu,$(RTL8188EU_VERSION)) RTL8188EU_LICENSE = GPL-2.0, proprietary (rtl8188eufw.bin firmware blob) RTL8188EU_LICENSE_FILES = COPYING
Signature · 6 lines
2.34.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH 2/2 DEVELOPERS: add Giulio Benetti to rtl8188eu package
--- DEVELOPERS | 1 + 1 file changed, 1 insertion(+)
DEVELOPERS +1 -0
@@ -1154,6 +1154,7 @@ F: package/nfs-utils/ F: package/python-uvloop/ F: package/qt5/ F: package/rockchip-mali/ +F: package/rtl8188eu/ F: package/rtl8189es/ F: package/rtl8723bu/ F: package/rtl8723ds/
Signature · 6 lines
2.34.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH 2/2] DEVELOPERS: add Giulio Benetti to rtl8188eu package
Hi Giulio,
Thank you!
Kind regards,
Petr
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH 2/2] DEVELOPERS: add Giulio Benetti to rtl8188eu package
In reply to Giulio BenettiHi Giulio,
Quoted 1 line · On Mon, 17 Oct 2022 22:18:04 +0200 Giulio Benetti…
Signed-off-by Giulio Benetti <[email protected]>
Thank you!
Not sure it makes sense for this kind of patch, but since I discovered Giulio knows much better than me this package:
Signature · 7 lines
Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Thomas Petazzoni via buildroot
AppliedRe: [Buildroot] [PATCH 2/2] DEVELOPERS: add Giulio Benetti to rtl8188eu package
In reply to Giulio BenettiQuoted 4 lines · On Mon, 17 Oct 2022 22:18:04 +0200 Giulio Benetti…
Signed-off-by Giulio Benetti <[email protected]>--- DEVELOPERS | 1 + 1 file changed, 1 insertion(+)
Applied to master, thanks.
However, please *always* resend complete patch series. For PATCH 1/2, you had sent a v2, and then a v3, and for this PATCH 2/2, only a v1 was there. This is *extremely* confusing for the maintainers.
So when you need to send a new version of one patch in a patch series, please *always* resend the complete patch series, and mark the entire previous patch series as Superseded.
Thanks a lot!
Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH 2/2] DEVELOPERS: add Giulio Benetti to rtl8188eu package
Quoted 10 lines · Thomas Petazzoni via buildroot
Quoted 4 lines · On Mon, 17 Oct 2022 22:18:04 +0200 Giulio Benetti…
Signed-off-by Giulio Benetti <[email protected]>--- DEVELOPERS | 1 + 1 file changed, 1 insertion(+)Applied to master, thanks.
Quoted 7 lines
However, please *always* resend complete patch series. For PATCH 1/2, you had sent a v2, and then a v3, and for this PATCH 2/2, only a v1 was there. This is *extremely* confusing for the maintainers.
So when you need to send a new version of one patch in a patch series, please *always* resend the complete patch series, and mark the entire previous patch series as Superseded.
Pardon Thomas, I've lost track of the DEVELOPERS patch while focusing on the 1/2 patch. I'll pay more attention.
Best regards
Signature · 6 lines
Giulio Benetti Benetti Engineering sas _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH 2/2] DEVELOPERS: add Giulio Benetti to rtl8188eu package
In reply to Giulio BenettiQuoted 3 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Giulio" == Giulio Benetti <[email protected]> writes:
Signed-off-by Giulio Benetti <[email protected]>
Committed to 2022.08.x and 2022.02.x, thanks.
Signature · 5 lines
Bye, Peter Korsgaard _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Pardon,
I've checked better the commits and this version fixes build failure with Linux 6.0.0+ but it introduces a runtime bug by removing code for Linux versions < 6.0.0. So I need to send another patch with a previous
commit SHA1 and create and send upstream a patch to fix the bug.
Best regards
Signature · 2 lines
Giulio Benetti CEO/CTO@Benetti Engineering sas
Quoted 23 lines · Giulio Benetti
Fixes:
http://autobuild.buildroot.org/results/550/550640296a92826f6f04d2344adde75c3025ea35/Signed-off-by Giulio Benetti <[email protected]>--- package/rtl8188eu/rtl8188eu.hash | 2 +- package/rtl8188eu/rtl8188eu.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)package/rtl8188eu/rtl8188eu.hash +1
-1@@ -1,3 +1,3 @@ # Locally computed -sha256 6bc46a13b20a2ed121844e51fd690216b2ab3b1faa1af8d9501090026ca9bd22 rtl8188eu-903b6fcb821465fe9c63e83416080df70c1c3c90.tar.gz +sha256 2f333604b39745a003b4a3c87bda3adcc0efd68100dff4aa3b54ae7992fc0143 rtl8188eu-77c1b083c5eb8336a2381aee20add496d1c96b51.tar.gz sha256 af8067302947c01fd9eee72befa54c7e3ef8a48fecde7fd71277f2290b2bf0f7 COPYINGpackage/rtl8188eu/rtl8188eu.mk +0
-0
package/rtl8188eu/rtl8188eu.mk line 10
Quoted 8 lines
package/rtl8188eu/rtl8188eu.mk +1
-1@@ -4,7 +4,7 @@ # ################################################################################ -RTL8188EU_VERSION = 903b6fcb821465fe9c63e83416080df70c1c3c90 +RTL8188EU_VERSION = 77c1b083c5eb8336a2381aee20add496d1c96b51 RTL8188EU_SITE = $(call github,lwfinger,rtl8188eu,$(RTL8188EU_VERSION)) RTL8188EU_LICENSE = GPL-2.0, proprietary (rtl8188eufw.bin firmware blob) RTL8188EU_LICENSE_FILES = COPYING
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH v2 1/1 package/rtl8188eu: bump version to fix build failure with linux >= 6.0.0
---V1->V2:
* use specific upstream commit SHA1 since the latest is buggy
--- package/rtl8188eu/rtl8188eu.hash | 2 +- package/rtl8188eu/rtl8188eu.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
package/rtl8188eu/rtl8188eu.hash +1 -1
@@ -1,3 +1,3 @@ # Locally computed -sha256 6bc46a13b20a2ed121844e51fd690216b2ab3b1faa1af8d9501090026ca9bd22 rtl8188eu-903b6fcb821465fe9c63e83416080df70c1c3c90.tar.gz +sha256 e6106521139cc463eaa74d1491e212437b2106c3aa0005b1b7b93f1d8a090237 rtl8188eu-7a7c5e0c0bc168ec5083a707e300e298dd4811fa.tar.gz sha256 af8067302947c01fd9eee72befa54c7e3ef8a48fecde7fd71277f2290b2bf0f7 COPYING
package/rtl8188eu/rtl8188eu.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -RTL8188EU_VERSION = 903b6fcb821465fe9c63e83416080df70c1c3c90 +RTL8188EU_VERSION = 7a7c5e0c0bc168ec5083a707e300e298dd4811fa RTL8188EU_SITE = $(call github,lwfinger,rtl8188eu,$(RTL8188EU_VERSION)) RTL8188EU_LICENSE = GPL-2.0, proprietary (rtl8188eufw.bin firmware blob) RTL8188EU_LICENSE_FILES = COPYING
Signature · 6 lines
2.34.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Hi Giulio, all,
Kind regards,
Petr
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Hi Giulio,
Quoted 4 lines · On Mon, 17 Oct 2022 23:12:39 +0200 Giulio Benetti…
Signed-off-by Giulio Benetti <[email protected]>---
V1->V2:
* use specific upstream commit SHA1 since the latest is buggy
Signature · 7 lines
Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Hello Giulio,
Quoted 4 lines · Giulio Benetti
Signed-off-by Giulio Benetti <[email protected]>---
V1->V2:
* use specific upstream commit SHA1 since the latest is buggy
Please mention this in the commit message (including the breaking upstream commit) and additional mention that the used commit is from the branch(?) not master..., will save some research time for later updates...
Regards,
Peter
Quoted 19 lines
--- package/rtl8188eu/rtl8188eu.hash | 2 +- package/rtl8188eu/rtl8188eu.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)package/rtl8188eu/rtl8188eu.hash +1
-1@@ -1,3 +1,3 @@ # Locally computed -sha256 6bc46a13b20a2ed121844e51fd690216b2ab3b1faa1af8d9501090026ca9bd22 rtl8188eu-903b6fcb821465fe9c63e83416080df70c1c3c90.tar.gz +sha256 e6106521139cc463eaa74d1491e212437b2106c3aa0005b1b7b93f1d8a090237 rtl8188eu-7a7c5e0c0bc168ec5083a707e300e298dd4811fa.tar.gz sha256 af8067302947c01fd9eee72befa54c7e3ef8a48fecde7fd71277f2290b2bf0f7 COPYINGpackage/rtl8188eu/rtl8188eu.mk +0
-0
package/rtl8188eu/rtl8188eu.mk line 10
Quoted 8 lines
package/rtl8188eu/rtl8188eu.mk +1
-1@@ -4,7 +4,7 @@ # ################################################################################ -RTL8188EU_VERSION = 903b6fcb821465fe9c63e83416080df70c1c3c90 +RTL8188EU_VERSION = 7a7c5e0c0bc168ec5083a707e300e298dd4811fa RTL8188EU_SITE = $(call github,lwfinger,rtl8188eu,$(RTL8188EU_VERSION)) RTL8188EU_LICENSE = GPL-2.0, proprietary (rtl8188eufw.bin firmware blob) RTL8188EU_LICENSE_FILES = COPYING
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Hi Peter,
Quoted 4 lines · Peter Seiderer
Hello Giulio,
On Mon, 17 Oct 2022 23:12:39 +0200, Giulio Benetti <[email protected]> wrote:
Quoted 8 lines
Quoted 4 lines
Signed-off-by Giulio Benetti <[email protected]>---
V1->V2:
* use specific upstream commit SHA1 since the latest is buggyPlease mention this in the commit message (including the breaking upstream commit) and additional mention that the used commit is from the branch(?) not master..., will save some research time for later updates...
Ok. My patch to fix the build with Linux < 6.0 has been already committed, so I send a V3 using the latest commit and I point the branch in the commit log. To be honest it wasn't easy for me too :-)
Thank you!
Best regards
Signature · 2 lines
Giulio Benetti Benetti Engineering sas
Quoted 25 lines
Regards,
PeterQuoted 22 lines
--- package/rtl8188eu/rtl8188eu.hash | 2 +- package/rtl8188eu/rtl8188eu.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)package/rtl8188eu/rtl8188eu.hash +1
-1@@ -1,3 +1,3 @@ # Locally computed -sha256 6bc46a13b20a2ed121844e51fd690216b2ab3b1faa1af8d9501090026ca9bd22 rtl8188eu-903b6fcb821465fe9c63e83416080df70c1c3c90.tar.gz +sha256 e6106521139cc463eaa74d1491e212437b2106c3aa0005b1b7b93f1d8a090237 rtl8188eu-7a7c5e0c0bc168ec5083a707e300e298dd4811fa.tar.gz sha256 af8067302947c01fd9eee72befa54c7e3ef8a48fecde7fd71277f2290b2bf0f7 COPYINGpackage/rtl8188eu/rtl8188eu.mk +0
-0@@ -4,7 +4,7 @@ # ################################################################################
Quoted 10 lines
package/rtl8188eu/rtl8188eu.mk line 10
Quoted 5 lines
package/rtl8188eu/rtl8188eu.mk +1
-1-RTL8188EU_VERSION = 903b6fcb821465fe9c63e83416080df70c1c3c90 +RTL8188EU_VERSION = 7a7c5e0c0bc168ec5083a707e300e298dd4811fa RTL8188EU_SITE = $(call github,lwfinger,rtl8188eu,$(RTL8188EU_VERSION)) RTL8188EU_LICENSE = GPL-2.0, proprietary (rtl8188eufw.bin firmware blob) RTL8188EU_LICENSE_FILES = COPYING_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
And I've also forgotten the Fixes:
Quoted 22 lines · Giulio Benetti
Hi Peter,
Quoted 4 lines · Peter Seiderer
Hello Giulio,
On Mon, 17 Oct 2022 23:12:39 +0200, Giulio Benetti <[email protected]> wrote:
Quoted 8 lines
Quoted 4 lines
Signed-off-by Giulio Benetti <[email protected]>---
V1->V2:
* use specific upstream commit SHA1 since the latest is buggyPlease mention this in the commit message (including the breaking upstream commit) and additional mention that the used commit is from the branch(?) not master..., will save some research time for later updates...
Ok. My patch to fix the build with Linux < 6.0 has been already committed, so I send a V3 using the latest commit and I point the branch in the commit log. To be honest it wasn't easy for me too :-)
Thank you!
Best regards
Signature · 6 lines
Giulio Benetti Benetti Engineering sas _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot