tty: n_gsm: Debug output allocation must use GFP_ATOMIC
PATCH 1/1 tty: n_gsm: Debug output allocation must use GFP_ATOMIC
Dan Carpenter <[email protected]> reported the following Smatch warning:
drivers/tty/n_gsm.c:720 gsm_data_kick()
warn: sleeping in atomic context
This is because gsm_control_message() is holding a spin lock so gsm_hex_dump_bytes() needs to use GFP_ATOMIC instead of GFP_KERNEL.
Fixes 925ea0fa5277 ("tty: n_gsm: Fix packet data hex dump output")
Reported-by Dan Carpenter <[email protected]>
Signed-off-by Tony Lindgren <[email protected]>
--- drivers/tty/n_gsm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/n_gsm.c +1 -1
@@ -459,7 +459,7 @@ static void gsm_hex_dump_bytes(const char *fname, const u8 *data,return ; } - prefix =kasprintf (GFP_KERNEL ,"%s: " , fname); + prefix =kasprintf (GFP_ATOMIC ,"%s: " , fname);if (!prefix)return ; print_hex_dump(KERN_INFO, prefix, DUMP_PREFIX_OFFSET, 16, 1, data, len,
Signature · 1 line
2.36.1
Quoted 6 lines · Tony Lindgren
Dan Carpenter <[email protected]> reported the following Smatch warning:
drivers/tty/n_gsm.c:720gsm_data_kick()
warn: sleeping in atomic context
Quoted 6 lines
This is because
gsm_control_message()is holding a spin lock sogsm_hex_dump_bytes()needs to useGFP_ATOMICinstead ofGFP_KERNEL.Fixes 925ea0fa5277 ("tty: n_gsm: Fix packet data hex dump output")Reported-by Dan Carpenter <[email protected]>Signed-off-by Tony Lindgren <[email protected]>
Reviewed-by Gregory CLEMENT <[email protected]>
Quoted 18 lines
--- drivers/tty/n_gsm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/tty/n_gsm.c +1
-1@@ -459,7 +459,7 @@ static void gsm_hex_dump_bytes(const char *fname, const u8 *data,return ; } - prefix =kasprintf (GFP_KERNEL ,"%s: " , fname); + prefix =kasprintf (GFP_ATOMIC ,"%s: " , fname);if (!prefix)return ; print_hex_dump(KERN_INFO, prefix, DUMP_PREFIX_OFFSET, 16, 1, data, len,Signature · 1 line
2.36.1
Signature · 3 lines
Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com