Skip to contentSkip to conversation

namei: make filename_parentat static

PATCH In review Jiapeng Chong 2 participants 2 messages Mar 17, 2022 – Mar 21, 2022 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 namei: make filename_parentat static

This symbol is not used outside of namei.c, so marks it static.

Fix the following w1 warning:

fs/namei.c:2587:5: warning: no previous prototype for ‘filename_parentat’ [-Wmissing-prototypes].

---
 fs/namei.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/namei.c +1 -1
index 44c366f3152f..fe3525807361 100644
@@ -2584,7 +2584,7 @@ static int __filename_parentat(int dfd, struct filename *name,
 	return retval;
 }
 
-int filename_parentat(int dfd, struct filename *name, unsigned int flags,
+static int filename_parentat(int dfd, struct filename *name, unsigned int flags,
 		      struct path *parent, struct qstr *last, int *type)
 {
 	return __filename_parentat(dfd, name, flags, parent, last, type, NULL);
Signature · 1 line
2.20.1.7.g153144c
#1 lore raw
Quoted 18 lines · Jiapeng Chong

This symbol is not used outside of namei.c, so marks it static.

Fix the following w1 warning:

fs/namei.c:2587:5: warning: no previous prototype for ‘filename_parentat’ [-Wmissing-prototypes].

---
 fs/namei.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/namei.c +0 -0
index 44c366f3152f..fe3525807361 100644

fs/namei.c static int __filename_parentat(int dfd, struct filename *name, · line 2590

Quoted 8 lines
fs/namei.c +1 -1
@@ -2584,7 +2584,7 @@ static int __filename_parentat(int dfd, struct filename *name,
 	return retval;
 }
 
-int filename_parentat(int dfd, struct filename *name, unsigned int flags,
+static int filename_parentat(int dfd, struct filename *name, unsigned int flags,
 		      struct path *parent, struct qstr *last, int *type)
 {
 	return __filename_parentat(dfd, name, flags, parent, last, type, NULL);

You must have based this on something other than the latest upstream tree. Currently on v5.17 we have:

2559 static int filename_parentat(int dfd, struct filename *name,
2560 unsigned int flags, struct path *parent,
2561 struct qstr *last, int *type)

Regards,
Stephen

Quoted 2 lines
Signature · 1 line
2.20.1.7.g153144c