Skip to contentSkip to conversation

linux-next: build failure after merge of the crypto tree

PATCH In review Stephen Rothwell 3 participants 6 messages Sep 27, 2021 – Oct 29, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi all,

After merging the crypto tree, today's linux-next build (powerpc ppc44x_defconfig) failed like this:

ERROR: modpost: "crypto_boot_test_finished" [crypto/crypto_algapi.ko] undefined!

Caused by commit

adad556efcdd ("crypto: api - Fix built-in testing dependency failures")

I have reverted that commit for today.

Signature · 2 lines
Cheers,
Stephen Rothwell
maintainer
#1 lore raw

PATCH 1/1 crypto: api - Export crypto_boot_test_finished

Quoted 7 lines · Stephen Rothwell

[-- text/plain, encoding quoted-printable, charset: US-ASCII, 18 lines --]

Hi all,

After merging the crypto tree, today's linux-next build (powerpc ppc44x_defconfig) failed like this:

Quoted 7 lines

ERROR: modpost: "crypto_boot_test_finished" [crypto/crypto_algapi.ko] undefined!

Caused by commit

adad556efcdd ("crypto: api - Fix built-in testing dependency failures")

I have reverted that commit for today.

Oops, does this patch fix the problem?

---8<---
We need to export crypto_boot_test_finished in case api.c is built-in while algapi.c is built as a module.

Fixes adad556efcdd ("crypto: api - Fix built-in testing dependency failures")
crypto/api.c +1 -0
index 1cf1f03347cc..ee5991fe11f8 100644
@@ -32,6 +32,7 @@ BLOCKING_NOTIFIER_HEAD(crypto_chain);
 EXPORT_SYMBOL_GPL(crypto_chain);
 
 DEFINE_STATIC_KEY_FALSE(crypto_boot_test_finished);
+EXPORT_SYMBOL_GPL(crypto_boot_test_finished);
 
 static struct crypto_alg *crypto_larval_wait(struct crypto_alg *alg);
 
Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
#3 lore raw

Re: [PATCH] crypto: api - Export crypto_boot_test_finished

Quoted 9 lines · Stephen Rothwell

Hi Herbert,

Quoted 2 lines · On Mon, 27 Sep 2021 19:23:42 +0800 Herbert Xu <[email protected]>…

Oops, does this patch fix the problem?

Yes, that fixes my build, thanks.

It fixes the build, but modules_install still fails:

  $ git checkout adad556efcdd42a1d9e060cbe5f6161cccf1fa28
  HEAD is now at adad556efcdd crypto: api - Fix built-in testing dependency failures
  $ git show e42dff467ee6 | patch -p1	# apply fixup patch
  patching file crypto/api.c
  $ make -s -j $(nproc) modules
  $ make -s modules_install
  depmod: ERROR: Cycle detected: crypto -> crypto_algapi -> crypto
  depmod: ERROR: Found 2 modules in dependency cycles!
  make: *** [Makefile:1801: modules_install] Error 1

cheers

maintainer
#4 lore raw

Re: [PATCH] crypto: api - Export crypto_boot_test_finished

Quoted 5 lines · Michael Ellerman

It fixes the build, but modules_install still fails:

  $ git checkout adad556efcdd42a1d9e060cbe5f6161cccf1fa28
  HEAD is now at adad556efcdd crypto: api - Fix built-in testing dependency failures

Sorry, the fix is in the queue:

https://patchwork.kernel.org/project/linux-crypto/patch/[email protected]/

Cheers,

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
#5 lore raw

Re: [PATCH] crypto: api - Export crypto_boot_test_finished

Quoted 10 lines · Herbert Xu
Quoted 5 lines · Michael Ellerman

It fixes the build, but modules_install still fails:

  $ git checkout adad556efcdd42a1d9e060cbe5f6161cccf1fa28
  HEAD is now at adad556efcdd crypto: api - Fix built-in testing dependency failures

Sorry, the fix is in the queue:

https://patchwork.kernel.org/project/linux-crypto/patch/[email protected]/

Thanks, that fixes it for me.

cheers