Skip to contentSkip to conversation

package/collectd: explicitly disable lua

PATCH New Fabrice Fontaine 2 participants 4 messages May 8, 2019 – May 9, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/collectd: explicitly disable lua

lua plugin has been added in version 5.6.0 with
https://github.com/collectd/collectd/commit/023092323ca617c8ff95b1efd4a055c29b1aaa3b

Disabled it otherwise it'll be enabled if liblua is found

---
 package/collectd/collectd.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/collectd/collectd.mk +1 -1
index 589324e612..027df8f111 100644
@@ -15,7 +15,7 @@ COLLECTD_LICENSE_FILES = COPYING libltdl/COPYING.LIB
 # These require unmet dependencies, are fringe, pointless or deprecated
 COLLECTD_PLUGINS_DISABLE = \
 	amqp apple_sensors aquaero ascent barometer dbi dpdkstat email \
-	gmond grpc hddtemp intel_rdt ipmi java libvirt lpar lvm \
+	gmond grpc hddtemp intel_rdt ipmi java libvirt lpar lua lvm \
 	madwifi mbmon mic multimeter netapp notify_desktop numa \
 	nut onewire oracle perl pf pinba powerdns python redis routeros \
 	rrdcached sigrok tape target_v5upgrade teamspeak2 ted \
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/collectd: explicitly disable lua

Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

lua plugin has been added in version 5.6.0 with
https://github.com/collectd/collectd/commit/023092323ca617c8ff95b1efd4a055c29b1aaa3b

Disabled it otherwise it'll be enabled if liblua is found

Is there any specific reason why we don't instead enable it if lua is enabled?

Quoted 25 lines
---
 package/collectd/collectd.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/collectd/collectd.mk +1 -1
index 589324e612..027df8f111 100644
@@ -15,7 +15,7 @@ COLLECTD_LICENSE_FILES = COPYING libltdl/COPYING.LIB
 # These require unmet dependencies, are fringe, pointless or deprecated
 COLLECTD_PLUGINS_DISABLE = \
 	amqp apple_sensors aquaero ascent barometer dbi dpdkstat email \
-	gmond grpc hddtemp intel_rdt ipmi java libvirt lpar lvm \
+	gmond grpc hddtemp intel_rdt ipmi java libvirt lpar lua lvm \
 	madwifi mbmon mic multimeter netapp notify_desktop numa \
 	nut onewire oracle perl pf pinba powerdns python redis routeros \
 	rrdcached sigrok tape target_v5upgrade teamspeak2 ted \
Signature · 6 lines
2.20.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 package/collectd: explicitly disable lua

Dear Peter,
Le jeu. 9 mai 2019 ? 11:01, Peter Korsgaard <[email protected]> a ?crit :

Quoted 10 lines
Quoted 7 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

lua plugin has been added in version 5.6.0 with
https://github.com/collectd/collectd/commit/023092323ca617c8ff95b1efd4a055c29b1aaa3b

Disabled it otherwise it'll be enabled if liblua is found

Is there any specific reason why we don't instead enable it if lua is enabled?

Because I didn't have time to test it yet and I saw that 2019.05-rc1 was released.
So my reasonig was to disable it for 2019.05 and enable it for next.

Quoted 22 lines
Quoted 21 lines
---
 package/collectd/collectd.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/collectd/collectd.mk +1 -2
index 589324e612..027df8f111 100644
@@ -15,7 +15,7 @@ COLLECTD_LICENSE_FILES = COPYING libltdl/COPYING.LIB
 # These require unmet dependencies, are fringe, pointless or deprecated
 COLLECTD_PLUGINS_DISABLE = \
     amqp apple_sensors aquaero ascent barometer dbi dpdkstat email \
-    gmond grpc hddtemp intel_rdt ipmi java libvirt lpar lvm \
+    gmond grpc hddtemp intel_rdt ipmi java libvirt lpar lua lvm \
     madwifi mbmon mic multimeter netapp notify_desktop numa \
     nut onewire oracle perl pf pinba powerdns python redis routeros \
     rrdcached sigrok tape target_v5upgrade teamspeak2 ted \
--

2.20.1

Quoted 7 lines
Quoted 4 lines

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

--
Bye, Peter Korsgaard

Best Regards,

Fabrice

#3 lore raw

PATCH 1/1 package/collectd: explicitly disable lua

Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

Dear Peter,
Le jeu. 9 mai 2019 ? 11:01, Peter Korsgaard <[email protected]> a ?crit :

Quoted 6 lines
Quoted 5 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

lua plugin has been added in version 5.6.0 with
https://github.com/collectd/collectd/commit/023092323ca617c8ff95b1efd4a055c29b1aaa3b

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Disabled it otherwise it'll be enabled if liblua is found

Is there any specific reason why we don't instead enable it if lua is enabled?

Because I didn't have time to test it yet and I saw that 2019.05-rc1 was released.
So my reasonig was to disable it for 2019.05 and enable it for next.

Ok, that is also fine by me.

Such meta-information can go into the commit message but under the -- line, so it doesn't end up in the git repo.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard