Skip to contentSkip to conversation

hw/arm/nseries: Deprecate the n800 and n810 machines

PATCH In review Thomas Huth 4 participants 6 messages Apr 12, 2019 – Apr 13, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hw/arm/nseries: Deprecate the n800 and n810 machines

These machines depend on the deprecated bluetooth subsystem. In case we finally decide to remove the bluetooth subsystem, we likely need to remove the n800 and n810 machines, too, so mark them now as deprecated.

---
 hw/arm/nseries.c     | 3 +++
 qemu-deprecated.texi | 6 ++++++
 2 files changed, 9 insertions(+)
hw/arm/nseries.c +3 -0
index 906b7ca22d..66e50b850c 100644
@@ -1309,6 +1309,9 @@ static void n8x0_init(MachineState *machine,
     struct n800_s *s = (struct n800_s *) g_malloc0(sizeof(*s));
     int sdram_size = binfo->ram_size;
 
+    warn_report("The n800 and n810 machines are deprecated. Please use a "
+                "different Arm machine instead.");
+
     s->mpu = omap2420_mpu_init(sysmem, sdram_size, machine->cpu_type);
 
     /* Setup peripherals
qemu-deprecated.texi +6 -0
index 2219386769..4de7452fac 100644
@@ -145,6 +145,12 @@ This machine type uses an unmaintained firmware, broken in lots of ways,
 and unable to start post-2004 operating systems. 40p machine type should be
 used instead.
 
+@subsection n800 and n810 (Arm) (since 4.1)
+
+These machines depend on the deprecated bluetooth subsystem. When the
+bluetooth subsystem will be removed, the n800 and n810 machines will be
+deleted, too. If possible, use a different Arm board instead.
+
 @section Device options
 
 @subsection Block device options
Signature · 1 line
2.21.0
#1 lore raw
Quoted 4 lines · Thomas Huth

These machines depend on the deprecated bluetooth subsystem. In case we finally decide to remove the bluetooth subsystem, we likely need to remove the n800 and n810 machines, too, so mark them now as deprecated.

...we could just remove the bluetooth devices from the boards?

thanks
-- PMM

#2 lore raw
Quoted 7 lines · Peter Maydell
Quoted 4 lines · Thomas Huth

These machines depend on the deprecated bluetooth subsystem. In case we finally decide to remove the bluetooth subsystem, we likely need to remove the n800 and n810 machines, too, so mark them now as deprecated.

...we could just remove the bluetooth devices from the boards?

Maybe we could. But do we really want to spent time to work on boards that likely nobody uses anymore? Or do you know anybody using it? (at least Guenter does not seem to use it, according to his list, see
https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg06125.html )

Thomas

#3 lore raw
Quoted 7 lines · Thomas Huth
Quoted 6 lines · Peter Maydell
Quoted 4 lines · Thomas Huth

These machines depend on the deprecated bluetooth subsystem. In case we finally decide to remove the bluetooth subsystem, we likely need to remove the n800 and n810 machines, too, so mark them now as deprecated.

Quoted 6 lines
Quoted 1 line

...we could just remove the bluetooth devices from the boards?

Maybe we could. But do we really want to spent time to work on boards that likely nobody uses anymore? Or do you know anybody using it? (at least Guenter does not seem to use it, according to his list, see
https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg06125.html )

I think we're far too willing to drag along code of dubious utility.

Deprecation is not a death sentence. It's a formal notice to users "we intend to drop this, and now is the time to argue for keeping it".

#4 lore raw
In reply to Thomas Huth
Quoted 15 lines · Thomas Huth

These machines depend on the deprecated bluetooth subsystem. In case we finally decide to remove the bluetooth subsystem, we likely need to remove the n800 and n810 machines, too, so mark them now as deprecated.

---
 hw/arm/nseries.c     | 3 +++
 qemu-deprecated.texi | 6 ++++++
 2 files changed, 9 insertions(+)
hw/arm/nseries.c +0 -0
index 906b7ca22d..66e50b850c 100644

hw/arm/nseries.c static void n8x0_init(MachineState *machine, · line 1314

Quoted 6 lines
hw/arm/nseries.c +3 -0
@@ -1309,6 +1309,9 @@ static void n8x0_init(MachineState *machine,
     struct n800_s *s = (struct n800_s *) g_malloc0(sizeof(*s));
     int sdram_size = binfo->ram_size;
 
+    warn_report("The n800 and n810 machines are deprecated. Please use a "
+                "different Arm machine instead.");
+

Unrelated to this patch, but can you add a similar warning in uart_hci_init() to make obvious that the bluetooth subsystem is now deprecated?

Quoted 21 lines
hw/arm/nseries.c +0 -0
     s->mpu = omap2420_mpu_init(sysmem, sdram_size, machine->cpu_type);
 
     /* Setup peripherals
qemu-deprecated.texi +6 -0
index 2219386769..4de7452fac 100644
@@ -145,6 +145,12 @@ This machine type uses an unmaintained firmware, broken in lots of ways,
 and unable to start post-2004 operating systems. 40p machine type should be
 used instead.
 
+@subsection n800 and n810 (Arm) (since 4.1)
+
+These machines depend on the deprecated bluetooth subsystem. When the
+bluetooth subsystem will be removed, the n800 and n810 machines will be
+deleted, too. If possible, use a different Arm board instead.
+
 @section Device options
 
 @subsection Block device options
#5 lore raw
Quoted 19 lines · Philippe Mathieu-Daudé
Quoted 18 lines · Thomas Huth

These machines depend on the deprecated bluetooth subsystem. In case we finally decide to remove the bluetooth subsystem, we likely need to remove the n800 and n810 machines, too, so mark them now as deprecated.

---
 hw/arm/nseries.c     | 3 +++
 qemu-deprecated.texi | 6 ++++++
 2 files changed, 9 insertions(+)
hw/arm/nseries.c +0 -0
index 906b7ca22d..66e50b850c 100644
@@ -1309,6 +1309,9 @@ static void n8x0_init(MachineState *machine,
     struct n800_s *s = (struct n800_s *) g_malloc0(sizeof(*s));
     int sdram_size = binfo->ram_size;
 
Quoted 7 lines

hw/arm/nseries.c static void n8x0_init(MachineState *machine, · line 1314

Quoted 3 lines
hw/arm/nseries.c +3 -0
+    warn_report("The n800 and n810 machines are deprecated. Please use a "
+                "different Arm machine instead.");
+

Unrelated to this patch, but can you add a similar warning in uart_hci_init() to make obvious that the bluetooth subsystem is now deprecated?

It's already there, in vl.c, case QEMU_OPTION_bt.

Thomas