Skip to contentSkip to conversation

tools/imx8m_image.sh: remove bashism

PATCH New Baruch Siach 6 participants 18 messages Jan 2, 2019 – Apr 1, 2019 3 messages not in the archive Arm i.MX and Layerscape

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 tools/imx8m_image.sh: remove bashism

Use a single '=' to test string equality for compatibility with non-bash shells. Otherwise, if /bin/sh is dash, build fails:

./tools/imx8m_image.sh: 15: [: signed_hdmi_imx8m.bin: unexpected operator ./tools/imx8m_image.sh: 15: [: signed_hdmi_imx8m.bin: unexpected operator ./tools/imx8m_image.sh: 15: [: spl/u-boot-spl-ddr.bin: unexpected operator ./tools/imx8m_image.sh: 15: [: spl/u-boot-spl-ddr.bin: unexpected operator WARNING './spl/u-boot-spl-ddr.bin' not found, resulting binary is not-functional

---
 tools/imx8m_image.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tools/imx8m_image.sh +2 -2
index 6346fb64d8c5..ec0881a12812 100755
@@ -12,7 +12,7 @@ blobs=`awk '/^SIGNED_HDMI/ {print $2} /^LOADER/ {print $2} /^SECOND_LOADER/ {pri
 for f in $blobs; do
 	tmp=$srctree/$f
 
-	if [ $f == "spl/u-boot-spl-ddr.bin" ] || [ $f == "u-boot.itb" ]; then
+	if [ $f = "spl/u-boot-spl-ddr.bin" ] || [ $f = "u-boot.itb" ]; then
 		continue
 	fi
 
@@ -28,7 +28,7 @@ for f in $blobs; do
 	sed -in "s;$f;$tmp;" $file
 done
 
-if [ $post_process == 1 ]; then
+if [ $post_process = 1 ]; then
 	if [ -f $srctree/lpddr4_pmu_train_1d_imem.bin ]; then
 		objcopy -I binary -O binary --pad-to 0x8000 --gap-fill=0x0 $srctree/lpddr4_pmu_train_1d_imem.bin lpddr4_pmu_train_1d_imem_pad.bin
 		objcopy -I binary -O binary --pad-to 0x4000 --gap-fill=0x0 $srctree/lpddr4_pmu_train_1d_dmem.bin lpddr4_pmu_train_1d_dmem_pad.bin
Signature · 1 line
2.19.2
#1 lore raw

PATCH 2/2 imx8mq_evk/README: remove ARCH environment variable

There is no need to set the ARCH variable when building U-Boot. In fact, the ARCH name in U-Boot is 'arm'.

---
 board/freescale/imx8mq_evk/README | 1 -
 1 file changed, 1 deletion(-)
board/freescale/imx8mq_evk/README +0 -1
index 07dbfb01fed8..1da6eaf24277 100644
@@ -23,7 +23,6 @@ $ cp firmware-imx-7.9/firmware-imx-7.9/firmware/ddr/synopsys/lpddr4*.bin $(srcte
 
 Build U-Boot
 ====================
-$ export ARCH=arm64
 $ export CROSS_COMPILE=aarch64-poky-linux-
 $ make imx8mq_evk_defconfig
 $ make flash.bin
Signature · 1 line
2.19.2
#2 lore raw

PATCH 2/2 imx8mq_evk/README: remove ARCH environment variable

Quoted 3 lines

There is no need to set the ARCH variable when building U-Boot. In fact, the ARCH name in U-Boot is 'arm'.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#6 lore raw

PATCH 2/2 imx8mq_evk/README: remove ARCH environment variable

Hi Stefano,

Quoted 5 lines · sbabic at denx.de
Quoted 3 lines

There is no need to set the ARCH variable when building U-Boot. In fact, the ARCH name in U-Boot is 'arm'.

Applied to u-boot-imx, master, thanks !

Thanks.

What about patch #1 in this series? It fixes build failure when /bin/sh is not bash.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#7 lore raw

PATCH 2/2 imx8mq_evk/README: remove ARCH environment variable

Hi Baruch,

Quoted 7 lines · Baruch Siach

Hi Stefano,

Quoted 4 lines · sbabic at denx.de
Quoted 3 lines

There is no need to set the ARCH variable when building U-Boot. In fact, the ARCH name in U-Boot is 'arm'.

Quoted 7 lines
Quoted 1 line

Applied to u-boot-imx, master, thanks !

Thanks.

What about patch #1 in this series? It fixes build failure when /bin/sh is not bash.

I suffer from the prejudice that a single "=" is always bad in a comparison.....I am surely influenced from bugs in C/C++ due to a missing "=" in my experience as developer.

I searched for such as comparison in other parts of build to justify this patch : I have just found it in "test/fs" (ok, this is not really part of build) and in ./lib/lzma/import_lzmasdk.sh. I fully agree that this could be just a problem of mine, and I confess I was already merged your patch and then removed again..

Apart of this, it looks like that a single "=" was already avoided in U-Boot scripts like the pest. Apart of the single entry I found above, it was avoided..

What about to substitute "=" with an explicit "-eq" ? Like :

	[ $f -eq "spl/u-boot-spl-ddr.bin" ]

Best regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#8 lore raw

PATCH 2/2 imx8mq_evk/README: remove ARCH environment variable

Hi Stefano,

Quoted 23 lines · Stefano Babic
Quoted 11 lines · Baruch Siach
Quoted 5 lines · sbabic at denx.de
Quoted 3 lines

There is no need to set the ARCH variable when building U-Boot. In fact, the ARCH name in U-Boot is 'arm'.

Applied to u-boot-imx, master, thanks !

Thanks.

What about patch #1 in this series? It fixes build failure when /bin/sh is not bash.

I suffer from the prejudice that a single "=" is always bad in a comparison.....I am surely influenced from bugs in C/C++ due to a missing "=" in my experience as developer.

I searched for such as comparison in other parts of build to justify this patch : I have just found it in "test/fs" (ok, this is not really part of build) and in ./lib/lzma/import_lzmasdk.sh. I fully agree that this could be just a problem of mine, and I confess I was already merged your patch and then removed again..

Quoted 7 lines

Apart of this, it looks like that a single "=" was already avoided in U-Boot scripts like the pest. Apart of the single entry I found above, it was avoided..

What about to substitute "=" with an explicit "-eq" ? Like :

	[ $f -eq "spl/u-boot-spl-ddr.bin" ]

The '-eq' operator only accept integers:

$ [ f -eq "spl/u-boot-spl-ddr.bin" ]
bash: test: f: integer expression expected

The alternative is to set the script shebang to /bin/bash. I don't like this solution. What do you think?

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#9 lore raw

PATCH 2/2 imx8mq_evk/README: remove ARCH environment variable

Quoted 34 lines · Baruch Siach

Hi Stefano,

Quoted 23 lines · Stefano Babic
Quoted 11 lines · Baruch Siach
Quoted 5 lines · sbabic at denx.de
Quoted 3 lines

There is no need to set the ARCH variable when building U-Boot. In fact, the ARCH name in U-Boot is 'arm'.

Applied to u-boot-imx, master, thanks !

Thanks.

What about patch #1 in this series? It fixes build failure when /bin/sh is not bash.

I suffer from the prejudice that a single "=" is always bad in a comparison.....I am surely influenced from bugs in C/C++ due to a missing "=" in my experience as developer.

I searched for such as comparison in other parts of build to justify this patch : I have just found it in "test/fs" (ok, this is not really part of build) and in ./lib/lzma/import_lzmasdk.sh. I fully agree that this could be just a problem of mine, and I confess I was already merged your patch and then removed again..

Quoted 7 lines

Apart of this, it looks like that a single "=" was already avoided in U-Boot scripts like the pest. Apart of the single entry I found above, it was avoided..

What about to substitute "=" with an explicit "-eq" ? Like :

	[ $f -eq "spl/u-boot-spl-ddr.bin" ]
Quoted 7 lines

The '-eq' operator only accept integers:

$ [ f -eq "spl/u-boot-spl-ddr.bin" ]
bash: test: f: integer expression expected

The alternative is to set the script shebang to /bin/bash. I don't like this solution. What do you think?

Is not possible to change the behavior of the script filtering the $blobs variable before evaluating ? The check is just for skipping these two files.

Something like :

blobs=`awk '/^SIGNED_HDMI/ {print $2} /^LOADER/ {print $2}
/^SECOND_LOADER/ {print $2} /^DDR_FW/ {print $2}' $file` | grep -v ""spl/u-boot-spl-ddr.bin" | ......

It look to me better to put in $blobs just the values that must be evaluated instead of checking them later. $blobs is not evaluated anymore.

Best regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#10 lore raw

PATCH 1/2 tools/imx8m_image.sh: remove bashism

In reply to Baruch Siach
Quoted 10 lines · Baruch Siach

Use a single '=' to test string equality for compatibility with non-bash shells. Otherwise, if /bin/sh is dash, build fails:

./tools/imx8m_image.sh: 15: [: signed_hdmi_imx8m.bin: unexpected operator ./tools/imx8m_image.sh: 15: [: signed_hdmi_imx8m.bin: unexpected operator ./tools/imx8m_image.sh: 15: [: spl/u-boot-spl-ddr.bin: unexpected operator ./tools/imx8m_image.sh: 15: [: spl/u-boot-spl-ddr.bin: unexpected operator WARNING './spl/u-boot-spl-ddr.bin' not found, resulting binary is not-functional

Thanks,
Chris

Disclaimer:

This email has been scanned for all known viruses by the MessageLabs Email Security System.

The contents of this email (including any attachments) are intended for the use of the mail addressee(s) shown, hence is private and in addition may include commercially sensitive information. If you are not the intended recipient of this email any disclosure, copying, distribution or use of its contents is strictly prohibited. You should notify the sender immediately and then delete it (including any attachments) from your system.

The information contained in or attached to this message may also be subject to the export control laws and regulations of the United Kingdom and the United States. This specifically includes, but is not limited to, the Arms Export Control Act (22 U.S.C. 2751-2794) and the International Traffic in Arms Regulation (22 C.F.R 120-130) as well as the Export Administration Act (50 U.S.C. App. 2401-2420), the Export Administration Regulation (15 C.F.R. 730-774) and the UK Export Control Act 2002.

Please help out the environment by only printing this e-mail if absolutely necessary - Thank you.

SEA is the brand name of Systems Engineering & Assessment Ltd (registered office: Beckington Castle, 17 Castle Corner, Beckington, Frome, Somerset, BA11 6TA, UK - company number 02302168).

reviewer
#11 lore raw

PATCH 1/2 tools/imx8m_image.sh: remove bashism

In reply to Baruch Siach

Hi Baruch and Stefano,

Quoted 11 lines · Baruch Siach

Use a single '=' to test string equality for compatibility with non-bash shells. Otherwise, if /bin/sh is dash, build fails:

./tools/imx8m_image.sh: 15: [: signed_hdmi_imx8m.bin: unexpected operator ./tools/imx8m_image.sh: 15: [: signed_hdmi_imx8m.bin: unexpected operator ./tools/imx8m_image.sh: 15: [: spl/u-boot-spl-ddr.bin: unexpected operator ./tools/imx8m_image.sh: 15: [: spl/u-boot-spl-ddr.bin: unexpected operator WARNING './spl/u-boot-spl-ddr.bin' not found, resulting binary is not-functional

I don't see this patch applied yet.

Do we have other solution?

Thanks

#12 lore raw

PATCH 1/2 tools/imx8m_image.sh: remove bashism

Hi Fabio,

Quoted 11 lines · Fabio Estevam
Quoted 10 lines · Baruch Siach

Use a single '=' to test string equality for compatibility with non-bash shells. Otherwise, if /bin/sh is dash, build fails:

./tools/imx8m_image.sh: 15: [: signed_hdmi_imx8m.bin: unexpected operator ./tools/imx8m_image.sh: 15: [: signed_hdmi_imx8m.bin: unexpected operator ./tools/imx8m_image.sh: 15: [: spl/u-boot-spl-ddr.bin: unexpected operator ./tools/imx8m_image.sh: 15: [: spl/u-boot-spl-ddr.bin: unexpected operator WARNING './spl/u-boot-spl-ddr.bin' not found, resulting binary is not-functional

Quoted 5 lines
Quoted 1 line

I don't see this patch applied yet.

Do we have other solution?

Stefano suggested an alternative in reply to the other patch:

https://lists.denx.de/pipermail/u-boot/2019-January/356941.html

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
#13 lore raw

PATCH 1/2 tools/imx8m_image.sh: remove bashism

In reply to Fabio Estevam

Hello everyone,

Quoted 10 lines · Fabio Estevam
Quoted 9 lines · Baruch Siach

Use a single '=' to test string equality for compatibility with non-bash shells. Otherwise, if /bin/sh is dash, build fails:

./tools/imx8m_image.sh: 15: [: signed_hdmi_imx8m.bin: unexpected operator ./tools/imx8m_image.sh: 15: [: signed_hdmi_imx8m.bin: unexpected operator ./tools/imx8m_image.sh: 15: [: spl/u-boot-spl-ddr.bin: unexpected operator ./tools/imx8m_image.sh: 15: [: spl/u-boot-spl-ddr.bin: unexpected operator WARNING './spl/u-boot-spl-ddr.bin' not found, resulting binary is not-functional

Quoted 5 lines
Quoted 1 line

I don't see this patch applied yet.

Do we have other solution?

This is still broken and the proposed patch does fix it. We should get this merged for 2019.04 release.

Please Stefano, consider this for release (be it through your branch for directly by Tom).

Best Regards,

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750
#14 lore raw

PATCH 1/2 tools/imx8m_image.sh: remove bashism

Hi Otavio,

Quoted 17 lines · Otavio Salvador

Hello everyone,

Quoted 14 lines · Fabio Estevam
Quoted 10 lines · Baruch Siach

Use a single '=' to test string equality for compatibility with non-bash shells. Otherwise, if /bin/sh is dash, build fails:

./tools/imx8m_image.sh: 15: [: signed_hdmi_imx8m.bin: unexpected operator ./tools/imx8m_image.sh: 15: [: signed_hdmi_imx8m.bin: unexpected operator ./tools/imx8m_image.sh: 15: [: spl/u-boot-spl-ddr.bin: unexpected operator ./tools/imx8m_image.sh: 15: [: spl/u-boot-spl-ddr.bin: unexpected operator WARNING './spl/u-boot-spl-ddr.bin' not found, resulting binary is not-functional

I don't see this patch applied yet.

Quoted 8 lines
Quoted 1 line

Do we have other solution?

This is still broken and the proposed patch does fix it. We should get this merged for 2019.04 release.

Please Stefano, consider this for release (be it through your branch for directly by Tom).

The thing is in which conditions this is broken and why it should be fixed here and in this way. Yes, I admit, I have not pondered this as a big issue - it could be also fixed replacing dash with bash on Debian-like distros, and I guess also on not-debian. And I am quite sure we cannot ensure compatibility with all possible shell that a customer will try , from csh to some exotic variant. Why is this so important to be rapidely fixed here ?

Best regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
reviewer
#15 lore raw

PATCH 1/2 tools/imx8m_image.sh: remove bashism

Hi Stefano,

Quoted 7 lines · Stefano Babic

The thing is in which conditions this is broken and why it should be fixed here and in this way. Yes, I admit, I have not pondered this as a big issue - it could be also fixed replacing dash with bash on Debian-like distros, and I guess also on not-debian. And I am quite sure we cannot ensure compatibility with all possible shell that a customer will try , from csh to some exotic variant. Why is this so important to be rapidely fixed here ?

On my Ubuntu 18.04 host I cannot build U-Boot for imx8mq-evk without this patch, so it would be really nice if we could get Baruch's or any other solution that fixes this issue.

Thanks

#16 lore raw

PATCH 1/2 tools/imx8m_image.sh: remove bashism

Hi Fabio,

Quoted 12 lines · Fabio Estevam

Hi Stefano,

Quoted 7 lines · Stefano Babic

The thing is in which conditions this is broken and why it should be fixed here and in this way. Yes, I admit, I have not pondered this as a big issue - it could be also fixed replacing dash with bash on Debian-like distros, and I guess also on not-debian. And I am quite sure we cannot ensure compatibility with all possible shell that a customer will try , from csh to some exotic variant. Why is this so important to be rapidely fixed here ?

Quoted 3 lines

On my Ubuntu 18.04 host I cannot build U-Boot for imx8mq-evk without this patch, so it would be really nice if we could get Baruch's or any other solution that fixes this issue.

Well, it looks like too much because I have 18.04, too, and I can build. I cannot say that Ubuntu users cannot build u-boot anymore. I guess you have /bin/sh -> dash, and /bin/sh -> bash solves the problem, too. Or using update-alternatives, as we are in Ubuntu. I can imagine it is disturbing in docker because a further step in docker-compose to set up the shell is required, too.
As far as I know, default is dash (but was not dash default a long of time ago ? I wonder this has become an issue recently, I have missed something in the between). Nevertheless, I am still missing why this is so important to push here when the user can set the shell and build without issues. And travis works, too, it is also based on Ubuntu :
trusty, quite old, but I was convinced that dash was the default in Ubuntu since a long time.

Maybe I am missing the point here...(to be honest: I put the patch in "Changes requested" a lot of time ago and I have forgotten about it..)

Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
reviewer
#17 lore raw

PATCH 1/2 tools/imx8m_image.sh: remove bashism

Hi Stefano,

Quoted 11 lines · Stefano Babic

Well, it looks like too much because I have 18.04, too, and I can build. I cannot say that Ubuntu users cannot build u-boot anymore. I guess you have /bin/sh -> dash, and /bin/sh -> bash solves the problem, too. Or using update-alternatives, as we are in Ubuntu. I can imagine it is disturbing in docker because a further step in docker-compose to set up the shell is required, too.
As far as I know, default is dash (but was not dash default a long of time ago ? I wonder this has become an issue recently, I have missed something in the between). Nevertheless, I am still missing why this is so important to push here when the user can set the shell and build without issues. And travis works, too, it is also based on Ubuntu :

Travis does not report an error, but Travis does not try to generate a real 'flash.bin' with the required DDR, HDMI and ATF firmwares.

The error comes when we try to generate flash.bin with all these firmwares.

Without Baruch's patch I can not generate a flash.bin that can boot on im8mq-evk, so that's why I see the lack of this patch as a big issue.

Thanks

#18 lore raw

PATCH 1/2 tools/imx8m_image.sh: remove bashism

Hi Fabio, Otavio,

Quoted 16 lines · Fabio Estevam

Hi Stefano,

Quoted 11 lines · Stefano Babic

Well, it looks like too much because I have 18.04, too, and I can build. I cannot say that Ubuntu users cannot build u-boot anymore. I guess you have /bin/sh -> dash, and /bin/sh -> bash solves the problem, too. Or using update-alternatives, as we are in Ubuntu. I can imagine it is disturbing in docker because a further step in docker-compose to set up the shell is required, too.
As far as I know, default is dash (but was not dash default a long of time ago ? I wonder this has become an issue recently, I have missed something in the between). Nevertheless, I am still missing why this is so important to push here when the user can set the shell and build without issues. And travis works, too, it is also based on Ubuntu :

Quoted 8 lines

Travis does not report an error, but Travis does not try to generate a real 'flash.bin' with the required DDR, HDMI and ATF firmwares.

The error comes when we try to generate flash.bin with all these firmwares.

Without Baruch's patch I can not generate a flash.bin that can boot on im8mq-evk, so that's why I see the lack of this patch as a big issue.

Ok - convinced. I pick it up.

Regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#19 lore raw

PATCH 1/2 tools/imx8m_image.sh: remove bashism

In reply to Stefano Babic
Quoted 7 lines · Stefano Babic
Quoted 6 lines

This is still broken and the proposed patch does fix it. We should get this merged for 2019.04 release.

Please Stefano, consider this for release (be it through your branch for directly by Tom).

Quoted 7 lines

The thing is in which conditions this is broken and why it should be fixed here and in this way. Yes, I admit, I have not pondered this as a big issue - it could be also fixed replacing dash with bash on Debian-like distros, and I guess also on not-debian. And I am quite sure we cannot ensure compatibility with all possible shell that a customer will try , from csh to some exotic variant. Why is this so important to be rapidely fixed here ?

The dash uses POSIX syntax and it failing on this is a bad signal. Asking people to change the default system shell to build U-Boot is no sense.

We cannot ensure compatibility, for sure, but using bashism makes it worse and non POSIX compatible.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750
#20 lore raw

PATCH 1/2 tools/imx8m_image.sh: remove bashism

In reply to Stefano Babic
Quoted 29 lines · Stefano Babic

Hi Otavio,

Quoted 17 lines · Otavio Salvador

Hello everyone,

Quoted 14 lines · Fabio Estevam
Quoted 10 lines · Baruch Siach

Use a single '=' to test string equality for compatibility with non-bash shells. Otherwise, if /bin/sh is dash, build fails:

./tools/imx8m_image.sh: 15: [: signed_hdmi_imx8m.bin: unexpected operator ./tools/imx8m_image.sh: 15: [: signed_hdmi_imx8m.bin: unexpected operator ./tools/imx8m_image.sh: 15: [: spl/u-boot-spl-ddr.bin: unexpected operator ./tools/imx8m_image.sh: 15: [: spl/u-boot-spl-ddr.bin: unexpected operator WARNING './spl/u-boot-spl-ddr.bin' not found, resulting binary is not-functional

I don't see this patch applied yet.

Quoted 8 lines
Quoted 1 line

Do we have other solution?

This is still broken and the proposed patch does fix it. We should get this merged for 2019.04 release.

Please Stefano, consider this for release (be it through your branch for directly by Tom).

Quoted 7 lines

The thing is in which conditions this is broken and why it should be fixed here and in this way. Yes, I admit, I have not pondered this as a big issue - it could be also fixed replacing dash with bash on Debian-like distros, and I guess also on not-debian. And I am quite sure we cannot ensure compatibility with all possible shell that a customer will try , from csh to some exotic variant. Why is this so important to be rapidely fixed here ?

The script says it uses /bin/sh and not /bin/bash, so you cannot do bashism in there.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190401/cc0f4eec/attachment.sig>