Skip to contentSkip to conversation

website: footer.html: use 1.7.1 release of clipboard.js

PATCH New Peter Korsgaard 1 participant 5 messages Apr 27, 2018 – Apr 28, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 website: footer.html: use 1.7.1 release of clipboard.js

The clipboard javascript code causes an error:

Uncaught TypeError: Illegal constructor
at buildroot.js:58

Which is caused by a recent change in upstream clipboard.js:

https://github.com/zenorocha/clipboard.js/releases/tag/v2.0.0

Changes constructor from new Clipboard() to new ClipboardJS()

The issue was that we were using the master version of clipboard.js instead of a specific release. Fix it by using the 1.7.1 version (latest release before the constructor change) instead.

---
 docs/website/footer.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
docs/website/footer.html +1 -1
index 279c8b1b5c..60a8872f77 100644
@@ -1,6 +1,6 @@
 	<script src="https://code.jquery.com/jquery-3.1.1.min.js"></script>
 	<script src="https://oss.maxcdn.com/bootstrap/3.3.7/js/bootstrap.min.js"></script>
-	<script src="https://cdn.rawgit.com/zenorocha/clipboard.js/master/dist/clipboard.min.js"></script>
+	<script src="https://cdn.rawgit.com/zenorocha/clipboard.js/v2.0.0/dist/clipboard.min.js"></script>
 	<script type="text/javascript" src="js/buildroot.js"></script>
 </body>
 </html>
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/2 website: footer.html: use 1.7.1 release of clipboard.js

Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Korsgaard <[email protected]> writes:

The clipboard javascript code causes an error:
Uncaught TypeError: Illegal constructor
at buildroot.js:58

Which is caused by a recent change in upstream clipboard.js:

https://github.com/zenorocha/clipboard.js/releases/tag/v2.0.0

Quoted 7 lines

Changes constructor from new Clipboard() to new ClipboardJS()

The issue was that we were using the master version of clipboard.js instead of a specific release. Fix it by using the 1.7.1 version (latest release before the constructor change) instead.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/2 website: footer.html: use 1.7.1 release of clipboard.js

In reply to Peter Korsgaard
Quoted 26 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Korsgaard <[email protected]> writes:

The clipboard javascript code causes an error:
Uncaught TypeError: Illegal constructor
at buildroot.js:58

Which is caused by a recent change in upstream clipboard.js:

https://github.com/zenorocha/clipboard.js/releases/tag/v2.0.0

Changes constructor from new Clipboard() to new ClipboardJS()

The issue was that we were using the master version of clipboard.js instead of a specific release. Fix it by using the 1.7.1 version (latest release before the constructor change) instead.

---
 docs/website/footer.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
docs/website/footer.html +0 -0
index 279c8b1b5c..60a8872f77 100644

docs/website/footer.html line 3

Quoted 4 lines
docs/website/footer.html +1 -1
@@ -1,6 +1,6 @@
 	<script src="https://code.jquery.com/jquery-3.1.1.min.js"></script>
 	<script src="https://oss.maxcdn.com/bootstrap/3.3.7/js/bootstrap.min.js"></script>
-	<script src="https://cdn.rawgit.com/zenorocha/clipboard.js/master/dist/clipboard.min.js"></script>
+	<script src="https://cdn.rawgit.com/zenorocha/clipboard.js/v2.0.0/dist/clipboard.min.js"></script>

Ehh, this was naturally meant to be v1.7.1, I forgot to save muy buffer. I've fixed it now.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 2/2 docs/website: add favicon.png

In reply to Peter Korsgaard

The website advertises a favicon in PNG format, but we don't actually provide one. From docs/website/header.html:

<link rel="shortcut icon" href="images/favicon.png">

So add one. Generated by:

convert -geometry 32x32! docs/website/images/logo_small.png \
docs/website/favicon.png

---
 docs/website/favicon.png | Bin 0 -> 1801 bytes
 1 file changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 docs/website/favicon.png
docs/website/favicon.png new file binary +0 -0
new file mode 100644
index 0000000000000000000000000000000000000000..3bfe1ba76eae9ee9ddc267f8acd1c624bbf3483c
GIT binary patch

zW;p%J+^V8Oq6!61cm(WUPFx&O(+*IeR}oAY<AeR<n+ at r;JJIRwZJlAf9k!UE4IK$ z@bGXS={oHn*y4DBsd+614|owEN{wt(p>I7bUwi^Fvj$>0=|F$?;|v>9^RAUW#D9 z-rD#uLZhn(sIZQ6px>H9(P9{gHD2;_aaO6VB6VkBVE3(Jwrc6_;iw#TpV2D8Lokq zKhtMwf<1Xf0G!zs%n#Vs_rz@h_4)IDjTK^yE{bm6||K+4<i2<oSEJiLjW|C_|>r zM&Nbjg|O$BV{EdNRib at Cxt2rys*nW$9kJ(loK7!&b%We8So?AX(sxE at 9m$hO*?K> zVpbe0MV8^@!>U}BUV#)rcbIGZn{uq*1lCI#&7RM=s%V)=e0WaFy6sRn9Ng&;GuF( zC)wWqAwtG!q<WTa&3gD${O;a7qVQ=_tiCx-ZA5+3!<nkXVZh2!_^BkWhbz^gOb1& z<Bbq7_j<L%Y1)rEtkx3<BTa%7x>8b!cKA|=D>m+m at T#1WQny@;3=|!ydaA9wekG z)N49whPLpMV*tds;Tq6 at E?=QE>4yJ=$EIInK8u-=#^oGBufPf6#bZxwBz{ZgM| zBLCxW7|#1 at Zv3uMYrXSJt--0r{L!8To9rKBW2}vi;B(ijB~g7C+?uXlL3GVsgTcx zP7m}qQeBr?%iy26HqRvrJhf_xS2j0VJ79sN>Gtov_ at 6QW6rgh>`ppsMpV3GXL&43 zXT}F}SZwj=QU#=J9E?a#&Dd8T+WxJ3!L+90ok6XG)|hCEkpST)w90Bi65s0pV}!!$ z;Dpkx7MFzA7#7lknR$zbW8=;=x2U-j3(REnPUtQ_BMMkgqrA{g+S!!LHL+TB8&oD7 za-Sw8k16S4$j4P{FSSb(upUjsfd*17Ds+$cgGgFwklr?ojJsQ8S72Z~I83qXnnm>C zUgj!45L&_27WQr>s7%Sfoc;FlYSbYYOIx_I-;=8S;hcS<pl(6IB^}O6kkey-1& zJvEGO5U6)<;MKKD at CS{i8Vi}MdFf)**)=5z!F7uEE=-DLCtK;*?jGOs(S*<gImmvW zJ=}dstrFob==KIbbbemva1&2r2aA<WnYcoHXwPaszva7O@ri2NhYYas!J#-rFaWV zu%|{#SHqu7ed!1<E7S2uM*fxoqlp{lD<+P!!iv>%DKAvw#=15|4hpa29PWimyD-< zREM<f${Mvsu70ojenHi-=)odFtzlpvGB_s=i7)!(7a3zXwJXBba$a;f;a$jg8Nf zUKKbY7rLmWM=h?(J%TVE{hog1GBu2rdPD5^><YZXZ#POHmB>nOyMyoVzaJ;<A-l7) zJ%)D_?)0oMxPU~)@WY?kK&6B@vk~-KTamtFV+PTW=qAVUXoyjWhQQ|V_!90?WhcF z*4gJC?_~R;DC2kZ*O;Ulj;B&Lo6Rm=AE)_uQFP};QUJWKT0ObsajNnOuj?oX4~dG zE9uK&c{Sg178LVqQSYL36#mf|kmLicmB}ff^!~zcXgp<S^j}5)d$@n|AhOXGZHWz2 z>JI(fo-*vLNYLujkV*Nu*FWYhUdx%7=oL&5y(l3|uKRYJtk+vq>wP~eXe|wMFS0yr zE%4-rjbB&qFeL$^OOAj>qiNbp3(fVBL8Z)tt}>+;f346(3)9=T+gXDH^%25Ip^FD zsjKx6suG^LnEbT_)v>*DEU at W3V@AHmLi74~loyhjCIyKsBDP%xis-MxZrRH_V_9f zXn|_S?6sbOH5op^7n!=|=M@$f=I8qIqcDQYzqZ{a0C3J%PlmRJy7pCzy^cuU%91ZI zDtHTjp_EKjKj<fqq?~*j!$a{ic{7jrPUL=k4Eg#$fclw0AgSWxb!E{BZTM$5BCl6 zfm>Q*?HpspWVs>LqmUQZGA8^t0rU{MM%oBHE*x|Xj1h)hXd-lt5r|AaHLw3E1O$2c YlJ5Th0>h0u&Mg3Ij4k at j#hY<|11;`3<p2Nx

literal 0
HcmV?d00001

Signature · 1 line
2.11.0
#4 lore raw

PATCH 2/2 docs/website: add favicon.png

Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Korsgaard <[email protected]> writes:

The website advertises a favicon in PNG format, but we don't actually provide one. From docs/website/header.html:

Quoted 8 lines

<link rel="shortcut icon" href="images/favicon.png">

So add one. Generated by:

convert -geometry 32x32! docs/website/images/logo_small.png \
docs/website/favicon.png

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard