Skip to contentSkip to conversation

meson: add configuration summary

PATCH In review Eric Engestrom 3 participants 5 messages Feb 27, 2018 – Feb 28, 2018 Arm/Amlogic Meson SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 meson: add configuration summary

The message block printed is the same as the one in configure.ac

---
 meson.build | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
meson.build +17 -0
index bd00cdc2cae9f0749180..ab6f881755935968b822 100644
@@ -373,3 +373,20 @@ if with_man_pages
 endif
 subdir('data')
 subdir('tests')
+
+message('')
+message('@0@ will be compiled with:'.format(meson.project_name()))
+message('')
+message('  libkms         @0@'.format(with_libkms))
+message('  Intel API      @0@'.format(with_intel))
+message('  vmwgfx API     @0@'.format(with_vmwgfx))
+message('  Radeon API     @0@'.format(with_radeon))
+message('  AMDGPU API     @0@'.format(with_amdgpu))
+message('  Nouveau API    @0@'.format(with_nouveau))
+message('  OMAP API       @0@'.format(with_omap))
+message('  EXYNOS API     @0@'.format(with_exynos))
+message('  Freedreno API  @0@ (kgsl: @1@)'.format(with_freedreno, with_freedreno_kgsl))
+message('  Tegra API      @0@'.format(with_tegra))
+message('  VC4 API        @0@'.format(with_vc4))
+message('  Etnaviv API    @0@'.format(with_etnaviv))
+message('')
Signature · 7 lines
Cheers,
  Eric

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw

Quoting Eric Engestrom (2018-02-27 03:11:07)

Quoted 36 lines

The message block printed is the same as the one in configure.ac

---
 meson.build | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
meson.build +17 -0
index bd00cdc2cae9f0749180..ab6f881755935968b822 100644
@@ -373,3 +373,20 @@ if with_man_pages
 endif
 subdir('data')
 subdir('tests')
+
+message('')
+message('@0@ will be compiled with:'.format(meson.project_name()))
+message('')
+message('  libkms         @0@'.format(with_libkms))
+message('  Intel API      @0@'.format(with_intel))
+message('  vmwgfx API     @0@'.format(with_vmwgfx))
+message('  Radeon API     @0@'.format(with_radeon))
+message('  AMDGPU API     @0@'.format(with_amdgpu))
+message('  Nouveau API    @0@'.format(with_nouveau))
+message('  OMAP API       @0@'.format(with_omap))
+message('  EXYNOS API     @0@'.format(with_exynos))
+message('  Freedreno API  @0@ (kgsl: @1@)'.format(with_freedreno, with_freedreno_kgsl))
+message('  Tegra API      @0@'.format(with_tegra))
+message('  VC4 API        @0@'.format(with_vc4))
+message('  Etnaviv API    @0@'.format(with_etnaviv))
+message('')
Signature · 2 lines
Cheers,
  Eric

This one is certainly simple enough that we can use a single message call and a ''' string :)

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#2 lore raw
Quoted 33 lines · Dylan Baker

[ Unknown signature status ]
Quoting Eric Engestrom (2018-02-27 03:11:07)

Quoted 31 lines

The message block printed is the same as the one in configure.ac

---
 meson.build | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
meson.build +16 -0
index bd00cdc2cae9f0749180..ab6f881755935968b822 100644
@@ -373,3 +373,20 @@ if with_man_pages
 endif
 subdir('data')
 subdir('tests')
+
+message('')
+message('@0@ will be compiled with:'.format(meson.project_name()))
+message('')
+message('  libkms         @0@'.format(with_libkms))
+message('  Intel API      @0@'.format(with_intel))
+message('  vmwgfx API     @0@'.format(with_vmwgfx))
+message('  Radeon API     @0@'.format(with_radeon))
+message('  AMDGPU API     @0@'.format(with_amdgpu))
+message('  Nouveau API    @0@'.format(with_nouveau))
+message('  OMAP API       @0@'.format(with_omap))
+message('  EXYNOS API     @0@'.format(with_exynos))
+message('  Freedreno API  @0@ (kgsl: @1@)'.format(with_freedreno, with_freedreno_kgsl))
+message('  Tegra API      @0@'.format(with_tegra))
+message('  VC4 API        @0@'.format(with_vc4))
+message('  Etnaviv API    @0@'.format(with_etnaviv))
Quoted 8 lines
Quoted 5 lines
meson.build +1 -0
+message('')
Signature · 2 lines
Cheers,
  Eric

This one is certainly simple enough that we can use a single message call and a ''' string :)

But then you end up with 13 @n@ values and when someone wants to put something earlier in the list for some sorting reason, then they need to renumber the rest. This is much nicer.

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#3 lore raw
Quoted 44 lines · Eric Anholt
Quoted 33 lines · Dylan Baker

[ Unknown signature status ]
Quoting Eric Engestrom (2018-02-27 03:11:07)

Quoted 31 lines

The message block printed is the same as the one in configure.ac

---
 meson.build | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
meson.build +16 -0
index bd00cdc2cae9f0749180..ab6f881755935968b822 100644
@@ -373,3 +373,20 @@ if with_man_pages
 endif
 subdir('data')
 subdir('tests')
+
+message('')
+message('@0@ will be compiled with:'.format(meson.project_name()))
+message('')
+message('  libkms         @0@'.format(with_libkms))
+message('  Intel API      @0@'.format(with_intel))
+message('  vmwgfx API     @0@'.format(with_vmwgfx))
+message('  Radeon API     @0@'.format(with_radeon))
+message('  AMDGPU API     @0@'.format(with_amdgpu))
+message('  Nouveau API    @0@'.format(with_nouveau))
+message('  OMAP API       @0@'.format(with_omap))
+message('  EXYNOS API     @0@'.format(with_exynos))
+message('  Freedreno API  @0@ (kgsl: @1@)'.format(with_freedreno, with_freedreno_kgsl))
+message('  Tegra API      @0@'.format(with_tegra))
+message('  VC4 API        @0@'.format(with_vc4))
+message('  Etnaviv API    @0@'.format(with_etnaviv))
Quoted 8 lines
Quoted 5 lines
meson.build +1 -0
+message('')
Signature · 2 lines
Cheers,
  Eric

This one is certainly simple enough that we can use a single message call and a ''' string :)

Quoted 3 lines

But then you end up with 13 @n@ values and when someone wants to put something earlier in the list for some sorting reason, then they need to renumber the rest. This is much nicer.

I have to agree here. Dylan, why did you want to avoid multiple message()? They're not expensive afaict, so I'm not sure what the gain would be?

I also had a try, and multiline messages only get a Message: prefix on the first line, so combining them would result in unpredictable vertical alignments. Unless there's a good reason to merge them, I'll keep them separate.
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#4 lore raw

Quoting Eric Engestrom (2018-02-28 07:11:20)

Quoted 49 lines · Eric Anholt
Quoted 44 lines
Quoted 33 lines · Dylan Baker

[ Unknown signature status ]
Quoting Eric Engestrom (2018-02-27 03:11:07)

Quoted 31 lines

The message block printed is the same as the one in configure.ac

---
 meson.build | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
meson.build +16 -0
index bd00cdc2cae9f0749180..ab6f881755935968b822 100644
@@ -373,3 +373,20 @@ if with_man_pages
 endif
 subdir('data')
 subdir('tests')
+
+message('')
+message('@0@ will be compiled with:'.format(meson.project_name()))
+message('')
+message('  libkms         @0@'.format(with_libkms))
+message('  Intel API      @0@'.format(with_intel))
+message('  vmwgfx API     @0@'.format(with_vmwgfx))
+message('  Radeon API     @0@'.format(with_radeon))
+message('  AMDGPU API     @0@'.format(with_amdgpu))
+message('  Nouveau API    @0@'.format(with_nouveau))
+message('  OMAP API       @0@'.format(with_omap))
+message('  EXYNOS API     @0@'.format(with_exynos))
+message('  Freedreno API  @0@ (kgsl: @1@)'.format(with_freedreno, with_freedreno_kgsl))
+message('  Tegra API      @0@'.format(with_tegra))
+message('  VC4 API        @0@'.format(with_vc4))
+message('  Etnaviv API    @0@'.format(with_etnaviv))
Quoted 8 lines
Quoted 5 lines
meson.build +1 -0
+message('')
Signature · 2 lines
Cheers,
  Eric

This one is certainly simple enough that we can use a single message call and a ''' string :)

Quoted 3 lines

But then you end up with 13 @n@ values and when someone wants to put something earlier in the list for some sorting reason, then they need to renumber the rest. This is much nicer.

Quoted 8 lines

I have to agree here. Dylan, why did you want to avoid multiple message()? They're not expensive afaict, so I'm not sure what the gain would be?

I also had a try, and multiline messages only get a Message: prefix on the first line, so combining them would result in unpredictable vertical alignments. Unless there's a good reason to merge them, I'll keep them separate.

It's mostly my irrational OCD, but I think a long series of calls to print or message (or whatever your language calls it) are incredibly hard to read.

message('')
message('@0@ will be compiled with:'.format(meson.project_name())) message('')

message('  libkms         @0@'.format(with_libkms))
message('  Intel API      @0@'.format(with_intel))
message('  vmwgfx API     @0@'.format(with_vmwgfx))
message('  Radeon API     @0@'.format(with_radeon))
message('  AMDGPU API     @0@'.format(with_amdgpu))
message('  Nouveau API    @0@'.format(with_nouveau))
message('  OMAP API       @0@'.format(with_omap))
message('  EXYNOS API     @0@'.format(with_exynos))
message('  Freedreno API  @0@ (kgsl: @1@)'.format(with_freedreno, with_freedreno_kgsl))
message('  Tegra API      @0@'.format(with_tegra))
message('  VC4 API        @0@'.format(with_vc4))
message('  Etnaviv API    @0@'.format(with_etnaviv))

message('')

vs

message('''

@0@ will be compiled with:

  libkms         @1@
  Intel API      @2@
  vmwgfx API     @3@
  Radeon API     @4@
  AMDGPU API     @5@
  Nouveau API    @6@
  OMAP API       @7@
  EXYNOS API     @8@
  Freedreno API  @9@ (kgsl: @10@)
  Tegra API      @11@
  VC4 API        @12@
  Etnaviv API    @13@

'''.format(
meson.project_name(),
with_libkms,
with_intel,
with_vmwgfx,
...
)

I do have to admit that Anholt is right that the lack of either an inline replacement syntax or an unnumbered formatter makes this somewhat unwieldy in meson. And it's not that big of a deal either way I guess.

Dylan

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel