Skip to contentSkip to conversation

pinctrl: Fix armada-37xx pmic pin group numbering

PATCH New Henrik Juul Pedersen 2 participants 2 messages Nov 6, 2017

Subsystems (3)
GPIO Pin control Arm/Marvell Kirkwood and Armada 370, 375, 38x, 39x, XP, 3700, 7K/8K, CN9130 SoC support
lore
Share & tools
lore

Henrik Juul Pedersen

author
#0 lore raw

PATCH 1/1 pinctrl: Fix armada-37xx pmic pin group numbering

Fix pin numbering in Marvell ARMADA 37xx pincontroller.

The pmic0 and pmic1 pin groups start on pins 6 and 7 respectively.

Signed-off-by Henrik Juul Pedersen <[email protected]>
---
 drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
index 71b94474..e223fac2 100644

drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +0 -0
@@ -157,8 +157,8 @@ static struct armada_37xx_pin_group

armada_37xx_nb_groups[] = {
PIN_GRP_GPIO("pwm1", 12, 1, BIT(4), "pwm"),
PIN_GRP_GPIO("pwm2", 13, 1, BIT(5), "pwm"),
PIN_GRP_GPIO("pwm3", 14, 1, BIT(6), "pwm"),
- PIN_GRP_GPIO("pmic1", 17, 1, BIT(7), "pmic"),
- PIN_GRP_GPIO("pmic0", 16, 1, BIT(8), "pmic"),
+ PIN_GRP_GPIO("pmic1", 7, 1, BIT(7), "pmic"),
+ PIN_GRP_GPIO("pmic0", 6, 1, BIT(8), "pmic"),
PIN_GRP_GPIO("i2c2", 2, 2, BIT(9), "i2c"),
PIN_GRP_GPIO("i2c1", 0, 2, BIT(10), "i2c"),
PIN_GRP_GPIO("spi_cs1", 17, 1, BIT(12), "spi"),

Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 pinctrl: Fix armada-37xx pmic pin group numbering

Hi Henrik,

Quoted 5 lines · Henrik Juul Pedersen

Fix pin numbering in Marvell ARMADA 37xx pincontroller.

The pmic0 and pmic1 pin groups start on pins 6 and 7 respectively.

Signed-off-by Henrik Juul Pedersen <[email protected]>
Acked-by Gregory CLEMENT <[email protected]>

when applying the patch, we should also add:

Fixes 87466ccd9401 ("pinctrl: armada-37xx: Add pin controller support

for Armada 37xx")
Cc: <[email protected]>

Thanks,

Gregory

Quoted 28 lines
---
 drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +2 -2
index 71b94474..e223fac2 100644
@@ -157,8 +157,8 @@ static struct armada_37xx_pin_group
 armada_37xx_nb_groups[] = {
  PIN_GRP_GPIO("pwm1", 12, 1, BIT(4), "pwm"),
  PIN_GRP_GPIO("pwm2", 13, 1, BIT(5), "pwm"),
  PIN_GRP_GPIO("pwm3", 14, 1, BIT(6), "pwm"),
- PIN_GRP_GPIO("pmic1", 17, 1, BIT(7), "pmic"),
- PIN_GRP_GPIO("pmic0", 16, 1, BIT(8), "pmic"),
+ PIN_GRP_GPIO("pmic1", 7, 1, BIT(7), "pmic"),
+ PIN_GRP_GPIO("pmic0", 6, 1, BIT(8), "pmic"),
  PIN_GRP_GPIO("i2c2", 2, 2, BIT(9), "i2c"),
  PIN_GRP_GPIO("i2c1", 0, 2, BIT(10), "i2c"),

PIN_GRP_GPIO("spi_cs1", 17, 1, BIT(12), "spi"),

Signature · 6 lines
2.14.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com