Skip to contentSkip to conversation

tiff: ensure directory exists before installing to it

PATCH New Danomi Manchego 3 participants 9 messages Sep 12, 2014 – Sep 25, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tiff: ensure directory exists before installing to it

Also, don't ignore errors during installation.

---
 package/tiff/tiff.mk |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/tiff/tiff.mk +2 -1
index 8d2e087..c61894b 100644
@@ -76,7 +76,8 @@ ifneq ($(BR2_PACKAGE_TIFF_JBIG),y)
 endif
 
 define TIFF_INSTALL_TARGET_CMDS
-	-cp -a $(@D)/libtiff/.libs/libtiff.so* $(TARGET_DIR)/usr/lib/
+	mkdir -p $(TARGET_DIR)/usr/lib/
+	cp -a $(@D)/libtiff/.libs/libtiff.so* $(TARGET_DIR)/usr/lib/
 	for i in $(TIFF_TOOLS_LIST); \
 	do \
 		$(INSTALL) -m 755 -D $(@D)/tools/$$i $(TARGET_DIR)/usr/bin/$$i; \
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 tiff: ensure directory exists before installing to it

Dear Danomi Manchego,

Quoted 6 lines · Danomi Manchego

Also, don't ignore errors during installation.

---
 package/tiff/tiff.mk |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 tiff: ensure directory exists before installing to it

In reply to Danomi Manchego

Dear Danomi Manchego,

Quoted 6 lines · Danomi Manchego

Also, don't ignore errors during installation.

---
 package/tiff/tiff.mk |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Could you explain which configuration produced an issue solved by this patch? I tried a number of combinations (different toolchain configurations, without C++, etc.) and I did not managed to produce the issue.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 tiff: ensure directory exists before installing to it

Thomas,

Quoted 10 lines · Thomas Petazzoni

Dear Danomi Manchego,

Quoted 6 lines · Danomi Manchego

Also, don't ignore errors during installation.

---
 package/tiff/tiff.mk |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 4 lines

Could you explain which configuration produced an issue solved by this patch? I tried a number of combinations (different toolchain configurations, without C++, etc.) and I did not managed to produce the issue.

I do not have a defconfig that demonstrates this. I tend to encounter these kind of error when I do the following trick to observe what exactly is installed to the target directory:

    make tiff-rebuild TARGET_DIR=$(pwd)/TIFF
    tree TIFF

If I hit an error, they I figure that I'm just one mostly empty custom skeleton and convoluted dependency graph away from hitting the error in real life. So then I submit a patch.

Danomi -

#4 lore raw

PATCH 1/1 tiff: ensure directory exists before installing to it

Dear Danomi Manchego,

Quoted 10 lines · Danomi Manchego

I do not have a defconfig that demonstrates this. I tend to encounter these kind of error when I do the following trick to observe what exactly is installed to the target directory:

    make tiff-rebuild TARGET_DIR=$(pwd)/TIFF
    tree TIFF

If I hit an error, they I figure that I'm just one mostly empty custom skeleton and convoluted dependency graph away from hitting the error in real life. So then I submit a patch.

Ok, thanks for the explanation. However, I'm wondering if we want to support this. By doing this, you completely circumvent the preparation work that is done by Buildroot: when you do make tiff-rebuild, only the building and installation steps are re-executed with a different TARGET_DIR. So any preparation work done before, such as directories created by the global "dirs" target (on which all packages depend) will not be done in your new TARGET_DIR.

Peter, Fabio, any opinion on this?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#5 lore raw

PATCH 1/1 tiff: ensure directory exists before installing to it

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hi,

Quoted 19 lines
Quoted 10 lines

I do not have a defconfig that demonstrates this. I tend to encounter these kind of error when I do the following trick to observe what exactly is installed to the target directory:

make tiff-rebuild TARGET_DIR=$(pwd)/TIFF
tree TIFF

If I hit an error, they I figure that I'm just one mostly empty custom skeleton and convoluted dependency graph away from hitting the error in real life. So then I submit a patch.

Ok, thanks for the explanation. However, I'm wondering if we want to support this. By doing this, you completely circumvent the preparation work that is done by Buildroot: when you do make tiff-rebuild, only the building and installation steps are re-executed with a different TARGET_DIR. So any preparation work done before, such as directories created by the global "dirs" target (on which all packages depend) will not be done in your new TARGET_DIR.

Quoted 1 line

Peter, Fabio, any opinion on this?

I don't think it is something we should really officially support, but the specific patch is ok as such, so I will commit it.

Signature · 1 line
Bye, Peter Korsgaard
#6 lore raw

PATCH 1/1 tiff: ensure directory exists before installing to it

In reply to Danomi Manchego
Quoted 15 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Danomi" == Danomi Manchego <[email protected]> writes:

Also, don't ignore errors during installation.

---
 package/tiff/tiff.mk |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/tiff/tiff.mk +0 -0
index 8d2e087..c61894b 100644

package/tiff/tiff.mk ifneq ($(BR2_PACKAGE_TIFF_JBIG),y) · line 80

Quoted 6 lines
package/tiff/tiff.mk +2 -1
@@ -76,7 +76,8 @@ ifneq ($(BR2_PACKAGE_TIFF_JBIG),y)
 endif
 
 define TIFF_INSTALL_TARGET_CMDS
-	-cp -a $(@D)/libtiff/.libs/libtiff.so* $(TARGET_DIR)/usr/lib/
+	mkdir -p $(TARGET_DIR)/usr/lib/
+	cp -a $(@D)/libtiff/.libs/libtiff.so* $(TARGET_DIR)/usr/lib/

Hmm, so what happens with a BR2_PREFER_STATIC_LIB=y build?

Quoted 1 line
Quoted 1 line
Quoted 1 line

tiff 4.0.3 Installing to target

mkdir -p /home/peko/source/buildroot/output/target/usr/lib/
cp -a /home/peko/source/buildroot/output/build/tiff-4.0.3/libtiff/.libs/libtiff.so* /home/peko/source/buildroot/output/target/usr/lib/
cp: cannot stat ?/home/peko/source/buildroot/output/build/tiff-4.0.3/libtiff/.libs/libtiff.so*?: No such file or directory package/pkg-generic.mk:228: recipe for target '/home/peko/source/buildroot/output/build/tiff-4.0.3/.stamp_target_installed' failed
make: *** [/home/peko/source/buildroot/output/build/tiff-4.0.3/.stamp_target_installed] Error 1

Not good. Why are we not just using 'make install' and removing whatever binaries / extras we don't want like we do for other packages?

Signature · 1 line
Bye, Peter Korsgaard
#7 lore raw

PATCH 1/1 tiff: ensure directory exists before installing to it

Peter,

Quoted 25 lines · Peter Korsgaard
Quoted 15 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Danomi" == Danomi Manchego <[email protected]> writes:

Also, don't ignore errors during installation.

---
 package/tiff/tiff.mk |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/tiff/tiff.mk +0 -0
index 8d2e087..c61894b 100644

package/tiff/tiff.mk ifneq ($(BR2_PACKAGE_TIFF_JBIG),y) · line 80

Quoted 6 lines
package/tiff/tiff.mk +2 -1
@@ -76,7 +76,8 @@ ifneq ($(BR2_PACKAGE_TIFF_JBIG),y)
 endif
 
 define TIFF_INSTALL_TARGET_CMDS
-    -cp -a $(@D)/libtiff/.libs/libtiff.so* $(TARGET_DIR)/usr/lib/
+    mkdir -p $(TARGET_DIR)/usr/lib/
+    cp -a $(@D)/libtiff/.libs/libtiff.so* $(TARGET_DIR)/usr/lib/

Hmm, so what happens with a BR2_PREFER_STATIC_LIB=y build?

Quoted 1 line
Quoted 1 line
Quoted 1 line

tiff 4.0.3 Installing to target

Quoted 8 lines

mkdir -p /home/peko/source/buildroot/output/target/usr/lib/
cp -a /home/peko/source/buildroot/output/build/tiff-4.0.3/libtiff/.libs/libtiff.so* /home/peko/source/buildroot/output/target/usr/lib/
cp: cannot stat ?/home/peko/source/buildroot/output/build/tiff-4.0.3/libtiff/.libs/libtiff.so*?: No such file or directory package/pkg-generic.mk:228: recipe for target '/home/peko/source/buildroot/output/build/tiff-4.0.3/.stamp_target_installed' failed
make: *** [/home/peko/source/buildroot/output/build/tiff-4.0.3/.stamp_target_installed] Error 1

Not good. Why are we not just using 'make install' and removing whatever binaries / extras we don't want like we do for other packages?

Looking throught the git history of tiff.mk, it appears that the current cp command is a direct descendent of the original pre-AUTOTARGETS hand written makefile from 2007, which manually installed the .so and the .a files. The .a file installation was dropped in 2008 in commit 9844a8ea2c24f50e3e102eca6562cd879196fcea when the package was converted to AUTOTARGETS, with the manual cp command instead of calling 'make install'. I guess nobody who uses the prefer-static feature uses tiff. There are couple other commits after that that modify the install commands, but the basic cp was always maintained. So I imagined that everyone before me just did what I did - the minimum change to address the issue of the day.

I tried compiling tiff with the TIFF_INSTALL_TARGET_CMDS deleted, and it seemed to work fine for my configuration - lots of new stuff installed to /usr/bins, and .a, .la, .so + symlinks installed to /usr/lib, and a bunch of documentation and man pages. So, no obvious disaster.

I could try spinning another patch to use the 'make install'. But there are 23 of those tiff bins installed by the default install. Currently, we have kconfig enables for 2 of those 23. Should there be switches for all the other ones, or just a hard-coded deletion intiff.mk, like libjpeg's bins?

Danomi -

Quoted 2 lines

--
Bye, Peter Korsgaard

#8 lore raw

PATCH 1/1 tiff: ensure directory exists before installing to it

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Danomi" == Danomi Manchego <[email protected]> writes:

Hi,

Quoted 11 lines

I tried compiling tiff with the TIFF_INSTALL_TARGET_CMDS deleted, and it seemed to work fine for my configuration - lots of new stuff installed to /usr/bins, and .a, .la, .so + symlinks installed to /usr/lib, and a bunch of documentation and man pages. So, no obvious disaster.

I could try spinning another patch to use the 'make install'. But there are 23 of those tiff bins installed by the default install. Currently, we have kconfig enables for 2 of those 23. Should there be switches for all the other ones, or just a hard-coded deletion intiff.mk, like libjpeg's bins?

Thanks. I would prefer to keep the behaviour as it is today (E.G. keep the options for the 2 and delete everything else). If in the future people need any of the remaining 21 programs then we can add options then.

Thanks!

Signature · 1 line
Bye, Peter Korsgaard