Skip to contentSkip to conversation

efi: Fix the build with user namespaces enabled.

PATCH New Eric W. Biederman 1 participant 1 message Dec 18, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 efi: Fix the build with user namespaces enabled.

When compiling efivars.c the build fails with:

CC drivers/firmware/efivars.o
drivers/firmware/efivars.c: In function ‘efivarfs_get_inode’:
drivers/firmware/efivars.c:886:31: error: incompatible types when assigning to type ‘kgid_t’ from type ‘int’ make[2]: *** [drivers/firmware/efivars.o] Error 1
make[1]: *** [drivers/firmware/efivars.o] Error 2

Fix the build error by removing the duplicate initialization of i_uid and i_gid inode_init_always has already initialized them to 0.

---
 drivers/firmware/efivars.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/firmware/efivars.c +0 -1
index 52c5d89..7b1c374 100644
@@ -883,7 +883,6 @@ static struct inode *efivarfs_get_inode(struct super_block *sb,
 
 	if (inode) {
 		inode->i_ino = get_next_ino();
-		inode->i_uid = inode->i_gid = 0;
 		inode->i_mode = mode;
 		inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME;
 		switch (mode & S_IFMT) {
Signature · 1 line
1.7.5.4