Skip to contentSkip to conversation

package/zic: fix host compile (needs CC/HOST_CONFIGURE_OPTS set)

PATCH Applied Peter Seiderer via buildroot 3 participants 3 messages Apr 1, 2024 – Apr 28, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/zic: fix host compile (needs CC/HOST_CONFIGURE_OPTS set)

Host compile of zic needs CC defined since version bump to 2024a (given by HOST_CONFIGURE_OPTS).

	$ diff -ru build/host-zic-2023c/Makefile build/host-zic-2024a/Makefile
  --- build/host-zic-2023c/Makefile	2024-04-01 12:44:14.515490354 +0200
  +++ build/host-zic-2024a/Makefile	2024-04-01 13:10:50.138333771 +0200
  [...]
  +# To affect how this Makefile works, you can run a shell script like this:
  +#
  +#	#!/bin/sh
  +#	make CC='gcc -std=gnu11' "$@"
  +#
  +# This example script is appropriate for a pre-2017 GNU/Linux system
  +# where a non-default setting is needed to support this package's use of C99.
  +#
  +# Alternatively, you can simply edit this Makefile to tailor the following
  +# macro definitions.
  +
  +###############################################################################
  +# Start of macros that one plausibly might want to tailor.
  [...]
  -cc=		cc
  -CC=		$(cc) -DTZDIR='"$(TZDIR)"'
  [...]

Fixes:

c99 -O1 -c -o zic.o zic.c
make[2]: c99: No such file or directory

---
 package/zic/zic.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/zic/zic.mk +1 -1
index 95fa1eaa96..8abcec9360 100644
@@ -12,7 +12,7 @@ ZIC_LICENSE = Public domain
 ZIC_LICENSE_FILES = LICENSE
 
 define HOST_ZIC_BUILD_CMDS
-	$(HOST_MAKE_ENV) $(MAKE) -C $(@D) zic
+	$(HOST_MAKE_ENV) $(MAKE) $(HOST_CONFIGURE_OPTS) -C $(@D) zic
 endef
 
 define HOST_ZIC_INSTALL_CMDS
Signature · 6 lines
2.44.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Peter, All,

On 2024-04-01 13:24 +0200, Peter Seiderer via buildroot spake thusly:

Quoted 16 lines

Host compile of zic needs CC defined since version bump to 2024a (given by HOST_CONFIGURE_OPTS).

	$ diff -ru build/host-zic-2023c/Makefile build/host-zic-2024a/Makefile
  --- build/host-zic-2023c/Makefile	2024-04-01 12:44:14.515490354 +0200
  +++ build/host-zic-2024a/Makefile	2024-04-01 13:10:50.138333771 +0200
  [...]
  +# To affect how this Makefile works, you can run a shell script like this:
  +#
  +#	#!/bin/sh
  +#	make CC='gcc -std=gnu11' "$@"
  +#
  +# This example script is appropriate for a pre-2017 GNU/Linux system
  +# where a non-default setting is needed to support this package's use of C99.
  +#
  +# Alternatively, you can simply edit this Makefile to tailor the following
Quoted 8 lines
  +# macro definitions.
  +
  +###############################################################################
  +# Start of macros that one plausibly might want to tailor.
  [...]
  -cc=		cc
  -CC=		$(cc) -DTZDIR='"$(TZDIR)"'
  [...]

This diff is not very helpful, so I replaced it with a reference to the upstream commit that changed the requirements.

I also slightly reworded the commit log to also mention that our CFLAGS and LDFLAGS are now used as well, in addition to the now required CC.

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 30 lines

Fixes:

c99 -O1 -c -o zic.o zic.c
make[2]: c99: No such file or directory

---
 package/zic/zic.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/zic/zic.mk +1 -1
index 95fa1eaa96..8abcec9360 100644
@@ -12,7 +12,7 @@ ZIC_LICENSE = Public domain
 ZIC_LICENSE_FILES = LICENSE
 
 define HOST_ZIC_BUILD_CMDS
-	$(HOST_MAKE_ENV) $(MAKE) -C $(@D) zic
+	$(HOST_MAKE_ENV) $(MAKE) $(HOST_CONFIGURE_OPTS) -C $(@D) zic
 endef
 
 define HOST_ZIC_INSTALL_CMDS
Signature · 6 lines
2.44.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw
In reply to Peter Seiderer via buildroot
Quoted 27 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Seiderer via buildroot <[email protected]> writes:

Host compile of zic needs CC defined since version bump to 2024a (given by HOST_CONFIGURE_OPTS).

	$ diff -ru build/host-zic-2023c/Makefile build/host-zic-2024a/Makefile
  --- build/host-zic-2023c/Makefile	2024-04-01 12:44:14.515490354 +0200
  +++ build/host-zic-2024a/Makefile	2024-04-01 13:10:50.138333771 +0200
  [...]
  +# To affect how this Makefile works, you can run a shell script like this:
  +#
  +#	#!/bin/sh
  +#	make CC='gcc -std=gnu11' "$@"
  +#
  +# This example script is appropriate for a pre-2017 GNU/Linux system
  +# where a non-default setting is needed to support this package's use of C99.
  +#
  +# Alternatively, you can simply edit this Makefile to tailor the following
  +# macro definitions.
  +
  +###############################################################################
  +# Start of macros that one plausibly might want to tailor.
  [...]
  -cc=		cc
  -CC=		$(cc) -DTZDIR='"$(TZDIR)"'
  [...]
Quoted 6 lines

Fixes:

c99 -O1 -c -o zic.o zic.c
make[2]: c99: No such file or directory

Committed to 2024.02.x, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot