irqchip: Allow test compilation of Broadcom drivers
PATCH 1/1 irqchip: Allow test compilation of Broadcom drivers
Allow test compilation of the Broadcom irqchip drivers by adding a COMPILE_TEST dependency.
--- drivers/irqchip/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/irqchip/Kconfig +3 -3
@@ -116,7 +116,7 @@ config BCM6345_L1_IRQ config BCM7038_L1_IRQ tristate "Broadcom STB 7038-style L1/L2 interrupt controller driver" - depends on ARCH_BRCMSTB || BMIPS_GENERIC + depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST default ARCH_BRCMSTB || BMIPS_GENERIC select GENERIC_IRQ_CHIP select IRQ_DOMAIN
@@ -124,14 +124,14 @@ config BCM7038_L1_IRQ config BCM7120_L2_IRQ tristate "Broadcom STB 7120-style L2 interrupt controller driver" - depends on ARCH_BRCMSTB || BMIPS_GENERIC + depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST default ARCH_BRCMSTB || BMIPS_GENERIC select GENERIC_IRQ_CHIP select IRQ_DOMAIN config BRCMSTB_L2_IRQ tristate "Broadcom STB generic L2 interrupt controller driver" - depends on ARCH_BCM2835 || ARCH_BRCMSTB || BMIPS_GENERIC + depends on ARCH_BCM2835 || ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST default ARCH_BCM2835 || ARCH_BRCMSTB || BMIPS_GENERIC select GENERIC_IRQ_CHIP select IRQ_DOMAIN
Signature · 1 line
2.25.1
Quoted 14 lines · Florian Fainelli
Allow test compilation of the Broadcom irqchip drivers by adding a
COMPILE_TESTdependency.Signed-off-by Florian Fainelli <[email protected]>--- drivers/irqchip/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/irqchip/Kconfig +0
-0
drivers/irqchip/Kconfig config BCM6345_L1_IRQ · line 119
Quoted 5 lines
drivers/irqchip/Kconfig +1
-1@@ -116,7 +116,7 @@ config BCM6345_L1_IRQ config BCM7038_L1_IRQ tristate "Broadcom STB 7038-style L1/L2 interrupt controller driver" - depends on ARCH_BRCMSTB || BMIPS_GENERIC + depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
Do we actually need all this churn now that OF is user-selectable (see 0166dc11be91)?
M.
Signature · 1 line
Without deviation from the norm, progress is not possible.
Quoted 17 lines · Marc Zyngier
Quoted 15 lines · Florian Fainelli
Allow test compilation of the Broadcom irqchip drivers by adding a
COMPILE_TESTdependency.Signed-off-by Florian Fainelli <[email protected]>--- drivers/irqchip/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/irqchip/Kconfig +0
-0@@ -116,7 +116,7 @@ config BCM6345_L1_IRQ
Quoted 7 lines
drivers/irqchip/Kconfig config BCM6345_L1_IRQ · line 119
Quoted 4 lines
drivers/irqchip/Kconfig +1
-1config BCM7038_L1_IRQ tristate "Broadcom STB 7038-style L1/L2 interrupt controller driver" - depends on ARCH_BRCMSTB || BMIPS_GENERIC + depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TESTDo we actually need all this churn now that OF is user-selectable (see
0166dc11be91)?
Seems to me that we would since that allows people to choose the building of these drivers rather than lift the dependencies and replace it with:
depends on OF
as this would prompt many users about drivers they do not care about.
Signature · 1 line
Florian