Skip to contentSkip to conversation

drm/i915/display: Fix warning callstack for imbalance wakeref

PATCH In review Mitul Golani 3 participants 3 messages Aug 23, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/display: Fix warning callstack for imbalance wakeref

While executing i915_selftest, wakeref imbalance warning is seen with i915_selftest failure.

Currently when Driver is suspended, while doing unregister it is taking wakeref without resuming the device.
This patch is resuming the device, if driver is already suspended and doing unregister process. It will check the suspend state and if driver is not resumed before taking wakeref then resume before it.

---
 drivers/gpu/drm/i915/i915_driver.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/gpu/drm/i915/i915_driver.c +9 -0
index deb8a8b76965..99d6df02dc67 100644
@@ -948,6 +948,15 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 
 void i915_driver_remove(struct drm_i915_private *i915)
 {
+	int ret;
+	/*
+	 * Resuming Device if already suspended to complete driver unregistration
+	 */
+	if (i915->runtime_pm.suspended && !atomic_read(&i915->runtime_pm.wakeref_count)) {
+		ret = pm_runtime_get_sync(i915->runtime_pm.kdev);
+		drm_WARN_ONCE(&i915->drm, ret < 0, "pm_runtime_get_sync() failed: %d\n", ret);
+	}
+
 	disable_rpm_wakeref_asserts(&i915->runtime_pm);
 
 	i915_driver_unregister(i915);
Signature · 1 line
2.25.1
#1 lore raw

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Fix warning callstack for imbalance wakeref (rev5)

== Series Details ==

== Series Details ==

Series: drm/i915/display: Fix warning callstack for imbalance wakeref (rev5)
URL : https://patchwork.freedesktop.org/series/107211/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_12014 -> Patchwork_107211v5
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_107211v5 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_107211v5, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/index.html

Participating hosts (30 -> 38)
------------------------------

Additional (8): fi-rkl-11600 bat-dg1-5 bat-dg2-8 bat-adlp-4 bat-jsl-3 bat-rplp-1 bat-rpls-1 bat-dg2-10

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_107211v5:

### IGT changes ###

#### Possible regressions ####

* igt@i915_suspend@basic-s2idle-without-i915:
- fi-bsw-kefka: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12014/fi-bsw-kefka/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/fi-bsw-kefka/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_107211v5 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@fbdev@info:
- bat-adlp-4: NOTRUN -> [SKIP][3] ([i915#2582]) +4 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-adlp-4/igt@[email protected]

* igt@fbdev@read:
- bat-dg1-5: NOTRUN -> [SKIP][4] ([i915#2582]) +4 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-dg1-5/igt@[email protected]

* igt@gem_huc_copy@huc-copy:
- fi-rkl-11600: NOTRUN -> [SKIP][5] ([i915#2190])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/fi-rkl-11600/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random-engines:
- fi-rkl-11600: NOTRUN -> [SKIP][6] ([i915#4613]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/fi-rkl-11600/igt@[email protected]

* igt@gem_lmem_swapping@verify-random:
- bat-adlp-4: NOTRUN -> [SKIP][7] ([i915#4613]) +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-adlp-4/igt@[email protected]

* igt@gem_mmap@basic:
- bat-dg1-5: NOTRUN -> [SKIP][8] ([i915#4083])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-dg1-5/igt@[email protected]

* igt@gem_tiled_fence_blits@basic:
- bat-dg1-5: NOTRUN -> [SKIP][9] ([i915#4077]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-dg1-5/igt@[email protected]

* igt@gem_tiled_pread_basic:
- fi-rkl-11600: NOTRUN -> [SKIP][10] ([i915#3282])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/fi-rkl-11600/igt@gem_tiled_pread_basic.html
- bat-dg1-5: NOTRUN -> [SKIP][11] ([i915#4079]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-dg1-5/igt@gem_tiled_pread_basic.html
- bat-adlp-4: NOTRUN -> [SKIP][12] ([i915#3282])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-adlp-4/igt@gem_tiled_pread_basic.html

* igt@i915_pm_backlight@basic-brightness:
- fi-rkl-11600: NOTRUN -> [SKIP][13] ([i915#3012])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/fi-rkl-11600/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][14] ([i915#1155])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-dg1-5/igt@[email protected]
- bat-adlp-4: NOTRUN -> [SKIP][15] ([i915#1155])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-adlp-4/igt@[email protected]

* igt@i915_pm_rps@basic-api:
- bat-dg1-5: NOTRUN -> [SKIP][16] ([i915#6621])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-dg1-5/igt@[email protected]
- bat-adlp-4: NOTRUN -> [SKIP][17] ([i915#6621])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-adlp-4/igt@[email protected]

* igt@i915_suspend@basic-s2idle-without-i915:
- bat-dg1-5: NOTRUN -> [INCOMPLETE][18] ([i915#6011])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-dg1-5/igt@[email protected]

* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: NOTRUN -> [INCOMPLETE][19] ([i915#5982])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/fi-rkl-11600/igt@[email protected]
- fi-hsw-4770: NOTRUN -> [INCOMPLETE][20] ([i915#4817] / [i915#6598])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/fi-hsw-4770/igt@[email protected]

* igt@kms_addfb_basic@basic-x-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][21] ([i915#4212]) +7 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-dg1-5/igt@[email protected]

* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][22] ([i915#4215])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-dg1-5/igt@[email protected]

* igt@kms_busy@basic:
- bat-dg1-5: NOTRUN -> [SKIP][23] ([i915#1845] / [i915#4303])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-dg1-5/igt@[email protected]

* igt@kms_chamelium@dp-crc-fast:
- bat-adlp-4: NOTRUN -> [SKIP][24] ([fdo#111827]) +8 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-adlp-4/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-rkl-11600: NOTRUN -> [SKIP][25] ([fdo#111827]) +7 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/fi-rkl-11600/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][26] ([fdo#111827]) +7 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-dg1-5/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- fi-rkl-11600: NOTRUN -> [SKIP][27] ([i915#4103])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/fi-rkl-11600/igt@[email protected]

* igt@kms_flip@basic-plain-flip:
- bat-adlp-4: NOTRUN -> [SKIP][28] ([i915#3637]) +3 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-adlp-4/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- fi-rkl-11600: NOTRUN -> [SKIP][29] ([fdo#109285] / [i915#4098])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/fi-rkl-11600/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][30] ([fdo#109285])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-dg1-5/igt@[email protected]

* igt@kms_force_connector_basic@prune-stale-modes:
- bat-adlp-4: NOTRUN -> [SKIP][31] ([i915#4093]) +3 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-adlp-4/igt@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- bat-adlp-4: NOTRUN -> [SKIP][32] ([i915#4342])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-adlp-4/igt@[email protected]

* igt@kms_pipe_crc_basic@nonblocking-crc:
- bat-dg1-5: NOTRUN -> [SKIP][33] ([i915#4078]) +13 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-dg1-5/igt@[email protected]

* igt@kms_pipe_crc_basic@read-crc:
- bat-adlp-4: NOTRUN -> [SKIP][34] ([i915#3546]) +10 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-adlp-4/igt@[email protected]

* igt@kms_psr@sprite_plane_onoff:
- fi-rkl-11600: NOTRUN -> [SKIP][35] ([i915#1072]) +3 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/fi-rkl-11600/igt@kms_psr@sprite_plane_onoff.html
- bat-dg1-5: NOTRUN -> [SKIP][36] ([i915#1072] / [i915#4078]) +3 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-dg1-5/igt@kms_psr@sprite_plane_onoff.html
- bat-adlp-4: NOTRUN -> [SKIP][37] ([i915#1072]) +3 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-adlp-4/igt@kms_psr@sprite_plane_onoff.html

* igt@kms_setmode@basic-clone-single-crtc:
- fi-rkl-11600: NOTRUN -> [SKIP][38] ([i915#3555] / [i915#4098])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/fi-rkl-11600/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][39] ([i915#3555])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-dg1-5/igt@[email protected]
- bat-adlp-4: NOTRUN -> [SKIP][40] ([i915#3555] / [i915#4579])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-adlp-4/igt@[email protected]

* igt@prime_vgem@basic-fence-flip:
- bat-adlp-4: NOTRUN -> [SKIP][41] ([fdo#109295] / [i915#3546] / [i915#3708])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-adlp-4/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][42] ([i915#1845] / [i915#3708])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-dg1-5/igt@[email protected]

* igt@prime_vgem@basic-fence-read:
- bat-dg1-5: NOTRUN -> [SKIP][43] ([i915#3708]) +2 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-dg1-5/igt@[email protected]

* igt@prime_vgem@basic-gtt:
- bat-dg1-5: NOTRUN -> [SKIP][44] ([i915#3708] / [i915#4077]) +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-dg1-5/igt@[email protected]

* igt@prime_vgem@basic-read:
- fi-rkl-11600: NOTRUN -> [SKIP][45] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/fi-rkl-11600/igt@[email protected]

* igt@prime_vgem@basic-userptr:
- bat-adlp-4: NOTRUN -> [SKIP][46] ([fdo#109295] / [i915#3301] / [i915#3708])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-adlp-4/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][47] ([i915#3708] / [i915#4873])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-dg1-5/igt@[email protected]
- fi-rkl-11600: NOTRUN -> [SKIP][48] ([fdo#109295] / [i915#3301] / [i915#3708])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/fi-rkl-11600/igt@[email protected]

* igt@prime_vgem@basic-write:
- bat-adlp-4: NOTRUN -> [SKIP][49] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-adlp-4/igt@[email protected]

* igt@runner@aborted:
- bat-dg1-5: NOTRUN -> [FAIL][50] ([i915#4312] / [i915#5257])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/bat-dg1-5/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [INCOMPLETE][51] ([i915#4785]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12014/fi-hsw-4770/igt@i915_selftest@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/fi-hsw-4770/igt@i915_selftest@[email protected]

#### Warnings ####

* igt@i915_suspend@basic-s3-without-i915:
- fi-elk-e7500: [INCOMPLETE][53] ([i915#6648]) -> [INCOMPLETE][54] ([i915#6598] / [i915#6601] / [i915#6648])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12014/fi-elk-e7500/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/fi-elk-e7500/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3003]: https://gitlab.freedesktop.org/drm/intel/issues/3003
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3595]: https://gitlab.freedesktop.org/drm/intel/issues/3595
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4093]: https://gitlab.freedesktop.org/drm/intel/issues/4093
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4303]: https://gitlab.freedesktop.org/drm/intel/issues/4303
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4342]: https://gitlab.freedesktop.org/drm/intel/issues/4342
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#5153]: https://gitlab.freedesktop.org/drm/intel/issues/5153
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5982]: https://gitlab.freedesktop.org/drm/intel/issues/5982
[i915#6011]: https://gitlab.freedesktop.org/drm/intel/issues/6011
[i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
[i915#6380]: https://gitlab.freedesktop.org/drm/intel/issues/6380
[i915#6598]: https://gitlab.freedesktop.org/drm/intel/issues/6598
[i915#6599]: https://gitlab.freedesktop.org/drm/intel/issues/6599
[i915#6601]: https://gitlab.freedesktop.org/drm/intel/issues/6601
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6642]: https://gitlab.freedesktop.org/drm/intel/issues/6642
[i915#6643]: https://gitlab.freedesktop.org/drm/intel/issues/6643
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#6648]: https://gitlab.freedesktop.org/drm/intel/issues/6648

Build changes
-------------

* Linux: CI_DRM_12014 -> Patchwork_107211v5

CI-20190529: 20190529
CI_DRM_12014: 1de33826aa86910c175ca773bc8f92d5948d094e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6634: e01fe99f00692864b709253638c809231d1fb333 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_107211v5: 1de33826aa86910c175ca773bc8f92d5948d094e @ git://anongit.freedesktop.org/gfx-ci/linux

### Linux commits

83476b9e647a drm/i915/display: Fix warning callstack for imbalance wakeref

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107211v5/index.html

maintainer
#2 lore raw
In reply to Mitul Golani
Quoted 9 lines · Mitul Golani

While executing i915_selftest, wakeref imbalance warning is seen with i915_selftest failure.

Currently when Driver is suspended, while doing unregister it is taking wakeref without resuming the device.
This patch is resuming the device, if driver is already suspended and doing unregister process. It will check the suspend state and if driver is not resumed before taking wakeref then resume before it.

Why have you sent the same patch multiple times in the same day?

Please see my earlier reply
https://lore.kernel.org/r/[email protected]

BR,
Jani.

Quoted 26 lines
---
 drivers/gpu/drm/i915/i915_driver.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/gpu/drm/i915/i915_driver.c +9 -0
index deb8a8b76965..99d6df02dc67 100644
@@ -948,6 +948,15 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 
 void i915_driver_remove(struct drm_i915_private *i915)
 {
+	int ret;
+	/*
+	 * Resuming Device if already suspended to complete driver unregistration
+	 */
+	if (i915->runtime_pm.suspended && !atomic_read(&i915->runtime_pm.wakeref_count)) {
+		ret = pm_runtime_get_sync(i915->runtime_pm.kdev);
+		drm_WARN_ONCE(&i915->drm, ret < 0, "pm_runtime_get_sync() failed: %d\n", ret);
+	}
+
 	disable_rpm_wakeref_asserts(&i915->runtime_pm);
 
 	i915_driver_unregister(i915);
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center