Skip to contentSkip to conversation

package/libllcp: drop wrong comment

PATCH New Fabrice Fontaine 3 participants 3 messages Dec 13, 2020 – Jan 5, 2021

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/libllcp: drop wrong comment

Dependency on threads comes from libllcp itself not from libusb (which is not even selected)

While at it, also add a comment about this dependency

---
Changes v1 -> v2:
- Add a comment

 package/libllcp/Config.in | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
package/libllcp/Config.in +4 -1
index 1660e92a87..5dc5c36a67 100644
@@ -1,9 +1,12 @@
 config BR2_PACKAGE_LIBLLCP
 	bool "libllcp"
-	depends on BR2_TOOLCHAIN_HAS_THREADS # libusb
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	select BR2_PACKAGE_LIBNFC
 	help
 	  Library extending libnfc with support for Logical Link Control
 	  Protocol.
 
 	  https://github.com/nfc-tools/libllcp
+
+comment "libllcp needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
2.29.2
#1 lore raw

PATCH v2 1/1 package/libllcp: drop wrong comment

Quoted 9 lines · On Sun, 13 Dec 2020 23:03:29 +0100 Fabrice Fontaine…

Dependency on threads comes from libllcp itself not from libusb (which is not even selected)

While at it, also add a comment about this dependency

---
Changes v1 -> v2:
- Add a comment

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH v2 1/1 package/libllcp: drop wrong comment

In reply to Fabrice Fontaine
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

Dependency on threads comes from libllcp itself not from libusb (which is not even selected)

While at it, also add a comment about this dependency

---
Changes v1 -> v2:
- Add a comment

Committed to 2020.02.x and 2020.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard