ndo_ioctl rework
Subsystems (113)
cover ndo_ioctl rework
From: Arnd Bergmann <[email protected]>
This series is some fallout from the series I sent earlier today to get rid of compat_alloc_user_space() and copy_in_user().
I wanted to be sure I address all the ways that 'struct ifreq' is used in device drivers through .ndo_do_ioctl, originally to prove that my approach of changing the struct definition was correct, but then I discarded that approach and went on anyway.
Roughly, the contents here are:
- split out all the users of SIOCDEVPRIVATE ioctls into a separate ndo_siocdevprivate callback, to better see what gets used where
- fix compat handling for those drivers that pass data directly inside of 'ifreq' rather than using an indirect ifr_data pointer
- remove unreachable code in ndo_ioctl handlers that relies on command codes we never pass into that, in particular for wireless drivers
- split out the ethernet specific ioctls into yet another ndo_eth_ioctl callback, as these are by far the most common use of ndo_do_ioctl today. I considered splitting them further into MII and timestamp controls, but went with the simpler change for now.
At this point, only a few oddball things remain in ndo_do_ioctl:
bridge, bonding, wan and two socket protocols passing down SIOCSIFADDR/SIOCGIFADDR. Again, these could all be moved into other callbacks as well if desired.
Any suggestions on how to proceed? I think the ndo_siocdevprivate change is the most interesting here, and I would like to get that merged. For the wireless drivers, removing the old drivers instead of just the dead code might be an alternative, depending on whether anyone thinks there might still be users.
The ndo_eth_ioctl change was something I did because it seemed easy, but I'm not super attached to it, and it could well be done differently.
None of this is really tested beyond simple compile tests, please review. All of it is also available as part of a larger branch at
https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git \
compat-alloc-user-space-6
Arnd
Arnd Bergmann (28):
net: split out SIOCDEVPRIVATE handling from dev_ioctl
staging: rtlwifi: use siocdevprivate
staging: wlan-ng: use siocdevprivate
hostap: use ndo_siocdevprivate
wireless: remove old ioctls
bridge: use ndo_siocdevprivate
phonet: use siocdevprivate
tulip: use ndo_siocdevprivate
bonding: use siocdevprivate
appletalk: use ndo_siocdevprivate
hamachi: use ndo_siocdevprivate
tehuti: use ndo_siocdevprivate
eql: use ndo_siocdevprivate
fddi: use ndo_siocdevprivate
net: usb: use ndo_siocdevprivate
slip/plip: use ndo_siocdevprivate
qeth: use ndo_siocdevprivate
cxgb3: use ndo_siocdevprivate
dev_ioctl: pass SIOCDEVPRIVATE data separately
dev_ioctl: split out ndo_eth_ioctl
wan: use ndo_siocdevprivate
hamradio: use ndo_siocdevprivate
airo: use ndo_siocdevprivate
ip_tunnel: use ndo_siocdevprivate
hippi: use ndo_siocdevprivate
sb1000: use ndo_siocdevprivate
ppp: use ndo_siocdevprivate
net: socket: return changed ifreq from SIOCDEVPRIVATE
Documentation/networking/netdevices.rst | 4 + Documentation/networking/timestamping.rst | 6 +- drivers/infiniband/ulp/ipoib/ipoib_main.c | 8 +- drivers/net/appletalk/ipddp.c | 15 +- drivers/net/bonding/bond_main.c | 72 +- drivers/net/eql.c | 23 +- drivers/net/ethernet/3com/3c574_cs.c | 2 +- drivers/net/ethernet/3com/3c59x.c | 4 +- drivers/net/ethernet/8390/ax88796.c | 2 +- drivers/net/ethernet/8390/axnet_cs.c | 2 +- drivers/net/ethernet/8390/pcnet_cs.c | 2 +- drivers/net/ethernet/adaptec/starfire.c | 2 +- drivers/net/ethernet/agere/et131x.c | 2 +- drivers/net/ethernet/allwinner/sun4i-emac.c | 2 +- drivers/net/ethernet/amd/amd8111e.c | 2 +- drivers/net/ethernet/amd/au1000_eth.c | 2 +- drivers/net/ethernet/amd/pcnet32.c | 2 +- drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 +- .../net/ethernet/aquantia/atlantic/aq_main.c | 2 +- drivers/net/ethernet/arc/emac_main.c | 2 +- drivers/net/ethernet/atheros/ag71xx.c | 2 +- drivers/net/ethernet/atheros/alx/main.c | 2 +- .../net/ethernet/atheros/atl1c/atl1c_main.c | 2 +- .../net/ethernet/atheros/atl1e/atl1e_main.c | 2 +- drivers/net/ethernet/atheros/atlx/atl1.c | 2 +- drivers/net/ethernet/atheros/atlx/atl2.c | 2 +- drivers/net/ethernet/aurora/nb8800.c | 2 +- drivers/net/ethernet/broadcom/b44.c | 2 +- drivers/net/ethernet/broadcom/bcm63xx_enet.c | 4 +- drivers/net/ethernet/broadcom/bgmac.c | 2 +- drivers/net/ethernet/broadcom/bnx2.c | 2 +- .../net/ethernet/broadcom/bnx2x/bnx2x_main.c | 2 +- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +- .../net/ethernet/broadcom/genet/bcmgenet.c | 2 +- drivers/net/ethernet/broadcom/sb1250-mac.c | 2 +- drivers/net/ethernet/broadcom/tg3.c | 2 +- drivers/net/ethernet/cadence/macb_main.c | 4 +- .../net/ethernet/cavium/liquidio/lio_main.c | 2 +- .../ethernet/cavium/liquidio/lio_vf_main.c | 2 +- .../net/ethernet/cavium/octeon/octeon_mgmt.c | 2 +- .../net/ethernet/cavium/thunder/nicvf_main.c | 2 +- drivers/net/ethernet/chelsio/cxgb/cxgb2.c | 2 +- .../net/ethernet/chelsio/cxgb3/cxgb3_main.c | 14 +- .../net/ethernet/chelsio/cxgb4/cxgb4_main.c | 2 +- .../ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 2 +- drivers/net/ethernet/cirrus/ep93xx_eth.c | 2 +- drivers/net/ethernet/davicom/dm9000.c | 2 +- drivers/net/ethernet/dec/tulip/de4x5.c | 9 +- drivers/net/ethernet/dec/tulip/tulip_core.c | 2 +- drivers/net/ethernet/dec/tulip/winbond-840.c | 2 +- drivers/net/ethernet/dlink/dl2k.c | 2 +- drivers/net/ethernet/dlink/sundance.c | 2 +- drivers/net/ethernet/dnet.c | 2 +- drivers/net/ethernet/ethoc.c | 2 +- drivers/net/ethernet/faraday/ftgmac100.c | 2 +- drivers/net/ethernet/faraday/ftmac100.c | 2 +- drivers/net/ethernet/fealnx.c | 2 +- .../net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +- .../net/ethernet/freescale/dpaa2/dpaa2-eth.c | 2 +- .../net/ethernet/freescale/enetc/enetc_pf.c | 2 +- .../net/ethernet/freescale/enetc/enetc_vf.c | 2 +- drivers/net/ethernet/freescale/fec_main.c | 2 +- drivers/net/ethernet/freescale/fec_mpc52xx.c | 2 +- .../ethernet/freescale/fs_enet/fs_enet-main.c | 2 +- drivers/net/ethernet/freescale/gianfar.c | 2 +- drivers/net/ethernet/freescale/ucc_geth.c | 2 +- drivers/net/ethernet/hisilicon/hisi_femac.c | 2 +- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 2 +- .../net/ethernet/hisilicon/hns3/hns3_enet.c | 2 +- drivers/net/ethernet/ibm/emac/core.c | 4 +- drivers/net/ethernet/ibm/ibmveth.c | 2 +- drivers/net/ethernet/intel/e100.c | 2 +- drivers/net/ethernet/intel/e1000/e1000_main.c | 2 +- drivers/net/ethernet/intel/e1000e/netdev.c | 2 +- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- drivers/net/ethernet/intel/igb/igb_main.c | 2 +- drivers/net/ethernet/intel/igbvf/netdev.c | 2 +- drivers/net/ethernet/intel/igc/igc_main.c | 2 +- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +- drivers/net/ethernet/jme.c | 2 +- drivers/net/ethernet/korina.c | 2 +- drivers/net/ethernet/lantiq_etop.c | 2 +- drivers/net/ethernet/marvell/mv643xx_eth.c | 2 +- drivers/net/ethernet/marvell/mvneta.c | 2 +- .../net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +- .../ethernet/marvell/octeontx2/nic/otx2_pf.c | 2 +- drivers/net/ethernet/marvell/pxa168_eth.c | 2 +- drivers/net/ethernet/marvell/skge.c | 2 +- drivers/net/ethernet/marvell/sky2.c | 4 +- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +- drivers/net/ethernet/mediatek/mtk_star_emac.c | 2 +- .../net/ethernet/mellanox/mlx4/en_netdev.c | 2 +- .../net/ethernet/mellanox/mlx5/core/en_main.c | 2 +- .../ethernet/mellanox/mlx5/core/ipoib/ipoib.c | 2 +- .../mellanox/mlx5/core/ipoib/ipoib_vlan.c | 2 +- .../net/ethernet/mellanox/mlxsw/spectrum.c | 2 +- drivers/net/ethernet/micrel/ks8851_common.c | 2 +- drivers/net/ethernet/micrel/ksz884x.c | 2 +- drivers/net/ethernet/microchip/lan743x_main.c | 2 +- drivers/net/ethernet/mscc/ocelot_net.c | 2 +- drivers/net/ethernet/natsemi/natsemi.c | 2 +- drivers/net/ethernet/neterion/s2io.c | 2 +- .../net/ethernet/neterion/vxge/vxge-main.c | 2 +- drivers/net/ethernet/nxp/lpc_eth.c | 2 +- .../ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 2 +- drivers/net/ethernet/packetengines/hamachi.c | 63 +- .../net/ethernet/packetengines/yellowfin.c | 2 +- drivers/net/ethernet/qlogic/qede/qede_main.c | 2 +- drivers/net/ethernet/qualcomm/emac/emac.c | 2 +- drivers/net/ethernet/rdc/r6040.c | 2 +- drivers/net/ethernet/realtek/8139cp.c | 2 +- drivers/net/ethernet/realtek/8139too.c | 2 +- drivers/net/ethernet/realtek/r8169_main.c | 2 +- drivers/net/ethernet/renesas/ravb_main.c | 2 +- drivers/net/ethernet/renesas/sh_eth.c | 4 +- .../net/ethernet/samsung/sxgbe/sxgbe_main.c | 2 +- drivers/net/ethernet/sfc/efx.c | 2 +- drivers/net/ethernet/sfc/falcon/efx.c | 2 +- drivers/net/ethernet/sgi/ioc3-eth.c | 2 +- drivers/net/ethernet/sgi/meth.c | 2 +- drivers/net/ethernet/sis/sis190.c | 2 +- drivers/net/ethernet/sis/sis900.c | 2 +- drivers/net/ethernet/smsc/epic100.c | 2 +- drivers/net/ethernet/smsc/smc91c92_cs.c | 2 +- drivers/net/ethernet/smsc/smsc911x.c | 2 +- drivers/net/ethernet/smsc/smsc9420.c | 2 +- drivers/net/ethernet/socionext/netsec.c | 2 +- drivers/net/ethernet/socionext/sni_ave.c | 2 +- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- drivers/net/ethernet/sun/cassini.c | 2 +- drivers/net/ethernet/sun/niu.c | 2 +- drivers/net/ethernet/sun/sungem.c | 2 +- .../net/ethernet/synopsys/dwc-xlgmac-net.c | 2 +- drivers/net/ethernet/tehuti/tehuti.c | 18 +- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 2 +- drivers/net/ethernet/ti/cpmac.c | 2 +- drivers/net/ethernet/ti/cpsw.c | 2 +- drivers/net/ethernet/ti/cpsw_new.c | 2 +- drivers/net/ethernet/ti/davinci_emac.c | 2 +- drivers/net/ethernet/ti/netcp_core.c | 2 +- drivers/net/ethernet/ti/tlan.c | 2 +- drivers/net/ethernet/toshiba/spider_net.c | 2 +- drivers/net/ethernet/toshiba/tc35815.c | 2 +- drivers/net/ethernet/tundra/tsi108_eth.c | 2 +- drivers/net/ethernet/via/via-rhine.c | 2 +- drivers/net/ethernet/via/via-velocity.c | 2 +- drivers/net/ethernet/xilinx/ll_temac_main.c | 2 +- .../net/ethernet/xilinx/xilinx_axienet_main.c | 2 +- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 2 +- drivers/net/ethernet/xircom/xirc2ps_cs.c | 2 +- drivers/net/ethernet/xscale/ixp4xx_eth.c | 2 +- drivers/net/fddi/skfp/skfddi.c | 18 +- drivers/net/hamradio/baycom_epp.c | 9 +- drivers/net/hamradio/baycom_par.c | 12 +- drivers/net/hamradio/baycom_ser_fdx.c | 12 +- drivers/net/hamradio/baycom_ser_hdx.c | 12 +- drivers/net/hamradio/bpqether.c | 9 +- drivers/net/hamradio/dmascc.c | 17 +- drivers/net/hamradio/hdlcdrv.c | 20 +- drivers/net/hamradio/scc.c | 13 +- drivers/net/hamradio/yam.c | 13 +- drivers/net/hippi/rrunner.c | 11 +- drivers/net/hippi/rrunner.h | 3 +- drivers/net/macvlan.c | 8 +- drivers/net/phy/phy.c | 4 +- drivers/net/plip/plip.c | 11 +- drivers/net/ppp/ppp_generic.c | 6 +- drivers/net/sb1000.c | 20 +- drivers/net/slip/slip.c | 12 +- drivers/net/usb/asix_devices.c | 6 +- drivers/net/usb/ax88172a.c | 2 +- drivers/net/usb/ax88179_178a.c | 2 +- drivers/net/usb/cdc-phonet.c | 5 +- drivers/net/usb/dm9601.c | 2 +- drivers/net/usb/lan78xx.c | 2 +- drivers/net/usb/mcs7830.c | 2 +- drivers/net/usb/pegasus.c | 4 +- drivers/net/usb/r8152.c | 2 +- drivers/net/usb/rtl8150.c | 5 +- drivers/net/usb/smsc75xx.c | 2 +- drivers/net/usb/smsc95xx.c | 2 +- drivers/net/usb/sr9700.c | 2 +- drivers/net/usb/sr9800.c | 2 +- drivers/net/wan/c101.c | 20 +- drivers/net/wan/dlci.c | 7 +- drivers/net/wan/farsync.c | 38 +- drivers/net/wan/hdlc_fr.c | 3 + drivers/net/wan/lmc/lmc_main.c | 38 +- drivers/net/wan/n2.c | 18 +- drivers/net/wan/pc300too.c | 19 +- drivers/net/wan/pci200syn.c | 19 +- drivers/net/wan/sbni.c | 12 +- drivers/net/wan/sdla.c | 8 +- drivers/net/wireless/atmel/atmel.c | 72 -- drivers/net/wireless/cisco/airo.c | 15 +- drivers/net/wireless/intersil/hostap/hostap.h | 4 +- .../wireless/intersil/hostap/hostap_ioctl.c | 227 +--- .../wireless/intersil/hostap/hostap_main.c | 6 +- drivers/s390/net/qeth_core.h | 2 + drivers/s390/net/qeth_core_main.c | 35 +- drivers/s390/net/qeth_l2_main.c | 2 +- drivers/s390/net/qeth_l3_main.c | 10 +- drivers/staging/ks7010/ks_wlan_net.c | 21 - drivers/staging/octeon/ethernet.c | 12 +- drivers/staging/rtl8188eu/include/ieee80211.h | 2 - .../staging/rtl8188eu/include/osdep_intf.h | 3 +- .../staging/rtl8188eu/include/rtw_android.h | 3 +- .../staging/rtl8188eu/os_dep/ioctl_linux.c | 941 -------------- drivers/staging/rtl8188eu/os_dep/os_intfs.c | 2 +- .../staging/rtl8188eu/os_dep/rtw_android.c | 13 +- drivers/staging/rtl8192u/r8192U_core.c | 109 -- drivers/staging/rtl8712/os_intfs.c | 1 - drivers/staging/rtl8712/osdep_intf.h | 2 - drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 125 -- .../staging/rtl8723bs/include/osdep_intf.h | 3 +- .../staging/rtl8723bs/os_dep/ioctl_linux.c | 1089 +---------------- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 21 +- drivers/staging/wlan-ng/p80211netdev.c | 75 +- include/linux/hdlcdrv.h | 2 +- include/linux/netdevice.h | 13 +- include/net/dsa.h | 14 +- include/net/ip_tunnels.h | 3 +- net/8021q/vlan_dev.c | 6 +- net/bridge/br_device.c | 1 + net/bridge/br_ioctl.c | 36 +- net/bridge/br_private.h | 2 + net/core/dev_ioctl.c | 73 +- net/dsa/master.c | 6 +- net/dsa/slave.c | 2 +- net/ethtool/ioctl.c | 3 +- net/ipv4/ip_gre.c | 2 +- net/ipv4/ip_tunnel.c | 9 +- net/ipv4/ip_vti.c | 2 +- net/ipv4/ipip.c | 2 +- net/ipv6/ip6_gre.c | 16 +- net/ipv6/ip6_tunnel.c | 18 +- net/ipv6/ip6_vti.c | 21 +- net/ipv6/sit.c | 35 +- net/phonet/pn_dev.c | 6 +- net/socket.c | 57 +- 240 files changed, 829 insertions(+), 3253 deletions(-)
Signature · 1 line
2.27.0
RFC 1/28 net: split out SIOCDEVPRIVATE handling from dev_ioctl
From: Arnd Bergmann <[email protected]>
SIOCDEVPRIVATE ioctl commands are mainly used in really old drivers, and they have a number of problems:
- They hide behind the normal .ndo_do_ioctl function that is also used for other things in modern drivers, so it's hard to spot a driver that actually uses one of these
- Since drivers use a number different calling conventions, it is impossible to support compat mode for them in a generic way.
- With all drivers using the same 16 commands codes, there is no way to introspect the data being passed through things like strace.
Add a new net_device_ops callback pointer, to address the first two of these. Separating them from .ndo_do_ioctl makes it easy to grep for drivers with a .ndo_siocdevprivate callback, and the unwieldy name hopefully makes it easier to spot in code review.
By passing the ifreq structure and the ifr_data pointer separately, it is no longer necessary to overload these, and the driver can use either one for a given command.
--- include/linux/netdevice.h | 3 +++ net/core/dev_ioctl.c | 25 ++++++++++++++++++++++--- 2 files changed, 25 insertions(+), 3 deletions(-)
include/linux/netdevice.h +3 -0
@@ -1301,6 +1301,9 @@ struct net_device_ops {int (*ndo_validate_addr)(struct net_device *dev);int (*ndo_do_ioctl)(struct net_device *dev,struct ifreq *ifr,int cmd); +int (*ndo_siocdevprivate)(struct net_device *dev, +struct ifreq *ifr, +void __user *data,int cmd);int (*ndo_set_config)(struct net_device *dev,struct ifmap *map); int (*ndo_change_mtu)(struct net_device *dev,
net/core/dev_ioctl.c +22 -3
@@ -269,6 +269,23 @@ static int dev_do_ioctl(struct net_device *dev,return err; } +static int dev_siocdevprivate (struct net_device *dev, +struct ifreq *ifr,unsigned int cmd) +{ +const struct net_device_ops *ops = dev->netdev_ops; +void __user *data = ifr->ifr_data; + +if (ops->ndo_siocdevprivate) { +if (netif_device_present (dev)) +return ops->ndo_siocdevprivate (dev, ifr, data, cmd); +else +return -ENODEV ; + } + +/* fall back to do_ioctl for drivers not yet converted */ +return dev_do_ioctl (dev, ifr, cmd); +} +/* * Perform the SIOCxIFxxx calls, inside rtnl_lock() */
@@ -346,9 +363,11 @@ static int dev_ifsioc(struct net *net, struct ifreq *ifr, unsigned int cmd)* Unknown or private ioctl */ default : - if ((cmd >= SIOCDEVPRIVATE && - cmd <= SIOCDEVPRIVATE + 15) || - cmd == SIOCBONDENSLAVE || +if (cmd >=SIOCDEVPRIVATE && + cmd <=SIOCDEVPRIVATE +15 ) +return dev_siocdevprivate (dev, ifr, cmd); + + if (cmd == SIOCBONDENSLAVE || cmd == SIOCBONDRELEASE || cmd == SIOCBONDSETHWADDR || cmd == SIOCBONDSLAVEINFOQUERY ||
Signature · 1 line
2.27.0
RFC 2/28 staging: rtlwifi: use siocdevprivate
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
rtl8188eu has an "android private" ioctl command multiplexer that is not currently safe for use in compat mode because of its triple-indirect pointer.
rtl8723bs uses a different interface on the SIOCDEVPRIVATE command, based on the iwpriv data structure
Both also have normal unreachable iwpriv commands, and all of the above should probably just get removed. For the moment, just switch over to the new interface.
--- drivers/staging/rtl8188eu/include/osdep_intf.h | 2 ++ .../staging/rtl8188eu/include/rtw_android.h | 3 ++- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 3 --- drivers/staging/rtl8188eu/os_dep/os_intfs.c | 1 + drivers/staging/rtl8188eu/os_dep/rtw_android.c | 13 ++++++++++--- drivers/staging/rtl8723bs/include/osdep_intf.h | 2 ++ drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 18 +++++++++++++++--- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 1 + 8 files changed, 33 insertions(+), 10 deletions(-)
drivers/staging/rtl8188eu/include/osdep_intf.h +2 -0
@@ -22,6 +22,8 @@ void rtw_stop_drv_threads(struct adapter *padapter);void rtw_cancel_all_timer (struct adapter *padapter);int rtw_ioctl (struct net_device *dev,struct ifreq *rq,int cmd); +int rtw_android_priv_cmd (struct net_device *dev,struct ifreq *rq, +void __user *data,int cmd);int rtw_init_netdev_name (struct net_device *pnetdev,const char *ifname);struct net_device *rtw_init_netdev (struct adapter *padapter);
drivers/staging/rtl8188eu/include/rtw_android.h +2 -1
@@ -46,6 +46,7 @@ enum ANDROID_WIFI_CMD { };int rtw_android_cmdstr_to_num (char *cmdstr); -int rtw_android_priv_cmd (struct net_device *net,struct ifreq *ifr,int cmd); +int rtw_android_priv_cmd (struct net_device *net,struct ifreq *ifr, +void __user *data,int cmd);#endif /* __RTW_ANDROID_H__ */
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c +0 -3
@@ -3011,9 +3011,6 @@ int rtw_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) ret =rtw_hostapd_ioctl (dev, &wrq->u.data);break ;#endif /* CONFIG_88EU_AP_MODE */ -case (SIOCDEVPRIVATE +1 ): - ret =rtw_android_priv_cmd (dev, rq, cmd); -break ;default : ret = -EOPNOTSUPP ;break ;
drivers/staging/rtl8188eu/os_dep/os_intfs.c +1 -0
@@ -290,6 +290,7 @@ static const struct net_device_ops rtw_netdev_ops = { .ndo_set_mac_address = rtw_net_set_mac_address, .ndo_get_stats = rtw_net_get_stats, .ndo_do_ioctl = rtw_ioctl, + .ndo_siocdevprivate = rtw_android_priv_cmd, };int rtw_init_netdev_name (struct net_device *pnetdev,const char *ifname)
drivers/staging/rtl8188eu/os_dep/rtw_android.c +10 -3
@@ -127,7 +127,8 @@ static int android_get_p2p_addr(struct net_device *net, char *command,return ETH_ALEN ; } -int rtw_android_priv_cmd (struct net_device *net,struct ifreq *ifr,int cmd) +int rtw_android_priv_cmd (struct net_device *net,struct ifreq *ifr, +void __user *data,int cmd) {int ret =0 ;char *command;
@@ -135,9 +136,15 @@ int rtw_android_priv_cmd(struct net_device *net, struct ifreq *ifr, int cmd)int bytes_written =0 ;struct android_wifi_priv_cmd priv_cmd; -if (!ifr->ifr_data) +if (cmd !=SIOCDEVPRIVATE ) +return -EOPNOTSUPP ; + +if (in_compat_syscall ())/* to be implemented */ +return -EOPNOTSUPP ; + +if (!data)return -EINVAL ; -if (copy_from_user (&priv_cmd, ifr->ifr_data,sizeof (priv_cmd))) +if (copy_from_user (&priv_cmd, data,sizeof (priv_cmd)))return -EFAULT ;if (priv_cmd.total_len <1 )return -EINVAL ;
drivers/staging/rtl8723bs/include/osdep_intf.h +2 -0
@@ -54,6 +54,8 @@ void rtw_stop_drv_threads(struct adapter *padapter);void rtw_cancel_all_timer (struct adapter *padapter);int rtw_ioctl (struct net_device *dev,struct ifreq *rq,int cmd); +int rtw_siocdevprivate (struct net_device *dev,struct ifreq *rq, +void __user *data,int cmd);int rtw_init_netdev_name (struct net_device *pnetdev,const char *ifname);struct net_device *rtw_init_netdev (struct adapter *padapter);
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +15 -3
@@ -5134,6 +5134,21 @@ static int rtw_ioctl_wext_private(struct net_device *dev, union iwreq_data *wrq_return err; } +int rtw_siocdevprivate (struct net_device *dev,struct ifreq *rq, +void __user *data,int cmd) +{ +struct iwreq *wrq = (struct iwreq *)rq; + +/* little hope of fixing this, better remove the whole function */ +if (in_compat_syscall ()) +return -EOPNOTSUPP ; + +if (cmd !=SIOCDEVPRIVATE ) +return -EOPNOTSUPP ; + +return rtw_ioctl_wext_private (dev, &wrq->u); +} +int rtw_ioctl (struct net_device *dev,struct ifreq *rq,int cmd) {struct iwreq *wrq = (struct iwreq *)rq;
@@ -5146,9 +5161,6 @@ int rtw_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)case RTL_IOCTL_HOSTAPD : ret =rtw_hostapd_ioctl (dev, &wrq->u.data);break ; -case SIOCDEVPRIVATE : - ret =rtw_ioctl_wext_private (dev, &wrq->u); -break ;default : ret = -EOPNOTSUPP ;break ;
drivers/staging/rtl8723bs/os_dep/os_intfs.c +1 -0
@@ -470,6 +470,7 @@ static const struct net_device_ops rtw_netdev_ops = { .ndo_set_mac_address = rtw_net_set_mac_address, .ndo_get_stats = rtw_net_get_stats, .ndo_do_ioctl = rtw_ioctl, + .ndo_siocdevprivate = rtw_siocdevprivate, };int rtw_init_netdev_name (struct net_device *pnetdev,const char *ifname)
Signature · 1 line
2.27.0
RFC 3/28 staging: wlan-ng: use siocdevprivate
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
wlan-ng has two private ioctls that correctly work in compat mode. Move these over to the new ndo_siocdevprivate mechanism.
The p80211netdev_ethtool() function is commented out and has no use here, so this can be removed
--- drivers/staging/wlan-ng/p80211netdev.c | 75 ++++---------------------- 1 file changed, 11 insertions(+), 64 deletions(-)
drivers/staging/wlan-ng/p80211netdev.c +11 -64
@@ -98,8 +98,8 @@ static int p80211knetdev_stop(struct net_device *netdev);static netdev_tx_t p80211knetdev_hard_start_xmit (struct sk_buff *skb,struct net_device *netdev);static void p80211knetdev_set_multicast_list (struct net_device *dev); -static int p80211knetdev_do_ioctl (struct net_device *dev,struct ifreq *ifr, -int cmd); +static int p80211knetdev_siocdevprivate (struct net_device *dev,struct ifreq *ifr, +void __user *data,int cmd);static int p80211knetdev_set_mac_address (struct net_device *dev,void *addr);static void p80211knetdev_tx_timeout (struct net_device *netdev,unsigned int txqueue);static int p80211_rx_typedrop (struct wlandevice *wlandev,u16 fc);
@@ -461,56 +461,8 @@ static void p80211knetdev_set_multicast_list(struct net_device *dev) wlandev->set_multicast_list (wlandev, dev); } -#ifdef SIOCETHTOOL - -static int p80211netdev_ethtool (struct wlandevice *wlandev, -void __user *useraddr) -{ -u32 ethcmd; -struct ethtool_drvinfo info; -struct ethtool_value edata; - -memset (&info,0 ,sizeof (info)); -memset (&edata,0 ,sizeof (edata)); - -if (copy_from_user (ðcmd, useraddr,sizeof (ethcmd))) -return -EFAULT ; - -switch (ethcmd) { -case ETHTOOL_GDRVINFO : - info.cmd = ethcmd; -snprintf (info.driver,sizeof (info.driver),"p80211_%s" , - wlandev->nsdname); -snprintf (info.version,sizeof (info.version),"%s" , -WLAN_RELEASE ); - -if (copy_to_user (useraddr, &info,sizeof (info))) -return -EFAULT ; -return 0 ; -#ifdef ETHTOOL_GLINK -case ETHTOOL_GLINK : - edata.cmd = ethcmd; - -if (wlandev->linkstatus && - (wlandev->macmode !=WLAN_MACMODE_NONE )) { - edata.data =1 ; - }else { - edata.data =0 ; - } - -if (copy_to_user (useraddr, &edata,sizeof (edata))) -return -EFAULT ; -return 0 ; -#endif - } - -return -EOPNOTSUPP ; -} - -#endif -/*---------------------------------------------------------------- -* p80211knetdev_do_ioctl +* p80211knetdev_siocdevprivate * * Handle an ioctl call on one of our devices. Everything Linux * ioctl specific is done here. Then we pass the contents of the
@@ -537,8 +489,9 @@ static int p80211netdev_ethtool(struct wlandevice *wlandev,* locks. *---------------------------------------------------------------- */ -static int p80211knetdev_do_ioctl (struct net_device *dev, -struct ifreq *ifr,int cmd) +static int p80211knetdev_siocdevprivate (struct net_device *dev, +struct ifreq *ifr, +void __user *data,int cmd) {int result =0 ;struct p80211ioctl_req *req = (struct p80211ioctl_req *)ifr;
@@ -547,13 +500,8 @@ static int p80211knetdev_do_ioctl(struct net_device *dev,netdev_dbg (dev,"rx'd ioctl, cmd=%d, len=%d\n" , cmd, req->len); -#ifdef SIOCETHTOOL -if (cmd ==SIOCETHTOOL ) { - result = -p80211netdev_ethtool (wlandev, (void __user *)ifr->ifr_data); - goto bail; - } -#endif +if (in_compat_syscall ()) +return -EOPNOTSUPP ;/* Test the magic, assume ifr is good if it's there */ if (req->magic !=P80211_IOCTL_MAGIC ) {
@@ -572,14 +520,13 @@ static int p80211knetdev_do_ioctl(struct net_device *dev,/* Allocate a buf of size req->len */ msgbuf =kmalloc (req->len,GFP_KERNEL );if (msgbuf) { -if (copy_from_user (msgbuf, (void __user *)req->data, req->len)) +if (copy_from_user (msgbuf, data, req->len)) result = -EFAULT ;else result =p80211req_dorequest (wlandev, msgbuf);if (result ==0 ) { -if (copy_to_user - ((void __user *)req->data, msgbuf, req->len)) { +if (copy_to_user (data, msgbuf, req->len)) { result = -EFAULT ; } }
@@ -684,7 +631,7 @@ static const struct net_device_ops p80211_netdev_ops = { .ndo_stop = p80211knetdev_stop, .ndo_start_xmit = p80211knetdev_hard_start_xmit, .ndo_set_rx_mode = p80211knetdev_set_multicast_list, - .ndo_do_ioctl = p80211knetdev_do_ioctl, + .ndo_siocdevprivate = p80211knetdev_siocdevprivate, .ndo_set_mac_address = p80211knetdev_set_mac_address, .ndo_tx_timeout = p80211knetdev_tx_timeout, .ndo_validate_addr = eth_validate_addr,
Signature · 1 line
2.27.0
RFC 4/28 hostap: use ndo_siocdevprivate
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
hostap has a combination of iwpriv ioctls that do not work at all, and two SIOCDEVPRIVATE commands that work natively but lack a compat conversion handler.
For the moment, move them over to the new ndo_siocdevprivate interface and return an error for compat mode.
--- drivers/net/wireless/intersil/hostap/hostap.h | 3 +- .../wireless/intersil/hostap/hostap_ioctl.c | 30 +++++++++++++++---- .../wireless/intersil/hostap/hostap_main.c | 3 ++ 3 files changed, 29 insertions(+), 7 deletions(-)
drivers/net/wireless/intersil/hostap/hostap.h +2 -1
@@ -93,6 +93,7 @@ extern const struct iw_handler_def hostap_iw_handler_def;extern const struct ethtool_ops prism2_ethtool_ops;int hostap_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd); - +int hostap_siocdevprivate (struct net_device *dev,struct ifreq *ifr, +void __user *data,int cmd);#endif /* HOSTAP_H */
drivers/net/wireless/intersil/hostap/hostap_ioctl.c +24 -6
@@ -3952,7 +3952,8 @@ const struct iw_handler_def hostap_iw_handler_def = .get_wireless_stats = hostap_get_wireless_stats, }; - +/* Private ioctls (iwpriv) that have not yet been converted +* into new wireless extensions API */ int hostap_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd) {struct iwreq *wrq = (struct iwreq *) ifr;
@@ -3964,9 +3965,6 @@ int hostap_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) local = iface->local;switch (cmd) { -/* Private ioctls (iwpriv) that have not yet been converted -* into new wireless extensions API */ -case PRISM2_IOCTL_INQUIRE :if (!capable (CAP_NET_ADMIN )) ret = -EPERM ;else ret =prism2_ioctl_priv_inquire (dev, (int *) wrq->u.name);
@@ -4020,11 +4018,31 @@ int hostap_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) wrq->u.ap_addr.sa_data);break ;#endif /* PRISM2_NO_KERNEL_IEEE80211_MGMT */ +default : + ret = -EOPNOTSUPP ; +break ; + } + +return ret; +} +/* Private ioctls that are not used with iwpriv; +* in SIOCDEVPRIVATE range */ +int hostap_siocdevprivate (struct net_device *dev,struct ifreq *ifr, +void __user *data,int cmd) +{ +struct iwreq *wrq = (struct iwreq *)ifr; +struct hostap_interface *iface; +local_info_t *local; +int ret =0 ; -/* Private ioctls that are not used with iwpriv; -* in SIOCDEVPRIVATE range */ + iface =netdev_priv (dev); + local = iface->local; + +if (in_compat_syscall ())/* not implemented yet */ +return -EOPNOTSUPP ; +switch (cmd) {#ifdef PRISM2_DOWNLOAD_SUPPORT case PRISM2_IOCTL_DOWNLOAD :if (!capable (CAP_NET_ADMIN )) ret = -EPERM ;
drivers/net/wireless/intersil/hostap/hostap_main.c +3 -0
@@ -797,6 +797,7 @@ static const struct net_device_ops hostap_netdev_ops = { .ndo_open = prism2_open, .ndo_stop = prism2_close, .ndo_do_ioctl = hostap_ioctl, + .ndo_siocdevprivate = hostap_siocdevprivate, .ndo_set_mac_address = prism2_set_mac_address, .ndo_set_rx_mode = hostap_set_multicast_list, .ndo_tx_timeout = prism2_tx_timeout,
@@ -809,6 +810,7 @@ static const struct net_device_ops hostap_mgmt_netdev_ops = { .ndo_open = prism2_open, .ndo_stop = prism2_close, .ndo_do_ioctl = hostap_ioctl, + .ndo_siocdevprivate = hostap_siocdevprivate, .ndo_set_mac_address = prism2_set_mac_address, .ndo_set_rx_mode = hostap_set_multicast_list, .ndo_tx_timeout = prism2_tx_timeout,
@@ -821,6 +823,7 @@ static const struct net_device_ops hostap_master_ops = { .ndo_open = prism2_open, .ndo_stop = prism2_close, .ndo_do_ioctl = hostap_ioctl, + .ndo_siocdevprivate = hostap_siocdevprivate, .ndo_set_mac_address = prism2_set_mac_address, .ndo_set_rx_mode = hostap_set_multicast_list, .ndo_tx_timeout = prism2_tx_timeout,
Signature · 1 line
2.27.0
RFC 5/28 wireless: remove old ioctls
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
Commit 8bfb36766064 ("wireless: wext: remove ndo_do_ioctl fallback") removed the ability to have private wireless ioctl commands implemented in the normal ndo_do_ioctl handler, under the assumption that no remaining drivers used that.
This turned out to be incorrect, as both the atmel and intersil drivers do in fact implement a few such commands, along with SIOCDEVPRIVATE commands and infrastructure that would allow handling them using the more modern abstraction.
Since nobody noticed that these interfaces have been broken for over 3.5 years and the drivers are still usable without them (provided there are still users), it seems better to just remove the now dead code rather than trying to make it work again. An alternative would be to just remove the drivers entirely.
There are also a few staging drivers that got merged with the same type of interface, which was either broken by the same commit, or it never worked for the drivers that got merged later.
--- drivers/net/wireless/atmel/atmel.c | 72 -- drivers/net/wireless/intersil/hostap/hostap.h | 1 - .../wireless/intersil/hostap/hostap_ioctl.c | 229 ---- .../wireless/intersil/hostap/hostap_main.c | 3 - drivers/staging/ks7010/ks_wlan_net.c | 21 - drivers/staging/rtl8188eu/include/ieee80211.h | 2 - .../staging/rtl8188eu/include/osdep_intf.h | 1 - .../staging/rtl8188eu/os_dep/ioctl_linux.c | 938 -------------- drivers/staging/rtl8188eu/os_dep/os_intfs.c | 1 - drivers/staging/rtl8192u/r8192U_core.c | 109 -- drivers/staging/rtl8712/os_intfs.c | 1 - drivers/staging/rtl8712/osdep_intf.h | 2 - drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 125 -- .../staging/rtl8723bs/include/osdep_intf.h | 1 - .../staging/rtl8723bs/os_dep/ioctl_linux.c | 1083 ----------------- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 20 +- 16 files changed, 1 insertion(+), 2608 deletions(-)
drivers/net/wireless/atmel/atmel.c +0 -72
@@ -572,7 +572,6 @@ static const struct { { REG_DOMAIN_ISRAEL, 3, 9, "Israel"} };static void build_wpa_mib (struct atmel_private *priv); -static int atmel_ioctl (struct net_device *dev,struct ifreq *rq,int cmd);static void atmel_copy_to_card (struct net_device *dev,u16 dest,const unsigned char *src,u16 len); static void atmel_copy_to_host(struct net_device *dev, unsigned char *dest,
@@ -1488,7 +1487,6 @@ static const struct net_device_ops atmel_netdev_ops = { .ndo_stop = atmel_close, .ndo_set_mac_address = atmel_set_mac_address, .ndo_start_xmit = start_tx, - .ndo_do_ioctl = atmel_ioctl, .ndo_validate_addr = eth_validate_addr, };
@@ -2621,76 +2619,6 @@ static const struct iw_handler_def atmel_handler_def = { .get_wireless_stats = atmel_get_wireless_stats }; -static int atmel_ioctl (struct net_device *dev,struct ifreq *rq,int cmd) -{ -int i, rc =0 ; -struct atmel_private *priv =netdev_priv (dev); -struct atmel_priv_ioctl com; -struct iwreq *wrq = (struct iwreq *) rq; -unsigned char *new_firmware; -char domain[REGDOMAINSZ +1 ]; - -switch (cmd) { -case ATMELIDIFC : - wrq->u.param.value =ATMELMAGIC ; -break ; - -case ATMELFWL : -if (copy_from_user (&com, rq->ifr_data,sizeof (com))) { - rc = -EFAULT ; -break ; - } - -if (!capable (CAP_NET_ADMIN )) { - rc = -EPERM ; -break ; - } - - new_firmware =memdup_user (com.data, com.len); -if (IS_ERR (new_firmware)) { - rc =PTR_ERR (new_firmware); -break ; - } - -kfree (priv->firmware); - - priv->firmware = new_firmware; - priv->firmware_length = com.len; -strncpy (priv->firmware_id, com.id,31 ); - priv->firmware_id[31 ] ='\0' ; -break ; - -case ATMELRD : -if (copy_from_user (domain, rq->ifr_data,REGDOMAINSZ )) { - rc = -EFAULT ; -break ; - } - -if (!capable (CAP_NET_ADMIN )) { - rc = -EPERM ; -break ; - } - - domain[REGDOMAINSZ ] =0 ; - rc = -EINVAL ; -for (i =0 ; i <ARRAY_SIZE (channel_table); i++) { -if (!strcasecmp (channel_table[i].name, domain)) { - priv->config_reg_domain = channel_table[i].reg_domain; - rc =0 ; - } - } - -if (rc ==0 && priv->station_state !=STATION_STATE_DOWN ) - rc =atmel_open (dev); -break ; - -default : - rc = -EOPNOTSUPP ; - } - -return rc; -} -struct auth_body {__le16 alg;__le16 trans_seq;
drivers/net/wireless/intersil/hostap/hostap.h +0 -1
@@ -92,7 +92,6 @@ void hostap_info_process(local_info_t *local, struct sk_buff *skb);extern const struct iw_handler_def hostap_iw_handler_def;extern const struct ethtool_ops prism2_ethtool_ops; -int hostap_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd);int hostap_siocdevprivate (struct net_device *dev,struct ifreq *ifr,void __user *data,int cmd);
drivers/net/wireless/intersil/hostap/hostap_ioctl.c +0 -229
247 lines not on this page · raw message
drivers/net/wireless/intersil/hostap/hostap_main.c +0 -3
@@ -796,7 +796,6 @@ static const struct net_device_ops hostap_netdev_ops = { .ndo_open = prism2_open, .ndo_stop = prism2_close, - .ndo_do_ioctl = hostap_ioctl, .ndo_siocdevprivate = hostap_siocdevprivate, .ndo_set_mac_address = prism2_set_mac_address, .ndo_set_rx_mode = hostap_set_multicast_list,
@@ -809,7 +808,6 @@ static const struct net_device_ops hostap_mgmt_netdev_ops = { .ndo_open = prism2_open, .ndo_stop = prism2_close, - .ndo_do_ioctl = hostap_ioctl, .ndo_siocdevprivate = hostap_siocdevprivate, .ndo_set_mac_address = prism2_set_mac_address, .ndo_set_rx_mode = hostap_set_multicast_list,
@@ -822,7 +820,6 @@ static const struct net_device_ops hostap_master_ops = { .ndo_open = prism2_open, .ndo_stop = prism2_close, - .ndo_do_ioctl = hostap_ioctl, .ndo_siocdevprivate = hostap_siocdevprivate, .ndo_set_mac_address = prism2_set_mac_address, .ndo_set_rx_mode = hostap_set_multicast_list,
drivers/staging/ks7010/ks_wlan_net.c +0 -21
@@ -51,8 +51,6 @@ static int ks_wlan_close(struct net_device *dev);static void ks_wlan_set_rx_mode (struct net_device *dev);static struct net_device_stats *ks_wlan_get_stats (struct net_device *dev);static int ks_wlan_set_mac_address (struct net_device *dev,void *addr); -static int ks_wlan_netdev_ioctl (struct net_device *dev,struct ifreq *rq, -int cmd);static atomic_t update_phyinfo;static struct timer_list update_phyinfo_timer;
@@ -2451,24 +2449,6 @@ static const struct iw_handler_def ks_wlan_handler_def = { .get_wireless_stats = ks_get_wireless_stats, }; -static int ks_wlan_netdev_ioctl (struct net_device *dev,struct ifreq *rq, -int cmd) -{ -int ret; -struct iwreq *wrq = (struct iwreq *)rq; - -switch (cmd) { -case SIOCIWFIRSTPRIV +20 :/* KS_WLAN_SET_STOP_REQ */ - ret =ks_wlan_set_stop_request (dev,NULL , &wrq->u.mode,NULL ); -break ; -// All other calls are currently unsupported -default : - ret = -EOPNOTSUPP ; - } - -return ret; -} -static struct net_device_stats *ks_wlan_get_stats (struct net_device *dev) {
@@ -2601,7 +2581,6 @@ static const struct net_device_ops ks_wlan_netdev_ops = { .ndo_start_xmit = ks_wlan_start_xmit, .ndo_open = ks_wlan_open, .ndo_stop = ks_wlan_close, - .ndo_do_ioctl = ks_wlan_netdev_ioctl, .ndo_set_mac_address = ks_wlan_set_mac_address, .ndo_get_stats = ks_wlan_get_stats, .ndo_tx_timeout = ks_wlan_tx_timeout,
drivers/staging/rtl8188eu/include/ieee80211.h +0 -2
@@ -14,8 +14,6 @@#ifdef CONFIG_88EU_AP_MODE -#define RTL_IOCTL_HOSTAPD (SIOCIWFIRSTPRIV + 28) -/* RTL871X_IOCTL_HOSTAPD ioctl() cmd: */ enum { RTL871X_HOSTAPD_FLUSH = 1,
drivers/staging/rtl8188eu/include/osdep_intf.h +0 -1
@@ -21,7 +21,6 @@ u8 rtw_reset_drv_sw(struct adapter *padapter);void rtw_stop_drv_threads (struct adapter *padapter);void rtw_cancel_all_timer (struct adapter *padapter); -int rtw_ioctl (struct net_device *dev,struct ifreq *rq,int cmd);int rtw_android_priv_cmd (struct net_device *dev,struct ifreq *rq,void __user *data,int cmd);
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c +0 -938
947 lines not on this page · raw message
drivers/staging/rtl8188eu/os_dep/os_intfs.c +0 -1
@@ -289,7 +289,6 @@ static const struct net_device_ops rtw_netdev_ops = { .ndo_select_queue = rtw_select_queue, .ndo_set_mac_address = rtw_net_set_mac_address, .ndo_get_stats = rtw_net_get_stats, - .ndo_do_ioctl = rtw_ioctl, .ndo_siocdevprivate = rtw_android_priv_cmd, };
drivers/staging/rtl8192u/r8192U_core.c +0 -109
121 lines not on this page · raw message
drivers/staging/rtl8712/os_intfs.c +0 -1
@@ -191,7 +191,6 @@ static const struct net_device_ops rtl8712_netdev_ops = { .ndo_start_xmit = r8712_xmit_entry, .ndo_set_mac_address = r871x_net_set_mac_address, .ndo_get_stats = r871x_net_get_stats, - .ndo_do_ioctl = r871x_ioctl, };struct net_device *r8712_init_netdev (void )
drivers/staging/rtl8712/osdep_intf.h +0 -2
@@ -27,6 +27,4 @@ struct intf_priv { struct completion io_retevt_comp; }; -int r871x_ioctl (struct net_device *dev,struct ifreq *rq,int cmd); -#endif /*_OSDEP_INTF_H_*/
drivers/staging/rtl8712/rtl871x_ioctl_linux.c +0 -125
137 lines not on this page · raw message
drivers/staging/rtl8723bs/include/osdep_intf.h +0 -1
@@ -53,7 +53,6 @@ u32 rtw_start_drv_threads(struct adapter *padapter);void rtw_stop_drv_threads (struct adapter *padapter);void rtw_cancel_all_timer (struct adapter *padapter); -int rtw_ioctl (struct net_device *dev,struct ifreq *rq,int cmd);int rtw_siocdevprivate (struct net_device *dev,struct ifreq *rq,void __user *data,int cmd);
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +0 -1083
1,092 lines not on this page · raw message
drivers/staging/rtl8723bs/os_dep/os_intfs.c +1 -19
@@ -416,30 +416,13 @@ u16 rtw_recv_select_queue(struct sk_buff *skb)return rtw_1d_to_queue[priority]; } -static int rtw_ndev_notifier_call (struct notifier_block *nb,unsigned long state,void *ptr) -{ -struct net_device *dev =netdev_notifier_info_to_dev (ptr); - -if (dev->netdev_ops->ndo_do_ioctl != rtw_ioctl) -return NOTIFY_DONE ; - -DBG_871X_LEVEL (_drv_info_,FUNC_NDEV_FMT " state:%lu\n" ,FUNC_NDEV_ARG (dev), state); - -return NOTIFY_DONE ; -} - -static struct notifier_block rtw_ndev_notifier = { - .notifier_call = rtw_ndev_notifier_call, -}; -int rtw_ndev_notifier_register (void ) { -return register_netdevice_notifier (&rtw_ndev_notifier); +return 0 ; }void rtw_ndev_notifier_unregister (void ) { -unregister_netdevice_notifier (&rtw_ndev_notifier); }
@@ -469,7 +452,6 @@ static const struct net_device_ops rtw_netdev_ops = { .ndo_select_queue = rtw_select_queue, .ndo_set_mac_address = rtw_net_set_mac_address, .ndo_get_stats = rtw_net_get_stats, - .ndo_do_ioctl = rtw_ioctl, .ndo_siocdevprivate = rtw_siocdevprivate, };
Signature · 1 line
2.27.0
RFC 6/28 bridge: use ndo_siocdevprivate
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
The bridge driver has an old set of ioctls using the SIOCDEVPRIVATE namespace that have never worked in compat mode and are explicitly forbidden already.
Move them over to ndo_siocdevprivate and fix compat mode for these, because we can.
--- net/bridge/br_device.c | 1 + net/bridge/br_ioctl.c | 36 ++++++++++++++++++++++++------------ net/bridge/br_private.h | 2 ++ 3 files changed, 27 insertions(+), 12 deletions(-)
net/bridge/br_device.c +1 -0
@@ -409,6 +409,7 @@ static const struct net_device_ops br_netdev_ops = { .ndo_change_rx_flags = br_dev_change_rx_flags, .ndo_change_mtu = br_change_mtu, .ndo_do_ioctl = br_dev_ioctl, + .ndo_siocdevprivate = br_dev_siocdevprivate, #ifdef CONFIG_NET_POLL_CONTROLLER .ndo_netpoll_setup = br_netpoll_setup, .ndo_netpoll_cleanup = br_netpoll_cleanup,
net/bridge/br_ioctl.c +24 -12
@@ -106,15 +106,31 @@ static int add_del_if(struct net_bridge *br, int ifindex, int isadd)* This interface is deprecated because it was too difficult * to do the translation for 32/64bit ioctl compatibility. */ -static int old_dev_ioctl (struct net_device *dev,struct ifreq *rq,int cmd) +int br_dev_siocdevprivate (struct net_device *dev,struct ifreq *rq,void __user *data,int cmd) {struct net_bridge *br =netdev_priv (dev);struct net_bridge_port *p =NULL ;unsigned long args[4 ]; +void __user *argp;int ret = -EOPNOTSUPP ; -if (copy_from_user (args, rq->ifr_data,sizeof (args))) -return -EFAULT ; +if (in_compat_syscall ()) { +unsigned int cargs[4 ]; +if (copy_from_user (cargs, data,sizeof (cargs))) +return -EFAULT ; + + args[0 ] = cargs[0 ]; + args[1 ] = cargs[1 ]; + args[2 ] = cargs[2 ]; + args[3 ] = cargs[3 ]; + + argp =compat_ptr (args[1 ]); + }else { +if (copy_from_user (args, data,sizeof (args))) +return -EFAULT ; + + argp = (void __user *)args[1 ]; + }switch (args[0 ]) {case BRCTL_ADD_IF :
@@ -171,7 +187,7 @@ static int old_dev_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)return -ENOMEM ;get_port_ifindices (br, indices, num); -if (copy_to_user ((void __user *)args[1 ], indices, num*sizeof (int ))) +if (copy_to_user (argp, indices, num*sizeof (int ))) num = -EFAULT ;kfree (indices);return num;
@@ -232,7 +248,7 @@ static int old_dev_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)rcu_read_unlock (); -if (copy_to_user ((void __user *)args[1 ], &p,sizeof (p))) +if (copy_to_user (argp, &p,sizeof (p)))return -EFAULT ;return 0 ;
@@ -282,8 +298,7 @@ static int old_dev_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) }case BRCTL_GET_FDB_ENTRIES : -return get_fdb_entries (br, (void __user *)args[1 ], - args[2 ], args[3 ]); +return get_fdb_entries (br, argp, args[2 ], args[3 ]); }if (!ret) {
@@ -320,7 +335,7 @@ static int old_deviceless(struct net *net, void __user *uarg) args[2 ] =get_bridge_ifindices (net, indices, args[2 ]); - ret =copy_to_user ((void __user *)args[1 ], indices, args[2 ]*sizeof (int )) + ret =copy_to_user (uarg, indices, args[2 ]*sizeof (int )) ? -EFAULT : args[2 ];kfree (indices);
@@ -335,7 +350,7 @@ static int old_deviceless(struct net *net, void __user *uarg)if (!ns_capable (net->user_ns,CAP_NET_ADMIN ))return -EPERM ; -if (copy_from_user (buf, (void __user *)args[1 ],IFNAMSIZ )) +if (copy_from_user (buf, uarg,IFNAMSIZ ))return -EFAULT ; buf[IFNAMSIZ -1 ] =0 ;
@@ -383,9 +398,6 @@ int br_dev_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)struct net_bridge *br =netdev_priv (dev);switch (cmd) { -case SIOCDEVPRIVATE : -return old_dev_ioctl (dev, rq, cmd); -case SIOCBRADDIF :case SIOCBRDELIF :return add_del_if (br, rq->ifr_ifindex, cmd ==SIOCBRADDIF );
net/bridge/br_private.h +2 -0
@@ -778,6 +778,8 @@ br_port_get_check_rtnl(const struct net_device *dev)/* br_ioctl.c */ int br_dev_ioctl (struct net_device *dev,struct ifreq *rq,int cmd); +int br_dev_siocdevprivate (struct net_device *dev,struct ifreq *rq, +void __user *data,int cmd);int br_ioctl_deviceless_stub (struct net *net,unsigned int cmd,void __user *arg);
Signature · 1 line
2.27.0
RFC 7/28 phonet: use siocdevprivate
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
phonet has a single private ioctl that is broken in compat mode on big-endian machines today because the data returned from it is never copied back to user space.
Move it over to the ndo_siocdevprivate callback, which also fixes the compat issue.
--- drivers/net/usb/cdc-phonet.c | 5 +++-- net/phonet/pn_dev.c | 6 +++--- 2 files changed, 6 insertions(+), 5 deletions(-)
drivers/net/usb/cdc-phonet.c +3 -2
@@ -253,7 +253,8 @@ static int usbpn_close(struct net_device *dev)return usb_set_interface (pnd->usb, num, !pnd->active_setting); } -static int usbpn_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd) +static int usbpn_siocdevprivate (struct net_device *dev,struct ifreq *ifr, +void __user *data,int cmd) {struct if_phonet_req *req = (struct if_phonet_req *)ifr;
@@ -269,7 +270,7 @@ static const struct net_device_ops usbpn_ops = { .ndo_open = usbpn_open, .ndo_stop = usbpn_close, .ndo_start_xmit = usbpn_xmit, - .ndo_do_ioctl = usbpn_ioctl, + .ndo_siocdevprivate = usbpn_siocdevprivate, };static void usbpn_setup (struct net_device *dev)
net/phonet/pn_dev.c +3 -3
@@ -233,11 +233,11 @@ static int phonet_device_autoconf(struct net_device *dev)struct if_phonet_req req;int ret; -if (!dev->netdev_ops->ndo_do_ioctl) +if (!dev->netdev_ops->ndo_siocdevprivate)return -EOPNOTSUPP ; - ret = dev->netdev_ops->ndo_do_ioctl (dev, (struct ifreq *)&req, -SIOCPNGAUTOCONF ); + ret = dev->netdev_ops->ndo_siocdevprivate (dev, (struct ifreq *)&req, +NULL ,SIOCPNGAUTOCONF );if (ret <0 )return ret;
Signature · 1 line
2.27.0
RFC 8/28 tulip: use ndo_siocdevprivate
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
The tulip driver has a debugging method over ioctl built-in, but it does not actually check the command type, which may end up leading to random behavior when trying to run other ioctls on it.
Change the driver to use ndo_siocdevprivate and limit the execution further to the first private command code. If anyone still has tools to run these debugging commands, they might have to be patched for it if they pass different ioctl command.
The function has existed in this form since the driver was merged in Linux-1.1.86.
--- drivers/net/ethernet/dec/tulip/de4x5.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/net/ethernet/dec/tulip/de4x5.c +6 -3
@@ -902,7 +902,7 @@ static int de4x5_close(struct net_device *dev);static struct net_device_stats *de4x5_get_stats (struct net_device *dev);static void de4x5_local_stats (struct net_device *dev,char *buf,int pkt_len);static void set_multicast_list (struct net_device *dev); -static int de4x5_ioctl (struct net_device *dev,struct ifreq *rq,int cmd); +static int de4x5_siocdevprivate (struct net_device *dev,struct ifreq *rq,void __user *data,int cmd);/* ** Private functions
@@ -1084,7 +1084,7 @@ static const struct net_device_ops de4x5_netdev_ops = { .ndo_start_xmit = de4x5_queue_pkt, .ndo_get_stats = de4x5_get_stats, .ndo_set_rx_mode = set_multicast_list, - .ndo_do_ioctl = de4x5_ioctl, + .ndo_siocdevprivate = de4x5_siocdevprivate, .ndo_set_mac_address= eth_mac_addr, .ndo_validate_addr = eth_validate_addr, };
@@ -5357,7 +5357,7 @@ de4x5_dbg_rx(struct sk_buff *skb, int len)** this function is only used for my testing. */ static int -de4x5_ioctl (struct net_device *dev,struct ifreq *rq,int cmd) +de4x5_siocdevprivate (struct net_device *dev,struct ifreq *rq,void __user *data,int cmd) {struct de4x5_private *lp =netdev_priv (dev);struct de4x5_ioctl *ioc = (struct de4x5_ioctl *) &rq->ifr_ifru;
@@ -5371,6 +5371,9 @@ de4x5_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) } tmp;u_long flags =0 ; +if (cmd !=SIOCDEVPRIVATE ||in_compat_syscall ()) +return -EOPNOTSUPP ; +switch (ioc->cmd) {case DE4X5_GET_HWADDR :/* Get the hardware address */ ioc->len =ETH_ALEN ;
Signature · 1 line
2.27.0
RFC 9/28 bonding: use siocdevprivate
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
The bonding driver supports two command codes for each operation: one in the SIOCDEVPRIVATE range and another one with the same definition but a unique command code.
Only the second set currently works in compat mode, as the ifr_data expansion overwrites part of the ifr_slave field.
Move the private ones into ndo_siocdevprivate and change the implementation to call the other function. This makes both version work correctly.
--- drivers/net/bonding/bond_main.c | 29 +++++++++++++++++++++++------ 1 file changed, 23 insertions(+), 6 deletions(-)
drivers/net/bonding/bond_main.c +23 -6
@@ -3781,7 +3781,6 @@ static int bond_do_ioctl(struct net_device *bond_dev, struct ifreq *ifr, int cmd }return 0 ; -case BOND_INFO_QUERY_OLD :case SIOCBONDINFOQUERY : u_binfo = (struct ifbond __user *)ifr->ifr_data;
@@ -3793,7 +3792,6 @@ static int bond_do_ioctl(struct net_device *bond_dev, struct ifreq *ifr, int cmdreturn -EFAULT ;return 0 ; -case BOND_SLAVE_INFO_QUERY_OLD :case SIOCBONDSLAVEINFOQUERY : u_sinfo = (struct ifslave __user *)ifr->ifr_data;
@@ -3823,19 +3821,15 @@ static int bond_do_ioctl(struct net_device *bond_dev, struct ifreq *ifr, int cmdreturn -ENODEV ;switch (cmd) { -case BOND_ENSLAVE_OLD :case SIOCBONDENSLAVE : res =bond_enslave (bond_dev, slave_dev,NULL );break ; -case BOND_RELEASE_OLD :case SIOCBONDRELEASE : res =bond_release (bond_dev, slave_dev);break ; -case BOND_SETHWADDR_OLD :case SIOCBONDSETHWADDR : res =bond_set_dev_addr (bond_dev, slave_dev);break ; -case BOND_CHANGE_ACTIVE_OLD :case SIOCBONDCHANGEACTIVE :bond_opt_initstr (&newval, slave_dev->name); res = __bond_opt_set_notify(bond, BOND_OPT_ACTIVE_SLAVE,
@@ -3848,6 +3842,28 @@ static int bond_do_ioctl(struct net_device *bond_dev, struct ifreq *ifr, int cmdreturn res; } +static int bond_siocdevprivate (struct net_device *bond_dev,struct ifreq *ifr, +void __user *data,int cmd) +{ +struct ifreq ifrdata = { .ifr_data = data }; +switch (cmd) { +case BOND_INFO_QUERY_OLD : +return bond_do_ioctl (bond_dev, &ifrdata,SIOCBONDINFOQUERY ); +case BOND_SLAVE_INFO_QUERY_OLD : +return bond_do_ioctl (bond_dev, &ifrdata,SIOCBONDSLAVEINFOQUERY ); +case BOND_ENSLAVE_OLD : +return bond_do_ioctl (bond_dev, ifr,SIOCBONDENSLAVE ); +case BOND_RELEASE_OLD : +return bond_do_ioctl (bond_dev, ifr,SIOCBONDRELEASE ); +case BOND_SETHWADDR_OLD : +return bond_do_ioctl (bond_dev, ifr,SIOCBONDSETHWADDR ); +case BOND_CHANGE_ACTIVE_OLD : +return bond_do_ioctl (bond_dev, ifr,SIOCBONDCHANGEACTIVE ); + } + +return -EOPNOTSUPP ; +} +static void bond_change_rx_flags (struct net_device *bond_dev,int change) {struct bonding *bond =netdev_priv (bond_dev);
@@ -4642,6 +4658,7 @@ static const struct net_device_ops bond_netdev_ops = { .ndo_select_queue = bond_select_queue, .ndo_get_stats64 = bond_get_stats, .ndo_do_ioctl = bond_do_ioctl, + .ndo_siocdevprivate = bond_siocdevprivate, .ndo_change_rx_flags = bond_change_rx_flags, .ndo_set_rx_mode = bond_set_rx_mode, .ndo_change_mtu = bond_change_mtu,
Signature · 1 line
2.27.0
RFC 10/28 appletalk: use ndo_siocdevprivate
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
appletalk has three SIOCDEVPRIVATE ioctl commands that are broken in compat mode because the passed structure contains a pointer.
Change it over to ndo_siocdevprivate for consistency and make it return an error when called in compat mode. This could be fixed if there are still users.
--- drivers/net/appletalk/ipddp.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-)
drivers/net/appletalk/ipddp.c +9 -6
@@ -54,11 +54,11 @@ static netdev_tx_t ipddp_xmit(struct sk_buff *skb,static int ipddp_create (struct ipddp_route *new_rt);static int ipddp_delete (struct ipddp_route *rt);static struct ipddp_route *__ipddp_find_route (struct ipddp_route *rt); -static int ipddp_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd); +static int ipddp_siocdevprivate (struct net_device *dev,struct ifreq *ifr,void __user *data,int cmd);static const struct net_device_ops ipddp_netdev_ops = { .ndo_start_xmit = ipddp_xmit, - .ndo_do_ioctl = ipddp_ioctl, + .ndo_siocdevprivate = ipddp_siocdevprivate, .ndo_set_mac_address = eth_mac_addr, .ndo_validate_addr = eth_validate_addr, };
@@ -268,15 +268,18 @@ static struct ipddp_route* __ipddp_find_route(struct ipddp_route *rt)return NULL ; } -static int ipddp_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd) +static int ipddp_siocdevprivate (struct net_device *dev,struct ifreq *ifr, +void __user *data,int cmd) { -struct ipddp_route __user *rt = ifr->ifr_data;struct ipddp_route rcp, rcp2, *rp; +if (in_compat_syscall ()) +return -EOPNOTSUPP ; +if (!capable (CAP_NET_ADMIN ))return -EPERM ; -if (copy_from_user (&rcp, rt,sizeof (rcp))) +if (copy_from_user (&rcp, data,sizeof (rcp)))return -EFAULT ; switch(cmd)
@@ -296,7 +299,7 @@ static int ipddp_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)spin_unlock_bh (&ipddp_route_lock);if (rp) { -if (copy_to_user (rt, &rcp2, +if (copy_to_user (data, &rcp2,sizeof (struct ipddp_route )))return -EFAULT ;return 0 ;
Signature · 1 line
2.27.0
RFC 11/28 hamachi: use ndo_siocdevprivate
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
hamachi has one command that overloads the ifreq argument and requires a conversion to ndo_siocdevprivate in order to make compat mode work, so split it from ndo_ioctl.
--- drivers/net/ethernet/packetengines/hamachi.c | 63 ++++++++++++-------- 1 file changed, 38 insertions(+), 25 deletions(-)
drivers/net/ethernet/packetengines/hamachi.c +38 -25
@@ -546,7 +546,9 @@ static int read_eeprom(void __iomem *ioaddr, int location);static int mdio_read (struct net_device *dev,int phy_id,int location);static void mdio_write (struct net_device *dev,int phy_id,int location,int value);static int hamachi_open (struct net_device *dev); -static int netdev_ioctl (struct net_device *dev,struct ifreq *rq,int cmd); +static int hamachi_ioctl (struct net_device *dev,struct ifreq *rq,int cmd); +static int hamachi_siocdevprivate (struct net_device *dev,struct ifreq *rq, +void __user *data,int cmd);static void hamachi_timer (struct timer_list *t);static void hamachi_tx_timeout (struct net_device *dev,unsigned int txqueue);static void hamachi_init_ring (struct net_device *dev);
@@ -571,7 +573,8 @@ static const struct net_device_ops hamachi_netdev_ops = { .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = eth_mac_addr, .ndo_tx_timeout = hamachi_tx_timeout, - .ndo_do_ioctl = netdev_ioctl, + .ndo_do_ioctl = hamachi_ioctl, + .ndo_siocdevprivate = hamachi_siocdevprivate, };
@@ -1867,7 +1870,36 @@ static const struct ethtool_ops ethtool_ops_no_mii = { .get_drvinfo = hamachi_get_drvinfo, }; -static int netdev_ioctl (struct net_device *dev,struct ifreq *rq,int cmd) +/* private ioctl: set rx,tx intr params */ +static int hamachi_siocdevprivate (struct net_device *dev,struct ifreq *rq, +void __user *data,int cmd) +{ +struct hamachi_private *np =netdev_priv (dev); +u32 *d = (u32 *)&rq->ifr_ifru; + +if (!netif_running (dev)) +return -EINVAL ; + +if (cmd !=SIOCDEVPRIVATE +3 ) +return -EOPNOTSUPP ; + +/* Should add this check here or an ordinary user can do nasty +* things. -KDU +* +* TODO: Shut down the Rx and Tx engines while doing this. +*/ +if (!capable (CAP_NET_ADMIN )) +return -EPERM ; +writel (d[0 ], np->base + TxIntrCtrl); +writel (d[1 ], np->base + RxIntrCtrl); +printk (KERN_NOTICE "%s: tx %08x, rx %08x intr\n" , dev->name, + (u32 )readl (np->base + TxIntrCtrl), + (u32 )readl (np->base + RxIntrCtrl)); + +return 0 ; +} + +static int hamachi_ioctl (struct net_device *dev,struct ifreq *rq,int cmd) {struct hamachi_private *np =netdev_priv (dev);struct mii_ioctl_data *data =if_mii (rq);
@@ -1876,28 +1908,9 @@ static int netdev_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)if (!netif_running (dev))return -EINVAL ; -if (cmd == (SIOCDEVPRIVATE +3 )) {/* set rx,tx intr params */ -u32 *d = (u32 *)&rq->ifr_ifru; -/* Should add this check here or an ordinary user can do nasty -* things. -KDU -* -* TODO: Shut down the Rx and Tx engines while doing this. -*/ -if (!capable (CAP_NET_ADMIN )) -return -EPERM ; -writel (d[0 ], np->base + TxIntrCtrl); -writel (d[1 ], np->base + RxIntrCtrl); -printk (KERN_NOTICE "%s: tx %08x, rx %08x intr\n" , dev->name, - (u32 )readl (np->base + TxIntrCtrl), - (u32 )readl (np->base + RxIntrCtrl)); - rc =0 ; - } - -else { -spin_lock_irq (&np->lock); - rc =generic_mii_ioctl (&np->mii_if, data, cmd,NULL ); -spin_unlock_irq (&np->lock); - } +spin_lock_irq (&np->lock); + rc =generic_mii_ioctl (&np->mii_if, data, cmd,NULL ); +spin_unlock_irq (&np->lock);return rc; }
Signature · 1 line
2.27.0
RFC 12/28 tehuti: use ndo_siocdevprivate
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
Tehuti only implements private ioctl commands, and implements them by overriding the ifreq layout, which is broken in compat mode.
Move it to the ndo_siocdevprivate callback in order to fix this.
--- drivers/net/ethernet/tehuti/tehuti.c | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-)
drivers/net/ethernet/tehuti/tehuti.c +5 -13
@@ -637,7 +637,8 @@ static int bdx_range_check(struct bdx_priv *priv, u32 offset) -EINVAL : 0; } -static int bdx_ioctl_priv (struct net_device *ndev,struct ifreq *ifr,int cmd) +static int bdx_siocdevprivate (struct net_device *ndev,struct ifreq *ifr, +void __user *udata,int cmd) {struct bdx_priv *priv =netdev_priv (ndev);u32 data[3 ];
@@ -647,7 +648,7 @@ static int bdx_ioctl_priv(struct net_device *ndev, struct ifreq *ifr, int cmd)DBG ("jiffies=%ld cmd=%d\n" , jiffies, cmd);if (cmd !=SIOCDEVPRIVATE ) { - error =copy_from_user (data, ifr->ifr_data,sizeof (data)); + error =copy_from_user (data, udata,sizeof (data));if (error) {pr_err ("can't copy from user\n" );RET (-EFAULT );
@@ -669,7 +670,7 @@ static int bdx_ioctl_priv(struct net_device *ndev, struct ifreq *ifr, int cmd) data[2 ] =READ_REG (priv, data[1 ]);DBG ("read_reg(0x%x)=0x%x (dec %d)\n" , data[1 ], data[2 ], data[2 ]); - error =copy_to_user (ifr->ifr_data, data,sizeof (data)); + error =copy_to_user (udata, data,sizeof (data));if (error)RET (-EFAULT );break ;
@@ -688,15 +689,6 @@ static int bdx_ioctl_priv(struct net_device *ndev, struct ifreq *ifr, int cmd)return 0 ; } -static int bdx_ioctl (struct net_device *ndev,struct ifreq *ifr,int cmd) -{ -ENTER ; -if (cmd >=SIOCDEVPRIVATE && cmd <= (SIOCDEVPRIVATE +15 )) -RET (bdx_ioctl_priv (ndev, ifr, cmd)); -else -RET (-EOPNOTSUPP ); -} -/** * __bdx_vlan_rx_vid - private helper for adding/killing VLAN vid * @ndev: network device
@@ -1860,7 +1852,7 @@ static const struct net_device_ops bdx_netdev_ops = { .ndo_stop = bdx_close, .ndo_start_xmit = bdx_tx_transmit, .ndo_validate_addr = eth_validate_addr, - .ndo_do_ioctl = bdx_ioctl, + .ndo_siocdevprivate = bdx_siocdevprivate, .ndo_set_rx_mode = bdx_setmulti, .ndo_change_mtu = bdx_change_mtu, .ndo_set_mac_address = bdx_set_mac,
Signature · 1 line
2.27.0
RFC 13/28 eql: use ndo_siocdevprivate
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
The private ioctls in eql pass the arguments correctly through ifr_data, but the slaving_request_t and slave_config_t structures are incompatible with compat mode and need special conversion code in the driver.
Convert to siocdevprivate for now, and return an error when called in compat mode.
--- drivers/net/eql.c | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-)
drivers/net/eql.c +14 -9
@@ -131,7 +131,8 @@static int eql_open (struct net_device *dev);static int eql_close (struct net_device *dev); -static int eql_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd); +static int eql_siocdevprivate (struct net_device *dev,struct ifreq *ifr, +void __user *data,int cmd);static netdev_tx_t eql_slave_xmit (struct sk_buff *skb,struct net_device *dev);#define eql_is_slave (dev) ((dev->flags & IFF_SLAVE) == IFF_SLAVE)
@@ -170,7 +171,7 @@ static const char version[] __initconst =static const struct net_device_ops eql_netdev_ops = { .ndo_open = eql_open, .ndo_stop = eql_close, - .ndo_do_ioctl = eql_ioctl, + .ndo_siocdevprivate = eql_siocdevprivate, .ndo_start_xmit = eql_slave_xmit, };
@@ -268,25 +269,29 @@ static int eql_s_slave_cfg(struct net_device *dev, slave_config_t __user *sc);static int eql_g_master_cfg (struct net_device *dev,master_config_t __user *mc);static int eql_s_master_cfg (struct net_device *dev,master_config_t __user *mc); -static int eql_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd) +static int eql_siocdevprivate (struct net_device *dev,struct ifreq *ifr, +void __user *data,int cmd) {if (cmd !=EQL_GETMASTRCFG && cmd !=EQL_GETSLAVECFG && !capable (CAP_NET_ADMIN ))return -EPERM ; +if (in_compat_syscall ())/* to be implemented */ +return -EOPNOTSUPP ; +switch (cmd) {case EQL_ENSLAVE : -return eql_enslave (dev, ifr->ifr_data); +return eql_enslave (dev, data);case EQL_EMANCIPATE : -return eql_emancipate (dev, ifr->ifr_data); +return eql_emancipate (dev, data);case EQL_GETSLAVECFG : -return eql_g_slave_cfg (dev, ifr->ifr_data); +return eql_g_slave_cfg (dev, data);case EQL_SETSLAVECFG : -return eql_s_slave_cfg (dev, ifr->ifr_data); +return eql_s_slave_cfg (dev, data);case EQL_GETMASTRCFG : -return eql_g_master_cfg (dev, ifr->ifr_data); +return eql_g_master_cfg (dev, data);case EQL_SETMASTRCFG : -return eql_s_master_cfg (dev, ifr->ifr_data); +return eql_s_master_cfg (dev, data);default :return -EOPNOTSUPP ; }
Signature · 1 line
2.27.0
RFC 14/28 fddi: use ndo_siocdevprivate
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
The skfddi driver has a private ioctl and passes the data correctly through ifr_data, but the use of a pointer in s_skfp_ioctl is broken in compat mode.
Change the driver to use ndo_siocdevprivate and disallow calling it in compat mode until a conversion handler is added.
--- drivers/net/fddi/skfp/skfddi.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-)
drivers/net/fddi/skfp/skfddi.c +11 -7
@@ -103,7 +103,8 @@ static struct net_device_stats *skfp_ctl_get_stats(struct net_device *dev);static void skfp_ctl_set_multicast_list (struct net_device *dev);static void skfp_ctl_set_multicast_list_wo_lock (struct net_device *dev);static int skfp_ctl_set_mac_address (struct net_device *dev,void *addr); -static int skfp_ioctl (struct net_device *dev,struct ifreq *rq,int cmd); +static int skfp_siocdevprivate (struct net_device *dev,struct ifreq *rq, +void __user *data,int cmd);static netdev_tx_t skfp_send_pkt (struct sk_buff *skb,struct net_device *dev);static void send_queued_packets (struct s_smc *smc);
@@ -164,7 +165,7 @@ static const struct net_device_ops skfp_netdev_ops = { .ndo_get_stats = skfp_ctl_get_stats, .ndo_set_rx_mode = skfp_ctl_set_multicast_list, .ndo_set_mac_address = skfp_ctl_set_mac_address, - .ndo_do_ioctl = skfp_ioctl, + .ndo_siocdevprivate = skfp_siocdevprivate, };/*
@@ -932,9 +933,9 @@ static int skfp_ctl_set_mac_address(struct net_device *dev, void *addr)/* -* ============== -* = skfp_ioctl = -* ============== +* ======================= +* = skfp_siocdevprivate = +* ======================= * * Overview: *
@@ -954,16 +955,19 @@ static int skfp_ctl_set_mac_address(struct net_device *dev, void *addr)*/ -static int skfp_ioctl (struct net_device *dev,struct ifreq *rq,int cmd) +static int skfp_siocdevprivate (struct net_device *dev,struct ifreq *rq,void __user *data,int cmd) {struct s_smc *smc =netdev_priv (dev);skfddi_priv *lp = &smc->os;struct s_skfp_ioctl ioc;int status =0 ; -if (copy_from_user (&ioc, rq->ifr_data,sizeof (struct s_skfp_ioctl ))) +if (copy_from_user (&ioc, data,sizeof (struct s_skfp_ioctl )))return -EFAULT ; +if (in_compat_syscall ()) +return -EOPNOTSUPP ; +switch (ioc.cmd) {case SKFP_GET_STATS :/* Get the driver statistics */ ioc.len =sizeof (lp->MacStat);
Signature · 1 line
2.27.0
RFC 15/28 net: usb: use ndo_siocdevprivate
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
The pegasus and rtl8150 drivers use SIOCDEVPRIVATE ioctls to access their MII registers, in place of the normal commands. This is broken for all compat ioctls today.
Change to ndo_siocdevprivate to fix it.
--- drivers/net/usb/pegasus.c | 4 ++-- drivers/net/usb/rtl8150.c | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-)
drivers/net/usb/pegasus.c +2 -2
@@ -988,7 +988,7 @@ static const struct ethtool_ops ops = { .set_link_ksettings = pegasus_set_link_ksettings, }; -static int pegasus_ioctl (struct net_device *net,struct ifreq *rq,int cmd) +static int pegasus_siocdevprivate (struct net_device *net,struct ifreq *rq,void __user *udata,int cmd) {__u16 *data = (__u16 *) &rq->ifr_ifru;pegasus_t *pegasus =netdev_priv (net);
@@ -1246,7 +1246,7 @@ static int pegasus_resume(struct usb_interface *intf)static const struct net_device_ops pegasus_netdev_ops = { .ndo_open = pegasus_open, .ndo_stop = pegasus_close, - .ndo_do_ioctl = pegasus_ioctl, + .ndo_siocdevprivate = pegasus_siocdevprivate, .ndo_start_xmit = pegasus_start_xmit, .ndo_set_rx_mode = pegasus_set_multicast, .ndo_tx_timeout = pegasus_tx_timeout,
drivers/net/usb/rtl8150.c +3 -2
@@ -822,7 +822,8 @@ static const struct ethtool_ops ops = { .get_link_ksettings = rtl8150_get_link_ksettings, }; -static int rtl8150_ioctl (struct net_device *netdev,struct ifreq *rq,int cmd) +static int rtl8150_siocdevprivate (struct net_device *netdev,struct ifreq *rq, +void __user *udata,int cmd) {rtl8150_t *dev =netdev_priv (netdev);u16 *data = (u16 *) & rq->ifr_ifru;
@@ -850,7 +851,7 @@ static int rtl8150_ioctl(struct net_device *netdev, struct ifreq *rq, int cmd)static const struct net_device_ops rtl8150_netdev_ops = { .ndo_open = rtl8150_open, .ndo_stop = rtl8150_close, - .ndo_do_ioctl = rtl8150_ioctl, + .ndo_siocdevprivate = rtl8150_siocdevprivate, .ndo_start_xmit = rtl8150_start_xmit, .ndo_tx_timeout = rtl8150_tx_timeout, .ndo_set_rx_mode = rtl8150_set_multicast,
Signature · 1 line
2.27.0
RFC 16/28 slip/plip: use ndo_siocdevprivate
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
slip and plip both use a couple of SIOCDEVPRIVATE ioctl commands that overload the ifreq layout in a way that is incompatible with compat mode.
Convert to use ndo_siocdevprivate to allow passing the data this way, but return an error in compat mode anyway because the private structure is still incompatible.
This could be fixed as well to make compat work properly.
--- drivers/net/plip/plip.c | 11 ++++++++--- drivers/net/slip/slip.c | 12 ++++++++---- 2 files changed, 16 insertions(+), 7 deletions(-)
drivers/net/plip/plip.c +8 -3
@@ -150,7 +150,8 @@ static int plip_hard_header_cache(const struct neighbour *neigh, struct hh_cache *hh, __be16 type);static int plip_open (struct net_device *dev);static int plip_close (struct net_device *dev); -static int plip_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd); +static int plip_siocdevprivate (struct net_device *dev,struct ifreq *ifr, +void __user *data,int cmd);static int plip_preempt (void *handle);static void plip_wakeup (void *handle);
@@ -265,7 +266,7 @@ static const struct net_device_ops plip_netdev_ops = { .ndo_open = plip_open, .ndo_stop = plip_close, .ndo_start_xmit = plip_tx_packet, - .ndo_do_ioctl = plip_ioctl, + .ndo_siocdevprivate = plip_siocdevprivate, .ndo_set_mac_address = eth_mac_addr, .ndo_validate_addr = eth_validate_addr, };
@@ -1205,7 +1206,8 @@ plip_wakeup(void *handle) }static int -plip_ioctl (struct net_device *dev,struct ifreq *rq,int cmd) +plip_siocdevprivate (struct net_device *dev,struct ifreq *rq, +void __user *data,int cmd) {struct net_local *nl =netdev_priv (dev);struct plipconf *pc = (struct plipconf *) &rq->ifr_ifru;
@@ -1213,6 +1215,9 @@ plip_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)if (cmd !=SIOCDEVPLIP )return -EOPNOTSUPP ; +if (in_compat_syscall ()) +return -EOPNOTSUPP ; +switch (pc->pcmd) {case PLIP_GET_TIMEOUT : pc->trigger = nl->trigger;
drivers/net/slip/slip.c +8 -4
@@ -108,7 +108,7 @@ static void slip_unesc6(struct slip *sl, unsigned char c);#ifdef CONFIG_SLIP_SMART static void sl_keepalive (struct timer_list *t);static void sl_outfill (struct timer_list *t); -static int sl_ioctl (struct net_device *dev,struct ifreq *rq,int cmd); +static int sl_siocdevprivate (struct net_device *dev,struct ifreq *rq,void __user *data,int cmd);#endif /********************************
@@ -647,7 +647,7 @@ static const struct net_device_ops sl_netdev_ops = { .ndo_change_mtu = sl_change_mtu, .ndo_tx_timeout = sl_tx_timeout, #ifdef CONFIG_SLIP_SMART - .ndo_do_ioctl = sl_ioctl, + .ndo_siocdevprivate = sl_siocdevprivate,#endif };
@@ -1179,11 +1179,12 @@ static int slip_ioctl(struct tty_struct *tty, struct file *file,/* VSV changes start here */ #ifdef CONFIG_SLIP_SMART -/* function do_ioctl called from net/core/dev.c +/* function sl_siocdevprivate called from net/core/dev.c to allow get/set outfill/keepalive parameter by ifconfig */ -static int sl_ioctl (struct net_device *dev,struct ifreq *rq,int cmd) +static int sl_siocdevprivate (struct net_device *dev,struct ifreq *rq, +void __user *data,int cmd) {struct slip *sl =netdev_priv (dev);unsigned long *p = (unsigned long *)&rq->ifr_ifru;
@@ -1191,6 +1192,9 @@ static int sl_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)if (sl ==NULL )/* Allocation failed ?? */ return -ENODEV ; +if (in_compat_syscall ()) +return -EOPNOTSUPP ; +spin_lock_bh (&sl->lock);if (!sl->tty) {
Signature · 1 line
2.27.0
RFC 17/28 qeth: use ndo_siocdevprivate
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
qeth has both standard MII ioctls and custom SIOCDEVPRIVATE ones, all of which work correctly with compat user space.
Move the private ones over to the new ndo_siocdevprivate callback.
--- drivers/s390/net/qeth_core.h | 2 ++ drivers/s390/net/qeth_core_main.c | 35 ++++++++++++++++++++++--------- drivers/s390/net/qeth_l3_main.c | 6 +++--- 3 files changed, 30 insertions(+), 13 deletions(-)
drivers/s390/net/qeth_core.h +2 -0
@@ -1118,6 +1118,8 @@ int qeth_do_send_packet(struct qeth_card *card, struct qeth_qdio_out_q *queue, unsigned int offset, unsigned int hd_len, int elements_needed);int qeth_do_ioctl (struct net_device *dev,struct ifreq *rq,int cmd); +int qeth_siocdevprivate (struct net_device *dev,struct ifreq *rq, +void __user *data,int cmd);void qeth_dbf_longtext (debug_info_t *id,int level,char *text, ...);int qeth_configure_cq (struct qeth_card *,enum qeth_cq );int qeth_hw_trap (struct qeth_card *,enum qeth_diags_trap_action );
drivers/s390/net/qeth_core_main.c +25 -10
@@ -6474,21 +6474,42 @@ struct qeth_card *qeth_get_card_by_busid(char *bus_id) }EXPORT_SYMBOL_GPL (qeth_get_card_by_busid); -int qeth_do_ioctl (struct net_device *dev,struct ifreq *rq,int cmd) +int qeth_siocdevprivate (struct net_device *dev,struct ifreq *rq,void __user *data,int cmd) {struct qeth_card *card = dev->ml_priv; -struct mii_ioctl_data *mii_data;int rc =0 ;switch (cmd) {case SIOC_QETH_ADP_SET_SNMP_CONTROL : - rc =qeth_snmp_command (card, rq->ifr_ifru.ifru_data); + rc =qeth_snmp_command (card, data);break ;case SIOC_QETH_GET_CARD_TYPE :if ((IS_OSD (card) ||IS_OSM (card) ||IS_OSX (card)) && !IS_VM_NIC (card))return 1 ;return 0 ; +case SIOC_QETH_QUERY_OAT : + rc =qeth_query_oat_command (card, data); +break ; +default : +if (card->discipline->do_ioctl) + rc = card->discipline->do_ioctl (dev, data, cmd); +else + rc = -EOPNOTSUPP ; + } +if (rc) +QETH_CARD_TEXT_ (card,2 ,"ioce%x" , rc); +return rc; +} +EXPORT_SYMBOL_GPL (qeth_siocdevprivate); + +int qeth_do_ioctl (struct net_device *dev,struct ifreq *rq,int cmd) +{ +struct qeth_card *card = dev->ml_priv; +struct mii_ioctl_data *mii_data; +int rc =0 ; + +switch (cmd) {case SIOCGMIIPHY : mii_data =if_mii (rq); mii_data->phy_id =0 ;
@@ -6501,14 +6522,8 @@ int qeth_do_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) mii_data->val_out =qeth_mdio_read (dev, mii_data->phy_id, mii_data->reg_num);break ; -case SIOC_QETH_QUERY_OAT : - rc =qeth_query_oat_command (card, rq->ifr_ifru.ifru_data); -break ;default : -if (card->discipline->do_ioctl) - rc = card->discipline->do_ioctl (dev, rq, cmd); -else - rc = -EOPNOTSUPP ; +return -EOPNOTSUPP ; }if (rc)QETH_CARD_TEXT_ (card,2 ,"ioce%x" , rc);
drivers/s390/net/qeth_l3_main.c +3 -3
@@ -1532,7 +1532,7 @@ static int qeth_l3_arp_flush_cache(struct qeth_card *card)return rc; } -static int qeth_l3_do_ioctl (struct net_device *dev,struct ifreq *rq,int cmd) +static int qeth_l3_do_ioctl (struct net_device *dev,struct ifreq *rq,void __user *data,int cmd) {struct qeth_card *card = dev->ml_priv;struct qeth_arp_cache_entry arp_entry;
@@ -1552,13 +1552,13 @@ static int qeth_l3_do_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) rc = -EPERM ;break ; } - rc =qeth_l3_arp_query (card, rq->ifr_ifru.ifru_data); + rc =qeth_l3_arp_query (card, data);break ;case SIOC_QETH_ARP_ADD_ENTRY :case SIOC_QETH_ARP_REMOVE_ENTRY :if (!capable (CAP_NET_ADMIN ))return -EPERM ; -if (copy_from_user (&arp_entry, rq->ifr_data,sizeof (arp_entry))) +if (copy_from_user (&arp_entry, data,sizeof (arp_entry)))return -EFAULT ; arp_cmd = (cmd == SIOC_QETH_ARP_ADD_ENTRY) ?
Signature · 1 line
2.27.0
RFC 18/28 cxgb3: use ndo_siocdevprivate
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
cxgb3 has a private multiplexor that works correctly in compat mode, split out the siocdevprivate callback from do_ioctl for simplification.
--- drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)
drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c +8 -4
@@ -2135,13 +2135,18 @@ static int in_range(int val, int lo, int hi)return val <0 || (val <= hi && val >= lo); } -static int cxgb_extension_ioctl (struct net_device *dev,void __user *useraddr) +static int cxgb_siocdevprivate (struct net_device *dev, +struct ifreq *ifreq, +void __user *useraddr, +int cmd) {struct port_info *pi =netdev_priv (dev);struct adapter *adapter = pi->adapter; -u32 cmd;int ret; +if (cmd !=SIOCCHIOCTL ) +return -EOPNOTSUPP ; +if (copy_from_user (&cmd, useraddr,sizeof (cmd)))return -EFAULT ;
@@ -2546,8 +2551,6 @@ static int cxgb_ioctl(struct net_device *dev, struct ifreq *req, int cmd) fallthrough;case SIOCGMIIPHY :return mdio_mii_ioctl (&pi->phy.mdio, data, cmd); -case SIOCCHIOCTL : -return cxgb_extension_ioctl (dev, req->ifr_data);default :return -EOPNOTSUPP ; }
@@ -3181,6 +3184,7 @@ static const struct net_device_ops cxgb_netdev_ops = { .ndo_validate_addr = eth_validate_addr, .ndo_set_rx_mode = cxgb_set_rxmode, .ndo_do_ioctl = cxgb_ioctl, + .ndo_siocdevprivate = cxgb_siocdevprivate, .ndo_change_mtu = cxgb_change_mtu, .ndo_set_mac_address = cxgb_set_mac_addr, .ndo_fix_features = cxgb_fix_features,
Signature · 1 line
2.27.0
RFC 19/28 dev_ioctl: pass SIOCDEVPRIVATE data separately
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
The compat handlers for SIOCDEVPRIVATE are incorrect for any driver that passes data as part of struct ifreq rather than as an ifr_data pointer, or that passes data back this way, since the compat_ifr_data_ioctl() helper overwrites the ifr_data pointer and does not copy anything back out.
Since all drivers using devprivate commands are now converted to the new .ndo_siocdevprivate callback, fix this by adding the missing piece and passing the pointer separately the whole way.
This further unifies the native and compat logic for socket ioctls, as the new code now passes the correct pointer as well as the correct data for both native and compat ioctls.
--- include/linux/netdevice.h | 4 +-- net/core/dev_ioctl.c | 22 +++++++++------- net/ethtool/ioctl.c | 3 +-- net/socket.c | 55 +++++++++------------------------------ 4 files changed, 28 insertions(+), 56 deletions(-)
include/linux/netdevice.h +2 -2
@@ -3833,9 +3833,9 @@ bool dev_valid_name(const char *name);int get_user_ifreq (struct ifreq *ifr,void __user **ifrdata,void __user *arg);int put_user_ifreq (struct ifreq *ifr,void __user *arg);int dev_ioctl (struct net *net,unsigned int cmd,struct ifreq *ifr, -bool *need_copyout); +void __user *data,bool *need_copyout);int dev_ifconf (struct net *net,struct ifconf __user *ifc); -int dev_ethtool (struct net *net,struct ifreq *); +int dev_ethtool (struct net *net,struct ifreq *,void __user *userdata);unsigned int dev_get_flags (const struct net_device *);int __dev_change_flags (struct net_device *dev,unsigned int flags,struct netlink_ext_ack *extack);
net/core/dev_ioctl.c +12 -10
@@ -269,11 +269,10 @@ static int dev_do_ioctl(struct net_device *dev,return err; } -static int dev_siocdevprivate (struct net_device *dev, -struct ifreq *ifr,unsigned int cmd) +static int dev_siocdevprivate (struct net_device *dev,struct ifreq *ifr, +void __user *data,unsigned int cmd) {const struct net_device_ops *ops = dev->netdev_ops; -void __user *data = ifr->ifr_data;if (ops->ndo_siocdevprivate) {if (netif_device_present (dev))
@@ -283,13 +282,15 @@ static int dev_siocdevprivate(struct net_device *dev, }/* fall back to do_ioctl for drivers not yet converted */ + ifr->ifr_data = data;return dev_do_ioctl (dev, ifr, cmd); }/* * Perform the SIOCxIFxxx calls, inside rtnl_lock() */ -static int dev_ifsioc (struct net *net,struct ifreq *ifr,unsigned int cmd) +static int dev_ifsioc (struct net *net,struct ifreq *ifr,void __user *data, +unsigned int cmd) {int err;struct net_device *dev =__dev_get_by_name (net, ifr->ifr_name);
@@ -365,7 +366,7 @@ static int dev_ifsioc(struct net *net, struct ifreq *ifr, unsigned int cmd)default :if (cmd >=SIOCDEVPRIVATE && cmd <=SIOCDEVPRIVATE +15 ) -return dev_siocdevprivate (dev, ifr, cmd); +return dev_siocdevprivate (dev, ifr, data, cmd); if (cmd == SIOCBONDENSLAVE || cmd == SIOCBONDRELEASE ||
@@ -434,7 +435,8 @@ EXPORT_SYMBOL(dev_load);* positive or a negative errno code on error. */ -int dev_ioctl (struct net *net,unsigned int cmd,struct ifreq *ifr,bool *need_copyout) +int dev_ioctl (struct net *net,unsigned int cmd,struct ifreq *ifr, +void __user *data,bool *need_copyout) {int ret;char *colon;
@@ -480,7 +482,7 @@ int dev_ioctl(struct net *net, unsigned int cmd, struct ifreq *ifr, bool *need_ccase SIOCETHTOOL :dev_load (net, ifr->ifr_name);rtnl_lock (); - ret =dev_ethtool (net, ifr); + ret =dev_ethtool (net, ifr, data);rtnl_unlock ();if (colon) *colon =':' ;
@@ -499,7 +501,7 @@ int dev_ioctl(struct net *net, unsigned int cmd, struct ifreq *ifr, bool *need_cif (!ns_capable (net->user_ns,CAP_NET_ADMIN ))return -EPERM ;rtnl_lock (); - ret =dev_ifsioc (net, ifr, cmd); + ret =dev_ifsioc (net, ifr, data, cmd);rtnl_unlock ();if (colon) *colon =':' ;
@@ -545,7 +547,7 @@ int dev_ioctl(struct net *net, unsigned int cmd, struct ifreq *ifr, bool *need_ccase SIOCBONDINFOQUERY :dev_load (net, ifr->ifr_name);rtnl_lock (); - ret =dev_ifsioc (net, ifr, cmd); + ret =dev_ifsioc (net, ifr, data, cmd);rtnl_unlock ();if (need_copyout) *need_copyout = false;
@@ -570,7 +572,7 @@ int dev_ioctl(struct net *net, unsigned int cmd, struct ifreq *ifr, bool *need_c cmd <= SIOCDEVPRIVATE + 15)) {dev_load (net, ifr->ifr_name);rtnl_lock (); - ret =dev_ifsioc (net, ifr, cmd); + ret =dev_ifsioc (net, ifr, data, cmd);rtnl_unlock ();return ret; }
net/ethtool/ioctl.c +1 -2
@@ -2671,10 +2671,9 @@ static int ethtool_set_fecparam(struct net_device *dev, void __user *useraddr)/* The main entry point in this file. Called from net/core/dev_ioctl.c */ -int dev_ethtool (struct net *net,struct ifreq *ifr) +int dev_ethtool (struct net *net,struct ifreq *ifr,void __user *useraddr) {struct net_device *dev =__dev_get_by_name (net, ifr->ifr_name); -void __user *useraddr = ifr->ifr_data;u32 ethcmd, sub_cmd;int rc;netdev_features_t old_features;
net/socket.c +13 -42
99 lines not on this page · raw message
Signature · 1 line
2.27.0
RFC 20/28 dev_ioctl: split out ndo_eth_ioctl
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
Most users of ndo_do_ioctl are ethernet drivers that implement the MII commands SIOCGMIIPHY/SIOCGMIIREG/SIOCSMIIREG, or hardware timestamping with SIOCSHWTSTAMP/SIOCGHWTSTAMP.
Separate these from the few drivers that use ndo_do_ioctl to implement SIOCBOND, SIOCBR and SIOCWANDEV commands.
This is a purely cosmetic change intended to help readers find their way through the implementation.
--- Documentation/networking/netdevices.rst | 4 ++ Documentation/networking/timestamping.rst | 6 +-- drivers/infiniband/ulp/ipoib/ipoib_main.c | 8 ++-- drivers/net/bonding/bond_main.c | 43 +++++++++++++------ drivers/net/ethernet/3com/3c574_cs.c | 2 +- drivers/net/ethernet/3com/3c59x.c | 4 +- drivers/net/ethernet/8390/ax88796.c | 2 +- drivers/net/ethernet/8390/axnet_cs.c | 2 +- drivers/net/ethernet/8390/pcnet_cs.c | 2 +- drivers/net/ethernet/adaptec/starfire.c | 2 +- drivers/net/ethernet/agere/et131x.c | 2 +- drivers/net/ethernet/allwinner/sun4i-emac.c | 2 +- drivers/net/ethernet/amd/amd8111e.c | 2 +- drivers/net/ethernet/amd/au1000_eth.c | 2 +- drivers/net/ethernet/amd/pcnet32.c | 2 +- drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 +- .../net/ethernet/aquantia/atlantic/aq_main.c | 2 +- drivers/net/ethernet/arc/emac_main.c | 2 +- drivers/net/ethernet/atheros/ag71xx.c | 2 +- drivers/net/ethernet/atheros/alx/main.c | 2 +- .../net/ethernet/atheros/atl1c/atl1c_main.c | 2 +- .../net/ethernet/atheros/atl1e/atl1e_main.c | 2 +- drivers/net/ethernet/atheros/atlx/atl1.c | 2 +- drivers/net/ethernet/atheros/atlx/atl2.c | 2 +- drivers/net/ethernet/aurora/nb8800.c | 2 +- drivers/net/ethernet/broadcom/b44.c | 2 +- drivers/net/ethernet/broadcom/bcm63xx_enet.c | 4 +- drivers/net/ethernet/broadcom/bgmac.c | 2 +- drivers/net/ethernet/broadcom/bnx2.c | 2 +- .../net/ethernet/broadcom/bnx2x/bnx2x_main.c | 2 +- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +- .../net/ethernet/broadcom/genet/bcmgenet.c | 2 +- drivers/net/ethernet/broadcom/sb1250-mac.c | 2 +- drivers/net/ethernet/broadcom/tg3.c | 2 +- drivers/net/ethernet/cadence/macb_main.c | 4 +- .../net/ethernet/cavium/liquidio/lio_main.c | 2 +- .../ethernet/cavium/liquidio/lio_vf_main.c | 2 +- .../net/ethernet/cavium/octeon/octeon_mgmt.c | 2 +- .../net/ethernet/cavium/thunder/nicvf_main.c | 2 +- drivers/net/ethernet/chelsio/cxgb/cxgb2.c | 2 +- .../net/ethernet/chelsio/cxgb3/cxgb3_main.c | 2 +- .../net/ethernet/chelsio/cxgb4/cxgb4_main.c | 2 +- .../ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 2 +- drivers/net/ethernet/cirrus/ep93xx_eth.c | 2 +- drivers/net/ethernet/davicom/dm9000.c | 2 +- drivers/net/ethernet/dec/tulip/tulip_core.c | 2 +- drivers/net/ethernet/dec/tulip/winbond-840.c | 2 +- drivers/net/ethernet/dlink/dl2k.c | 2 +- drivers/net/ethernet/dlink/sundance.c | 2 +- drivers/net/ethernet/dnet.c | 2 +- drivers/net/ethernet/ethoc.c | 2 +- drivers/net/ethernet/faraday/ftgmac100.c | 2 +- drivers/net/ethernet/faraday/ftmac100.c | 2 +- drivers/net/ethernet/fealnx.c | 2 +- .../net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +- .../net/ethernet/freescale/dpaa2/dpaa2-eth.c | 2 +- .../net/ethernet/freescale/enetc/enetc_pf.c | 2 +- .../net/ethernet/freescale/enetc/enetc_vf.c | 2 +- drivers/net/ethernet/freescale/fec_main.c | 2 +- drivers/net/ethernet/freescale/fec_mpc52xx.c | 2 +- .../ethernet/freescale/fs_enet/fs_enet-main.c | 2 +- drivers/net/ethernet/freescale/gianfar.c | 2 +- drivers/net/ethernet/freescale/ucc_geth.c | 2 +- drivers/net/ethernet/hisilicon/hisi_femac.c | 2 +- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 2 +- .../net/ethernet/hisilicon/hns3/hns3_enet.c | 2 +- drivers/net/ethernet/ibm/emac/core.c | 4 +- drivers/net/ethernet/ibm/ibmveth.c | 2 +- drivers/net/ethernet/intel/e100.c | 2 +- drivers/net/ethernet/intel/e1000/e1000_main.c | 2 +- drivers/net/ethernet/intel/e1000e/netdev.c | 2 +- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- drivers/net/ethernet/intel/igb/igb_main.c | 2 +- drivers/net/ethernet/intel/igbvf/netdev.c | 2 +- drivers/net/ethernet/intel/igc/igc_main.c | 2 +- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +- drivers/net/ethernet/jme.c | 2 +- drivers/net/ethernet/korina.c | 2 +- drivers/net/ethernet/lantiq_etop.c | 2 +- drivers/net/ethernet/marvell/mv643xx_eth.c | 2 +- drivers/net/ethernet/marvell/mvneta.c | 2 +- .../net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +- .../ethernet/marvell/octeontx2/nic/otx2_pf.c | 2 +- drivers/net/ethernet/marvell/pxa168_eth.c | 2 +- drivers/net/ethernet/marvell/skge.c | 2 +- drivers/net/ethernet/marvell/sky2.c | 4 +- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +- drivers/net/ethernet/mediatek/mtk_star_emac.c | 2 +- .../net/ethernet/mellanox/mlx4/en_netdev.c | 2 +- .../net/ethernet/mellanox/mlx5/core/en_main.c | 2 +- .../ethernet/mellanox/mlx5/core/ipoib/ipoib.c | 2 +- .../mellanox/mlx5/core/ipoib/ipoib_vlan.c | 2 +- .../net/ethernet/mellanox/mlxsw/spectrum.c | 2 +- drivers/net/ethernet/micrel/ks8851_common.c | 2 +- drivers/net/ethernet/micrel/ksz884x.c | 2 +- drivers/net/ethernet/microchip/lan743x_main.c | 2 +- drivers/net/ethernet/mscc/ocelot_net.c | 2 +- drivers/net/ethernet/natsemi/natsemi.c | 2 +- drivers/net/ethernet/neterion/s2io.c | 2 +- .../net/ethernet/neterion/vxge/vxge-main.c | 2 +- drivers/net/ethernet/nxp/lpc_eth.c | 2 +- .../ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 2 +- drivers/net/ethernet/packetengines/hamachi.c | 2 +- .../net/ethernet/packetengines/yellowfin.c | 2 +- drivers/net/ethernet/qlogic/qede/qede_main.c | 2 +- drivers/net/ethernet/qualcomm/emac/emac.c | 2 +- drivers/net/ethernet/rdc/r6040.c | 2 +- drivers/net/ethernet/realtek/8139cp.c | 2 +- drivers/net/ethernet/realtek/8139too.c | 2 +- drivers/net/ethernet/realtek/r8169_main.c | 2 +- drivers/net/ethernet/renesas/ravb_main.c | 2 +- drivers/net/ethernet/renesas/sh_eth.c | 4 +- .../net/ethernet/samsung/sxgbe/sxgbe_main.c | 2 +- drivers/net/ethernet/sfc/efx.c | 2 +- drivers/net/ethernet/sfc/falcon/efx.c | 2 +- drivers/net/ethernet/sgi/ioc3-eth.c | 2 +- drivers/net/ethernet/sgi/meth.c | 2 +- drivers/net/ethernet/sis/sis190.c | 2 +- drivers/net/ethernet/sis/sis900.c | 2 +- drivers/net/ethernet/smsc/epic100.c | 2 +- drivers/net/ethernet/smsc/smc91c92_cs.c | 2 +- drivers/net/ethernet/smsc/smsc911x.c | 2 +- drivers/net/ethernet/smsc/smsc9420.c | 2 +- drivers/net/ethernet/socionext/netsec.c | 2 +- drivers/net/ethernet/socionext/sni_ave.c | 2 +- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- drivers/net/ethernet/sun/cassini.c | 2 +- drivers/net/ethernet/sun/niu.c | 2 +- drivers/net/ethernet/sun/sungem.c | 2 +- .../net/ethernet/synopsys/dwc-xlgmac-net.c | 2 +- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 2 +- drivers/net/ethernet/ti/cpmac.c | 2 +- drivers/net/ethernet/ti/cpsw.c | 2 +- drivers/net/ethernet/ti/cpsw_new.c | 2 +- drivers/net/ethernet/ti/davinci_emac.c | 2 +- drivers/net/ethernet/ti/netcp_core.c | 2 +- drivers/net/ethernet/ti/tlan.c | 2 +- drivers/net/ethernet/toshiba/spider_net.c | 2 +- drivers/net/ethernet/toshiba/tc35815.c | 2 +- drivers/net/ethernet/tundra/tsi108_eth.c | 2 +- drivers/net/ethernet/via/via-rhine.c | 2 +- drivers/net/ethernet/via/via-velocity.c | 2 +- drivers/net/ethernet/xilinx/ll_temac_main.c | 2 +- .../net/ethernet/xilinx/xilinx_axienet_main.c | 2 +- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 2 +- drivers/net/ethernet/xircom/xirc2ps_cs.c | 2 +- drivers/net/ethernet/xscale/ixp4xx_eth.c | 2 +- drivers/net/macvlan.c | 8 ++-- drivers/net/phy/phy.c | 4 +- drivers/net/usb/asix_devices.c | 6 +-- drivers/net/usb/ax88172a.c | 2 +- drivers/net/usb/ax88179_178a.c | 2 +- drivers/net/usb/dm9601.c | 2 +- drivers/net/usb/lan78xx.c | 2 +- drivers/net/usb/mcs7830.c | 2 +- drivers/net/usb/r8152.c | 2 +- drivers/net/usb/smsc75xx.c | 2 +- drivers/net/usb/smsc95xx.c | 2 +- drivers/net/usb/sr9700.c | 2 +- drivers/net/usb/sr9800.c | 2 +- drivers/s390/net/qeth_l2_main.c | 2 +- drivers/s390/net/qeth_l3_main.c | 4 +- drivers/staging/octeon/ethernet.c | 12 +++--- include/linux/netdevice.h | 6 +++ include/net/dsa.h | 14 +++--- net/8021q/vlan_dev.c | 6 +-- net/core/dev_ioctl.c | 38 +++++++++++----- net/dsa/master.c | 6 +-- net/dsa/slave.c | 2 +- 169 files changed, 265 insertions(+), 222 deletions(-)
Documentation/networking/netdevices.rst +4 -0
@@ -63,6 +63,10 @@ ndo_do_ioctl: Synchronization: rtnl_lock() semaphore. Context: process +ndo_eth_ioctl: + Synchronization: rtnl_lock() semaphore. + Context: process + ndo_get_stats: Synchronization: dev_base_lock rwlock. Context: nominally process, but don't sleep inside an rwlock
Documentation/networking/timestamping.rst +3 -3
@@ -624,7 +624,7 @@ interfaces of a DSA switch to share the same PHC. By design, PTP timestamping with a DSA switch does not need any special handling in the driver for the host port it is attached to. However, when the host port also supports PTP timestamping, DSA will take care of intercepting -the ``.ndo_do_ioctl`` calls towards the host port, and block attempts to enable +the ``.ndo_eth_ioctl`` calls towards the host port, and block attempts to enable hardware timestamping on it. This is because the SO_TIMESTAMPING API does not allow the delivery of multiple hardware timestamps for the same packet, so anybody else except for the DSA switch port must be prevented from doing so.
@@ -672,7 +672,7 @@ ethtool ioctl operations for them need to be mediated by their respective MAC driver. Therefore, as opposed to DSA switches, modifications need to be done to each individual MAC driver for PHY timestamping support. This entails: -- Checking, in ``.ndo_do_ioctl``, whether ``phy_has_hwtstamp(netdev->phydev)`` +- Checking, in ``.ndo_eth_ioctl``, whether ``phy_has_hwtstamp(netdev->phydev)`` is true or not. If it is, then the MAC driver should not process this request but instead pass it on to the PHY using ``phy_mii_ioctl()``.
@@ -731,7 +731,7 @@ For example, a typical driver design for TX timestamping might be to split the transmission part into 2 portions: 1. "TX": checks whether PTP timestamping has been previously enabled through - the ``.ndo_do_ioctl`` ("``priv->hwtstamp_tx_enabled == true``") and the + the ``.ndo_eth_ioctl`` ("``priv->hwtstamp_tx_enabled == true``") and the current skb requires a TX timestamp ("``skb_shinfo(skb)->tx_flags & SKBTX_HW_TSTAMP``"). If this is true, it sets the "``skb_shinfo(skb)->tx_flags |= SKBTX_IN_PROGRESS``" flag. Note: as
drivers/infiniband/ulp/ipoib/ipoib_main.c +4 -4
@@ -1736,10 +1736,10 @@ static int ipoib_ioctl(struct net_device *dev, struct ifreq *ifr, {struct ipoib_dev_priv *priv =ipoib_priv (dev); -if (!priv->rn_ops->ndo_do_ioctl) +if (!priv->rn_ops->ndo_eth_ioctl)return -EOPNOTSUPP ; -return priv->rn_ops->ndo_do_ioctl (dev, ifr, cmd); +return priv->rn_ops->ndo_eth_ioctl (dev, ifr, cmd); }static int ipoib_dev_init (struct net_device *dev)
@@ -2069,7 +2069,7 @@ static const struct net_device_ops ipoib_netdev_ops_pf = { .ndo_set_vf_guid = ipoib_set_vf_guid, .ndo_set_mac_address = ipoib_set_mac, .ndo_get_stats64 = ipoib_get_stats, - .ndo_do_ioctl = ipoib_ioctl, + .ndo_eth_ioctl = ipoib_ioctl, };static const struct net_device_ops ipoib_netdev_ops_vf = {
@@ -2084,7 +2084,7 @@ static const struct net_device_ops ipoib_netdev_ops_vf = { .ndo_set_rx_mode = ipoib_set_mcast_list, .ndo_get_iflink = ipoib_get_iflink, .ndo_get_stats64 = ipoib_get_stats, - .ndo_do_ioctl = ipoib_ioctl, + .ndo_eth_ioctl = ipoib_ioctl, };static const struct net_device_ops ipoib_netdev_default_pf = {
drivers/net/bonding/bond_main.c +30 -13
83 lines not on this page · raw message
drivers/net/ethernet/3com/3c574_cs.c +1 -1
@@ -252,7 +252,7 @@ static const struct net_device_ops el3_netdev_ops = { .ndo_start_xmit = el3_start_xmit, .ndo_tx_timeout = el3_tx_timeout, .ndo_get_stats = el3_get_stats, - .ndo_do_ioctl = el3_ioctl, + .ndo_eth_ioctl = el3_ioctl, .ndo_set_rx_mode = set_multicast_list, .ndo_set_mac_address = eth_mac_addr, .ndo_validate_addr = eth_validate_addr,
drivers/net/ethernet/3com/3c59x.c +2 -2
@@ -1052,7 +1052,7 @@ static const struct net_device_ops boomrang_netdev_ops = { .ndo_tx_timeout = vortex_tx_timeout, .ndo_get_stats = vortex_get_stats, #ifdef CONFIG_PCI - .ndo_do_ioctl = vortex_ioctl, + .ndo_eth_ioctl = vortex_ioctl, #endif .ndo_set_rx_mode = set_rx_mode, .ndo_set_mac_address = eth_mac_addr,
@@ -1069,7 +1069,7 @@ static const struct net_device_ops vortex_netdev_ops = { .ndo_tx_timeout = vortex_tx_timeout, .ndo_get_stats = vortex_get_stats, #ifdef CONFIG_PCI - .ndo_do_ioctl = vortex_ioctl, + .ndo_eth_ioctl = vortex_ioctl, #endif .ndo_set_rx_mode = set_rx_mode, .ndo_set_mac_address = eth_mac_addr,
drivers/net/ethernet/8390/ax88796.c +1 -1
@@ -635,7 +635,7 @@ static void ax_eeprom_register_write(struct eeprom_93cx6 *eeprom)static const struct net_device_ops ax_netdev_ops = { .ndo_open = ax_open, .ndo_stop = ax_close, - .ndo_do_ioctl = ax_ioctl, + .ndo_eth_ioctl = ax_ioctl, .ndo_start_xmit = ax_ei_start_xmit, .ndo_tx_timeout = ax_ei_tx_timeout,
drivers/net/ethernet/8390/axnet_cs.c +1 -1
@@ -128,7 +128,7 @@ static inline struct axnet_dev *PRIV(struct net_device *dev)static const struct net_device_ops axnet_netdev_ops = { .ndo_open = axnet_open, .ndo_stop = axnet_close, - .ndo_do_ioctl = axnet_ioctl, + .ndo_eth_ioctl = axnet_ioctl, .ndo_start_xmit = axnet_start_xmit, .ndo_tx_timeout = axnet_tx_timeout, .ndo_get_stats = get_stats,
drivers/net/ethernet/8390/pcnet_cs.c +1 -1
@@ -223,7 +223,7 @@ static const struct net_device_ops pcnet_netdev_ops = { .ndo_set_config = set_config, .ndo_start_xmit = ei_start_xmit, .ndo_get_stats = ei_get_stats, - .ndo_do_ioctl = ei_ioctl, + .ndo_eth_ioctl = ei_ioctl, .ndo_set_rx_mode = ei_set_multicast_list, .ndo_tx_timeout = ei_tx_timeout, .ndo_set_mac_address = eth_mac_addr,
drivers/net/ethernet/adaptec/starfire.c +1 -1
@@ -625,7 +625,7 @@ static const struct net_device_ops netdev_ops = { .ndo_tx_timeout = tx_timeout, .ndo_get_stats = get_stats, .ndo_set_rx_mode = set_rx_mode, - .ndo_do_ioctl = netdev_ioctl, + .ndo_eth_ioctl = netdev_ioctl, .ndo_set_mac_address = eth_mac_addr, .ndo_validate_addr = eth_validate_addr,#ifdef VLAN_SUPPORT
drivers/net/ethernet/agere/et131x.c +1 -1
@@ -3882,7 +3882,7 @@ static const struct net_device_ops et131x_netdev_ops = { .ndo_set_mac_address = eth_mac_addr, .ndo_validate_addr = eth_validate_addr, .ndo_get_stats = et131x_stats, - .ndo_do_ioctl = phy_do_ioctl, + .ndo_eth_ioctl = phy_do_ioctl, }; static int et131x_pci_setup(struct pci_dev *pdev,
drivers/net/ethernet/allwinner/sun4i-emac.c +1 -1
@@ -774,7 +774,7 @@ static const struct net_device_ops emac_netdev_ops = { .ndo_start_xmit = emac_start_xmit, .ndo_tx_timeout = emac_timeout, .ndo_set_rx_mode = emac_set_rx_mode, - .ndo_do_ioctl = phy_do_ioctl_running, + .ndo_eth_ioctl = phy_do_ioctl_running, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = emac_set_mac_address,#ifdef CONFIG_NET_POLL_CONTROLLER
drivers/net/ethernet/amd/amd8111e.c +1 -1
@@ -1737,7 +1737,7 @@ static const struct net_device_ops amd8111e_netdev_ops = { .ndo_set_rx_mode = amd8111e_set_multicast_list, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = amd8111e_set_mac_address, - .ndo_do_ioctl = amd8111e_ioctl, + .ndo_eth_ioctl = amd8111e_ioctl, .ndo_change_mtu = amd8111e_change_mtu, #ifdef CONFIG_NET_POLL_CONTROLLER .ndo_poll_controller = amd8111e_poll,
drivers/net/ethernet/amd/au1000_eth.c +1 -1
@@ -1051,7 +1051,7 @@ static const struct net_device_ops au1000_netdev_ops = { .ndo_stop = au1000_close, .ndo_start_xmit = au1000_tx, .ndo_set_rx_mode = au1000_multicast_list, - .ndo_do_ioctl = phy_do_ioctl_running, + .ndo_eth_ioctl = phy_do_ioctl_running, .ndo_tx_timeout = au1000_tx_timeout, .ndo_set_mac_address = eth_mac_addr, .ndo_validate_addr = eth_validate_addr,
drivers/net/ethernet/amd/pcnet32.c +1 -1
@@ -1571,7 +1571,7 @@ static const struct net_device_ops pcnet32_netdev_ops = { .ndo_tx_timeout = pcnet32_tx_timeout, .ndo_get_stats = pcnet32_get_stats, .ndo_set_rx_mode = pcnet32_set_multicast_list, - .ndo_do_ioctl = pcnet32_ioctl, + .ndo_eth_ioctl = pcnet32_ioctl, .ndo_set_mac_address = eth_mac_addr, .ndo_validate_addr = eth_validate_addr,#ifdef CONFIG_NET_POLL_CONTROLLER
drivers/net/ethernet/amd/xgbe/xgbe-drv.c +1 -1
@@ -2283,7 +2283,7 @@ static const struct net_device_ops xgbe_netdev_ops = { .ndo_set_rx_mode = xgbe_set_rx_mode, .ndo_set_mac_address = xgbe_set_mac_address, .ndo_validate_addr = eth_validate_addr, - .ndo_do_ioctl = xgbe_ioctl, + .ndo_eth_ioctl = xgbe_ioctl, .ndo_change_mtu = xgbe_change_mtu, .ndo_tx_timeout = xgbe_tx_timeout, .ndo_get_stats64 = xgbe_get_stats64,
drivers/net/ethernet/aquantia/atlantic/aq_main.c +1 -1
@@ -419,7 +419,7 @@ static const struct net_device_ops aq_ndev_ops = { .ndo_change_mtu = aq_ndev_change_mtu, .ndo_set_mac_address = aq_ndev_set_mac_address, .ndo_set_features = aq_ndev_set_features, - .ndo_do_ioctl = aq_ndev_ioctl, + .ndo_eth_ioctl = aq_ndev_ioctl, .ndo_vlan_rx_add_vid = aq_ndo_vlan_rx_add_vid, .ndo_vlan_rx_kill_vid = aq_ndo_vlan_rx_kill_vid, .ndo_setup_tc = aq_ndo_setup_tc,
drivers/net/ethernet/arc/emac_main.c +1 -1
@@ -844,7 +844,7 @@ static const struct net_device_ops arc_emac_netdev_ops = { .ndo_set_mac_address = arc_emac_set_address, .ndo_get_stats = arc_emac_stats, .ndo_set_rx_mode = arc_emac_set_rx_mode, - .ndo_do_ioctl = phy_do_ioctl_running, + .ndo_eth_ioctl = phy_do_ioctl_running,#ifdef CONFIG_NET_POLL_CONTROLLER .ndo_poll_controller = arc_emac_poll_controller,#endif
drivers/net/ethernet/atheros/ag71xx.c +1 -1
@@ -1841,7 +1841,7 @@ static const struct net_device_ops ag71xx_netdev_ops = { .ndo_open = ag71xx_open, .ndo_stop = ag71xx_stop, .ndo_start_xmit = ag71xx_hard_start_xmit, - .ndo_do_ioctl = phy_do_ioctl, + .ndo_eth_ioctl = phy_do_ioctl, .ndo_tx_timeout = ag71xx_tx_timeout, .ndo_change_mtu = ag71xx_change_mtu, .ndo_set_mac_address = eth_mac_addr,
drivers/net/ethernet/atheros/alx/main.c +1 -1
@@ -1680,7 +1680,7 @@ static const struct net_device_ops alx_netdev_ops = { .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = alx_set_mac_address, .ndo_change_mtu = alx_change_mtu, - .ndo_do_ioctl = alx_ioctl, + .ndo_eth_ioctl = alx_ioctl, .ndo_tx_timeout = alx_tx_timeout, .ndo_fix_features = alx_fix_features,#ifdef CONFIG_NET_POLL_CONTROLLER
drivers/net/ethernet/atheros/atl1c/atl1c_main.c +1 -1
@@ -2478,7 +2478,7 @@ static const struct net_device_ops atl1c_netdev_ops = { .ndo_change_mtu = atl1c_change_mtu, .ndo_fix_features = atl1c_fix_features, .ndo_set_features = atl1c_set_features, - .ndo_do_ioctl = atl1c_ioctl, + .ndo_eth_ioctl = atl1c_ioctl, .ndo_tx_timeout = atl1c_tx_timeout, .ndo_get_stats = atl1c_get_stats,#ifdef CONFIG_NET_POLL_CONTROLLER
drivers/net/ethernet/atheros/atl1e/atl1e_main.c +1 -1
@@ -2247,7 +2247,7 @@ static const struct net_device_ops atl1e_netdev_ops = { .ndo_fix_features = atl1e_fix_features, .ndo_set_features = atl1e_set_features, .ndo_change_mtu = atl1e_change_mtu, - .ndo_do_ioctl = atl1e_ioctl, + .ndo_eth_ioctl = atl1e_ioctl, .ndo_tx_timeout = atl1e_tx_timeout, #ifdef CONFIG_NET_POLL_CONTROLLER .ndo_poll_controller = atl1e_netpoll,
drivers/net/ethernet/atheros/atlx/atl1.c +1 -1
@@ -2885,7 +2885,7 @@ static const struct net_device_ops atl1_netdev_ops = { .ndo_change_mtu = atl1_change_mtu, .ndo_fix_features = atlx_fix_features, .ndo_set_features = atlx_set_features, - .ndo_do_ioctl = atlx_ioctl, + .ndo_eth_ioctl = atlx_ioctl, .ndo_tx_timeout = atlx_tx_timeout, #ifdef CONFIG_NET_POLL_CONTROLLER .ndo_poll_controller = atl1_poll_controller,
drivers/net/ethernet/atheros/atlx/atl2.c +1 -1
@@ -1293,7 +1293,7 @@ static const struct net_device_ops atl2_netdev_ops = { .ndo_change_mtu = atl2_change_mtu, .ndo_fix_features = atl2_fix_features, .ndo_set_features = atl2_set_features, - .ndo_do_ioctl = atl2_ioctl, + .ndo_eth_ioctl = atl2_ioctl, .ndo_tx_timeout = atl2_tx_timeout, #ifdef CONFIG_NET_POLL_CONTROLLER .ndo_poll_controller = atl2_poll_controller,
drivers/net/ethernet/aurora/nb8800.c +1 -1
@@ -1011,7 +1011,7 @@ static const struct net_device_ops nb8800_netdev_ops = { .ndo_start_xmit = nb8800_xmit, .ndo_set_mac_address = nb8800_set_mac_address, .ndo_set_rx_mode = nb8800_set_rx_mode, - .ndo_do_ioctl = phy_do_ioctl, + .ndo_eth_ioctl = phy_do_ioctl, .ndo_validate_addr = eth_validate_addr, };
drivers/net/ethernet/broadcom/b44.c +1 -1
@@ -2198,7 +2198,7 @@ static const struct net_device_ops b44_netdev_ops = { .ndo_set_rx_mode = b44_set_rx_mode, .ndo_set_mac_address = b44_set_mac_addr, .ndo_validate_addr = eth_validate_addr, - .ndo_do_ioctl = b44_ioctl, + .ndo_eth_ioctl = b44_ioctl, .ndo_tx_timeout = b44_tx_timeout, .ndo_change_mtu = b44_change_mtu,#ifdef CONFIG_NET_POLL_CONTROLLER
drivers/net/ethernet/broadcom/bcm63xx_enet.c +2 -2
@@ -1677,7 +1677,7 @@ static const struct net_device_ops bcm_enet_ops = { .ndo_start_xmit = bcm_enet_start_xmit, .ndo_set_mac_address = bcm_enet_set_mac_address, .ndo_set_rx_mode = bcm_enet_set_multicast_list, - .ndo_do_ioctl = bcm_enet_ioctl, + .ndo_eth_ioctl = bcm_enet_ioctl, .ndo_change_mtu = bcm_enet_change_mtu, };
@@ -2443,7 +2443,7 @@ static const struct net_device_ops bcm_enetsw_ops = { .ndo_stop = bcm_enetsw_stop, .ndo_start_xmit = bcm_enet_start_xmit, .ndo_change_mtu = bcm_enet_change_mtu, - .ndo_do_ioctl = bcm_enetsw_ioctl, + .ndo_eth_ioctl = bcm_enetsw_ioctl, };
drivers/net/ethernet/broadcom/bgmac.c +1 -1
@@ -1263,7 +1263,7 @@ static const struct net_device_ops bgmac_netdev_ops = { .ndo_set_rx_mode = bgmac_set_rx_mode, .ndo_set_mac_address = bgmac_set_mac_address, .ndo_validate_addr = eth_validate_addr, - .ndo_do_ioctl = phy_do_ioctl_running, + .ndo_eth_ioctl = phy_do_ioctl_running, .ndo_change_mtu = bgmac_change_mtu, };
drivers/net/ethernet/broadcom/bnx2.c +1 -1
@@ -8546,7 +8546,7 @@ static const struct net_device_ops bnx2_netdev_ops = { .ndo_stop = bnx2_close, .ndo_get_stats64 = bnx2_get_stats64, .ndo_set_rx_mode = bnx2_set_rx_mode, - .ndo_do_ioctl = bnx2_ioctl, + .ndo_eth_ioctl = bnx2_ioctl, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = bnx2_change_mac_addr, .ndo_change_mtu = bnx2_change_mtu,
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c +1 -1
@@ -13050,7 +13050,7 @@ static const struct net_device_ops bnx2x_netdev_ops = { .ndo_set_rx_mode = bnx2x_set_rx_mode, .ndo_set_mac_address = bnx2x_change_mac_addr, .ndo_validate_addr = bnx2x_validate_addr, - .ndo_do_ioctl = bnx2x_ioctl, + .ndo_eth_ioctl = bnx2x_ioctl, .ndo_change_mtu = bnx2x_change_mtu, .ndo_fix_features = bnx2x_fix_features, .ndo_set_features = bnx2x_set_features,
drivers/net/ethernet/broadcom/bnxt/bnxt.c +1 -1
@@ -12071,7 +12071,7 @@ static const struct net_device_ops bnxt_netdev_ops = { .ndo_stop = bnxt_close, .ndo_get_stats64 = bnxt_get_stats64, .ndo_set_rx_mode = bnxt_set_rx_mode, - .ndo_do_ioctl = bnxt_ioctl, + .ndo_eth_ioctl = bnxt_ioctl, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = bnxt_change_mac_addr, .ndo_change_mtu = bnxt_change_mtu,
drivers/net/ethernet/broadcom/genet/bcmgenet.c +1 -1
@@ -3659,7 +3659,7 @@ static const struct net_device_ops bcmgenet_netdev_ops = { .ndo_tx_timeout = bcmgenet_timeout, .ndo_set_rx_mode = bcmgenet_set_rx_mode, .ndo_set_mac_address = bcmgenet_set_mac_addr, - .ndo_do_ioctl = phy_do_ioctl_running, + .ndo_eth_ioctl = phy_do_ioctl_running, .ndo_set_features = bcmgenet_set_features, #ifdef CONFIG_NET_POLL_CONTROLLER .ndo_poll_controller = bcmgenet_poll_controller,
drivers/net/ethernet/broadcom/sb1250-mac.c +1 -1
@@ -2136,7 +2136,7 @@ static const struct net_device_ops sbmac_netdev_ops = { .ndo_start_xmit = sbmac_start_tx, .ndo_set_rx_mode = sbmac_set_rx_mode, .ndo_tx_timeout = sbmac_tx_timeout, - .ndo_do_ioctl = sbmac_mii_ioctl, + .ndo_eth_ioctl = sbmac_mii_ioctl, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = eth_mac_addr,#ifdef CONFIG_NET_POLL_CONTROLLER
drivers/net/ethernet/broadcom/tg3.c +1 -1
@@ -14304,7 +14304,7 @@ static const struct net_device_ops tg3_netdev_ops = { .ndo_validate_addr = eth_validate_addr, .ndo_set_rx_mode = tg3_set_rx_mode, .ndo_set_mac_address = tg3_set_mac_addr, - .ndo_do_ioctl = tg3_ioctl, + .ndo_eth_ioctl = tg3_ioctl, .ndo_tx_timeout = tg3_tx_timeout, .ndo_change_mtu = tg3_change_mtu, .ndo_fix_features = tg3_fix_features,
drivers/net/ethernet/cadence/macb_main.c +2 -2
@@ -3495,7 +3495,7 @@ static const struct net_device_ops macb_netdev_ops = { .ndo_start_xmit = macb_start_xmit, .ndo_set_rx_mode = macb_set_rx_mode, .ndo_get_stats = macb_get_stats, - .ndo_do_ioctl = macb_ioctl, + .ndo_eth_ioctl = macb_ioctl, .ndo_validate_addr = eth_validate_addr, .ndo_change_mtu = macb_change_mtu, .ndo_set_mac_address = eth_mac_addr,
@@ -4166,7 +4166,7 @@ static const struct net_device_ops at91ether_netdev_ops = { .ndo_get_stats = macb_get_stats, .ndo_set_rx_mode = macb_set_rx_mode, .ndo_set_mac_address = eth_mac_addr, - .ndo_do_ioctl = macb_ioctl, + .ndo_eth_ioctl = macb_ioctl, .ndo_validate_addr = eth_validate_addr, #ifdef CONFIG_NET_POLL_CONTROLLER .ndo_poll_controller = at91ether_poll_controller,
drivers/net/ethernet/cavium/liquidio/lio_main.c +1 -1
@@ -3216,7 +3216,7 @@ static const struct net_device_ops lionetdevops = { .ndo_vlan_rx_add_vid = liquidio_vlan_rx_add_vid, .ndo_vlan_rx_kill_vid = liquidio_vlan_rx_kill_vid, .ndo_change_mtu = liquidio_change_mtu, - .ndo_do_ioctl = liquidio_ioctl, + .ndo_eth_ioctl = liquidio_ioctl, .ndo_fix_features = liquidio_fix_features, .ndo_set_features = liquidio_set_features, .ndo_udp_tunnel_add = udp_tunnel_nic_add_port,
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c +1 -1
@@ -1876,7 +1876,7 @@ static const struct net_device_ops lionetdevops = { .ndo_vlan_rx_add_vid = liquidio_vlan_rx_add_vid, .ndo_vlan_rx_kill_vid = liquidio_vlan_rx_kill_vid, .ndo_change_mtu = liquidio_change_mtu, - .ndo_do_ioctl = liquidio_ioctl, + .ndo_eth_ioctl = liquidio_ioctl, .ndo_fix_features = liquidio_fix_features, .ndo_set_features = liquidio_set_features, .ndo_udp_tunnel_add = udp_tunnel_nic_add_port,
drivers/net/ethernet/cavium/octeon/octeon_mgmt.c +1 -1
@@ -1373,7 +1373,7 @@ static const struct net_device_ops octeon_mgmt_ops = { .ndo_start_xmit = octeon_mgmt_xmit, .ndo_set_rx_mode = octeon_mgmt_set_rx_filtering, .ndo_set_mac_address = octeon_mgmt_set_mac_address, - .ndo_do_ioctl = octeon_mgmt_ioctl, + .ndo_eth_ioctl = octeon_mgmt_ioctl, .ndo_change_mtu = octeon_mgmt_change_mtu, #ifdef CONFIG_NET_POLL_CONTROLLER .ndo_poll_controller = octeon_mgmt_poll_controller,
drivers/net/ethernet/cavium/thunder/nicvf_main.c +1 -1
@@ -2098,7 +2098,7 @@ static const struct net_device_ops nicvf_netdev_ops = { .ndo_fix_features = nicvf_fix_features, .ndo_set_features = nicvf_set_features, .ndo_bpf = nicvf_xdp, - .ndo_do_ioctl = nicvf_ioctl, + .ndo_eth_ioctl = nicvf_ioctl, .ndo_set_rx_mode = nicvf_set_rx_mode, };
drivers/net/ethernet/chelsio/cxgb/cxgb2.c +1 -1
@@ -968,7 +968,7 @@ static const struct net_device_ops cxgb_netdev_ops = { .ndo_get_stats = t1_get_stats, .ndo_validate_addr = eth_validate_addr, .ndo_set_rx_mode = t1_set_rxmode, - .ndo_do_ioctl = t1_ioctl, + .ndo_eth_ioctl = t1_ioctl, .ndo_change_mtu = t1_change_mtu, .ndo_set_mac_address = t1_set_mac_addr, .ndo_fix_features = t1_fix_features,
drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c +1 -1
@@ -3183,7 +3183,7 @@ static const struct net_device_ops cxgb_netdev_ops = { .ndo_get_stats = cxgb_get_stats, .ndo_validate_addr = eth_validate_addr, .ndo_set_rx_mode = cxgb_set_rxmode, - .ndo_do_ioctl = cxgb_ioctl, + .ndo_eth_ioctl = cxgb_ioctl, .ndo_siocdevprivate = cxgb_siocdevprivate, .ndo_change_mtu = cxgb_change_mtu, .ndo_set_mac_address = cxgb_set_mac_addr,
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c +1 -1
@@ -3870,7 +3870,7 @@ static const struct net_device_ops cxgb4_netdev_ops = { .ndo_set_mac_address = cxgb_set_mac_addr, .ndo_set_features = cxgb_set_features, .ndo_validate_addr = eth_validate_addr, - .ndo_do_ioctl = cxgb_ioctl, + .ndo_eth_ioctl = cxgb_ioctl, .ndo_change_mtu = cxgb_change_mtu, #ifdef CONFIG_NET_POLL_CONTROLLER .ndo_poll_controller = cxgb_netpoll,
drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c +1 -1
@@ -2837,7 +2837,7 @@ static const struct net_device_ops cxgb4vf_netdev_ops = { .ndo_set_rx_mode = cxgb4vf_set_rxmode, .ndo_set_mac_address = cxgb4vf_set_mac_addr, .ndo_validate_addr = eth_validate_addr, - .ndo_do_ioctl = cxgb4vf_do_ioctl, + .ndo_eth_ioctl = cxgb4vf_do_ioctl, .ndo_change_mtu = cxgb4vf_change_mtu, .ndo_fix_features = cxgb4vf_fix_features, .ndo_set_features = cxgb4vf_set_features,
drivers/net/ethernet/cirrus/ep93xx_eth.c +1 -1
@@ -733,7 +733,7 @@ static const struct net_device_ops ep93xx_netdev_ops = { .ndo_open = ep93xx_open, .ndo_stop = ep93xx_close, .ndo_start_xmit = ep93xx_xmit, - .ndo_do_ioctl = ep93xx_ioctl, + .ndo_eth_ioctl = ep93xx_ioctl, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = eth_mac_addr, };
drivers/net/ethernet/davicom/dm9000.c +1 -1
@@ -1373,7 +1373,7 @@ static const struct net_device_ops dm9000_netdev_ops = { .ndo_start_xmit = dm9000_start_xmit, .ndo_tx_timeout = dm9000_timeout, .ndo_set_rx_mode = dm9000_hash_table, - .ndo_do_ioctl = dm9000_ioctl, + .ndo_eth_ioctl = dm9000_ioctl, .ndo_set_features = dm9000_set_features, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = eth_mac_addr,
drivers/net/ethernet/dec/tulip/tulip_core.c +1 -1
@@ -1271,7 +1271,7 @@ static const struct net_device_ops tulip_netdev_ops = { .ndo_tx_timeout = tulip_tx_timeout, .ndo_stop = tulip_close, .ndo_get_stats = tulip_get_stats, - .ndo_do_ioctl = private_ioctl, + .ndo_eth_ioctl = private_ioctl, .ndo_set_rx_mode = set_rx_mode, .ndo_set_mac_address = eth_mac_addr, .ndo_validate_addr = eth_validate_addr,
drivers/net/ethernet/dec/tulip/winbond-840.c +1 -1
@@ -341,7 +341,7 @@ static const struct net_device_ops netdev_ops = { .ndo_start_xmit = start_tx, .ndo_get_stats = get_stats, .ndo_set_rx_mode = set_rx_mode, - .ndo_do_ioctl = netdev_ioctl, + .ndo_eth_ioctl = netdev_ioctl, .ndo_tx_timeout = tx_timeout, .ndo_set_mac_address = eth_mac_addr, .ndo_validate_addr = eth_validate_addr,
drivers/net/ethernet/dlink/dl2k.c +1 -1
@@ -95,7 +95,7 @@ static const struct net_device_ops netdev_ops = { .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = eth_mac_addr, .ndo_set_rx_mode = set_multicast, - .ndo_do_ioctl = rio_ioctl, + .ndo_eth_ioctl = rio_ioctl, .ndo_tx_timeout = rio_tx_timeout, };
drivers/net/ethernet/dlink/sundance.c +1 -1
@@ -479,7 +479,7 @@ static const struct net_device_ops netdev_ops = { .ndo_start_xmit = start_tx, .ndo_get_stats = get_stats, .ndo_set_rx_mode = set_rx_mode, - .ndo_do_ioctl = netdev_ioctl, + .ndo_eth_ioctl = netdev_ioctl, .ndo_tx_timeout = tx_timeout, .ndo_change_mtu = change_mtu, .ndo_set_mac_address = sundance_set_mac_addr,
drivers/net/ethernet/dnet.c +1 -1
@@ -742,7 +742,7 @@ static const struct net_device_ops dnet_netdev_ops = { .ndo_stop = dnet_close, .ndo_get_stats = dnet_get_stats, .ndo_start_xmit = dnet_start_xmit, - .ndo_do_ioctl = phy_do_ioctl_running, + .ndo_eth_ioctl = phy_do_ioctl_running, .ndo_set_mac_address = eth_mac_addr, .ndo_validate_addr = eth_validate_addr, };
drivers/net/ethernet/ethoc.c +1 -1
@@ -1009,7 +1009,7 @@ static const struct ethtool_ops ethoc_ethtool_ops = {static const struct net_device_ops ethoc_netdev_ops = { .ndo_open = ethoc_open, .ndo_stop = ethoc_stop, - .ndo_do_ioctl = ethoc_ioctl, + .ndo_eth_ioctl = ethoc_ioctl, .ndo_set_mac_address = ethoc_set_mac_address, .ndo_set_rx_mode = ethoc_set_multicast_list, .ndo_change_mtu = ethoc_change_mtu,
drivers/net/ethernet/faraday/ftgmac100.c +1 -1
@@ -1586,7 +1586,7 @@ static const struct net_device_ops ftgmac100_netdev_ops = { .ndo_start_xmit = ftgmac100_hard_start_xmit, .ndo_set_mac_address = ftgmac100_set_mac_addr, .ndo_validate_addr = eth_validate_addr, - .ndo_do_ioctl = phy_do_ioctl, + .ndo_eth_ioctl = phy_do_ioctl, .ndo_tx_timeout = ftgmac100_tx_timeout, .ndo_set_rx_mode = ftgmac100_set_rx_mode, .ndo_set_features = ftgmac100_set_features,
drivers/net/ethernet/faraday/ftmac100.c +1 -1
@@ -1043,7 +1043,7 @@ static const struct net_device_ops ftmac100_netdev_ops = { .ndo_start_xmit = ftmac100_hard_start_xmit, .ndo_set_mac_address = eth_mac_addr, .ndo_validate_addr = eth_validate_addr, - .ndo_do_ioctl = ftmac100_do_ioctl, + .ndo_eth_ioctl = ftmac100_do_ioctl, };/******************************************************************************
drivers/net/ethernet/fealnx.c +1 -1
@@ -463,7 +463,7 @@ static const struct net_device_ops netdev_ops = { .ndo_start_xmit = start_tx, .ndo_get_stats = get_stats, .ndo_set_rx_mode = set_rx_mode, - .ndo_do_ioctl = mii_ioctl, + .ndo_eth_ioctl = mii_ioctl, .ndo_tx_timeout = fealnx_tx_timeout, .ndo_set_mac_address = eth_mac_addr, .ndo_validate_addr = eth_validate_addr,
drivers/net/ethernet/freescale/dpaa/dpaa_eth.c +1 -1
@@ -2724,7 +2724,7 @@ static const struct net_device_ops dpaa_ops = { .ndo_set_mac_address = dpaa_set_mac_address, .ndo_validate_addr = eth_validate_addr, .ndo_set_rx_mode = dpaa_set_rx_mode, - .ndo_do_ioctl = dpaa_ioctl, + .ndo_eth_ioctl = dpaa_ioctl, .ndo_setup_tc = dpaa_setup_tc, };
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c +1 -1
@@ -2502,7 +2502,7 @@ static const struct net_device_ops dpaa2_eth_ops = { .ndo_get_stats64 = dpaa2_eth_get_stats, .ndo_set_rx_mode = dpaa2_eth_set_rx_mode, .ndo_set_features = dpaa2_eth_set_features, - .ndo_do_ioctl = dpaa2_eth_ioctl, + .ndo_eth_ioctl = dpaa2_eth_ioctl, .ndo_change_mtu = dpaa2_eth_change_mtu, .ndo_bpf = dpaa2_eth_xdp, .ndo_xdp_xmit = dpaa2_eth_xdp_xmit,
drivers/net/ethernet/freescale/enetc/enetc_pf.c +1 -1
@@ -693,7 +693,7 @@ static const struct net_device_ops enetc_ndev_ops = { .ndo_set_vf_vlan = enetc_pf_set_vf_vlan, .ndo_set_vf_spoofchk = enetc_pf_set_vf_spoofchk, .ndo_set_features = enetc_pf_set_features, - .ndo_do_ioctl = enetc_ioctl, + .ndo_eth_ioctl = enetc_ioctl, .ndo_setup_tc = enetc_setup_tc, };
drivers/net/ethernet/freescale/enetc/enetc_vf.c +1 -1
@@ -99,7 +99,7 @@ static const struct net_device_ops enetc_ndev_ops = { .ndo_get_stats = enetc_get_stats, .ndo_set_mac_address = enetc_vf_set_mac_addr, .ndo_set_features = enetc_vf_set_features, - .ndo_do_ioctl = enetc_ioctl, + .ndo_eth_ioctl = enetc_ioctl, .ndo_setup_tc = enetc_setup_tc, };
drivers/net/ethernet/freescale/fec_main.c +1 -1
@@ -3228,7 +3228,7 @@ static const struct net_device_ops fec_netdev_ops = { .ndo_validate_addr = eth_validate_addr, .ndo_tx_timeout = fec_timeout, .ndo_set_mac_address = fec_set_mac_address, - .ndo_do_ioctl = fec_enet_ioctl, + .ndo_eth_ioctl = fec_enet_ioctl,#ifdef CONFIG_NET_POLL_CONTROLLER .ndo_poll_controller = fec_poll_controller,#endif
drivers/net/ethernet/freescale/fec_mpc52xx.c +1 -1
@@ -792,7 +792,7 @@ static const struct net_device_ops mpc52xx_fec_netdev_ops = { .ndo_set_rx_mode = mpc52xx_fec_set_multicast_list, .ndo_set_mac_address = mpc52xx_fec_set_mac_address, .ndo_validate_addr = eth_validate_addr, - .ndo_do_ioctl = phy_do_ioctl, + .ndo_eth_ioctl = phy_do_ioctl, .ndo_tx_timeout = mpc52xx_fec_tx_timeout, .ndo_get_stats = mpc52xx_fec_get_stats, #ifdef CONFIG_NET_POLL_CONTROLLER
drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c +1 -1
@@ -900,7 +900,7 @@ static const struct net_device_ops fs_enet_netdev_ops = { .ndo_start_xmit = fs_enet_start_xmit, .ndo_tx_timeout = fs_timeout, .ndo_set_rx_mode = fs_set_multicast_list, - .ndo_do_ioctl = phy_do_ioctl_running, + .ndo_eth_ioctl = phy_do_ioctl_running, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = eth_mac_addr,#ifdef CONFIG_NET_POLL_CONTROLLER
drivers/net/ethernet/freescale/gianfar.c +1 -1
@@ -3291,7 +3291,7 @@ static const struct net_device_ops gfar_netdev_ops = { .ndo_set_features = gfar_set_features, .ndo_set_rx_mode = gfar_set_multi, .ndo_tx_timeout = gfar_timeout, - .ndo_do_ioctl = gfar_ioctl, + .ndo_eth_ioctl = gfar_ioctl, .ndo_get_stats = gfar_get_stats, .ndo_change_carrier = fixed_phy_change_carrier, .ndo_set_mac_address = gfar_set_mac_addr,
drivers/net/ethernet/freescale/ucc_geth.c +1 -1
@@ -3679,7 +3679,7 @@ static const struct net_device_ops ucc_geth_netdev_ops = { .ndo_set_mac_address = ucc_geth_set_mac_addr, .ndo_set_rx_mode = ucc_geth_set_multi, .ndo_tx_timeout = ucc_geth_timeout, - .ndo_do_ioctl = ucc_geth_ioctl, + .ndo_eth_ioctl = ucc_geth_ioctl,#ifdef CONFIG_NET_POLL_CONTROLLER .ndo_poll_controller = ucc_netpoll,#endif
drivers/net/ethernet/hisilicon/hisi_femac.c +1 -1
@@ -685,7 +685,7 @@ static const struct net_device_ops hisi_femac_netdev_ops = { .ndo_open = hisi_femac_net_open, .ndo_stop = hisi_femac_net_close, .ndo_start_xmit = hisi_femac_net_xmit, - .ndo_do_ioctl = phy_do_ioctl_running, + .ndo_eth_ioctl = phy_do_ioctl_running, .ndo_set_mac_address = hisi_femac_set_mac_address, .ndo_set_rx_mode = hisi_femac_net_set_rx_mode, };
drivers/net/ethernet/hisilicon/hns/hns_enet.c +1 -1
@@ -1943,7 +1943,7 @@ static const struct net_device_ops hns_nic_netdev_ops = { .ndo_tx_timeout = hns_nic_net_timeout, .ndo_set_mac_address = hns_nic_net_set_mac_address, .ndo_change_mtu = hns_nic_change_mtu, - .ndo_do_ioctl = phy_do_ioctl_running, + .ndo_eth_ioctl = phy_do_ioctl_running, .ndo_set_features = hns_nic_set_features, .ndo_fix_features = hns_nic_fix_features, .ndo_get_stats64 = hns_nic_get_stats64,
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c +1 -1
@@ -2029,7 +2029,7 @@ static const struct net_device_ops hns3_nic_netdev_ops = { .ndo_start_xmit = hns3_nic_net_xmit, .ndo_tx_timeout = hns3_nic_net_timeout, .ndo_set_mac_address = hns3_nic_net_set_mac_address, - .ndo_do_ioctl = hns3_nic_do_ioctl, + .ndo_eth_ioctl = hns3_nic_do_ioctl, .ndo_change_mtu = hns3_nic_change_mtu, .ndo_set_features = hns3_nic_set_features, .ndo_features_check = hns3_features_check,
drivers/net/ethernet/ibm/emac/core.c +2 -2
@@ -3010,7 +3010,7 @@ static const struct net_device_ops emac_netdev_ops = { .ndo_stop = emac_close, .ndo_get_stats = emac_stats, .ndo_set_rx_mode = emac_set_multicast_list, - .ndo_do_ioctl = emac_ioctl, + .ndo_eth_ioctl = emac_ioctl, .ndo_tx_timeout = emac_tx_timeout, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = emac_set_mac_address,
@@ -3022,7 +3022,7 @@ static const struct net_device_ops emac_gige_netdev_ops = { .ndo_stop = emac_close, .ndo_get_stats = emac_stats, .ndo_set_rx_mode = emac_set_multicast_list, - .ndo_do_ioctl = emac_ioctl, + .ndo_eth_ioctl = emac_ioctl, .ndo_tx_timeout = emac_tx_timeout, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = emac_set_mac_address,
drivers/net/ethernet/ibm/ibmveth.c +1 -1
@@ -1631,7 +1631,7 @@ static const struct net_device_ops ibmveth_netdev_ops = { .ndo_stop = ibmveth_close, .ndo_start_xmit = ibmveth_start_xmit, .ndo_set_rx_mode = ibmveth_set_multicast_list, - .ndo_do_ioctl = ibmveth_ioctl, + .ndo_eth_ioctl = ibmveth_ioctl, .ndo_change_mtu = ibmveth_change_mtu, .ndo_fix_features = ibmveth_fix_features, .ndo_set_features = ibmveth_set_features,
drivers/net/ethernet/intel/e100.c +1 -1
@@ -2803,7 +2803,7 @@ static const struct net_device_ops e100_netdev_ops = { .ndo_validate_addr = eth_validate_addr, .ndo_set_rx_mode = e100_set_multicast_list, .ndo_set_mac_address = e100_set_mac_address, - .ndo_do_ioctl = e100_do_ioctl, + .ndo_eth_ioctl = e100_do_ioctl, .ndo_tx_timeout = e100_tx_timeout, #ifdef CONFIG_NET_POLL_CONTROLLER .ndo_poll_controller = e100_netpoll,
drivers/net/ethernet/intel/e1000/e1000_main.c +1 -1
@@ -832,7 +832,7 @@ static const struct net_device_ops e1000_netdev_ops = { .ndo_set_mac_address = e1000_set_mac, .ndo_tx_timeout = e1000_tx_timeout, .ndo_change_mtu = e1000_change_mtu, - .ndo_do_ioctl = e1000_ioctl, + .ndo_eth_ioctl = e1000_ioctl, .ndo_validate_addr = eth_validate_addr, .ndo_vlan_rx_add_vid = e1000_vlan_rx_add_vid, .ndo_vlan_rx_kill_vid = e1000_vlan_rx_kill_vid,
drivers/net/ethernet/intel/e1000e/netdev.c +1 -1
@@ -7331,7 +7331,7 @@ static const struct net_device_ops e1000e_netdev_ops = { .ndo_set_rx_mode = e1000e_set_rx_mode, .ndo_set_mac_address = e1000_set_mac, .ndo_change_mtu = e1000_change_mtu, - .ndo_do_ioctl = e1000_ioctl, + .ndo_eth_ioctl = e1000_ioctl, .ndo_tx_timeout = e1000_tx_timeout, .ndo_validate_addr = eth_validate_addr,
drivers/net/ethernet/intel/i40e/i40e_main.c +1 -1
@@ -12769,7 +12769,7 @@ static const struct net_device_ops i40e_netdev_ops = { .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = i40e_set_mac, .ndo_change_mtu = i40e_change_mtu, - .ndo_do_ioctl = i40e_ioctl, + .ndo_eth_ioctl = i40e_ioctl, .ndo_tx_timeout = i40e_tx_timeout, .ndo_vlan_rx_add_vid = i40e_vlan_rx_add_vid, .ndo_vlan_rx_kill_vid = i40e_vlan_rx_kill_vid,
drivers/net/ethernet/intel/igb/igb_main.c +1 -1
@@ -2973,7 +2973,7 @@ static const struct net_device_ops igb_netdev_ops = { .ndo_set_rx_mode = igb_set_rx_mode, .ndo_set_mac_address = igb_set_mac, .ndo_change_mtu = igb_change_mtu, - .ndo_do_ioctl = igb_ioctl, + .ndo_eth_ioctl = igb_ioctl, .ndo_tx_timeout = igb_tx_timeout, .ndo_validate_addr = eth_validate_addr, .ndo_vlan_rx_add_vid = igb_vlan_rx_add_vid,
drivers/net/ethernet/intel/igbvf/netdev.c +1 -1
@@ -2669,7 +2669,7 @@ static const struct net_device_ops igbvf_netdev_ops = { .ndo_set_rx_mode = igbvf_set_rx_mode, .ndo_set_mac_address = igbvf_set_mac, .ndo_change_mtu = igbvf_change_mtu, - .ndo_do_ioctl = igbvf_ioctl, + .ndo_eth_ioctl = igbvf_ioctl, .ndo_tx_timeout = igbvf_tx_timeout, .ndo_vlan_rx_add_vid = igbvf_vlan_rx_add_vid, .ndo_vlan_rx_kill_vid = igbvf_vlan_rx_kill_vid,
drivers/net/ethernet/intel/igc/igc_main.c +1 -1
@@ -4859,7 +4859,7 @@ static const struct net_device_ops igc_netdev_ops = { .ndo_fix_features = igc_fix_features, .ndo_set_features = igc_set_features, .ndo_features_check = igc_features_check, - .ndo_do_ioctl = igc_ioctl, + .ndo_eth_ioctl = igc_ioctl, .ndo_setup_tc = igc_setup_tc, };
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +1 -1
@@ -10241,7 +10241,7 @@ static const struct net_device_ops ixgbe_netdev_ops = { .ndo_set_tx_maxrate = ixgbe_tx_maxrate, .ndo_vlan_rx_add_vid = ixgbe_vlan_rx_add_vid, .ndo_vlan_rx_kill_vid = ixgbe_vlan_rx_kill_vid, - .ndo_do_ioctl = ixgbe_ioctl, + .ndo_eth_ioctl = ixgbe_ioctl, .ndo_set_vf_mac = ixgbe_ndo_set_vf_mac, .ndo_set_vf_vlan = ixgbe_ndo_set_vf_vlan, .ndo_set_vf_rate = ixgbe_ndo_set_vf_bw,
drivers/net/ethernet/jme.c +1 -1
@@ -2902,7 +2902,7 @@ static const struct net_device_ops jme_netdev_ops = { .ndo_open = jme_open, .ndo_stop = jme_close, .ndo_validate_addr = eth_validate_addr, - .ndo_do_ioctl = jme_ioctl, + .ndo_eth_ioctl = jme_ioctl, .ndo_start_xmit = jme_start_xmit, .ndo_set_mac_address = jme_set_macaddr, .ndo_set_rx_mode = jme_set_multi,
drivers/net/ethernet/korina.c +1 -1
@@ -1012,7 +1012,7 @@ static const struct net_device_ops korina_netdev_ops = { .ndo_start_xmit = korina_send_packet, .ndo_set_rx_mode = korina_multicast_list, .ndo_tx_timeout = korina_tx_timeout, - .ndo_do_ioctl = korina_ioctl, + .ndo_eth_ioctl = korina_ioctl, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = eth_mac_addr,#ifdef CONFIG_NET_POLL_CONTROLLER
drivers/net/ethernet/lantiq_etop.c +1 -1
@@ -609,7 +609,7 @@ static const struct net_device_ops ltq_eth_netdev_ops = { .ndo_stop = ltq_etop_stop, .ndo_start_xmit = ltq_etop_tx, .ndo_change_mtu = ltq_etop_change_mtu, - .ndo_do_ioctl = phy_do_ioctl, + .ndo_eth_ioctl = phy_do_ioctl, .ndo_set_mac_address = ltq_etop_set_mac_address, .ndo_validate_addr = eth_validate_addr, .ndo_set_rx_mode = ltq_etop_set_multicast_list,
drivers/net/ethernet/marvell/mv643xx_eth.c +1 -1
@@ -3061,7 +3061,7 @@ static const struct net_device_ops mv643xx_eth_netdev_ops = { .ndo_set_rx_mode = mv643xx_eth_set_rx_mode, .ndo_set_mac_address = mv643xx_eth_set_mac_address, .ndo_validate_addr = eth_validate_addr, - .ndo_do_ioctl = mv643xx_eth_ioctl, + .ndo_eth_ioctl = mv643xx_eth_ioctl, .ndo_change_mtu = mv643xx_eth_change_mtu, .ndo_set_features = mv643xx_eth_set_features, .ndo_tx_timeout = mv643xx_eth_tx_timeout,
drivers/net/ethernet/marvell/mvneta.c +1 -1
@@ -4904,7 +4904,7 @@ static const struct net_device_ops mvneta_netdev_ops = { .ndo_change_mtu = mvneta_change_mtu, .ndo_fix_features = mvneta_fix_features, .ndo_get_stats64 = mvneta_get_stats64, - .ndo_do_ioctl = mvneta_ioctl, + .ndo_eth_ioctl = mvneta_ioctl, .ndo_bpf = mvneta_xdp, .ndo_xdp_xmit = mvneta_xdp_xmit, };
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c +1 -1
@@ -5299,7 +5299,7 @@ static const struct net_device_ops mvpp2_netdev_ops = { .ndo_set_mac_address = mvpp2_set_mac_address, .ndo_change_mtu = mvpp2_change_mtu, .ndo_get_stats64 = mvpp2_get_stats64, - .ndo_do_ioctl = mvpp2_ioctl, + .ndo_eth_ioctl = mvpp2_ioctl, .ndo_vlan_rx_add_vid = mvpp2_vlan_rx_add_vid, .ndo_vlan_rx_kill_vid = mvpp2_vlan_rx_kill_vid, .ndo_set_features = mvpp2_set_features,
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c +1 -1
@@ -1913,7 +1913,7 @@ static const struct net_device_ops otx2_netdev_ops = { .ndo_set_features = otx2_set_features, .ndo_tx_timeout = otx2_tx_timeout, .ndo_get_stats64 = otx2_get_stats64, - .ndo_do_ioctl = otx2_ioctl, + .ndo_eth_ioctl = otx2_ioctl, };static int otx2_wq_init (struct otx2_nic *pf)
drivers/net/ethernet/marvell/pxa168_eth.c +1 -1
@@ -1377,7 +1377,7 @@ static const struct net_device_ops pxa168_eth_netdev_ops = { .ndo_set_rx_mode = pxa168_eth_set_rx_mode, .ndo_set_mac_address = pxa168_eth_set_mac_address, .ndo_validate_addr = eth_validate_addr, - .ndo_do_ioctl = phy_do_ioctl, + .ndo_eth_ioctl = phy_do_ioctl, .ndo_change_mtu = pxa168_eth_change_mtu, .ndo_tx_timeout = pxa168_eth_tx_timeout,#ifdef CONFIG_NET_POLL_CONTROLLER
drivers/net/ethernet/marvell/skge.c +1 -1
@@ -3786,7 +3786,7 @@ static const struct net_device_ops skge_netdev_ops = { .ndo_open = skge_up, .ndo_stop = skge_down, .ndo_start_xmit = skge_xmit_frame, - .ndo_do_ioctl = skge_ioctl, + .ndo_eth_ioctl = skge_ioctl, .ndo_get_stats = skge_get_stats, .ndo_tx_timeout = skge_tx_timeout, .ndo_change_mtu = skge_change_mtu,
drivers/net/ethernet/marvell/sky2.c +2 -2
@@ -4690,7 +4690,7 @@ static const struct net_device_ops sky2_netdev_ops[2] = { .ndo_open = sky2_open, .ndo_stop = sky2_close, .ndo_start_xmit = sky2_xmit_frame, - .ndo_do_ioctl = sky2_ioctl, + .ndo_eth_ioctl = sky2_ioctl, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = sky2_set_mac_address, .ndo_set_rx_mode = sky2_set_multicast,
@@ -4707,7 +4707,7 @@ static const struct net_device_ops sky2_netdev_ops[2] = { .ndo_open = sky2_open, .ndo_stop = sky2_close, .ndo_start_xmit = sky2_xmit_frame, - .ndo_do_ioctl = sky2_ioctl, + .ndo_eth_ioctl = sky2_ioctl, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = sky2_set_mac_address, .ndo_set_rx_mode = sky2_set_multicast,
drivers/net/ethernet/mediatek/mtk_eth_soc.c +1 -1
@@ -2794,7 +2794,7 @@ static const struct net_device_ops mtk_netdev_ops = { .ndo_start_xmit = mtk_start_xmit, .ndo_set_mac_address = mtk_set_mac_address, .ndo_validate_addr = eth_validate_addr, - .ndo_do_ioctl = mtk_do_ioctl, + .ndo_eth_ioctl = mtk_do_ioctl, .ndo_tx_timeout = mtk_tx_timeout, .ndo_get_stats64 = mtk_get_stats64, .ndo_fix_features = mtk_fix_features,
drivers/net/ethernet/mediatek/mtk_star_emac.c +1 -1
@@ -1161,7 +1161,7 @@ static const struct net_device_ops mtk_star_netdev_ops = { .ndo_start_xmit = mtk_star_netdev_start_xmit, .ndo_get_stats64 = mtk_star_netdev_get_stats64, .ndo_set_rx_mode = mtk_star_set_rx_mode, - .ndo_do_ioctl = mtk_star_netdev_ioctl, + .ndo_eth_ioctl = mtk_star_netdev_ioctl, .ndo_set_mac_address = eth_mac_addr, .ndo_validate_addr = eth_validate_addr, };
drivers/net/ethernet/mellanox/mlx4/en_netdev.c +1 -1
@@ -2822,7 +2822,7 @@ static const struct net_device_ops mlx4_netdev_ops = { .ndo_set_mac_address = mlx4_en_set_mac, .ndo_validate_addr = eth_validate_addr, .ndo_change_mtu = mlx4_en_change_mtu, - .ndo_do_ioctl = mlx4_en_ioctl, + .ndo_eth_ioctl = mlx4_en_ioctl, .ndo_tx_timeout = mlx4_en_tx_timeout, .ndo_vlan_rx_add_vid = mlx4_en_vlan_rx_add_vid, .ndo_vlan_rx_kill_vid = mlx4_en_vlan_rx_kill_vid,
drivers/net/ethernet/mellanox/mlx5/core/en_main.c +1 -1
@@ -4568,7 +4568,7 @@ const struct net_device_ops mlx5e_netdev_ops = { .ndo_set_features = mlx5e_set_features, .ndo_fix_features = mlx5e_fix_features, .ndo_change_mtu = mlx5e_change_nic_mtu, - .ndo_do_ioctl = mlx5e_ioctl, + .ndo_eth_ioctl = mlx5e_ioctl, .ndo_set_tx_maxrate = mlx5e_set_tx_maxrate, .ndo_udp_tunnel_add = udp_tunnel_nic_add_port, .ndo_udp_tunnel_del = udp_tunnel_nic_del_port,
drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c +1 -1
@@ -49,7 +49,7 @@ static const struct net_device_ops mlx5i_netdev_ops = { .ndo_init = mlx5i_dev_init, .ndo_uninit = mlx5i_dev_cleanup, .ndo_change_mtu = mlx5i_change_mtu, - .ndo_do_ioctl = mlx5i_ioctl, + .ndo_eth_ioctl = mlx5i_ioctl, };/* IPoIB mlx5 netdev profile */
drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib_vlan.c +1 -1
@@ -149,7 +149,7 @@ static const struct net_device_ops mlx5i_pkey_netdev_ops = { .ndo_get_stats64 = mlx5i_get_stats, .ndo_uninit = mlx5i_pkey_dev_cleanup, .ndo_change_mtu = mlx5i_pkey_change_mtu, - .ndo_do_ioctl = mlx5i_pkey_ioctl, + .ndo_eth_ioctl = mlx5i_pkey_ioctl, };/* Child NDOs */
drivers/net/ethernet/mellanox/mlxsw/spectrum.c +1 -1
@@ -1164,7 +1164,7 @@ static const struct net_device_ops mlxsw_sp_port_netdev_ops = { .ndo_vlan_rx_kill_vid = mlxsw_sp_port_kill_vid, .ndo_set_features = mlxsw_sp_set_features, .ndo_get_devlink_port = mlxsw_sp_port_get_devlink_port, - .ndo_do_ioctl = mlxsw_sp_port_ioctl, + .ndo_eth_ioctl = mlxsw_sp_port_ioctl, }; static int
drivers/net/ethernet/micrel/ks8851_common.c +1 -1
@@ -691,7 +691,7 @@ static int ks8851_net_ioctl(struct net_device *dev, struct ifreq *req, int cmd)static const struct net_device_ops ks8851_netdev_ops = { .ndo_open = ks8851_net_open, .ndo_stop = ks8851_net_stop, - .ndo_do_ioctl = ks8851_net_ioctl, + .ndo_eth_ioctl = ks8851_net_ioctl, .ndo_start_xmit = ks8851_start_xmit, .ndo_set_mac_address = ks8851_set_mac_address, .ndo_set_rx_mode = ks8851_set_rx_mode,
drivers/net/ethernet/micrel/ksz884x.c +1 -1
@@ -6813,7 +6813,7 @@ static const struct net_device_ops netdev_ops = { .ndo_set_features = netdev_set_features, .ndo_set_mac_address = netdev_set_mac_address, .ndo_validate_addr = eth_validate_addr, - .ndo_do_ioctl = netdev_ioctl, + .ndo_eth_ioctl = netdev_ioctl, .ndo_set_rx_mode = netdev_set_rx_mode, #ifdef CONFIG_NET_POLL_CONTROLLER .ndo_poll_controller = netdev_netpoll,
drivers/net/ethernet/microchip/lan743x_main.c +1 -1
@@ -2698,7 +2698,7 @@ static const struct net_device_ops lan743x_netdev_ops = { .ndo_open = lan743x_netdev_open, .ndo_stop = lan743x_netdev_close, .ndo_start_xmit = lan743x_netdev_xmit_frame, - .ndo_do_ioctl = lan743x_netdev_ioctl, + .ndo_eth_ioctl = lan743x_netdev_ioctl, .ndo_set_rx_mode = lan743x_netdev_set_multicast, .ndo_change_mtu = lan743x_netdev_change_mtu, .ndo_get_stats64 = lan743x_netdev_get_stats64,
drivers/net/ethernet/mscc/ocelot_net.c +1 -1
@@ -653,7 +653,7 @@ static const struct net_device_ops ocelot_port_netdev_ops = { .ndo_set_features = ocelot_set_features, .ndo_get_port_parent_id = ocelot_get_port_parent_id, .ndo_setup_tc = ocelot_setup_tc, - .ndo_do_ioctl = ocelot_ioctl, + .ndo_eth_ioctl = ocelot_ioctl, };struct net_device *ocelot_port_to_netdev (struct ocelot *ocelot,int port)
drivers/net/ethernet/natsemi/natsemi.c +1 -1
@@ -790,7 +790,7 @@ static const struct net_device_ops natsemi_netdev_ops = { .ndo_get_stats = get_stats, .ndo_set_rx_mode = set_rx_mode, .ndo_change_mtu = natsemi_change_mtu, - .ndo_do_ioctl = netdev_ioctl, + .ndo_eth_ioctl = netdev_ioctl, .ndo_tx_timeout = ns_tx_timeout, .ndo_set_mac_address = eth_mac_addr, .ndo_validate_addr = eth_validate_addr,
drivers/net/ethernet/neterion/s2io.c +1 -1
@@ -7614,7 +7614,7 @@ static const struct net_device_ops s2io_netdev_ops = { .ndo_start_xmit = s2io_xmit, .ndo_validate_addr = eth_validate_addr, .ndo_set_rx_mode = s2io_set_multicast, - .ndo_do_ioctl = s2io_ioctl, + .ndo_eth_ioctl = s2io_ioctl, .ndo_set_mac_address = s2io_set_mac_addr, .ndo_change_mtu = s2io_change_mtu, .ndo_set_features = s2io_set_features,
drivers/net/ethernet/neterion/vxge/vxge-main.c +1 -1
@@ -3354,7 +3354,7 @@ static const struct net_device_ops vxge_netdev_ops = { .ndo_start_xmit = vxge_xmit, .ndo_validate_addr = eth_validate_addr, .ndo_set_rx_mode = vxge_set_multicast, - .ndo_do_ioctl = vxge_ioctl, + .ndo_eth_ioctl = vxge_ioctl, .ndo_set_mac_address = vxge_set_mac_addr, .ndo_change_mtu = vxge_change_mtu, .ndo_fix_features = vxge_fix_features,
drivers/net/ethernet/nxp/lpc_eth.c +1 -1
@@ -1218,7 +1218,7 @@ static const struct net_device_ops lpc_netdev_ops = { .ndo_stop = lpc_eth_close, .ndo_start_xmit = lpc_eth_hard_start_xmit, .ndo_set_rx_mode = lpc_eth_set_multicast_list, - .ndo_do_ioctl = phy_do_ioctl_running, + .ndo_eth_ioctl = phy_do_ioctl_running, .ndo_set_mac_address = lpc_set_mac_address, .ndo_validate_addr = eth_validate_addr, };
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c +1 -1
@@ -2350,7 +2350,7 @@ static const struct net_device_ops pch_gbe_netdev_ops = { .ndo_tx_timeout = pch_gbe_tx_timeout, .ndo_change_mtu = pch_gbe_change_mtu, .ndo_set_features = pch_gbe_set_features, - .ndo_do_ioctl = pch_gbe_ioctl, + .ndo_eth_ioctl = pch_gbe_ioctl, .ndo_set_rx_mode = pch_gbe_set_multi, #ifdef CONFIG_NET_POLL_CONTROLLER .ndo_poll_controller = pch_gbe_netpoll,
drivers/net/ethernet/packetengines/hamachi.c +1 -1
@@ -573,7 +573,7 @@ static const struct net_device_ops hamachi_netdev_ops = { .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = eth_mac_addr, .ndo_tx_timeout = hamachi_tx_timeout, - .ndo_do_ioctl = hamachi_ioctl, + .ndo_eth_ioctl = hamachi_ioctl, .ndo_siocdevprivate = hamachi_siocdevprivate, };
drivers/net/ethernet/packetengines/yellowfin.c +1 -1
@@ -362,7 +362,7 @@ static const struct net_device_ops netdev_ops = { .ndo_set_rx_mode = set_rx_mode, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = eth_mac_addr, - .ndo_do_ioctl = netdev_ioctl, + .ndo_eth_ioctl = netdev_ioctl, .ndo_tx_timeout = yellowfin_tx_timeout, };
drivers/net/ethernet/qlogic/qede/qede_main.c +1 -1
@@ -645,7 +645,7 @@ static const struct net_device_ops qede_netdev_ops = { .ndo_set_mac_address = qede_set_mac_addr, .ndo_validate_addr = eth_validate_addr, .ndo_change_mtu = qede_change_mtu, - .ndo_do_ioctl = qede_ioctl, + .ndo_eth_ioctl = qede_ioctl, .ndo_tx_timeout = qede_tx_timeout, #ifdef CONFIG_QED_SRIOV .ndo_set_vf_mac = qede_set_vf_mac,
drivers/net/ethernet/qualcomm/emac/emac.c +1 -1
@@ -377,7 +377,7 @@ static const struct net_device_ops emac_netdev_ops = { .ndo_start_xmit = emac_start_xmit, .ndo_set_mac_address = eth_mac_addr, .ndo_change_mtu = emac_change_mtu, - .ndo_do_ioctl = phy_do_ioctl_running, + .ndo_eth_ioctl = phy_do_ioctl_running, .ndo_tx_timeout = emac_tx_timeout, .ndo_get_stats64 = emac_get_stats64, .ndo_set_features = emac_set_features,
drivers/net/ethernet/rdc/r6040.c +1 -1
@@ -953,7 +953,7 @@ static const struct net_device_ops r6040_netdev_ops = { .ndo_set_rx_mode = r6040_multicast_list, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = eth_mac_addr, - .ndo_do_ioctl = phy_do_ioctl, + .ndo_eth_ioctl = phy_do_ioctl, .ndo_tx_timeout = r6040_tx_timeout, #ifdef CONFIG_NET_POLL_CONTROLLER .ndo_poll_controller = r6040_poll_controller,
drivers/net/ethernet/realtek/8139cp.c +1 -1
@@ -1869,7 +1869,7 @@ static const struct net_device_ops cp_netdev_ops = { .ndo_set_mac_address = cp_set_mac_address, .ndo_set_rx_mode = cp_set_rx_mode, .ndo_get_stats = cp_get_stats, - .ndo_do_ioctl = cp_ioctl, + .ndo_eth_ioctl = cp_ioctl, .ndo_start_xmit = cp_start_xmit, .ndo_tx_timeout = cp_tx_timeout, .ndo_set_features = cp_set_features,
drivers/net/ethernet/realtek/8139too.c +1 -1
@@ -932,7 +932,7 @@ static const struct net_device_ops rtl8139_netdev_ops = { .ndo_set_mac_address = rtl8139_set_mac_address, .ndo_start_xmit = rtl8139_start_xmit, .ndo_set_rx_mode = rtl8139_set_rx_mode, - .ndo_do_ioctl = netdev_ioctl, + .ndo_eth_ioctl = netdev_ioctl, .ndo_tx_timeout = rtl8139_tx_timeout, #ifdef CONFIG_NET_POLL_CONTROLLER .ndo_poll_controller = rtl8139_poll_controller,
drivers/net/ethernet/realtek/r8169_main.c +1 -1
@@ -4979,7 +4979,7 @@ static const struct net_device_ops rtl_netdev_ops = { .ndo_fix_features = rtl8169_fix_features, .ndo_set_features = rtl8169_set_features, .ndo_set_mac_address = rtl_set_mac_address, - .ndo_do_ioctl = phy_do_ioctl_running, + .ndo_eth_ioctl = phy_do_ioctl_running, .ndo_set_rx_mode = rtl_set_rx_mode, #ifdef CONFIG_NET_POLL_CONTROLLER .ndo_poll_controller = rtl8169_netpoll,
drivers/net/ethernet/renesas/ravb_main.c +1 -1
@@ -1877,7 +1877,7 @@ static const struct net_device_ops ravb_netdev_ops = { .ndo_get_stats = ravb_get_stats, .ndo_set_rx_mode = ravb_set_rx_mode, .ndo_tx_timeout = ravb_tx_timeout, - .ndo_do_ioctl = ravb_do_ioctl, + .ndo_eth_ioctl = ravb_do_ioctl, .ndo_change_mtu = ravb_change_mtu, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = eth_mac_addr,
drivers/net/ethernet/renesas/sh_eth.c +2 -2
@@ -3108,7 +3108,7 @@ static const struct net_device_ops sh_eth_netdev_ops = { .ndo_get_stats = sh_eth_get_stats, .ndo_set_rx_mode = sh_eth_set_rx_mode, .ndo_tx_timeout = sh_eth_tx_timeout, - .ndo_do_ioctl = phy_do_ioctl_running, + .ndo_eth_ioctl = phy_do_ioctl_running, .ndo_change_mtu = sh_eth_change_mtu, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = eth_mac_addr,
@@ -3124,7 +3124,7 @@ static const struct net_device_ops sh_eth_netdev_ops_tsu = { .ndo_vlan_rx_add_vid = sh_eth_vlan_rx_add_vid, .ndo_vlan_rx_kill_vid = sh_eth_vlan_rx_kill_vid, .ndo_tx_timeout = sh_eth_tx_timeout, - .ndo_do_ioctl = phy_do_ioctl_running, + .ndo_eth_ioctl = phy_do_ioctl_running, .ndo_change_mtu = sh_eth_change_mtu, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = eth_mac_addr,
drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c +1 -1
@@ -1964,7 +1964,7 @@ static const struct net_device_ops sxgbe_netdev_ops = { .ndo_set_features = sxgbe_set_features, .ndo_set_rx_mode = sxgbe_set_rx_mode, .ndo_tx_timeout = sxgbe_tx_timeout, - .ndo_do_ioctl = sxgbe_ioctl, + .ndo_eth_ioctl = sxgbe_ioctl,#ifdef CONFIG_NET_POLL_CONTROLLER .ndo_poll_controller = sxgbe_poll_controller,#endif
drivers/net/ethernet/sfc/efx.c +1 -1
@@ -591,7 +591,7 @@ static const struct net_device_ops efx_netdev_ops = { .ndo_tx_timeout = efx_watchdog, .ndo_start_xmit = efx_hard_start_xmit, .ndo_validate_addr = eth_validate_addr, - .ndo_do_ioctl = efx_ioctl, + .ndo_eth_ioctl = efx_ioctl, .ndo_change_mtu = efx_change_mtu, .ndo_set_mac_address = efx_set_mac_address, .ndo_set_rx_mode = efx_set_rx_mode,
drivers/net/ethernet/sfc/falcon/efx.c +1 -1
@@ -2219,7 +2219,7 @@ static const struct net_device_ops ef4_netdev_ops = { .ndo_tx_timeout = ef4_watchdog, .ndo_start_xmit = ef4_hard_start_xmit, .ndo_validate_addr = eth_validate_addr, - .ndo_do_ioctl = ef4_ioctl, + .ndo_eth_ioctl = ef4_ioctl, .ndo_change_mtu = ef4_change_mtu, .ndo_set_mac_address = ef4_set_mac_address, .ndo_set_rx_mode = ef4_set_rx_mode,
drivers/net/ethernet/sgi/ioc3-eth.c +1 -1
@@ -820,7 +820,7 @@ static const struct net_device_ops ioc3_netdev_ops = { .ndo_tx_timeout = ioc3_timeout, .ndo_get_stats = ioc3_get_stats, .ndo_set_rx_mode = ioc3_set_multicast_list, - .ndo_do_ioctl = ioc3_ioctl, + .ndo_eth_ioctl = ioc3_ioctl, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = ioc3_set_mac_address, };
drivers/net/ethernet/sgi/meth.c +1 -1
@@ -812,7 +812,7 @@ static const struct net_device_ops meth_netdev_ops = { .ndo_open = meth_open, .ndo_stop = meth_release, .ndo_start_xmit = meth_tx, - .ndo_do_ioctl = meth_ioctl, + .ndo_eth_ioctl = meth_ioctl, .ndo_tx_timeout = meth_tx_timeout, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = eth_mac_addr,
drivers/net/ethernet/sis/sis190.c +1 -1
@@ -1841,7 +1841,7 @@ static int sis190_mac_addr(struct net_device *dev, void *p)static const struct net_device_ops sis190_netdev_ops = { .ndo_open = sis190_open, .ndo_stop = sis190_close, - .ndo_do_ioctl = sis190_ioctl, + .ndo_eth_ioctl = sis190_ioctl, .ndo_start_xmit = sis190_start_xmit, .ndo_tx_timeout = sis190_tx_timeout, .ndo_set_rx_mode = sis190_set_rx_mode,
drivers/net/ethernet/sis/sis900.c +1 -1
@@ -404,7 +404,7 @@ static const struct net_device_ops sis900_netdev_ops = { .ndo_set_rx_mode = set_rx_mode, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = eth_mac_addr, - .ndo_do_ioctl = mii_ioctl, + .ndo_eth_ioctl = mii_ioctl, .ndo_tx_timeout = sis900_tx_timeout, #ifdef CONFIG_NET_POLL_CONTROLLER .ndo_poll_controller = sis900_poll,
drivers/net/ethernet/smsc/epic100.c +1 -1
@@ -312,7 +312,7 @@ static const struct net_device_ops epic_netdev_ops = { .ndo_tx_timeout = epic_tx_timeout, .ndo_get_stats = epic_get_stats, .ndo_set_rx_mode = set_rx_mode, - .ndo_do_ioctl = netdev_ioctl, + .ndo_eth_ioctl = netdev_ioctl, .ndo_set_mac_address = eth_mac_addr, .ndo_validate_addr = eth_validate_addr, };
drivers/net/ethernet/smsc/smc91c92_cs.c +1 -1
@@ -294,7 +294,7 @@ static const struct net_device_ops smc_netdev_ops = { .ndo_tx_timeout = smc_tx_timeout, .ndo_set_config = s9k_config, .ndo_set_rx_mode = set_rx_mode, - .ndo_do_ioctl = smc_ioctl, + .ndo_eth_ioctl = smc_ioctl, .ndo_set_mac_address = eth_mac_addr, .ndo_validate_addr = eth_validate_addr, };
drivers/net/ethernet/smsc/smsc911x.c +1 -1
@@ -2140,7 +2140,7 @@ static const struct net_device_ops smsc911x_netdev_ops = { .ndo_start_xmit = smsc911x_hard_start_xmit, .ndo_get_stats = smsc911x_get_stats, .ndo_set_rx_mode = smsc911x_set_multicast_list, - .ndo_do_ioctl = phy_do_ioctl_running, + .ndo_eth_ioctl = phy_do_ioctl_running, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = smsc911x_set_mac_address, #ifdef CONFIG_NET_POLL_CONTROLLER
drivers/net/ethernet/smsc/smsc9420.c +1 -1
@@ -1482,7 +1482,7 @@ static const struct net_device_ops smsc9420_netdev_ops = { .ndo_start_xmit = smsc9420_hard_start_xmit, .ndo_get_stats = smsc9420_get_stats, .ndo_set_rx_mode = smsc9420_set_multicast_list, - .ndo_do_ioctl = phy_do_ioctl_running, + .ndo_eth_ioctl = phy_do_ioctl_running, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = eth_mac_addr,#ifdef CONFIG_NET_POLL_CONTROLLER
drivers/net/ethernet/socionext/netsec.c +1 -1
@@ -1826,7 +1826,7 @@ static const struct net_device_ops netsec_netdev_ops = { .ndo_set_features = netsec_netdev_set_features, .ndo_set_mac_address = eth_mac_addr, .ndo_validate_addr = eth_validate_addr, - .ndo_do_ioctl = phy_do_ioctl, + .ndo_eth_ioctl = phy_do_ioctl, .ndo_xdp_xmit = netsec_xdp_xmit, .ndo_bpf = netsec_xdp, };
drivers/net/ethernet/socionext/sni_ave.c +1 -1
@@ -1543,7 +1543,7 @@ static const struct net_device_ops ave_netdev_ops = { .ndo_open = ave_open, .ndo_stop = ave_stop, .ndo_start_xmit = ave_start_xmit, - .ndo_do_ioctl = ave_ioctl, + .ndo_eth_ioctl = ave_ioctl, .ndo_set_rx_mode = ave_set_rx_mode, .ndo_get_stats64 = ave_get_stats64, .ndo_set_mac_address = ave_set_mac_address,
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +1 -1
@@ -4601,7 +4601,7 @@ static const struct net_device_ops stmmac_netdev_ops = { .ndo_set_features = stmmac_set_features, .ndo_set_rx_mode = stmmac_set_rx_mode, .ndo_tx_timeout = stmmac_tx_timeout, - .ndo_do_ioctl = stmmac_ioctl, + .ndo_eth_ioctl = stmmac_ioctl, .ndo_setup_tc = stmmac_setup_tc, .ndo_select_queue = stmmac_select_queue,#ifdef CONFIG_NET_POLL_CONTROLLER
drivers/net/ethernet/sun/cassini.c +1 -1
@@ -4875,7 +4875,7 @@ static const struct net_device_ops cas_netdev_ops = { .ndo_start_xmit = cas_start_xmit, .ndo_get_stats = cas_get_stats, .ndo_set_rx_mode = cas_set_multicast, - .ndo_do_ioctl = cas_ioctl, + .ndo_eth_ioctl = cas_ioctl, .ndo_tx_timeout = cas_tx_timeout, .ndo_change_mtu = cas_change_mtu, .ndo_set_mac_address = eth_mac_addr,
drivers/net/ethernet/sun/niu.c +1 -1
@@ -9661,7 +9661,7 @@ static const struct net_device_ops niu_netdev_ops = { .ndo_set_rx_mode = niu_set_rx_mode, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = niu_set_mac_addr, - .ndo_do_ioctl = niu_ioctl, + .ndo_eth_ioctl = niu_ioctl, .ndo_tx_timeout = niu_tx_timeout, .ndo_change_mtu = niu_change_mtu, };
drivers/net/ethernet/sun/sungem.c +1 -1
@@ -2831,7 +2831,7 @@ static const struct net_device_ops gem_netdev_ops = { .ndo_start_xmit = gem_start_xmit, .ndo_get_stats = gem_get_stats, .ndo_set_rx_mode = gem_set_multicast, - .ndo_do_ioctl = gem_ioctl, + .ndo_eth_ioctl = gem_ioctl, .ndo_tx_timeout = gem_tx_timeout, .ndo_change_mtu = gem_change_mtu, .ndo_validate_addr = eth_validate_addr,
drivers/net/ethernet/synopsys/dwc-xlgmac-net.c +1 -1
@@ -933,7 +933,7 @@ static const struct net_device_ops xlgmac_netdev_ops = { .ndo_change_mtu = xlgmac_change_mtu, .ndo_set_mac_address = xlgmac_set_mac_address, .ndo_validate_addr = eth_validate_addr, - .ndo_do_ioctl = xlgmac_ioctl, + .ndo_eth_ioctl = xlgmac_ioctl, .ndo_vlan_rx_add_vid = xlgmac_vlan_rx_add_vid, .ndo_vlan_rx_kill_vid = xlgmac_vlan_rx_kill_vid, #ifdef CONFIG_NET_POLL_CONTROLLER
drivers/net/ethernet/ti/am65-cpsw-nuss.c +1 -1
@@ -1405,7 +1405,7 @@ static const struct net_device_ops am65_cpsw_nuss_netdev_ops_2g = { .ndo_tx_timeout = am65_cpsw_nuss_ndo_host_tx_timeout, .ndo_vlan_rx_add_vid = am65_cpsw_nuss_ndo_slave_add_vid, .ndo_vlan_rx_kill_vid = am65_cpsw_nuss_ndo_slave_kill_vid, - .ndo_do_ioctl = am65_cpsw_nuss_ndo_slave_ioctl, + .ndo_eth_ioctl = am65_cpsw_nuss_ndo_slave_ioctl, .ndo_set_features = am65_cpsw_nuss_ndo_slave_set_features, .ndo_setup_tc = am65_cpsw_qos_ndo_setup_tc, };
drivers/net/ethernet/ti/cpmac.c +1 -1
@@ -1044,7 +1044,7 @@ static const struct net_device_ops cpmac_netdev_ops = { .ndo_start_xmit = cpmac_start_xmit, .ndo_tx_timeout = cpmac_tx_timeout, .ndo_set_rx_mode = cpmac_set_multicast_list, - .ndo_do_ioctl = phy_do_ioctl_running, + .ndo_eth_ioctl = phy_do_ioctl_running, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = eth_mac_addr, };
drivers/net/ethernet/ti/cpsw.c +1 -1
@@ -1166,7 +1166,7 @@ static const struct net_device_ops cpsw_netdev_ops = { .ndo_stop = cpsw_ndo_stop, .ndo_start_xmit = cpsw_ndo_start_xmit, .ndo_set_mac_address = cpsw_ndo_set_mac_address, - .ndo_do_ioctl = cpsw_ndo_ioctl, + .ndo_eth_ioctl = cpsw_ndo_ioctl, .ndo_validate_addr = eth_validate_addr, .ndo_tx_timeout = cpsw_ndo_tx_timeout, .ndo_set_rx_mode = cpsw_ndo_set_rx_mode,
drivers/net/ethernet/ti/cpsw_new.c +1 -1
@@ -1133,7 +1133,7 @@ static const struct net_device_ops cpsw_netdev_ops = { .ndo_stop = cpsw_ndo_stop, .ndo_start_xmit = cpsw_ndo_start_xmit, .ndo_set_mac_address = cpsw_ndo_set_mac_address, - .ndo_do_ioctl = cpsw_ndo_ioctl, + .ndo_eth_ioctl = cpsw_ndo_ioctl, .ndo_validate_addr = eth_validate_addr, .ndo_tx_timeout = cpsw_ndo_tx_timeout, .ndo_set_rx_mode = cpsw_ndo_set_rx_mode,
drivers/net/ethernet/ti/davinci_emac.c +1 -1
@@ -1670,7 +1670,7 @@ static const struct net_device_ops emac_netdev_ops = { .ndo_start_xmit = emac_dev_xmit, .ndo_set_rx_mode = emac_dev_mcast_set, .ndo_set_mac_address = emac_dev_setmac_addr, - .ndo_do_ioctl = emac_devioctl, + .ndo_eth_ioctl = emac_devioctl, .ndo_tx_timeout = emac_dev_tx_timeout, .ndo_get_stats = emac_dev_getnetstats,#ifdef CONFIG_NET_POLL_CONTROLLER
drivers/net/ethernet/ti/netcp_core.c +1 -1
@@ -1944,7 +1944,7 @@ static const struct net_device_ops netcp_netdev_ops = { .ndo_stop = netcp_ndo_stop, .ndo_start_xmit = netcp_ndo_start_xmit, .ndo_set_rx_mode = netcp_set_rx_mode, - .ndo_do_ioctl = netcp_ndo_ioctl, + .ndo_eth_ioctl = netcp_ndo_ioctl, .ndo_get_stats64 = netcp_get_stats, .ndo_set_mac_address = eth_mac_addr, .ndo_validate_addr = eth_validate_addr,
drivers/net/ethernet/ti/tlan.c +1 -1
@@ -750,7 +750,7 @@ static const struct net_device_ops tlan_netdev_ops = { .ndo_tx_timeout = tlan_tx_timeout, .ndo_get_stats = tlan_get_stats, .ndo_set_rx_mode = tlan_set_multicast_list, - .ndo_do_ioctl = tlan_ioctl, + .ndo_eth_ioctl = tlan_ioctl, .ndo_set_mac_address = eth_mac_addr, .ndo_validate_addr = eth_validate_addr,#ifdef CONFIG_NET_POLL_CONTROLLER
drivers/net/ethernet/toshiba/spider_net.c +1 -1
@@ -2197,7 +2197,7 @@ static const struct net_device_ops spider_net_ops = { .ndo_start_xmit = spider_net_xmit, .ndo_set_rx_mode = spider_net_set_multi, .ndo_set_mac_address = spider_net_set_mac, - .ndo_do_ioctl = spider_net_do_ioctl, + .ndo_eth_ioctl = spider_net_do_ioctl, .ndo_tx_timeout = spider_net_tx_timeout, .ndo_validate_addr = eth_validate_addr,/* HW VLAN */
drivers/net/ethernet/toshiba/tc35815.c +1 -1
@@ -750,7 +750,7 @@ static const struct net_device_ops tc35815_netdev_ops = { .ndo_get_stats = tc35815_get_stats, .ndo_set_rx_mode = tc35815_set_multicast_list, .ndo_tx_timeout = tc35815_tx_timeout, - .ndo_do_ioctl = phy_do_ioctl_running, + .ndo_eth_ioctl = phy_do_ioctl_running, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = eth_mac_addr,#ifdef CONFIG_NET_POLL_CONTROLLER
drivers/net/ethernet/tundra/tsi108_eth.c +1 -1
@@ -1538,7 +1538,7 @@ static const struct net_device_ops tsi108_netdev_ops = { .ndo_start_xmit = tsi108_send_packet, .ndo_set_rx_mode = tsi108_set_rx_mode, .ndo_get_stats = tsi108_get_stats, - .ndo_do_ioctl = tsi108_do_ioctl, + .ndo_eth_ioctl = tsi108_do_ioctl, .ndo_set_mac_address = tsi108_set_mac, .ndo_validate_addr = eth_validate_addr, };
drivers/net/ethernet/via/via-rhine.c +1 -1
@@ -884,7 +884,7 @@ static const struct net_device_ops rhine_netdev_ops = { .ndo_set_rx_mode = rhine_set_rx_mode, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = eth_mac_addr, - .ndo_do_ioctl = netdev_ioctl, + .ndo_eth_ioctl = netdev_ioctl, .ndo_tx_timeout = rhine_tx_timeout, .ndo_vlan_rx_add_vid = rhine_vlan_rx_add_vid, .ndo_vlan_rx_kill_vid = rhine_vlan_rx_kill_vid,
drivers/net/ethernet/via/via-velocity.c +1 -1
@@ -2637,7 +2637,7 @@ static const struct net_device_ops velocity_netdev_ops = { .ndo_set_mac_address = eth_mac_addr, .ndo_set_rx_mode = velocity_set_multi, .ndo_change_mtu = velocity_change_mtu, - .ndo_do_ioctl = velocity_ioctl, + .ndo_eth_ioctl = velocity_ioctl, .ndo_vlan_rx_add_vid = velocity_vlan_rx_add_vid, .ndo_vlan_rx_kill_vid = velocity_vlan_rx_kill_vid,#ifdef CONFIG_NET_POLL_CONTROLLER
drivers/net/ethernet/xilinx/ll_temac_main.c +1 -1
@@ -1218,7 +1218,7 @@ static const struct net_device_ops temac_netdev_ops = { .ndo_set_rx_mode = temac_set_multicast_list, .ndo_set_mac_address = temac_set_mac_address, .ndo_validate_addr = eth_validate_addr, - .ndo_do_ioctl = phy_do_ioctl_running, + .ndo_eth_ioctl = phy_do_ioctl_running,#ifdef CONFIG_NET_POLL_CONTROLLER .ndo_poll_controller = temac_poll_controller,#endif
drivers/net/ethernet/xilinx/xilinx_axienet_main.c +1 -1
@@ -1236,7 +1236,7 @@ static const struct net_device_ops axienet_netdev_ops = { .ndo_change_mtu = axienet_change_mtu, .ndo_set_mac_address = netdev_set_mac_address, .ndo_validate_addr = eth_validate_addr, - .ndo_do_ioctl = axienet_ioctl, + .ndo_eth_ioctl = axienet_ioctl, .ndo_set_rx_mode = axienet_set_multicast_list, #ifdef CONFIG_NET_POLL_CONTROLLER .ndo_poll_controller = axienet_poll_controller,
drivers/net/ethernet/xilinx/xilinx_emaclite.c +1 -1
@@ -1266,7 +1266,7 @@ static const struct net_device_ops xemaclite_netdev_ops = { .ndo_start_xmit = xemaclite_send, .ndo_set_mac_address = xemaclite_set_mac_address, .ndo_tx_timeout = xemaclite_tx_timeout, - .ndo_do_ioctl = xemaclite_ioctl, + .ndo_eth_ioctl = xemaclite_ioctl,#ifdef CONFIG_NET_POLL_CONTROLLER .ndo_poll_controller = xemaclite_poll_controller,#endif
drivers/net/ethernet/xircom/xirc2ps_cs.c +1 -1
@@ -464,7 +464,7 @@ static const struct net_device_ops netdev_ops = { .ndo_start_xmit = do_start_xmit, .ndo_tx_timeout = xirc_tx_timeout, .ndo_set_config = do_config, - .ndo_do_ioctl = do_ioctl, + .ndo_eth_ioctl = do_ioctl, .ndo_set_rx_mode = set_multicast_list, .ndo_set_mac_address = eth_mac_addr, .ndo_validate_addr = eth_validate_addr,
drivers/net/ethernet/xscale/ixp4xx_eth.c +1 -1
@@ -1354,7 +1354,7 @@ static const struct net_device_ops ixp4xx_netdev_ops = { .ndo_stop = eth_close, .ndo_start_xmit = eth_xmit, .ndo_set_rx_mode = eth_set_mcast_list, - .ndo_do_ioctl = eth_ioctl, + .ndo_eth_ioctl = eth_ioctl, .ndo_set_mac_address = eth_mac_addr, .ndo_validate_addr = eth_validate_addr, };
drivers/net/macvlan.c +4 -4
@@ -828,7 +828,7 @@ static int macvlan_change_mtu(struct net_device *dev, int new_mtu)return 0 ; } -static int macvlan_do_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd) +static int macvlan_eth_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd) {struct net_device *real_dev =macvlan_dev_real_dev (dev);const struct net_device_ops *ops = real_dev->netdev_ops;
@@ -844,8 +844,8 @@ static int macvlan_do_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)break ; fallthrough;case SIOCGHWTSTAMP : -if (netif_device_present (real_dev) && ops->ndo_do_ioctl) - err = ops->ndo_do_ioctl (real_dev, &ifrr, cmd); +if (netif_device_present (real_dev) && ops->ndo_eth_ioctl) + err = ops->ndo_eth_ioctl (real_dev, &ifrr, cmd);break ; }
@@ -1150,7 +1150,7 @@ static const struct net_device_ops macvlan_netdev_ops = { .ndo_stop = macvlan_stop, .ndo_start_xmit = macvlan_start_xmit, .ndo_change_mtu = macvlan_change_mtu, - .ndo_do_ioctl = macvlan_do_ioctl, + .ndo_eth_ioctl = macvlan_eth_ioctl, .ndo_fix_features = macvlan_fix_features, .ndo_change_rx_flags = macvlan_change_rx_flags, .ndo_set_mac_address = macvlan_set_mac_address,
drivers/net/phy/phy.c +2 -2
@@ -442,7 +442,7 @@ int phy_mii_ioctl(struct phy_device *phydev, struct ifreq *ifr, int cmd)EXPORT_SYMBOL (phy_mii_ioctl);/** -* phy_do_ioctl - generic ndo_do_ioctl implementation +* phy_do_ioctl - generic ndo_eth_ioctl implementation * @dev: the net_device struct * @ifr: &struct ifreq for socket ioctl's * @cmd: ioctl cmd to execute
@@ -457,7 +457,7 @@ int phy_do_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)EXPORT_SYMBOL (phy_do_ioctl);/** -* phy_do_ioctl_running - generic ndo_do_ioctl implementation but test first +* phy_do_ioctl_running - generic ndo_eth_ioctl implementation but test first * * @dev: the net_device struct * @ifr: &struct ifreq for socket ioctl's
drivers/net/usb/asix_devices.c +3 -3
@@ -197,7 +197,7 @@ static const struct net_device_ops ax88172_netdev_ops = { .ndo_get_stats64 = usbnet_get_stats64, .ndo_set_mac_address = eth_mac_addr, .ndo_validate_addr = eth_validate_addr, - .ndo_do_ioctl = asix_ioctl, + .ndo_eth_ioctl = asix_ioctl, .ndo_set_rx_mode = ax88172_set_multicast, };
@@ -583,7 +583,7 @@ static const struct net_device_ops ax88772_netdev_ops = { .ndo_get_stats64 = usbnet_get_stats64, .ndo_set_mac_address = asix_set_mac_address, .ndo_validate_addr = eth_validate_addr, - .ndo_do_ioctl = asix_ioctl, + .ndo_eth_ioctl = asix_ioctl, .ndo_set_rx_mode = asix_set_multicast, };
@@ -1054,7 +1054,7 @@ static const struct net_device_ops ax88178_netdev_ops = { .ndo_set_mac_address = asix_set_mac_address, .ndo_validate_addr = eth_validate_addr, .ndo_set_rx_mode = asix_set_multicast, - .ndo_do_ioctl = asix_ioctl, + .ndo_eth_ioctl = asix_ioctl, .ndo_change_mtu = ax88178_change_mtu, };
drivers/net/usb/ax88172a.c +1 -1
@@ -123,7 +123,7 @@ static const struct net_device_ops ax88172a_netdev_ops = { .ndo_get_stats64 = usbnet_get_stats64, .ndo_set_mac_address = asix_set_mac_address, .ndo_validate_addr = eth_validate_addr, - .ndo_do_ioctl = phy_do_ioctl_running, + .ndo_eth_ioctl = phy_do_ioctl_running, .ndo_set_rx_mode = asix_set_multicast, };
drivers/net/usb/ax88179_178a.c +1 -1
@@ -1035,7 +1035,7 @@ static const struct net_device_ops ax88179_netdev_ops = { .ndo_change_mtu = ax88179_change_mtu, .ndo_set_mac_address = ax88179_set_mac_addr, .ndo_validate_addr = eth_validate_addr, - .ndo_do_ioctl = ax88179_ioctl, + .ndo_eth_ioctl = ax88179_ioctl, .ndo_set_rx_mode = ax88179_set_multicast, .ndo_set_features = ax88179_set_features, };
drivers/net/usb/dm9601.c +1 -1
@@ -345,7 +345,7 @@ static const struct net_device_ops dm9601_netdev_ops = { .ndo_change_mtu = usbnet_change_mtu, .ndo_get_stats64 = usbnet_get_stats64, .ndo_validate_addr = eth_validate_addr, - .ndo_do_ioctl = dm9601_ioctl, + .ndo_eth_ioctl = dm9601_ioctl, .ndo_set_rx_mode = dm9601_set_multicast, .ndo_set_mac_address = dm9601_set_mac_address, };
drivers/net/usb/lan78xx.c +1 -1
@@ -3612,7 +3612,7 @@ static const struct net_device_ops lan78xx_netdev_ops = { .ndo_change_mtu = lan78xx_change_mtu, .ndo_set_mac_address = lan78xx_set_mac_addr, .ndo_validate_addr = eth_validate_addr, - .ndo_do_ioctl = phy_do_ioctl_running, + .ndo_eth_ioctl = phy_do_ioctl_running, .ndo_set_rx_mode = lan78xx_set_multicast, .ndo_set_features = lan78xx_set_features, .ndo_vlan_rx_add_vid = lan78xx_vlan_rx_add_vid,
drivers/net/usb/mcs7830.c +1 -1
@@ -464,7 +464,7 @@ static const struct net_device_ops mcs7830_netdev_ops = { .ndo_change_mtu = usbnet_change_mtu, .ndo_get_stats64 = usbnet_get_stats64, .ndo_validate_addr = eth_validate_addr, - .ndo_do_ioctl = mcs7830_ioctl, + .ndo_eth_ioctl = mcs7830_ioctl, .ndo_set_rx_mode = mcs7830_set_multicast, .ndo_set_mac_address = mcs7830_set_mac_address, };
drivers/net/usb/r8152.c +1 -1
@@ -6466,7 +6466,7 @@ static int rtl8152_change_mtu(struct net_device *dev, int new_mtu)static const struct net_device_ops rtl8152_netdev_ops = { .ndo_open = rtl8152_open, .ndo_stop = rtl8152_close, - .ndo_do_ioctl = rtl8152_ioctl, + .ndo_eth_ioctl = rtl8152_ioctl, .ndo_start_xmit = rtl8152_start_xmit, .ndo_tx_timeout = rtl8152_tx_timeout, .ndo_set_features = rtl8152_set_features,
drivers/net/usb/smsc75xx.c +1 -1
@@ -1439,7 +1439,7 @@ static const struct net_device_ops smsc75xx_netdev_ops = { .ndo_change_mtu = smsc75xx_change_mtu, .ndo_set_mac_address = eth_mac_addr, .ndo_validate_addr = eth_validate_addr, - .ndo_do_ioctl = smsc75xx_ioctl, + .ndo_eth_ioctl = smsc75xx_ioctl, .ndo_set_rx_mode = smsc75xx_set_multicast, .ndo_set_features = smsc75xx_set_features, };
drivers/net/usb/smsc95xx.c +1 -1
@@ -1044,7 +1044,7 @@ static const struct net_device_ops smsc95xx_netdev_ops = { .ndo_get_stats64 = usbnet_get_stats64, .ndo_set_mac_address = eth_mac_addr, .ndo_validate_addr = eth_validate_addr, - .ndo_do_ioctl = smsc95xx_ioctl, + .ndo_eth_ioctl = smsc95xx_ioctl, .ndo_set_rx_mode = smsc95xx_set_multicast, .ndo_set_features = smsc95xx_set_features, };
drivers/net/usb/sr9700.c +1 -1
@@ -310,7 +310,7 @@ static const struct net_device_ops sr9700_netdev_ops = { .ndo_change_mtu = usbnet_change_mtu, .ndo_get_stats64 = usbnet_get_stats64, .ndo_validate_addr = eth_validate_addr, - .ndo_do_ioctl = sr9700_ioctl, + .ndo_eth_ioctl = sr9700_ioctl, .ndo_set_rx_mode = sr9700_set_multicast, .ndo_set_mac_address = sr9700_set_mac_address, };
drivers/net/usb/sr9800.c +1 -1
@@ -684,7 +684,7 @@ static const struct net_device_ops sr9800_netdev_ops = { .ndo_get_stats64 = usbnet_get_stats64, .ndo_set_mac_address = sr_set_mac_address, .ndo_validate_addr = eth_validate_addr, - .ndo_do_ioctl = sr_ioctl, + .ndo_eth_ioctl = sr_ioctl, .ndo_set_rx_mode = sr_set_multicast, };
drivers/s390/net/qeth_l2_main.c +1 -1
@@ -873,7 +873,7 @@ static const struct net_device_ops qeth_l2_netdev_ops = { .ndo_select_queue = qeth_l2_select_queue, .ndo_validate_addr = qeth_l2_validate_addr, .ndo_set_rx_mode = qeth_l2_set_rx_mode, - .ndo_do_ioctl = qeth_do_ioctl, + .ndo_eth_ioctl = qeth_do_ioctl, .ndo_set_mac_address = qeth_l2_set_mac_address, .ndo_vlan_rx_add_vid = qeth_l2_vlan_rx_add_vid, .ndo_vlan_rx_kill_vid = qeth_l2_vlan_rx_kill_vid,
drivers/s390/net/qeth_l3_main.c +2 -2
@@ -1847,7 +1847,7 @@ static const struct net_device_ops qeth_l3_netdev_ops = { .ndo_select_queue = qeth_l3_iqd_select_queue, .ndo_validate_addr = eth_validate_addr, .ndo_set_rx_mode = qeth_l3_set_rx_mode, - .ndo_do_ioctl = qeth_do_ioctl, + .ndo_eth_ioctl = qeth_do_ioctl, .ndo_fix_features = qeth_fix_features, .ndo_set_features = qeth_set_features, .ndo_vlan_rx_add_vid = qeth_l3_vlan_rx_add_vid,
@@ -1864,7 +1864,7 @@ static const struct net_device_ops qeth_l3_osa_netdev_ops = { .ndo_select_queue = qeth_l3_osa_select_queue, .ndo_validate_addr = eth_validate_addr, .ndo_set_rx_mode = qeth_l3_set_rx_mode, - .ndo_do_ioctl = qeth_do_ioctl, + .ndo_eth_ioctl = qeth_do_ioctl, .ndo_fix_features = qeth_fix_features, .ndo_set_features = qeth_set_features, .ndo_vlan_rx_add_vid = qeth_l3_vlan_rx_add_vid,
drivers/staging/octeon/ethernet.c +6 -6
@@ -527,7 +527,7 @@ static const struct net_device_ops cvm_oct_npi_netdev_ops = { .ndo_start_xmit = cvm_oct_xmit, .ndo_set_rx_mode = cvm_oct_common_set_multicast_list, .ndo_set_mac_address = cvm_oct_common_set_mac_address, - .ndo_do_ioctl = cvm_oct_ioctl, + .ndo_eth_ioctl = cvm_oct_ioctl, .ndo_change_mtu = cvm_oct_common_change_mtu, .ndo_get_stats = cvm_oct_common_get_stats, #ifdef CONFIG_NET_POLL_CONTROLLER
@@ -543,7 +543,7 @@ static const struct net_device_ops cvm_oct_xaui_netdev_ops = { .ndo_start_xmit = cvm_oct_xmit, .ndo_set_rx_mode = cvm_oct_common_set_multicast_list, .ndo_set_mac_address = cvm_oct_common_set_mac_address, - .ndo_do_ioctl = cvm_oct_ioctl, + .ndo_eth_ioctl = cvm_oct_ioctl, .ndo_change_mtu = cvm_oct_common_change_mtu, .ndo_get_stats = cvm_oct_common_get_stats, #ifdef CONFIG_NET_POLL_CONTROLLER
@@ -559,7 +559,7 @@ static const struct net_device_ops cvm_oct_sgmii_netdev_ops = { .ndo_start_xmit = cvm_oct_xmit, .ndo_set_rx_mode = cvm_oct_common_set_multicast_list, .ndo_set_mac_address = cvm_oct_common_set_mac_address, - .ndo_do_ioctl = cvm_oct_ioctl, + .ndo_eth_ioctl = cvm_oct_ioctl, .ndo_change_mtu = cvm_oct_common_change_mtu, .ndo_get_stats = cvm_oct_common_get_stats, #ifdef CONFIG_NET_POLL_CONTROLLER
@@ -573,7 +573,7 @@ static const struct net_device_ops cvm_oct_spi_netdev_ops = { .ndo_start_xmit = cvm_oct_xmit, .ndo_set_rx_mode = cvm_oct_common_set_multicast_list, .ndo_set_mac_address = cvm_oct_common_set_mac_address, - .ndo_do_ioctl = cvm_oct_ioctl, + .ndo_eth_ioctl = cvm_oct_ioctl, .ndo_change_mtu = cvm_oct_common_change_mtu, .ndo_get_stats = cvm_oct_common_get_stats, #ifdef CONFIG_NET_POLL_CONTROLLER
@@ -589,7 +589,7 @@ static const struct net_device_ops cvm_oct_rgmii_netdev_ops = { .ndo_start_xmit = cvm_oct_xmit, .ndo_set_rx_mode = cvm_oct_common_set_multicast_list, .ndo_set_mac_address = cvm_oct_common_set_mac_address, - .ndo_do_ioctl = cvm_oct_ioctl, + .ndo_eth_ioctl = cvm_oct_ioctl, .ndo_change_mtu = cvm_oct_common_change_mtu, .ndo_get_stats = cvm_oct_common_get_stats, #ifdef CONFIG_NET_POLL_CONTROLLER
@@ -602,7 +602,7 @@ static const struct net_device_ops cvm_oct_pow_netdev_ops = { .ndo_start_xmit = cvm_oct_xmit_pow, .ndo_set_rx_mode = cvm_oct_common_set_multicast_list, .ndo_set_mac_address = cvm_oct_common_set_mac_address, - .ndo_do_ioctl = cvm_oct_ioctl, + .ndo_eth_ioctl = cvm_oct_ioctl, .ndo_change_mtu = cvm_oct_common_change_mtu, .ndo_get_stats = cvm_oct_common_get_stats, #ifdef CONFIG_NET_POLL_CONTROLLER
include/linux/netdevice.h +6 -0
@@ -1019,6 +1019,10 @@ struct netdev_net_notifier {* the generic interface code. If not defined ioctls return * not supported error code. * +* * int (*ndo_eth_ioctl)(struct net_device *dev, struct ifreq *ifr, int cmd); +* Called for ethernet specific ioctls: SIOCGMIIPHY, SIOCGMIIREG, +* SIOCSMIIREG, SIOCSHWTSTAMP and SIOCGHWTSTAMP. +* * int (*ndo_set_config)(struct net_device *dev, struct ifmap *map); * Used to set network devices bus interface parameters. This interface * is retained for legacy reasons; new devices should use the bus
@@ -1301,6 +1305,8 @@ struct net_device_ops {int (*ndo_validate_addr)(struct net_device *dev);int (*ndo_do_ioctl)(struct net_device *dev,struct ifreq *ifr,int cmd); +int (*ndo_eth_ioctl)(struct net_device *dev, +struct ifreq *ifr,int cmd);int (*ndo_siocdevprivate)(struct net_device *dev,struct ifreq *ifr,void __user *data,int cmd);
include/net/dsa.h +7 -7
@@ -99,8 +99,8 @@ struct dsa_device_ops {* function pointers. */ struct dsa_netdevice_ops { -int (*ndo_do_ioctl)(struct net_device *dev,struct ifreq *ifr, -int cmd); +int (*ndo_eth_ioctl)(struct net_device *dev,struct ifreq *ifr, +int cmd); };#define DSA_TAG_DRIVER_ALIAS "dsa_tag-"
@@ -781,8 +781,8 @@ static inline int __dsa_netdevice_ops_check(struct net_device *dev)return 0 ; } -static inline int dsa_ndo_do_ioctl (struct net_device *dev,struct ifreq *ifr, -int cmd) +static inline int dsa_ndo_eth_ioctl (struct net_device *dev,struct ifreq *ifr, +int cmd) {const struct dsa_netdevice_ops *ops;int err;
@@ -793,11 +793,11 @@ static inline int dsa_ndo_do_ioctl(struct net_device *dev, struct ifreq *ifr, ops = dev->dsa_ptr->netdev_ops; - return ops->ndo_do_ioctl(dev, ifr, cmd); + return ops->ndo_eth_ioctl(dev, ifr, cmd); }#else -static inline int dsa_ndo_do_ioctl (struct net_device *dev,struct ifreq *ifr, -int cmd) +static inline int dsa_ndo_eth_ioctl (struct net_device *dev,struct ifreq *ifr, +int cmd) {return -EOPNOTSUPP ; }
net/8021q/vlan_dev.c +3 -3
@@ -372,8 +372,8 @@ static int vlan_dev_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)case SIOCGMIIREG :case SIOCSMIIREG :case SIOCGHWTSTAMP : -if (netif_device_present (real_dev) && ops->ndo_do_ioctl) - err = ops->ndo_do_ioctl (real_dev, &ifrr, cmd); +if (netif_device_present (real_dev) && ops->ndo_eth_ioctl) + err = ops->ndo_eth_ioctl (real_dev, &ifrr, cmd);break ; }
@@ -785,7 +785,7 @@ static const struct net_device_ops vlan_netdev_ops = { .ndo_set_mac_address = vlan_dev_set_mac_address, .ndo_set_rx_mode = vlan_dev_set_rx_mode, .ndo_change_rx_flags = vlan_dev_change_rx_flags, - .ndo_do_ioctl = vlan_dev_ioctl, + .ndo_eth_ioctl = vlan_dev_ioctl, .ndo_neigh_setup = vlan_dev_neigh_setup, .ndo_get_stats64 = vlan_dev_get_stats64, #if IS_ENABLED(CONFIG_FCOE)
net/core/dev_ioctl.c +27 -11
@@ -249,19 +249,19 @@ static int net_hwtstamp_validate(struct ifreq *ifr)return 0 ; } -static int dev_do_ioctl (struct net_device *dev, -struct ifreq *ifr,unsigned int cmd) +static int dev_eth_ioctl (struct net_device *dev, +struct ifreq *ifr,unsigned int cmd) {const struct net_device_ops *ops = dev->netdev_ops;int err = -EOPNOTSUPP ; - err =dsa_ndo_do_ioctl (dev, ifr, cmd); + err =dsa_ndo_eth_ioctl (dev, ifr, cmd);if (err ==0 || err != -EOPNOTSUPP )return err; -if (ops->ndo_do_ioctl) { +if (ops->ndo_eth_ioctl) {if (netif_device_present (dev)) - err = ops->ndo_do_ioctl (dev, ifr, cmd); + err = ops->ndo_eth_ioctl (dev, ifr, cmd);else err = -ENODEV ; }
@@ -269,6 +269,21 @@ static int dev_do_ioctl(struct net_device *dev,return err; } +static int dev_do_ioctl (struct net_device *dev, +struct ifreq *ifr,unsigned int cmd) +{ +const struct net_device_ops *ops = dev->netdev_ops; + +if (ops->ndo_do_ioctl) { +if (netif_device_present (dev)) +return ops->ndo_do_ioctl (dev, ifr, cmd); +else +return -ENODEV ; + } + +return -EOPNOTSUPP ; +} +static int dev_siocdevprivate (struct net_device *dev,struct ifreq *ifr,void __user *data,unsigned int cmd) {
@@ -368,19 +383,20 @@ static int dev_ifsioc(struct net *net, struct ifreq *ifr, void __user *data, cmd <= SIOCDEVPRIVATE + 15)return dev_siocdevprivate (dev, ifr, data, cmd); -if (cmd ==SIOCBONDENSLAVE || +if (cmd ==SIOCGMIIPHY || + cmd ==SIOCGMIIREG || + cmd ==SIOCSMIIREG || + cmd ==SIOCSHWTSTAMP || + cmd ==SIOCGHWTSTAMP ) { + err =dev_eth_ioctl (dev, ifr, cmd); + }else if (cmd ==SIOCBONDENSLAVE || cmd ==SIOCBONDRELEASE || cmd ==SIOCBONDSETHWADDR || cmd ==SIOCBONDSLAVEINFOQUERY || cmd ==SIOCBONDINFOQUERY || cmd ==SIOCBONDCHANGEACTIVE || - cmd ==SIOCGMIIPHY || - cmd ==SIOCGMIIREG || - cmd ==SIOCSMIIREG || cmd ==SIOCBRADDIF || cmd ==SIOCBRDELIF || - cmd ==SIOCSHWTSTAMP || - cmd ==SIOCGHWTSTAMP || cmd ==SIOCWANDEV ) { err =dev_do_ioctl (dev, ifr, cmd); }else
net/dsa/master.c +3 -3
@@ -209,14 +209,14 @@ static int dsa_master_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)break ; } -if (dev->netdev_ops->ndo_do_ioctl) - err = dev->netdev_ops->ndo_do_ioctl (dev, ifr, cmd); +if (dev->netdev_ops->ndo_eth_ioctl) + err = dev->netdev_ops->ndo_eth_ioctl (dev, ifr, cmd);return err; }static const struct dsa_netdevice_ops dsa_netdev_ops = { - .ndo_do_ioctl = dsa_master_ioctl, + .ndo_eth_ioctl = dsa_master_ioctl, };static int dsa_master_ethtool_setup (struct net_device *dev)
net/dsa/slave.c +1 -1
@@ -1592,7 +1592,7 @@ static const struct net_device_ops dsa_slave_netdev_ops = { .ndo_fdb_add = dsa_legacy_fdb_add, .ndo_fdb_del = dsa_legacy_fdb_del, .ndo_fdb_dump = dsa_slave_fdb_dump, - .ndo_do_ioctl = dsa_slave_ioctl, + .ndo_eth_ioctl = dsa_slave_ioctl, .ndo_get_iflink = dsa_slave_get_iflink, #ifdef CONFIG_NET_POLL_CONTROLLER .ndo_netpoll_setup = dsa_slave_netpoll_setup,
Signature · 1 line
2.27.0
RFC 21/28 wan: use ndo_siocdevprivate
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
The wan drivers each support some custom SIOCDEVPRIVATE ioctls, plus the common SIOCWANDEV command.
Split these so the ioctl callback only deals with SIOCWANDEV and the rest is handled by ndo_siocdevprivate.
It might make sense to also split out SIOCWANDEV into a separate callback in order to eventually remove ndo_do_ioctl entirely.
--- drivers/net/wan/c101.c | 20 +++++++++++++----- drivers/net/wan/dlci.c | 7 ++++--- drivers/net/wan/farsync.c | 38 ++++++++++++++++++++++++++-------- drivers/net/wan/hdlc_fr.c | 3 +++ drivers/net/wan/lmc/lmc_main.c | 38 ++++++++++++++++++++-------------- drivers/net/wan/n2.c | 18 ++++++++++------ drivers/net/wan/pc300too.c | 19 ++++++++++------- drivers/net/wan/pci200syn.c | 19 ++++++++++------- drivers/net/wan/sbni.c | 12 +++++------ drivers/net/wan/sdla.c | 8 +++---- 10 files changed, 120 insertions(+), 62 deletions(-)
drivers/net/wan/c101.c +15 -5
@@ -219,14 +219,12 @@ static int c101_close(struct net_device *dev) } -static int c101_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd) +static int c101_siocdevprivate (struct net_device *dev,struct ifreq *ifr, +void __user *data,int cmd) { -const size_t size =sizeof (sync_serial_settings); -sync_serial_settings new_line; -sync_serial_settings __user *line = ifr->ifr_settings.ifs_ifsu.sync; +#ifdef DEBUG_RINGS port_t *port =dev_to_port (dev); -#ifdef DEBUG_RINGS if (cmd ==SIOCDEVPRIVATE ) {sca_dump_rings (dev); printk(KERN_DEBUG "MSCI1: ST: %02x %02x %02x %02x\n",
@@ -237,6 +235,17 @@ static int c101_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) return 0; }#endif + +return -EOPNOTSUPP ; +} + +static int c101_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd) +{ +const size_t size =sizeof (sync_serial_settings); +sync_serial_settings new_line; +sync_serial_settings __user *line = ifr->ifr_settings.ifs_ifsu.sync; +port_t *port =dev_to_port (dev); +if (cmd !=SIOCWANDEV )return hdlc_ioctl (dev, ifr, cmd);
@@ -300,6 +309,7 @@ static const struct net_device_ops c101_ops = { .ndo_stop = c101_close, .ndo_start_xmit = hdlc_start_xmit, .ndo_do_ioctl = c101_ioctl, + .ndo_siocdevprivate = c101_siocdevprivate, };static int __init c101_run (unsigned long irq,unsigned long winbase)
drivers/net/wan/dlci.c +4 -3
@@ -229,7 +229,8 @@ static int dlci_config(struct net_device *dev, struct dlci_conf __user *conf, inreturn 0 ; } -static int dlci_dev_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd) +static int dlci_siocdevprivate (struct net_device *dev,struct ifreq *ifr, +void __user *data,int cmd) {struct dlci_local *dlp;
@@ -252,7 +253,7 @@ static int dlci_dev_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)if (!*(short *)(dev->dev_addr))return -EINVAL ; -return dlci_config (dev, ifr->ifr_data, cmd ==DLCI_GET_CONF ); +return dlci_config (dev, data, cmd ==DLCI_GET_CONF );default :return -EOPNOTSUPP ;
@@ -458,7 +459,7 @@ static const struct header_ops dlci_header_ops = {static const struct net_device_ops dlci_netdev_ops = { .ndo_open = dlci_open, .ndo_stop = dlci_close, - .ndo_do_ioctl = dlci_dev_ioctl, + .ndo_siocdevprivate = dlci_siocdevprivate, .ndo_start_xmit = dlci_transmit, .ndo_change_mtu = dlci_change_mtu, };
drivers/net/wan/farsync.c +29 -9
@@ -1975,7 +1975,7 @@ fst_get_iface(struct fst_card_info *card, struct fst_port_info *port, }static int -fst_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd) +fst_siocdevprivate (struct net_device *dev,struct ifreq *ifr,void __user *data,int cmd) {struct fst_card_info *card;struct fst_port_info *port;
@@ -1984,7 +1984,7 @@ fst_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)unsigned long flags;void *buf; -dbg (DBG_IOCTL ,"ioctl: %x, %p\n" , cmd, ifr->ifr_data); +dbg (DBG_IOCTL ,"ioctl: %x, %p\n" , cmd, data); port =dev_to_port (dev); card = port->card;
@@ -2008,10 +2008,10 @@ fst_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)/* First copy in the header with the length and offset of data * to write */ -if (ifr->ifr_data ==NULL ) { +if (data ==NULL ) {return -EINVAL ; } -if (copy_from_user (&wrthdr, ifr->ifr_data, +if (copy_from_user (&wrthdr, data,sizeof (struct fstioc_write ))) {return -EFAULT ; }
@@ -2026,7 +2026,7 @@ fst_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)/* Now copy the data to the card. */ - buf =memdup_user (ifr->ifr_data +sizeof (struct fstioc_write ), + buf =memdup_user (data +sizeof (struct fstioc_write ), wrthdr.size);if (IS_ERR (buf))return PTR_ERR (buf);
@@ -2059,13 +2059,13 @@ fst_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) } } -if (ifr->ifr_data ==NULL ) { +if (data ==NULL ) {return -EINVAL ; }gather_conf_info (card, port, &info); -if (copy_to_user (ifr->ifr_data, &info,sizeof (info))) { +if (copy_to_user (data, &info,sizeof (info))) {return -EFAULT ; }return 0 ;
@@ -2082,12 +2082,31 @@ fst_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) card->card_no, card->state);return -EIO ; } -if (copy_from_user (&info, ifr->ifr_data,sizeof (info))) { +if (copy_from_user (&info, data,sizeof (info))) {return -EFAULT ; }return set_conf_from_info (card, port, &info); +default : +return -EINVAL ; + } +} +static int +fst_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd) +{ +struct fst_card_info *card; +struct fst_port_info *port; + +dbg (DBG_IOCTL ,"ioctl: %x, %x\n" , cmd, ifr->ifr_settings.type); + + port =dev_to_port (dev); + card = port->card; + +if (!capable (CAP_NET_ADMIN )) +return -EPERM ; + +switch (cmd) {case SIOCWANDEV :switch (ifr->ifr_settings.type) {case IF_GET_IFACE :
@@ -2389,7 +2408,8 @@ static const struct net_device_ops fst_ops = { .ndo_open = fst_open, .ndo_stop = fst_close, .ndo_start_xmit = hdlc_start_xmit, - .ndo_do_ioctl = fst_ioctl, + .ndo_do_ioctl = fst_ioctl, + .ndo_siocdevprivate = fst_siocdevprivate, .ndo_tx_timeout = fst_tx_timeout, };
drivers/net/wan/hdlc_fr.c +3 -0
@@ -380,6 +380,9 @@ static int pvc_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)struct pvc_device *pvc = dev->ml_priv;fr_proto_pvc_info info; +if (cmd !=SIOCWANDEV ) +return -EOPNOTSUPP ; +if (ifr->ifr_settings.type ==IF_GET_PROTO ) {if (dev->type ==ARPHRD_ETHER ) ifr->ifr_settings.type =IF_PROTO_FR_ETH_PVC ;
drivers/net/wan/lmc/lmc_main.c +23 -15
@@ -105,7 +105,8 @@ static void lmc_driver_timeout(struct net_device *dev, unsigned int txqueue);* linux reserves 16 device specific IOCTLs. We call them * LMCIOC* to control various bits of our world. */ -int lmc_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd)/*fold00*/ +static int lmc_siocdevprivate (struct net_device *dev,struct ifreq *ifr, +void __user *data,int cmd)/*fold00*/ {lmc_softc_t *sc =dev_to_sc (dev);lmc_ctl_t ctl;
@@ -124,7 +125,7 @@ int lmc_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) /*fold00*/* To date internally, just copy this out to the user. */ case LMCIOCGINFO :/*fold01*/ -if (copy_to_user (ifr->ifr_data, &sc->ictl,sizeof (lmc_ctl_t))) +if (copy_to_user (data, &sc->ictl,sizeof (lmc_ctl_t))) ret = -EFAULT ;else ret =0 ;
@@ -141,7 +142,7 @@ int lmc_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) /*fold00*/break ; } -if (copy_from_user (&ctl, ifr->ifr_data,sizeof (lmc_ctl_t))) { +if (copy_from_user (&ctl, data,sizeof (lmc_ctl_t))) { ret = -EFAULT ;break ; }
@@ -171,7 +172,7 @@ int lmc_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) /*fold00*/break ; } -if (copy_from_user (&new_type, ifr->ifr_data,sizeof (u16))) { +if (copy_from_user (&new_type, data,sizeof (u16))) { ret = -EFAULT ;break ; }
@@ -211,7 +212,7 @@ int lmc_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) /*fold00*/ sc->lmc_xinfo.Magic1 =0xDEADBEEF ; -if (copy_to_user (ifr->ifr_data, &sc->lmc_xinfo, +if (copy_to_user (data, &sc->lmc_xinfo,sizeof (struct lmc_xinfo ))) ret = -EFAULT ;else
@@ -245,9 +246,9 @@ int lmc_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) /*fold00*/ regVal &T1FRAMER_SEF_MASK ; }spin_unlock_irqrestore (&sc->lmc_lock, flags); -if (copy_to_user (ifr->ifr_data, &sc->lmc_device->stats, +if (copy_to_user (data, &sc->lmc_device->stats,sizeof (sc->lmc_device->stats)) || -copy_to_user (ifr->ifr_data +sizeof (sc->lmc_device->stats), +copy_to_user (data +sizeof (sc->lmc_device->stats), &sc->extra_stats,sizeof (sc->extra_stats))) ret = -EFAULT ;else
@@ -282,7 +283,7 @@ int lmc_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) /*fold00*/break ; } -if (copy_from_user (&ctl, ifr->ifr_data,sizeof (lmc_ctl_t))) { +if (copy_from_user (&ctl, data,sizeof (lmc_ctl_t))) { ret = -EFAULT ;break ; }
@@ -314,11 +315,11 @@ int lmc_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) /*fold00*/#ifdef DEBUG case LMCIOCDUMPEVENTLOG : -if (copy_to_user (ifr->ifr_data, &lmcEventLogIndex,sizeof (u32))) { +if (copy_to_user (data, &lmcEventLogIndex,sizeof (u32))) { ret = -EFAULT ;break ; } -if (copy_to_user (ifr->ifr_data +sizeof (u32), lmcEventLogBuf, +if (copy_to_user (data +sizeof (u32), lmcEventLogBuf,sizeof (lmcEventLogBuf))) ret = -EFAULT ;else
@@ -346,7 +347,7 @@ int lmc_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) /*fold00*/*/ netif_stop_queue (dev); -if (copy_from_user (&xc, ifr->ifr_data,sizeof (struct lmc_xilinx_control ))) { +if (copy_from_user (&xc, data,sizeof (struct lmc_xilinx_control ))) { ret = -EFAULT ;break ; }
@@ -611,15 +612,21 @@ int lmc_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) /*fold00*/ }break ; -default :/*fold01*/ -/* If we don't know what to do, give the protocol a shot. */ - ret =lmc_proto_ioctl (sc, ifr, cmd); -break ; +default : +break ; }return ret; } +int lmc_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd) +{ +if (cmd !=SIOCWANDEV ) +return -EOPNOTSUPP ; + +return lmc_proto_ioctl (dev_to_sc (dev), ifr, cmd); +} +/* the watchdog process that cruises around */ static void lmc_watchdog (struct timer_list *t)/*fold00*/
@@ -791,6 +798,7 @@ static const struct net_device_ops lmc_ops = { .ndo_stop = lmc_close, .ndo_start_xmit = hdlc_start_xmit, .ndo_do_ioctl = lmc_ioctl, + .ndo_siocdevprivate = lmc_siocdevprivate, .ndo_tx_timeout = lmc_driver_timeout, .ndo_get_stats = lmc_get_stats, };
drivers/net/wan/n2.c +12 -6
@@ -242,6 +242,17 @@ static int n2_close(struct net_device *dev) } +static int n2_siocdevprivate (struct net_device *dev,struct ifreq *ifr, +void __user *data,int cmd) +{ +#ifdef DEBUG_RINGS +if (cmd ==SIOCDEVPRIVATE ) { +sca_dump_rings (dev); +return 0 ; + } +#endif +return -EOPNOTSUPP ; +}static int n2_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd) {
@@ -250,12 +261,6 @@ static int n2_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)sync_serial_settings __user *line = ifr->ifr_settings.ifs_ifsu.sync;port_t *port =dev_to_port (dev); -#ifdef DEBUG_RINGS -if (cmd ==SIOCDEVPRIVATE ) { -sca_dump_rings (dev); -return 0 ; - } -#endif if (cmd !=SIOCWANDEV )return hdlc_ioctl (dev, ifr, cmd);
@@ -329,6 +334,7 @@ static const struct net_device_ops n2_ops = { .ndo_stop = n2_close, .ndo_start_xmit = hdlc_start_xmit, .ndo_do_ioctl = n2_ioctl, + .ndo_siocdevprivate = n2_siocdevprivate, }; static int __init n2_run(unsigned long io, unsigned long irq,
drivers/net/wan/pc300too.c +12 -7
@@ -186,7 +186,17 @@ static int pc300_close(struct net_device *dev)return 0 ; } - +static int pc300_siocdevprivate (struct net_device *dev,struct ifreq *ifr, +void __user *data,int cmd) +{ +#ifdef DEBUG_RINGS +if (cmd ==SIOCDEVPRIVATE ) { +sca_dump_rings (dev); +return 0 ; + } +#endif +return -EOPNOTSUPP ; +}static int pc300_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd) {
@@ -196,12 +206,6 @@ static int pc300_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)int new_type;port_t *port =dev_to_port (dev); -#ifdef DEBUG_RINGS -if (cmd ==SIOCDEVPRIVATE ) { -sca_dump_rings (dev); -return 0 ; - } -#endif if (cmd !=SIOCWANDEV )return hdlc_ioctl (dev, ifr, cmd);
@@ -290,6 +294,7 @@ static const struct net_device_ops pc300_ops = { .ndo_stop = pc300_close, .ndo_start_xmit = hdlc_start_xmit, .ndo_do_ioctl = pc300_ioctl, + .ndo_siocdevprivate = pc300_siocdevprivate, }; static int pc300_pci_init_one(struct pci_dev *pdev,
drivers/net/wan/pci200syn.c +12 -7
@@ -177,7 +177,17 @@ static int pci200_close(struct net_device *dev)return 0 ; } - +static int pci200_siocdevprivate (struct net_device *dev,struct ifreq *ifr, +void __user *data,int cmd) +{ +#ifdef DEBUG_RINGS +if (cmd ==SIOCDEVPRIVATE ) { +sca_dump_rings (dev); +return 0 ; + } +#endif +return -EOPNOTSUPP ; +}static int pci200_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd) {
@@ -186,12 +196,6 @@ static int pci200_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)sync_serial_settings __user *line = ifr->ifr_settings.ifs_ifsu.sync;port_t *port =dev_to_port (dev); -#ifdef DEBUG_RINGS -if (cmd ==SIOCDEVPRIVATE ) { -sca_dump_rings (dev); -return 0 ; - } -#endif if (cmd !=SIOCWANDEV )return hdlc_ioctl (dev, ifr, cmd);
@@ -268,6 +272,7 @@ static const struct net_device_ops pci200_ops = { .ndo_stop = pci200_close, .ndo_start_xmit = hdlc_start_xmit, .ndo_do_ioctl = pci200_ioctl, + .ndo_siocdevprivate = pci200_siocdevprivate, }; static int pci200_pci_init_one(struct pci_dev *pdev,
drivers/net/wan/sbni.c +6 -6
@@ -119,7 +119,7 @@ static int sbni_open( struct net_device * );static int sbni_close (struct net_device * );static netdev_tx_t sbni_start_xmit (struct sk_buff *,struct net_device * ); -static int sbni_ioctl (struct net_device *,struct ifreq *,int ); +static int sbni_siocdevprivate (struct net_device *,struct ifreq *,void __user *,int );static void set_multicast_list (struct net_device * );static irqreturn_t sbni_interrupt (int ,void * );
@@ -211,7 +211,7 @@ static const struct net_device_ops sbni_netdev_ops = { .ndo_stop = sbni_close, .ndo_start_xmit = sbni_start_xmit, .ndo_set_rx_mode = set_multicast_list, - .ndo_do_ioctl = sbni_ioctl, + .ndo_siocdevprivate = sbni_siocdevprivate, .ndo_set_mac_address = eth_mac_addr, .ndo_validate_addr = eth_validate_addr, };
@@ -1297,7 +1297,7 @@ sbni_card_probe( unsigned long ioaddr )/* -------------------------------------------------------------------------- */ static int -sbni_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd ) +sbni_siocdevprivate (struct net_device *dev,struct ifreq *ifr,void __user *data,int cmd ) {struct net_local *nl =netdev_priv (dev);struct sbni_flags flags;
@@ -1310,7 +1310,7 @@ sbni_ioctl( struct net_device *dev, struct ifreq *ifr, int cmd )switch ( cmd ) {case SIOCDEVGETINSTATS : -if (copy_to_user ( ifr->ifr_data, &nl->in_stats, +if (copy_to_user (data, &nl->in_stats,sizeof (struct sbni_in_stats ) )) error = -EFAULT ;break ;
@@ -1328,7 +1328,7 @@ sbni_ioctl( struct net_device *dev, struct ifreq *ifr, int cmd ) flags.rxl = nl->cur_rxl_index; flags.fixed_rxl = nl->delta_rxl ==0 ; -if (copy_to_user ( ifr->ifr_data, &flags,sizeof flags )) +if (copy_to_user (data, &flags,sizeof flags )) error = -EFAULT ;break ;
@@ -1358,7 +1358,7 @@ sbni_ioctl( struct net_device *dev, struct ifreq *ifr, int cmd )if (!capable (CAP_NET_ADMIN ))return -EPERM ; -if (copy_from_user ( slave_name, ifr->ifr_data,sizeof slave_name )) +if (copy_from_user ( slave_name, data,sizeof slave_name ))return -EFAULT ; slave_dev =dev_get_by_name (&init_net, slave_name );if ( !slave_dev || !(slave_dev->flags &IFF_UP ) ) {
drivers/net/wan/sdla.c +4 -4
@@ -1245,7 +1245,7 @@ static int sdla_reconfig(struct net_device *dev)return 0 ; } -static int sdla_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd) +static int sdla_siocdevprivate (struct net_device *dev,struct ifreq *ifr,void __user *data,int cmd) {struct frad_local *flp;
@@ -1261,7 +1261,7 @@ static int sdla_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) {case FRAD_GET_CONF :case FRAD_SET_CONF : -return sdla_config (dev, ifr->ifr_data, cmd ==FRAD_GET_CONF ); +return sdla_config (dev, data, cmd ==FRAD_GET_CONF );case SDLA_IDENTIFY : ifr->ifr_flags = flp->type;
@@ -1298,7 +1298,7 @@ NOTE: This is rather a useless action right now, as thecase SDLA_READMEM :if (!capable (CAP_SYS_RAWIO ))return -EPERM ; -return sdla_xfer (dev, ifr->ifr_data, cmd ==SDLA_READMEM ); +return sdla_xfer (dev, data, cmd ==SDLA_READMEM );case SDLA_START :sdla_start (dev);
@@ -1586,7 +1586,7 @@ static int sdla_set_config(struct net_device *dev, struct ifmap *map)static const struct net_device_ops sdla_netdev_ops = { .ndo_open = sdla_open, .ndo_stop = sdla_close, - .ndo_do_ioctl = sdla_ioctl, + .ndo_siocdevprivate = sdla_siocdevprivate, .ndo_set_config = sdla_set_config, .ndo_start_xmit = sdla_transmit, .ndo_change_mtu = sdla_change_mtu,
Signature · 1 line
2.27.0
RFC 22/28 hamradio: use ndo_siocdevprivate
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
hamradio uses a set of private ioctls that do seem to work correctly in compat mode, as they only rely on the ifr_data pointer.
Move them over to the ndo_siocdevprivate callback as a cleanup.
--- drivers/net/hamradio/baycom_epp.c | 9 +++++---- drivers/net/hamradio/baycom_par.c | 12 ++++++------ drivers/net/hamradio/baycom_ser_fdx.c | 12 ++++++------ drivers/net/hamradio/baycom_ser_hdx.c | 12 ++++++------ drivers/net/hamradio/bpqether.c | 9 +++++---- drivers/net/hamradio/dmascc.c | 17 +++++++---------- drivers/net/hamradio/hdlcdrv.c | 20 +++++++++++--------- drivers/net/hamradio/scc.c | 13 ++++++++----- drivers/net/hamradio/yam.c | 13 ++++++------- include/linux/hdlcdrv.h | 2 +- 10 files changed, 61 insertions(+), 58 deletions(-)
drivers/net/hamradio/baycom_epp.c +5 -4
@@ -1005,7 +1005,8 @@ static int baycom_setmode(struct baycom_state *bc, const char *modestr)/* --------------------------------------------------------------------- */ -static int baycom_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd) +static int baycom_siocdevprivate (struct net_device *dev,struct ifreq *ifr, +void __user *data,int cmd) {struct baycom_state *bc =netdev_priv (dev);struct hdlcdrv_ioctl hi;
@@ -1013,7 +1014,7 @@ static int baycom_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)if (cmd !=SIOCDEVPRIVATE )return -ENOIOCTLCMD ; -if (copy_from_user (&hi, ifr->ifr_data,sizeof (hi))) +if (copy_from_user (&hi, data,sizeof (hi)))return -EFAULT ;switch (hi.cmd) {default :
@@ -1104,7 +1105,7 @@ static int baycom_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)return HDLCDRV_PARMASK_IOBASE ; } -if (copy_to_user (ifr->ifr_data, &hi,sizeof (hi))) +if (copy_to_user (data, &hi,sizeof (hi)))return -EFAULT ;return 0 ; }
@@ -1114,7 +1115,7 @@ static int baycom_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)static const struct net_device_ops baycom_netdev_ops = { .ndo_open = epp_open, .ndo_stop = epp_close, - .ndo_do_ioctl = baycom_ioctl, + .ndo_siocdevprivate = baycom_siocdevprivate, .ndo_start_xmit = baycom_send_packet, .ndo_set_mac_address = baycom_set_mac_address, };
drivers/net/hamradio/baycom_par.c +6 -6
@@ -380,7 +380,7 @@ static int par96_close(struct net_device *dev)* ===================== hdlcdrv driver interface ========================= */ -static int baycom_ioctl (struct net_device *dev,struct ifreq *ifr, +static int baycom_ioctl (struct net_device *dev,void __user *data,struct hdlcdrv_ioctl *hi,int cmd);/* --------------------------------------------------------------------- */
@@ -408,7 +408,7 @@ static int baycom_setmode(struct baycom_state *bc, const char *modestr)/* --------------------------------------------------------------------- */ -static int baycom_ioctl (struct net_device *dev,struct ifreq *ifr, +static int baycom_ioctl (struct net_device *dev,void __user *data,struct hdlcdrv_ioctl *hi,int cmd) {struct baycom_state *bc;
@@ -428,7 +428,7 @@ static int baycom_ioctl(struct net_device *dev, struct ifreq *ifr,case HDLCDRVCTL_GETMODE :strcpy (hi->data.modename, bc->options ?"par96" :"picpar" ); -if (copy_to_user (ifr->ifr_data, hi,sizeof (struct hdlcdrv_ioctl ))) +if (copy_to_user (data, hi,sizeof (struct hdlcdrv_ioctl )))return -EFAULT ;return 0 ;
@@ -440,7 +440,7 @@ static int baycom_ioctl(struct net_device *dev, struct ifreq *ifr,case HDLCDRVCTL_MODELIST :strcpy (hi->data.modename,"par96,picpar" ); -if (copy_to_user (ifr->ifr_data, hi,sizeof (struct hdlcdrv_ioctl ))) +if (copy_to_user (data, hi,sizeof (struct hdlcdrv_ioctl )))return -EFAULT ;return 0 ;
@@ -449,7 +449,7 @@ static int baycom_ioctl(struct net_device *dev, struct ifreq *ifr, } -if (copy_from_user (&bi, ifr->ifr_data,sizeof (bi))) +if (copy_from_user (&bi, data,sizeof (bi)))return -EFAULT ;switch (bi.cmd) {default :
@@ -464,7 +464,7 @@ static int baycom_ioctl(struct net_device *dev, struct ifreq *ifr,#endif /* BAYCOM_DEBUG */ } -if (copy_to_user (ifr->ifr_data, &bi,sizeof (bi))) +if (copy_to_user (data, &bi,sizeof (bi)))return -EFAULT ;return 0 ;
drivers/net/hamradio/baycom_ser_fdx.c +6 -6
@@ -462,7 +462,7 @@ static int ser12_close(struct net_device *dev)/* --------------------------------------------------------------------- */ -static int baycom_ioctl (struct net_device *dev,struct ifreq *ifr, +static int baycom_ioctl (struct net_device *dev,void __user *data,struct hdlcdrv_ioctl *hi,int cmd);/* --------------------------------------------------------------------- */
@@ -497,7 +497,7 @@ static int baycom_setmode(struct baycom_state *bc, const char *modestr)/* --------------------------------------------------------------------- */ -static int baycom_ioctl (struct net_device *dev,struct ifreq *ifr, +static int baycom_ioctl (struct net_device *dev,void __user *data,struct hdlcdrv_ioctl *hi,int cmd) {struct baycom_state *bc;
@@ -519,7 +519,7 @@ static int baycom_ioctl(struct net_device *dev, struct ifreq *ifr,sprintf (hi->data.modename,"ser%u" , bc->baud /100 );if (bc->opt_dcd <=0 )strcat (hi->data.modename, (!bc->opt_dcd) ?"*" :"+" ); -if (copy_to_user (ifr->ifr_data, hi,sizeof (struct hdlcdrv_ioctl ))) +if (copy_to_user (data, hi,sizeof (struct hdlcdrv_ioctl )))return -EFAULT ;return 0 ;
@@ -531,7 +531,7 @@ static int baycom_ioctl(struct net_device *dev, struct ifreq *ifr,case HDLCDRVCTL_MODELIST :strcpy (hi->data.modename,"ser12,ser3,ser24" ); -if (copy_to_user (ifr->ifr_data, hi,sizeof (struct hdlcdrv_ioctl ))) +if (copy_to_user (data, hi,sizeof (struct hdlcdrv_ioctl )))return -EFAULT ;return 0 ;
@@ -540,7 +540,7 @@ static int baycom_ioctl(struct net_device *dev, struct ifreq *ifr, } -if (copy_from_user (&bi, ifr->ifr_data,sizeof (bi))) +if (copy_from_user (&bi, data,sizeof (bi)))return -EFAULT ;switch (bi.cmd) {default :
@@ -555,7 +555,7 @@ static int baycom_ioctl(struct net_device *dev, struct ifreq *ifr,#endif /* BAYCOM_DEBUG */ } -if (copy_to_user (ifr->ifr_data, &bi,sizeof (bi))) +if (copy_to_user (data, &bi,sizeof (bi)))return -EFAULT ;return 0 ;
drivers/net/hamradio/baycom_ser_hdx.c +6 -6
@@ -521,7 +521,7 @@ static int ser12_close(struct net_device *dev)/* --------------------------------------------------------------------- */ -static int baycom_ioctl (struct net_device *dev,struct ifreq *ifr, +static int baycom_ioctl (struct net_device *dev,void __user *data,struct hdlcdrv_ioctl *hi,int cmd);/* --------------------------------------------------------------------- */
@@ -551,7 +551,7 @@ static int baycom_setmode(struct baycom_state *bc, const char *modestr)/* --------------------------------------------------------------------- */ -static int baycom_ioctl (struct net_device *dev,struct ifreq *ifr, +static int baycom_ioctl (struct net_device *dev,void __user *data,struct hdlcdrv_ioctl *hi,int cmd) {struct baycom_state *bc;
@@ -573,7 +573,7 @@ static int baycom_ioctl(struct net_device *dev, struct ifreq *ifr,strcpy (hi->data.modename,"ser12" );if (bc->opt_dcd <=0 )strcat (hi->data.modename, (!bc->opt_dcd) ?"*" : (bc->opt_dcd ==-2 ) ?"@" :"+" ); -if (copy_to_user (ifr->ifr_data, hi,sizeof (struct hdlcdrv_ioctl ))) +if (copy_to_user (data, hi,sizeof (struct hdlcdrv_ioctl )))return -EFAULT ;return 0 ;
@@ -585,7 +585,7 @@ static int baycom_ioctl(struct net_device *dev, struct ifreq *ifr,case HDLCDRVCTL_MODELIST :strcpy (hi->data.modename,"ser12" ); -if (copy_to_user (ifr->ifr_data, hi,sizeof (struct hdlcdrv_ioctl ))) +if (copy_to_user (data, hi,sizeof (struct hdlcdrv_ioctl )))return -EFAULT ;return 0 ;
@@ -594,7 +594,7 @@ static int baycom_ioctl(struct net_device *dev, struct ifreq *ifr, } -if (copy_from_user (&bi, ifr->ifr_data,sizeof (bi))) +if (copy_from_user (&bi, data,sizeof (bi)))return -EFAULT ;switch (bi.cmd) {default :
@@ -609,7 +609,7 @@ static int baycom_ioctl(struct net_device *dev, struct ifreq *ifr,#endif /* BAYCOM_DEBUG */ } -if (copy_to_user (ifr->ifr_data, &bi,sizeof (bi))) +if (copy_to_user (data, &bi,sizeof (bi)))return -EFAULT ;return 0 ;
drivers/net/hamradio/bpqether.c +5 -4
@@ -314,9 +314,10 @@ static int bpq_set_mac_address(struct net_device *dev, void *addr)* source ethernet address (broadcast * or multicast: accept all) */ -static int bpq_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd) +static int bpq_siocdevprivate (struct net_device *dev,struct ifreq *ifr, +void __user *data,int cmd) { -struct bpq_ethaddr __user *ethaddr = ifr->ifr_data; +struct bpq_ethaddr __user *ethaddr = data;struct bpqdev *bpq =netdev_priv (dev);struct bpq_req req;
@@ -325,7 +326,7 @@ static int bpq_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)switch (cmd) {case SIOCSBPQETHOPT : -if (copy_from_user (&req, ifr->ifr_data,sizeof (struct bpq_req ))) +if (copy_from_user (&req, data,sizeof (struct bpq_req )))return -EFAULT ;switch (req.cmd) {case SIOCGBPQETHPARAM :
@@ -448,7 +449,7 @@ static const struct net_device_ops bpq_netdev_ops = { .ndo_stop = bpq_close, .ndo_start_xmit = bpq_xmit, .ndo_set_mac_address = bpq_set_mac_address, - .ndo_do_ioctl = bpq_ioctl, + .ndo_siocdevprivate = bpq_siocdevprivate, };static void bpq_setup (struct net_device *dev)
drivers/net/hamradio/dmascc.c +7 -10
@@ -225,7 +225,7 @@ static int read_scc_data(struct scc_priv *priv);static int scc_open (struct net_device *dev);static int scc_close (struct net_device *dev); -static int scc_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd); +static int scc_siocdevprivate (struct net_device *dev,struct ifreq *ifr,int cmd);static int scc_send_packet (struct sk_buff *skb,struct net_device *dev);static int scc_set_mac_address (struct net_device *dev,void *sa);
@@ -432,7 +432,7 @@ static const struct net_device_ops scc_netdev_ops = { .ndo_open = scc_open, .ndo_stop = scc_close, .ndo_start_xmit = scc_send_packet, - .ndo_do_ioctl = scc_ioctl, + .ndo_siocdevprivate = scc_siocdevprivate, .ndo_set_mac_address = scc_set_mac_address, };
@@ -881,15 +881,13 @@ static int scc_close(struct net_device *dev) } -static int scc_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd) +static int scc_siocdevprivate (struct net_device *dev,struct ifreq *ifr,void __user *data,int cmd) {struct scc_priv *priv = dev->ml_priv;switch (cmd) {case SIOCGSCCPARAM : -if (copy_to_user - (ifr->ifr_data, &priv->param, -sizeof (struct scc_param ))) +if (copy_to_user (data, &priv->param,sizeof (struct scc_param )))return -EFAULT ;return 0 ;case SIOCSSCCPARAM :
@@ -897,13 +895,12 @@ static int scc_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)return -EPERM ;if (netif_running (dev))return -EAGAIN ; -if (copy_from_user - (&priv->param, ifr->ifr_data, -sizeof (struct scc_param ))) +if (copy_from_user (&priv->param, data, +sizeof (struct scc_param )))return -EFAULT ;return 0 ;default : -return -EINVAL ; +return -EOPNOTSUPP ; } }
drivers/net/hamradio/hdlcdrv.c +11 -9
@@ -483,23 +483,25 @@ static int hdlcdrv_close(struct net_device *dev)/* --------------------------------------------------------------------- */ -static int hdlcdrv_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd) +static int hdlcdrv_siocdevprivate (struct net_device *dev,struct ifreq *ifr, +void __user *data,int cmd) {struct hdlcdrv_state *s =netdev_priv (dev);struct hdlcdrv_ioctl bi; -if (cmd !=SIOCDEVPRIVATE ) { -if (s->ops && s->ops->ioctl) -return s->ops->ioctl (dev, ifr, &bi, cmd); +if (cmd !=SIOCDEVPRIVATE )return -ENOIOCTLCMD ; - } -if (copy_from_user (&bi, ifr->ifr_data,sizeof (bi))) + +if (in_compat_syscall ())/* to be implemented */ +return -ENOIOCTLCMD ; + +if (copy_from_user (&bi, data,sizeof (bi)))return -EFAULT ;switch (bi.cmd) {default :if (s->ops && s->ops->ioctl) -return s->ops->ioctl (dev, ifr, &bi, cmd); +return s->ops->ioctl (dev, data, &bi, cmd);return -ENOIOCTLCMD ;case HDLCDRVCTL_GETCHANNELPAR :
@@ -605,7 +607,7 @@ static int hdlcdrv_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)break ; } -if (copy_to_user (ifr->ifr_data, &bi,sizeof (bi))) +if (copy_to_user (data, &bi,sizeof (bi)))return -EFAULT ;return 0 ;
@@ -617,7 +619,7 @@ static const struct net_device_ops hdlcdrv_netdev = { .ndo_open = hdlcdrv_open, .ndo_stop = hdlcdrv_close, .ndo_start_xmit = hdlcdrv_send_packet, - .ndo_do_ioctl = hdlcdrv_ioctl, + .ndo_siocdevprivate = hdlcdrv_siocdevprivate, .ndo_set_mac_address = hdlcdrv_set_mac_address, };
drivers/net/hamradio/scc.c +8 -5
@@ -210,7 +210,8 @@ static int scc_net_close(struct net_device *dev);static void scc_net_rx (struct scc_channel *scc,struct sk_buff *skb);static netdev_tx_t scc_net_tx (struct sk_buff *skb,struct net_device *dev); -static int scc_net_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd); +static int scc_net_siocdevprivate (struct net_device *dev,struct ifreq *ifr, +void __user *data,int cmd);static int scc_net_set_mac_address (struct net_device *dev,void *addr);static struct net_device_stats *scc_net_get_stats (struct net_device *dev);
@@ -1550,7 +1551,7 @@ static const struct net_device_ops scc_netdev_ops = { .ndo_start_xmit = scc_net_tx, .ndo_set_mac_address = scc_net_set_mac_address, .ndo_get_stats = scc_net_get_stats, - .ndo_do_ioctl = scc_net_ioctl, + .ndo_siocdevprivate = scc_net_siocdevprivate, };/* ----> Initialize device <----- */
@@ -1703,7 +1704,8 @@ static netdev_tx_t scc_net_tx(struct sk_buff *skb, struct net_device *dev)* SIOCSCCCAL - send calib. pattern arg: (struct scc_calibrate *) arg */ -static int scc_net_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd) +static int scc_net_siocdevprivate (struct net_device *dev, +struct ifreq *ifr,void __user *arg,int cmd) {struct scc_kiss_cmd kiss_cmd;struct scc_mem_config memcfg;
@@ -1712,8 +1714,6 @@ static int scc_net_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)struct scc_channel *scc = (struct scc_channel *) dev->ml_priv;int chan;unsigned char device_name[IFNAMSIZ ]; -void __user *arg = ifr->ifr_data; -if (!Driver_Initialized) {
@@ -1722,6 +1722,9 @@ static int scc_net_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)int found =1 ;if (!capable (CAP_SYS_RAWIO ))return -EPERM ; +if (in_compat_syscall ()) +return -EOPNOTSUPP ; +if (!arg)return -EFAULT ;if (Nchips >=SCC_MAXCHIPS )
drivers/net/hamradio/yam.c +6 -7
@@ -920,14 +920,14 @@ static int yam_close(struct net_device *dev)/* --------------------------------------------------------------------- */ -static int yam_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd) +static int yam_siocdevprivate (struct net_device *dev,struct ifreq *ifr,void __user *data,int cmd) {struct yam_port *yp =netdev_priv (dev);struct yamdrv_ioctl_cfg yi;struct yamdrv_ioctl_mcs *ym;int ioctl_cmd; -if (copy_from_user (&ioctl_cmd, ifr->ifr_data,sizeof (int ))) +if (copy_from_user (&ioctl_cmd, data,sizeof (int )))return -EFAULT ;if (yp->magic !=YAM_MAGIC )
@@ -947,8 +947,7 @@ static int yam_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)case SIOCYAMSMCS :if (netif_running (dev))return -EINVAL ;/* Cannot change this parameter when up */ - ym =memdup_user (ifr->ifr_data, -sizeof (struct yamdrv_ioctl_mcs )); + ym =memdup_user (data,sizeof (struct yamdrv_ioctl_mcs ));if (IS_ERR (ym))return PTR_ERR (ym);if (ym->cmd !=SIOCYAMSMCS )
@@ -965,7 +964,7 @@ static int yam_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)case SIOCYAMSCFG :if (!capable (CAP_SYS_RAWIO ))return -EPERM ; -if (copy_from_user (&yi, ifr->ifr_data,sizeof (struct yamdrv_ioctl_cfg ))) +if (copy_from_user (&yi, data,sizeof (struct yamdrv_ioctl_cfg )))return -EFAULT ;if (yi.cmd !=SIOCYAMSCFG )
@@ -1045,7 +1044,7 @@ static int yam_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) yi.cfg.txtail = yp->txtail; yi.cfg.persist = yp->pers; yi.cfg.slottime = yp->slot; -if (copy_to_user (ifr->ifr_data, &yi,sizeof (struct yamdrv_ioctl_cfg ))) +if (copy_to_user (data, &yi,sizeof (struct yamdrv_ioctl_cfg )))return -EFAULT ;break ;
@@ -1074,7 +1073,7 @@ static const struct net_device_ops yam_netdev_ops = { .ndo_open = yam_open, .ndo_stop = yam_close, .ndo_start_xmit = yam_send_packet, - .ndo_do_ioctl = yam_ioctl, + .ndo_siocdevprivate = yam_siocdevprivate, .ndo_set_mac_address = yam_set_mac_address, };
include/linux/hdlcdrv.h +1 -1
@@ -79,7 +79,7 @@ struct hdlcdrv_ops {*/ int (*open)(struct net_device *);int (*close)(struct net_device *); -int (*ioctl)(struct net_device *,struct ifreq *, +int (*ioctl)(struct net_device *,void __user *,struct hdlcdrv_ioctl *,int ); };
Signature · 1 line
2.27.0
RFC 23/28 airo: use ndo_siocdevprivate
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
The airo driver overloads SIOCDEVPRIVATE ioctls with another set based on SIOCIWFIRSTPRIV. Only the first ones actually work (also in compat mode) as the others do not get passed down any more.
Change it over to ndo_siocdevprivate for clarification.
--- drivers/net/wireless/cisco/airo.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-)
drivers/net/wireless/cisco/airo.c +8 -7
@@ -1142,7 +1142,7 @@ static int waitbusy(struct airo_info *ai);static irqreturn_t airo_interrupt (int irq,void * dev_id);static int airo_thread (void *data);static void timer_func (struct net_device *dev); -static int airo_ioctl (struct net_device *dev,struct ifreq *rq,int cmd); +static int airo_siocdevprivate (struct net_device *dev,struct ifreq *rq,void __user *,int cmd);static struct iw_statistics *airo_get_wireless_stats (struct net_device *dev);static void airo_read_wireless_stats (struct airo_info *local);#ifdef CISCO_EXT
@@ -2668,7 +2668,7 @@ static const struct net_device_ops airo11_netdev_ops = { .ndo_start_xmit = airo_start_xmit11, .ndo_get_stats = airo_get_stats, .ndo_set_mac_address = airo_set_mac_address, - .ndo_do_ioctl = airo_ioctl, + .ndo_siocdevprivate = airo_siocdevprivate, };static void wifi_setup (struct net_device *dev)
@@ -2768,7 +2768,7 @@ static const struct net_device_ops airo_netdev_ops = { .ndo_get_stats = airo_get_stats, .ndo_set_rx_mode = airo_set_multicast_list, .ndo_set_mac_address = airo_set_mac_address, - .ndo_do_ioctl = airo_ioctl, + .ndo_siocdevprivate = airo_siocdevprivate, .ndo_validate_addr = eth_validate_addr, };
@@ -2779,7 +2779,7 @@ static const struct net_device_ops mpi_netdev_ops = { .ndo_get_stats = airo_get_stats, .ndo_set_rx_mode = airo_set_multicast_list, .ndo_set_mac_address = airo_set_mac_address, - .ndo_do_ioctl = airo_ioctl, + .ndo_siocdevprivate = airo_siocdevprivate, .ndo_validate_addr = eth_validate_addr, };
@@ -7650,7 +7650,8 @@ static const struct iw_handler_def airo_handler_def =* Javier Achirica did a great job of merging code from the unnamed CISCO * developer that added support for flashing the card. */ -static int airo_ioctl (struct net_device *dev,struct ifreq *rq,int cmd) +static int airo_siocdevprivate (struct net_device *dev,struct ifreq *rq, +void __user *data,int cmd) {int rc =0 ;struct airo_info *ai = dev->ml_priv;
@@ -7667,7 +7668,7 @@ static int airo_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) {int val =AIROMAGIC ;aironet_ioctl com; -if (copy_from_user (&com, rq->ifr_data,sizeof (com))) +if (copy_from_user (&com, data,sizeof (com))) rc = -EFAULT ;else if (copy_to_user (com.data, (char *)&val,sizeof (val))) rc = -EFAULT ;
@@ -7683,7 +7684,7 @@ static int airo_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)*/ {aironet_ioctl com; -if (copy_from_user (&com, rq->ifr_data,sizeof (com))) { +if (copy_from_user (&com, data,sizeof (com))) { rc = -EFAULT ;break ; }
Signature · 1 line
2.27.0
RFC 24/28 ip_tunnel: use ndo_siocdevprivate
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
The various ipv4 and ipv6 tunnel drivers each implement a set of 12 SIOCDEVPRIVATE commands for managing tunnels. These all work correctly in compat mode.
Move them over to the new .ndo_siocdevprivate operation.
--- include/net/ip_tunnels.h | 3 ++- net/ipv4/ip_gre.c | 2 +- net/ipv4/ip_tunnel.c | 9 +++++---- net/ipv4/ip_vti.c | 2 +- net/ipv4/ipip.c | 2 +- net/ipv6/ip6_gre.c | 16 ++++++++-------- net/ipv6/ip6_tunnel.c | 18 ++++++++++-------- net/ipv6/ip6_vti.c | 21 +++++++++++---------- net/ipv6/sit.c | 35 ++++++++++++++++++----------------- 9 files changed, 57 insertions(+), 51 deletions(-)
include/net/ip_tunnels.h +2 -1
@@ -270,7 +270,8 @@ void ip_tunnel_xmit(struct sk_buff *skb, struct net_device *dev,void ip_md_tunnel_xmit (struct sk_buff *skb,struct net_device *dev,const u8 proto,int tunnel_hlen);int ip_tunnel_ctl (struct net_device *dev,struct ip_tunnel_parm *p,int cmd); -int ip_tunnel_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd); +int ip_tunnel_siocdevprivate (struct net_device *dev,struct ifreq *ifr, +void __user *data,int cmd);int __ip_tunnel_change_mtu (struct net_device *dev,int new_mtu,bool strict);int ip_tunnel_change_mtu (struct net_device *dev,int new_mtu);
net/ipv4/ip_gre.c +1 -1
@@ -918,7 +918,7 @@ static const struct net_device_ops ipgre_netdev_ops = { .ndo_stop = ipgre_close, #endif .ndo_start_xmit = ipgre_xmit, - .ndo_do_ioctl = ip_tunnel_ioctl, + .ndo_siocdevprivate = ip_tunnel_siocdevprivate, .ndo_change_mtu = ip_tunnel_change_mtu, .ndo_get_stats64 = ip_tunnel_get_stats64, .ndo_get_iflink = ip_tunnel_get_iflink,
net/ipv4/ip_tunnel.c +5 -4
@@ -958,19 +958,20 @@ int ip_tunnel_ctl(struct net_device *dev, struct ip_tunnel_parm *p, int cmd) }EXPORT_SYMBOL_GPL (ip_tunnel_ctl); -int ip_tunnel_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd) +int ip_tunnel_siocdevprivate (struct net_device *dev,struct ifreq *ifr, +void __user *data,int cmd) {struct ip_tunnel_parm p;int err; -if (copy_from_user (&p, ifr->ifr_ifru.ifru_data,sizeof (p))) +if (copy_from_user (&p, data,sizeof (p)))return -EFAULT ; err = dev->netdev_ops->ndo_tunnel_ctl (dev, &p, cmd); -if (!err &©_to_user (ifr->ifr_ifru.ifru_data, &p,sizeof (p))) +if (!err &©_to_user (data, &p,sizeof (p)))return -EFAULT ;return err; } -EXPORT_SYMBOL_GPL (ip_tunnel_ioctl); +EXPORT_SYMBOL_GPL (ip_tunnel_siocdevprivate);int __ip_tunnel_change_mtu (struct net_device *dev,int new_mtu,bool strict) {
net/ipv4/ip_vti.c +1 -1
@@ -402,7 +402,7 @@ static const struct net_device_ops vti_netdev_ops = { .ndo_init = vti_tunnel_init, .ndo_uninit = ip_tunnel_uninit, .ndo_start_xmit = vti_tunnel_xmit, - .ndo_do_ioctl = ip_tunnel_ioctl, + .ndo_siocdevprivate = ip_tunnel_siocdevprivate, .ndo_change_mtu = ip_tunnel_change_mtu, .ndo_get_stats64 = ip_tunnel_get_stats64, .ndo_get_iflink = ip_tunnel_get_iflink,
net/ipv4/ipip.c +1 -1
@@ -345,7 +345,7 @@ static const struct net_device_ops ipip_netdev_ops = { .ndo_init = ipip_tunnel_init, .ndo_uninit = ip_tunnel_uninit, .ndo_start_xmit = ipip_tunnel_xmit, - .ndo_do_ioctl = ip_tunnel_ioctl, + .ndo_siocdevprivate = ip_tunnel_siocdevprivate, .ndo_change_mtu = ip_tunnel_change_mtu, .ndo_get_stats64 = ip_tunnel_get_stats64, .ndo_get_iflink = ip_tunnel_get_iflink,
net/ipv6/ip6_gre.c +8 -8
@@ -1235,8 +1235,8 @@ static void ip6gre_tnl_parm_to_user(struct ip6_tnl_parm2 *u,memcpy (u->name, p->name,sizeof (u->name)); } -static int ip6gre_tunnel_ioctl (struct net_device *dev, -struct ifreq *ifr,int cmd) +static int ip6gre_tunnel_siocdevprivate (struct net_device *dev, +struct ifreq *ifr,void __user *data,int cmd) {int err =0 ;struct ip6_tnl_parm2 p;
@@ -1250,7 +1250,7 @@ static int ip6gre_tunnel_ioctl(struct net_device *dev,switch (cmd) {case SIOCGETTUNNEL :if (dev == ign->fb_tunnel_dev) { -if (copy_from_user (&p, ifr->ifr_ifru.ifru_data,sizeof (p))) { +if (copy_from_user (&p, data,sizeof (p))) { err = -EFAULT ;break ; }
@@ -1261,7 +1261,7 @@ static int ip6gre_tunnel_ioctl(struct net_device *dev, }memset (&p,0 ,sizeof (p));ip6gre_tnl_parm_to_user (&p, &t->parms); -if (copy_to_user (ifr->ifr_ifru.ifru_data, &p,sizeof (p))) +if (copy_to_user (data, &p,sizeof (p))) err = -EFAULT ;break ;
@@ -1272,7 +1272,7 @@ static int ip6gre_tunnel_ioctl(struct net_device *dev, goto done; err = -EFAULT ; -if (copy_from_user (&p, ifr->ifr_ifru.ifru_data,sizeof (p))) +if (copy_from_user (&p, data,sizeof (p))) goto done; err = -EINVAL ;
@@ -1309,7 +1309,7 @@ static int ip6gre_tunnel_ioctl(struct net_device *dev,memset (&p,0 ,sizeof (p));ip6gre_tnl_parm_to_user (&p, &t->parms); -if (copy_to_user (ifr->ifr_ifru.ifru_data, &p,sizeof (p))) +if (copy_to_user (data, &p,sizeof (p))) err = -EFAULT ; }else err = (cmd ==SIOCADDTUNNEL ? -ENOBUFS : -ENOENT );
@@ -1322,7 +1322,7 @@ static int ip6gre_tunnel_ioctl(struct net_device *dev,if (dev == ign->fb_tunnel_dev) { err = -EFAULT ; -if (copy_from_user (&p, ifr->ifr_ifru.ifru_data,sizeof (p))) +if (copy_from_user (&p, data,sizeof (p))) goto done; err = -ENOENT ;ip6gre_tnl_parm_from_user (&p1, &p);
@@ -1389,7 +1389,7 @@ static const struct net_device_ops ip6gre_netdev_ops = { .ndo_init = ip6gre_tunnel_init, .ndo_uninit = ip6gre_tunnel_uninit, .ndo_start_xmit = ip6gre_tunnel_xmit, - .ndo_do_ioctl = ip6gre_tunnel_ioctl, + .ndo_siocdevprivate = ip6gre_tunnel_siocdevprivate, .ndo_change_mtu = ip6_tnl_change_mtu, .ndo_get_stats64 = ip_tunnel_get_stats64, .ndo_get_iflink = ip6_tnl_get_iflink,
net/ipv6/ip6_tunnel.c +10 -8
@@ -1614,7 +1614,8 @@ ip6_tnl_parm_to_user(struct ip6_tnl_parm *u, const struct __ip6_tnl_parm *p)/** * ip6_tnl_ioctl - configure ipv6 tunnels from userspace * @dev: virtual device associated with tunnel -* @ifr: parameters passed from userspace +* @ifr: unused +* @data: parameters passed from userspace * @cmd: command to be performed * * Description:
@@ -1640,7 +1641,8 @@ ip6_tnl_parm_to_user(struct ip6_tnl_parm *u, const struct __ip6_tnl_parm *p)**/ static int -ip6_tnl_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd) +ip6_tnl_siocdevprivate (struct net_device *dev,struct ifreq *ifr, +void __user *data,int cmd) {int err =0 ;struct ip6_tnl_parm p;
@@ -1654,7 +1656,7 @@ ip6_tnl_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)switch (cmd) {case SIOCGETTUNNEL :if (dev == ip6n->fb_tnl_dev) { -if (copy_from_user (&p, ifr->ifr_ifru.ifru_data,sizeof (p))) { +if (copy_from_user (&p, data,sizeof (p))) { err = -EFAULT ;break ; }
@@ -1666,7 +1668,7 @@ ip6_tnl_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)memset (&p,0 ,sizeof (p)); }ip6_tnl_parm_to_user (&p, &t->parms); -if (copy_to_user (ifr->ifr_ifru.ifru_data, &p,sizeof (p))) { +if (copy_to_user (data, &p,sizeof (p))) { err = -EFAULT ; }break ;
@@ -1676,7 +1678,7 @@ ip6_tnl_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)if (!ns_capable (net->user_ns,CAP_NET_ADMIN ))break ; err = -EFAULT ; -if (copy_from_user (&p, ifr->ifr_ifru.ifru_data,sizeof (p))) +if (copy_from_user (&p, data,sizeof (p)))break ; err = -EINVAL ; if (p.proto != IPPROTO_IPV6 && p.proto != IPPROTO_IPIP &&
@@ -1700,7 +1702,7 @@ ip6_tnl_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)if (!IS_ERR (t)) { err =0 ;ip6_tnl_parm_to_user (&p, &t->parms); -if (copy_to_user (ifr->ifr_ifru.ifru_data, &p,sizeof (p))) +if (copy_to_user (data, &p,sizeof (p))) err = -EFAULT ; }else {
@@ -1714,7 +1716,7 @@ ip6_tnl_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)if (dev == ip6n->fb_tnl_dev) { err = -EFAULT ; -if (copy_from_user (&p, ifr->ifr_ifru.ifru_data,sizeof (p))) +if (copy_from_user (&p, data,sizeof (p)))break ; err = -ENOENT ;ip6_tnl_parm_from_user (&p1, &p);
@@ -1833,7 +1835,7 @@ static const struct net_device_ops ip6_tnl_netdev_ops = { .ndo_init = ip6_tnl_dev_init, .ndo_uninit = ip6_tnl_dev_uninit, .ndo_start_xmit = ip6_tnl_start_xmit, - .ndo_do_ioctl = ip6_tnl_ioctl, + .ndo_siocdevprivate = ip6_tnl_siocdevprivate, .ndo_change_mtu = ip6_tnl_change_mtu, .ndo_get_stats = ip6_get_stats, .ndo_get_iflink = ip6_tnl_get_iflink,
net/ipv6/ip6_vti.c +11 -10
@@ -769,13 +769,14 @@ vti6_parm_to_user(struct ip6_tnl_parm2 *u, const struct __ip6_tnl_parm *p) }/** -* vti6_ioctl - configure vti6 tunnels from userspace +* vti6_siocdevprivate - configure vti6 tunnels from userspace * @dev: virtual device associated with tunnel -* @ifr: parameters passed from userspace +* @ifr: unused +* @data: parameters passed from userspace * @cmd: command to be performed * * Description: -* vti6_ioctl() is used for managing vti6 tunnels +* vti6_siocdevprivate() is used for managing vti6 tunnels * from userspace. * * The possible commands are the following:
@@ -796,7 +797,7 @@ vti6_parm_to_user(struct ip6_tnl_parm2 *u, const struct __ip6_tnl_parm *p)* %-ENODEV if attempting to change or delete a nonexisting device **/ static int -vti6_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd) +vti6_siocdevprivate (struct net_device *dev,struct ifreq *ifr,void __user *data,int cmd) {int err =0 ;struct ip6_tnl_parm2 p;
@@ -808,7 +809,7 @@ vti6_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)switch (cmd) {case SIOCGETTUNNEL :if (dev == ip6n->fb_tnl_dev) { -if (copy_from_user (&p, ifr->ifr_ifru.ifru_data,sizeof (p))) { +if (copy_from_user (&p, data,sizeof (p))) { err = -EFAULT ;break ; }
@@ -820,7 +821,7 @@ vti6_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)if (!t) t =netdev_priv (dev);vti6_parm_to_user (&p, &t->parms); -if (copy_to_user (ifr->ifr_ifru.ifru_data, &p,sizeof (p))) +if (copy_to_user (data, &p,sizeof (p))) err = -EFAULT ;break ;case SIOCADDTUNNEL :
@@ -829,7 +830,7 @@ vti6_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)if (!ns_capable (net->user_ns,CAP_NET_ADMIN ))break ; err = -EFAULT ; -if (copy_from_user (&p, ifr->ifr_ifru.ifru_data,sizeof (p))) +if (copy_from_user (&p, data,sizeof (p)))break ; err = -EINVAL ;if (p.proto !=IPPROTO_IPV6 && p.proto !=0 )
@@ -850,7 +851,7 @@ vti6_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)if (t) { err =0 ;vti6_parm_to_user (&p, &t->parms); -if (copy_to_user (ifr->ifr_ifru.ifru_data, &p,sizeof (p))) +if (copy_to_user (data, &p,sizeof (p))) err = -EFAULT ; }else
@@ -863,7 +864,7 @@ vti6_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)if (dev == ip6n->fb_tnl_dev) { err = -EFAULT ; -if (copy_from_user (&p, ifr->ifr_ifru.ifru_data,sizeof (p))) +if (copy_from_user (&p, data,sizeof (p)))break ; err = -ENOENT ;vti6_parm_from_user (&p1, &p);
@@ -888,7 +889,7 @@ static const struct net_device_ops vti6_netdev_ops = { .ndo_init = vti6_dev_init, .ndo_uninit = vti6_dev_uninit, .ndo_start_xmit = vti6_tnl_xmit, - .ndo_do_ioctl = vti6_ioctl, + .ndo_siocdevprivate = vti6_siocdevprivate, .ndo_get_stats64 = ip_tunnel_get_stats64, .ndo_get_iflink = ip6_tnl_get_iflink, };
net/ipv6/sit.c +18 -17
@@ -298,9 +298,8 @@ __ipip6_tunnel_locate_prl(struct ip_tunnel *t, __be32 addr) } -static int ipip6_tunnel_get_prl (struct net_device *dev,struct ifreq *ifr) +static int ipip6_tunnel_get_prl (struct net_device *dev,struct ip_tunnel_prl __user *a) { -struct ip_tunnel_prl __user *a = ifr->ifr_ifru.ifru_data;struct ip_tunnel *t =netdev_priv (dev);struct ip_tunnel_prl kprl, *kp;struct ip_tunnel_prl_entry *prl;
@@ -452,8 +451,8 @@ ipip6_tunnel_del_prl(struct ip_tunnel *t, struct ip_tunnel_prl *a)return err; } -static int ipip6_tunnel_prl_ctl (struct net_device *dev,struct ifreq *ifr, -int cmd) +static int ipip6_tunnel_prl_ctl (struct net_device *dev, +struct ip_tunnel_prl __user *data,int cmd) {struct ip_tunnel *t =netdev_priv (dev);struct ip_tunnel_prl prl;
@@ -464,7 +463,7 @@ static int ipip6_tunnel_prl_ctl(struct net_device *dev, struct ifreq *ifr,if (dev ==dev_to_sit_net (dev)->fb_tunnel_dev)return -EINVAL ; -if (copy_from_user (&prl, ifr->ifr_ifru.ifru_data,sizeof (prl))) +if (copy_from_user (&prl, data,sizeof (prl)))return -EFAULT ;switch (cmd) {
@@ -1193,14 +1192,14 @@ static int ipip6_tunnel_update_6rd(struct ip_tunnel *t, }static int -ipip6_tunnel_get6rd (struct net_device *dev,struct ifreq *ifr) +ipip6_tunnel_get6rd (struct net_device *dev,struct ip_tunnel_parm __user *data) {struct ip_tunnel *t =netdev_priv (dev);struct ip_tunnel_6rd ip6rd;struct ip_tunnel_parm p;if (dev ==dev_to_sit_net (dev)->fb_tunnel_dev) { -if (copy_from_user (&p, ifr->ifr_ifru.ifru_data,sizeof (p))) +if (copy_from_user (&p, data,sizeof (p)))return -EFAULT ; t =ipip6_tunnel_locate (t->net, &p,0 ); }
@@ -1211,13 +1210,14 @@ ipip6_tunnel_get6rd(struct net_device *dev, struct ifreq *ifr) ip6rd.relay_prefix = t->ip6rd.relay_prefix; ip6rd.prefixlen = t->ip6rd.prefixlen; ip6rd.relay_prefixlen = t->ip6rd.relay_prefixlen; -if (copy_to_user (ifr->ifr_ifru.ifru_data, &ip6rd,sizeof (ip6rd))) +if (copy_to_user (data, &ip6rd,sizeof (ip6rd)))return -EFAULT ;return 0 ; }static int -ipip6_tunnel_6rdctl (struct net_device *dev,struct ifreq *ifr,int cmd) +ipip6_tunnel_6rdctl (struct net_device *dev,struct ip_tunnel_6rd __user *data, +int cmd) {struct ip_tunnel *t =netdev_priv (dev);struct ip_tunnel_6rd ip6rd;
@@ -1225,7 +1225,7 @@ ipip6_tunnel_6rdctl(struct net_device *dev, struct ifreq *ifr, int cmd)if (!ns_capable (t->net->user_ns,CAP_NET_ADMIN ))return -EPERM ; -if (copy_from_user (&ip6rd, ifr->ifr_ifru.ifru_data,sizeof (ip6rd))) +if (copy_from_user (&ip6rd, data,sizeof (ip6rd)))return -EFAULT ;if (cmd !=SIOCDEL6RD ) {
@@ -1364,27 +1364,28 @@ ipip6_tunnel_ctl(struct net_device *dev, struct ip_tunnel_parm *p, int cmd) }static int -ipip6_tunnel_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd) +ipip6_tunnel_siocdevprivate (struct net_device *dev,struct ifreq *ifr, +void __user *data,int cmd) {switch (cmd) {case SIOCGETTUNNEL :case SIOCADDTUNNEL :case SIOCCHGTUNNEL :case SIOCDELTUNNEL : -return ip_tunnel_ioctl (dev, ifr, cmd); +return ip_tunnel_siocdevprivate (dev, ifr, data, cmd);case SIOCGETPRL : -return ipip6_tunnel_get_prl (dev, ifr); +return ipip6_tunnel_get_prl (dev, data);case SIOCADDPRL :case SIOCDELPRL :case SIOCCHGPRL : -return ipip6_tunnel_prl_ctl (dev, ifr, cmd); +return ipip6_tunnel_prl_ctl (dev, data, cmd);#ifdef CONFIG_IPV6_SIT_6RD case SIOCGET6RD : -return ipip6_tunnel_get6rd (dev, ifr); +return ipip6_tunnel_get6rd (dev, data);case SIOCADD6RD :case SIOCCHG6RD :case SIOCDEL6RD : -return ipip6_tunnel_6rdctl (dev, ifr, cmd); +return ipip6_tunnel_6rdctl (dev, data, cmd);#endif default :return -EINVAL ;
@@ -1395,7 +1396,7 @@ static const struct net_device_ops ipip6_netdev_ops = { .ndo_init = ipip6_tunnel_init, .ndo_uninit = ipip6_tunnel_uninit, .ndo_start_xmit = sit_tunnel_xmit, - .ndo_do_ioctl = ipip6_tunnel_ioctl, + .ndo_siocdevprivate = ipip6_tunnel_siocdevprivate, .ndo_get_stats64 = ip_tunnel_get_stats64, .ndo_get_iflink = ip_tunnel_get_iflink, .ndo_tunnel_ctl = ipip6_tunnel_ctl,
Signature · 1 line
2.27.0
RFC 25/28 hippi: use ndo_siocdevprivate
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
The rr_ioctl uses private ioctl commands that correctly pass all data through ifr_data, which works fine in compat mode.
Change it to use ndo_siocdevprivate as a cleanup.
--- drivers/net/hippi/rrunner.c | 11 ++++++----- drivers/net/hippi/rrunner.h | 3 ++- 2 files changed, 8 insertions(+), 6 deletions(-)
drivers/net/hippi/rrunner.c +6 -5
@@ -63,7 +63,7 @@ static const char version[] =static const struct net_device_ops rr_netdev_ops = { .ndo_open = rr_open, .ndo_stop = rr_close, - .ndo_do_ioctl = rr_ioctl, + .ndo_siocdevprivate = rr_siocdevprivate, .ndo_start_xmit = rr_start_xmit, .ndo_set_mac_address = hippi_mac_addr, };
@@ -1568,7 +1568,8 @@ static int rr_load_firmware(struct net_device *dev) } -static int rr_ioctl (struct net_device *dev,struct ifreq *rq,int cmd) +static int rr_siocdevprivate (struct net_device *dev,struct ifreq *rq, +void __user *data,int cmd) {struct rr_private *rrpriv;unsigned char *image, *oldimage;
@@ -1603,7 +1604,7 @@ static int rr_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) error = -EFAULT ; goto gf_out; } - error =copy_to_user (rq->ifr_data, image,EEPROM_BYTES ); + error =copy_to_user (data, image,EEPROM_BYTES );if (error) error = -EFAULT ; gf_out:
@@ -1615,7 +1616,7 @@ static int rr_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)return -EPERM ; } - image =memdup_user (rq->ifr_data,EEPROM_BYTES ); + image =memdup_user (data,EEPROM_BYTES );if (IS_ERR (image))return PTR_ERR (image);
@@ -1658,7 +1659,7 @@ static int rr_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)return error;case SIOCRRID : -return put_user (0x52523032 , (int __user *)rq->ifr_data); +return put_user (0x52523032 , (int __user *)data);default :return error; }
drivers/net/hippi/rrunner.h +2 -1
@@ -835,7 +835,8 @@ static int rr_open(struct net_device *dev);static netdev_tx_t rr_start_xmit (struct sk_buff *skb,struct net_device *dev);static int rr_close (struct net_device *dev); -static int rr_ioctl (struct net_device *dev,struct ifreq *rq,int cmd); +static int rr_siocdevprivate (struct net_device *dev,struct ifreq *rq, +void __user *data,int cmd); static unsigned int rr_read_eeprom(struct rr_private *rrpriv, unsigned long offset, unsigned char *buf,
Signature · 1 line
2.27.0
RFC 26/28 sb1000: use ndo_siocdevprivate
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
The private sb1000 ioctl commands all work correctly in compat mode. Change the to ndo_siocdevprivate as a cleanup.
--- drivers/net/sb1000.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-)
drivers/net/sb1000.c +11 -9
@@ -78,7 +78,8 @@ struct sb1000_private {/* prototypes for Linux interface */ extern int sb1000_probe (struct net_device *dev);static int sb1000_open (struct net_device *dev); -static int sb1000_dev_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd); +static int sb1000_siocdevprivate (struct net_device *dev,struct ifreq *ifr, +void __user *data,int cmd);static netdev_tx_t sb1000_start_xmit (struct sk_buff *skb,struct net_device *dev);static irqreturn_t sb1000_interrupt (int irq,void *dev_id);
@@ -135,7 +136,7 @@ MODULE_DEVICE_TABLE(pnp, sb1000_pnp_ids);static const struct net_device_ops sb1000_netdev_ops = { .ndo_open = sb1000_open, .ndo_start_xmit = sb1000_start_xmit, - .ndo_do_ioctl = sb1000_dev_ioctl, + .ndo_siocdevprivate = sb1000_siocdevprivate, .ndo_stop = sb1000_close, .ndo_set_mac_address = eth_mac_addr, .ndo_validate_addr = eth_validate_addr,
@@ -987,7 +988,8 @@ sb1000_open(struct net_device *dev)return 0 ;/* Always succeed */ } -static int sb1000_dev_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd) +static int sb1000_siocdevprivate (struct net_device *dev,struct ifreq *ifr, +void __user *data,int cmd) {char * name;unsigned char version[2 ];
@@ -1011,7 +1013,7 @@ static int sb1000_dev_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) stats[2 ] = dev->stats.rx_packets; stats[3 ] = dev->stats.rx_errors; stats[4 ] = dev->stats.rx_dropped; -if (copy_to_user (ifr->ifr_data, stats,sizeof (stats))) +if (copy_to_user (data, stats,sizeof (stats)))return -EFAULT ; status =0 ;break ;
@@ -1019,21 +1021,21 @@ static int sb1000_dev_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)case SIOCGCMFIRMWARE :/* get firmware version */ if ((status =sb1000_get_firmware_version (ioaddr, name, version,1 )))return status; -if (copy_to_user (ifr->ifr_data, version,sizeof (version))) +if (copy_to_user (data, version,sizeof (version)))return -EFAULT ;break ;case SIOCGCMFREQUENCY :/* get frequency */ if ((status =sb1000_get_frequency (ioaddr, name, &frequency)))return status; -if (put_user (frequency, (int __user *) ifr->ifr_data)) +if (put_user (frequency, (int __user *) data))return -EFAULT ;break ;case SIOCSCMFREQUENCY :/* set frequency */ if (!capable (CAP_NET_ADMIN ))return -EPERM ; -if (get_user (frequency, (int __user *) ifr->ifr_data)) +if (get_user (frequency, (int __user *) data))return -EFAULT ;if ((status =sb1000_set_frequency (ioaddr, name, frequency)))return status;
@@ -1042,14 +1044,14 @@ static int sb1000_dev_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)case SIOCGCMPIDS :/* get PIDs */ if ((status =sb1000_get_PIDs (ioaddr, name,PID )))return status; -if (copy_to_user (ifr->ifr_data,PID ,sizeof (PID ))) +if (copy_to_user (data,PID ,sizeof (PID )))return -EFAULT ;break ;case SIOCSCMPIDS :/* set PIDs */ if (!capable (CAP_NET_ADMIN ))return -EPERM ; -if (copy_from_user (PID , ifr->ifr_data,sizeof (PID ))) +if (copy_from_user (PID , data,sizeof (PID )))return -EFAULT ;if ((status =sb1000_set_PIDs (ioaddr, name,PID )))return status;
Signature · 1 line
2.27.0
RFC 27/28 ppp: use ndo_siocdevprivate
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
ppp has a custom statistics interface using SIOCDEVPRIVATE ioctl commands that works correctly in compat mode.
Convert it to use ndo_siocdevprivate as a cleanup.
--- drivers/net/ppp/ppp_generic.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/ppp/ppp_generic.c +3 -3
@@ -1342,11 +1342,11 @@ ppp_start_xmit(struct sk_buff *skb, struct net_device *dev) }static int -ppp_net_ioctl (struct net_device *dev,struct ifreq *ifr,int cmd) +ppp_net_siocdevprivate (struct net_device *dev,struct ifreq *ifr, +void __user *addr,int cmd) {struct ppp *ppp =netdev_priv (dev);int err = -EFAULT ; -void __user *addr = (void __user *) ifr->ifr_ifru.ifru_data;struct ppp_stats stats;struct ppp_comp_stats cstats;char *vers;
@@ -1454,7 +1454,7 @@ static const struct net_device_ops ppp_netdev_ops = { .ndo_init = ppp_dev_init, .ndo_uninit = ppp_dev_uninit, .ndo_start_xmit = ppp_start_xmit, - .ndo_do_ioctl = ppp_net_ioctl, + .ndo_siocdevprivate = ppp_net_siocdevprivate, .ndo_get_stats64 = ppp_get_stats64, };
Signature · 1 line
2.27.0
RFC 28/28 net: socket: return changed ifreq from SIOCDEVPRIVATE
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
Some drivers that use SIOCDEVPRIVATE ioctl commands modify the ifreq structure and expect it to be passed back to user space, which has never really happened for compat mode because the calling these drivers through ndo_do_ioctl requires overwriting the ifr_data pointer.
Now that all drivers are converted to ndo_siocdevprivate, change it to handle this correctly in both compat and native mode.
--- net/core/dev_ioctl.c | 4 +--- net/socket.c | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-)
net/core/dev_ioctl.c +1 -3
@@ -296,9 +296,7 @@ static int dev_siocdevprivate(struct net_device *dev, struct ifreq *ifr,return -ENODEV ; } -/* fall back to do_ioctl for drivers not yet converted */ - ifr->ifr_data = data; -return dev_do_ioctl (dev, ifr, cmd); +return -EOPNOTSUPP ; }/*
net/socket.c +1 -1
@@ -3206,7 +3206,7 @@ static int compat_sock_ioctl_trans(struct file *file, struct socket *sock,struct net *net =sock_net (sk);if (cmd >=SIOCDEVPRIVATE && cmd <= (SIOCDEVPRIVATE +15 )) -return compat_ifr_data_ioctl (net, cmd, argp); +return sock_ioctl (file, cmd, (unsigned long )argp);switch (cmd) {case SIOCSIFBR :
Signature · 1 line
2.27.0
Jakub Kicinski
maintainerQuoted 3 lines · On Fri, 6 Nov 2020 23:17:15 +0100 Arnd Bergmann wrote:
Any suggestions on how to proceed? I think the
ndo_siocdevprivatechange is the most interesting here, and I would like to get that merged.
Splitting out / eliminating ioctl pass-thry in general seems like a nice clean up. How did you get the ndo_eth_ioctl patch done, was it manual work?
Quoted 3 lines
For the wireless drivers, removing the old drivers instead of just the dead code might be an alternative, depending on whether anyone thinks there might still be users.
Dunno if you want to dig into removal with a series like this, anything using ioctls will be pretty old (with the exception of what you separated into ndo_eth_ioctl). You may get bogged down.
Quoted 9 lines · Jakub Kicinski
Quoted 3 lines · On Fri, 6 Nov 2020 23:17:15 +0100 Arnd Bergmann wrote:
Any suggestions on how to proceed? I think the
ndo_siocdevprivatechange is the most interesting here, and I would like to get that merged.Splitting out / eliminating ioctl pass-thry in general seems like a nice clean up. How did you get the
ndo_eth_ioctlpatch done, was it manual work?
I had done a fairly detailed manual search through all drivers with a .ndo_do_ioctl function to find the SIOCDEVPRIVATE users, based on a simple shell script. After I had converted all of those, I realized that 80% of the remaining ndo_do_ioctl users were in drivers/net/ethernet, implementing the same five commands, so I did a 'git grep -wl ndo_do_ioctl drivers/net/ethernet/ | sed -i "s:ndo_do_ioctl:ndo_eth_ioctl"' and converted the rest by hand.
FWIW, this is what remains afterwards:
$ git grep -w ndo_do_ioctl
Documentation/networking/netdevices.rst:ndo_do_ioctl:
drivers/char/pcmcia/synclink_cs.c: .ndo_do_ioctl = hdlcdev_ioctl,
drivers/net/appletalk/cops.c: .ndo_do_ioctl = cops_ioctl,
drivers/net/appletalk/ltpc.c: .ndo_do_ioctl = ltpc_ioctl,
drivers/net/bonding/bond_main.c: .ndo_do_ioctl = bond_do_ioctl,
drivers/net/wan/c101.c: .ndo_do_ioctl = c101_ioctl,
drivers/net/wan/cosa.c: .ndo_do_ioctl = cosa_net_ioctl,
drivers/net/wan/farsync.c: .ndo_do_ioctl = fst_ioctl,
drivers/net/wan/fsl_ucc_hdlc.c: .ndo_do_ioctl = uhdlc_ioctl,
drivers/net/wan/hdlc_fr.c: .ndo_do_ioctl = pvc_ioctl,
drivers/net/wan/hostess_sv11.c: .ndo_do_ioctl = hostess_ioctl,
drivers/net/wan/ixp4xx_hss.c: .ndo_do_ioctl = hss_hdlc_ioctl,
drivers/net/wan/lmc/lmc_main.c: .ndo_do_ioctl = lmc_ioctl,
drivers/net/wan/n2.c: .ndo_do_ioctl = n2_ioctl,
drivers/net/wan/pc300too.c: .ndo_do_ioctl = pc300_ioctl,
drivers/net/wan/pci200syn.c: .ndo_do_ioctl = pci200_ioctl,
drivers/net/wan/sealevel.c: .ndo_do_ioctl = sealevel_ioctl,
drivers/net/wan/wanxl.c: .ndo_do_ioctl = wanxl_ioctl,
drivers/tty/synclink.c: .ndo_do_ioctl = hdlcdev_ioctl,
drivers/tty/synclink_gt.c: .ndo_do_ioctl = hdlcdev_ioctl,
drivers/tty/synclinkmp.c: .ndo_do_ioctl = hdlcdev_ioctl,
include/linux/netdevice.h: * int (*ndo_do_ioctl)(struct net_device
*dev, struct ifreq *ifr, int cmd);
include/linux/netdevice.h: int
(*ndo_do_ioctl)(struct net_device *dev,
net/appletalk/aarp.c: if (!(ops->ndo_do_ioctl(iface->dev, &atreq,
SIOCSIFADDR))) {
net/appletalk/aarp.c: ops->ndo_do_ioctl(iface->dev, &atreq,
SIOCGIFADDR);
net/bridge/br_device.c: .ndo_do_ioctl = br_dev_ioctl,
net/core/dev_ioctl.c: if (ops->ndo_do_ioctl) {
net/core/dev_ioctl.c: return ops->ndo_do_ioctl(dev, ifr, cmd);
net/ieee802154/socket.c: if (dev->type == ARPHRD_IEEE802154 &&
dev->netdev_ops->ndo_do_ioctl)
net/ieee802154/socket.c: ret =
dev->netdev_ops->ndo_do_ioctl(dev, &ifr, cmd);
net/mac802154/iface.c: .ndo_do_ioctl = mac802154_wpan_ioctl,Quoted 8 lines
Quoted 3 lines
For the wireless drivers, removing the old drivers instead of just the dead code might be an alternative, depending on whether anyone thinks there might still be users.
Dunno if you want to dig into removal with a series like this, anything using ioctls will be pretty old (with the exception of what you separated into
ndo_eth_ioctl). You may get bogged down.
Ok
Arnd
Quoted 8 lines · Jakub Kicinski
Quoted 3 lines
For the wireless drivers, removing the old drivers instead of just the dead code might be an alternative, depending on whether anyone thinks there might still be users.
Dunno if you want to dig into removal with a series like this, anything using ioctls will be pretty old (with the exception of what you separated into
ndo_eth_ioctl). You may get bogged down.
I would very much like to get rid of unused ancient wireless drivers but the problem is that it's next to impossible to know if someone still uses a driver, or if the driver is even working. For example, few months back I suggested removing one driver which I thought to be completely unused (forgot already the name of the driver) and to my big surprise there was still a user, and he reported it working with a recent kernel release.
So I don't know what to do. Should we try adding a warning like below? :)
"This ancient driver will be removed from the kernel in 2022, but if
it still works send report to <...@...> to avoid the removal."
How do other subsystems handle ancient drivers?
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Quoted 8 lines · Kalle Valo
Jakub Kicinski <[email protected]> writes:
So I don't know what to do. Should we try adding a warning like below? :)
"This ancient driver will be removed from the kernel in 2022, but if
it still works send report to <...@...> to avoid the removal."How do other subsystems handle ancient drivers?
A good way to get everyone's attention would be to collect as many drivers as possible that are almost certainly unused and move them to drivers/staging/ with a warning like the above, as I just did for drivers/wimax. That would make it to the usual news outlets and lead to the remaining users (if any) noticing it so they can then ask for the drivers to be moved back -- or decide it's time to let go if the hardware can easily be replaced.
Arnd
Quoted 10 lines · Arnd Bergmann
Quoted 8 lines · Kalle Valo
Jakub Kicinski <[email protected]> writes:
So I don't know what to do. Should we try adding a warning like below? :)
"This ancient driver will be removed from the kernel in 2022, but if
it still works send report to <...@...> to avoid the removal."How do other subsystems handle ancient drivers?
Quoted 7 lines
A good way to get everyone's attention would be to collect as many drivers as possible that are almost certainly unused and move them to
drivers/staging/with a warning like the above, as I just did fordrivers/wimax. That would make it to the usual news outlets and lead to the remaining users (if any) noticing it so they can then ask for the drivers to be moved back -- or decide it's time to let go if the hardware can easily be replaced.
I like that. I think we first should make a list of drivers which we suspect are either unused or not working anymore.
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches