Skip to contentSkip to conversation

Fix typos

PATCH New Iulian Onofrei 4 participants 8 messages Aug 30, 2020 – Sep 1, 2020 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 Fix typos

From: Iulian Onofrei <[email protected]>

---
 package/libeXosip2/Config.in           | 4 ++--
 package/nvidia-driver/nvidia-driver.mk | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
package/libeXosip2/Config.in +2 -2
index 4cb8218f20..9fbe9789f8 100644
@@ -4,10 +4,10 @@ config BR2_PACKAGE_LIBEXOSIP2
 	select BR2_PACKAGE_LIBOSIP2
 	help
 	  eXosip is a library that hides the complexity of using the
-	  SIP protocol for mutlimedia session establishement.
+	  SIP protocol for multimedia session establishment.
 	  This protocol is mainly to be used by VoIP telephony
 	  applications (endpoints or conference server) but might be
-	  also usefull for any application that wish to establish
+	  also useful for any application that wish to establish
 	  sessions like multiplayer games.
 	  eXosip is based in libosip.
 
package/nvidia-driver/nvidia-driver.mk +2 -2
index baf2ba2be5..44e34cb7b4 100644
@@ -35,7 +35,7 @@ NVIDIA_DRIVER_PROVIDES += libgl libegl libgles
 # NVidia extensions (which is deemed bad now), while the former follows
 # the newly-introduced vendor-neutral "dispatching" API/ABI:
 #   https://github.com/aritger/linux-opengl-abi-proposal/blob/master/linux-opengl-abi-proposal.txt
-# However, this is not very usefull to us, as we don't support multiple
+# However, this is not very useful to us, as we don't support multiple
 # GL providers at the same time on the system, which this proposal is
 # aimed at supporting.
 #
@@ -84,7 +84,7 @@ endef
 # Those libraries are 'private' libraries requiring an agreement with
 # NVidia to develop code for those libs. There seems to be no restriction
 # on using those libraries (e.g. if the user has such an agreement, or
-# wants to run a third-party program developped under such an agreement).
+# wants to run a third-party program developed under such an agreement).
 ifeq ($(BR2_PACKAGE_NVIDIA_DRIVER_PRIVATE_LIBS),y)
 NVIDIA_DRIVER_LIBS += \
 	libnvidia-ifr.so.$(NVIDIA_DRIVER_VERSION) \
Signature · 1 line
2.24.3 (Apple Git-128)
#2 lore raw

PATCH 1/1 Fix typos

Hi Iulian,

Thank you for this patch. I wanted to apply this patch while fixing up the
comments below, but there's a fundamental problem...

Quoted 1 line · Iulian Onofrei via buildroot

From: Iulian Onofrei <[email protected]>

There must be a Signed-off-by line for yourself. This is a short way for you
to assert that you are entitled to contribute the patch under Buildroot's GPL license. See http://elinux.org/Developer_Certificate_Of_Origin
for more details.

If you don't have time to make proper patches according to my comments below,
you can just reply with the Signed-off-by line, and we can take it from there.

Quoted 4 lines
---
 package/libeXosip2/Config.in           | 4 ++--
 package/nvidia-driver/nvidia-driver.mk | 4 ++--

Please split into two patches, one per package. Also, the summary line should
include the package name. So:

package/libeXosip2: fix typo in help text
package/nvidia-driver: fix typo in comment

Thanks!

Regards,
Arnout

Quoted 42 lines
 2 files changed, 4 insertions(+), 4 deletions(-)
package/libeXosip2/Config.in +2 -2
index 4cb8218f20..9fbe9789f8 100644
@@ -4,10 +4,10 @@ config BR2_PACKAGE_LIBEXOSIP2
 	select BR2_PACKAGE_LIBOSIP2
 	help
 	  eXosip is a library that hides the complexity of using the
-	  SIP protocol for mutlimedia session establishement.
+	  SIP protocol for multimedia session establishment.
 	  This protocol is mainly to be used by VoIP telephony
 	  applications (endpoints or conference server) but might be
-	  also usefull for any application that wish to establish
+	  also useful for any application that wish to establish
 	  sessions like multiplayer games.
 	  eXosip is based in libosip.
 
package/nvidia-driver/nvidia-driver.mk +2 -2
index baf2ba2be5..44e34cb7b4 100644
@@ -35,7 +35,7 @@ NVIDIA_DRIVER_PROVIDES += libgl libegl libgles
 # NVidia extensions (which is deemed bad now), while the former follows
 # the newly-introduced vendor-neutral "dispatching" API/ABI:
 #   https://github.com/aritger/linux-opengl-abi-proposal/blob/master/linux-opengl-abi-proposal.txt
-# However, this is not very usefull to us, as we don't support multiple
+# However, this is not very useful to us, as we don't support multiple
 # GL providers at the same time on the system, which this proposal is
 # aimed at supporting.
 #
@@ -84,7 +84,7 @@ endef
 # Those libraries are 'private' libraries requiring an agreement with
 # NVidia to develop code for those libs. There seems to be no restriction
 # on using those libraries (e.g. if the user has such an agreement, or
-# wants to run a third-party program developped under such an agreement).
+# wants to run a third-party program developed under such an agreement).
 ifeq ($(BR2_PACKAGE_NVIDIA_DRIVER_PRIVATE_LIBS),y)
 NVIDIA_DRIVER_LIBS += \
 	libnvidia-ifr.so.$(NVIDIA_DRIVER_VERSION) \
#3 lore raw

PATCH 1/2 package/libeXosip2: fix typos in help text

In reply to Iulian Onofrei
---
 package/libeXosip2/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/libeXosip2/Config.in +2 -2
index 4cb8218f20..9fbe9789f8 100644
@@ -4,10 +4,10 @@ config BR2_PACKAGE_LIBEXOSIP2
 	select BR2_PACKAGE_LIBOSIP2
 	help
 	  eXosip is a library that hides the complexity of using the
-	  SIP protocol for mutlimedia session establishement.
+	  SIP protocol for multimedia session establishment.
 	  This protocol is mainly to be used by VoIP telephony
 	  applications (endpoints or conference server) but might be
-	  also usefull for any application that wish to establish
+	  also useful for any application that wish to establish
 	  sessions like multiplayer games.
 	  eXosip is based in libosip.
 
Signature · 1 line
2.24.3 (Apple Git-128)
#4 lore raw

PATCH 2/2 package/nvidia-driver: fix typos in comments

---
 package/nvidia-driver/nvidia-driver.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/nvidia-driver/nvidia-driver.mk +2 -2
index baf2ba2be5..44e34cb7b4 100644
@@ -35,7 +35,7 @@ NVIDIA_DRIVER_PROVIDES += libgl libegl libgles
 # NVidia extensions (which is deemed bad now), while the former follows
 # the newly-introduced vendor-neutral "dispatching" API/ABI:
 #   https://github.com/aritger/linux-opengl-abi-proposal/blob/master/linux-opengl-abi-proposal.txt
-# However, this is not very usefull to us, as we don't support multiple
+# However, this is not very useful to us, as we don't support multiple
 # GL providers at the same time on the system, which this proposal is
 # aimed at supporting.
 #
@@ -84,7 +84,7 @@ endef
 # Those libraries are 'private' libraries requiring an agreement with
 # NVidia to develop code for those libs. There seems to be no restriction
 # on using those libraries (e.g. if the user has such an agreement, or
-# wants to run a third-party program developped under such an agreement).
+# wants to run a third-party program developed under such an agreement).
 ifeq ($(BR2_PACKAGE_NVIDIA_DRIVER_PRIVATE_LIBS),y)
 NVIDIA_DRIVER_LIBS += \
 	libnvidia-ifr.so.$(NVIDIA_DRIVER_VERSION) \
Signature · 1 line
2.24.3 (Apple Git-128)
#5 lore raw

PATCH 2/2 package/nvidia-driver: fix typos in comments

Iulian, All,

On 2020-08-31 00:26 +0300, Iulian Onofrei spake thusly:

Quoted 1 line

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 29 lines
---
 package/nvidia-driver/nvidia-driver.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/nvidia-driver/nvidia-driver.mk +2 -2
index baf2ba2be5..44e34cb7b4 100644
@@ -35,7 +35,7 @@ NVIDIA_DRIVER_PROVIDES += libgl libegl libgles
 # NVidia extensions (which is deemed bad now), while the former follows
 # the newly-introduced vendor-neutral "dispatching" API/ABI:
 #   https://github.com/aritger/linux-opengl-abi-proposal/blob/master/linux-opengl-abi-proposal.txt
-# However, this is not very usefull to us, as we don't support multiple
+# However, this is not very useful to us, as we don't support multiple
 # GL providers at the same time on the system, which this proposal is
 # aimed at supporting.
 #
@@ -84,7 +84,7 @@ endef
 # Those libraries are 'private' libraries requiring an agreement with
 # NVidia to develop code for those libs. There seems to be no restriction
 # on using those libraries (e.g. if the user has such an agreement, or
-# wants to run a third-party program developped under such an agreement).
+# wants to run a third-party program developed under such an agreement).
 ifeq ($(BR2_PACKAGE_NVIDIA_DRIVER_PRIVATE_LIBS),y)
 NVIDIA_DRIVER_LIBS += \
 	libnvidia-ifr.so.$(NVIDIA_DRIVER_VERSION) \
Signature · 1 line
2.24.3 (Apple Git-128)
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'