Skip to contentSkip to conversation

package/python-xmodem: new package

PATCH New Marcin Niestroj 2 participants 4 messages Apr 30, 2020 – May 2, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/python-xmodem: new package

---
 DEVELOPERS                               |  1 +
 package/Config.in                        |  1 +
 package/python-xmodem/Config.in          |  6 ++++++
 package/python-xmodem/python-xmodem.hash |  3 +++
 package/python-xmodem/python-xmodem.mk   | 13 +++++++++++++
 5 files changed, 24 insertions(+)
 create mode 100644 package/python-xmodem/Config.in
 create mode 100644 package/python-xmodem/python-xmodem.hash
 create mode 100644 package/python-xmodem/python-xmodem.mk
DEVELOPERS +1 -0
index cc72b288be..8d4ad02a38 100644
@@ -1598,6 +1598,7 @@ F:	package/lua-stdlib/
 F:	package/luaossl/
 F:	package/murata-cyw-fw/
 F:	package/netdata/
+F:	package/python-xmodem/
 F:	package/rs485conf/
 F:	package/turbolua/
 F:	support/testing/tests/package/test_netdata.py
package/Config.in +1 -0
index 53c8ce0e29..49671993ed 100644
@@ -1213,6 +1213,7 @@ menu "External python modules"
 	source "package/python-xlutils/Config.in"
 	source "package/python-xlwt/Config.in"
 	source "package/python-xmltodict/Config.in"
+	source "package/python-xmodem/Config.in"
 	source "package/python-yarl/Config.in"
 	source "package/python-yieldfrom/Config.in"
 	source "package/python-zc-lockfile/Config.in"
package/python-xmodem/Config.in new file +6 -0
new file mode 100644
index 0000000000..ef927f1337
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_PYTHON_XMODEM
+	bool "python-xmodem"
+	help
+	  XMODEM protocol implementation.
+
+	  https://github.com/tehmaze/xmodem
package/python-xmodem/python-xmodem.hash new file +3 -0
new file mode 100644
index 0000000000..268fe30bf7
@@ -0,0 +1,3 @@
+# md5, sha256 from https://pypi.org/pypi/xmodem/json
+md5  f876cb35caf276b61990377710a3b4c4  xmodem-0.4.6.tar.gz
+sha256  089737298f5738eabc43f2519efdc80b402693768f16383f7013b9e6f8f279d7  xmodem-0.4.6.tar.gz
package/python-xmodem/python-xmodem.mk new file +13 -0
new file mode 100644
index 0000000000..a6ca46f857
@@ -0,0 +1,13 @@
+################################################################################
+#
+# python-xmodem
+#
+################################################################################
+
+PYTHON_XMODEM_VERSION = 0.4.6
+PYTHON_XMODEM_SOURCE = xmodem-$(PYTHON_XMODEM_VERSION).tar.gz
+PYTHON_XMODEM_SITE = https://files.pythonhosted.org/packages/29/5d/a20d7957f207fc4c4c143881ca7b9617ab7700c153012372ef0a934c7710
+PYTHON_XMODEM_SETUP_TYPE = setuptools
+PYTHON_XMODEM_LICENSE = MIT
+
+$(eval $(python-package))
Signature · 1 line
2.26.2
#1 lore raw

PATCH 1/1 package/python-xmodem: new package

Hi All!

The problem with this package is that there is no license file when we download from pypi. But there is one on github. Question is: what should we do about it?

Quoted 13 lines · Marcin Niestroj
---
 DEVELOPERS                               |  1 +
 package/Config.in                        |  1 +
 package/python-xmodem/Config.in          |  6 ++++++
 package/python-xmodem/python-xmodem.hash |  3 +++
 package/python-xmodem/python-xmodem.mk   | 13 +++++++++++++
 5 files changed, 24 insertions(+)
 create mode 100644 package/python-xmodem/Config.in
 create mode 100644 package/python-xmodem/python-xmodem.hash
 create mode 100644 package/python-xmodem/python-xmodem.mk

[snip]

Signature · 1 line
Marcin Niestr?j
#2 lore raw

PATCH 1/1 package/python-xmodem: new package

Hello,

Quoted 6 lines · Marcin Niestr?j

Hi All!

The problem with this package is that there is no license file when we download from pypi. But there is one on github. Question is: what should we do about it?

We already have some python packages which don't include the license on the tarball, although it exists in the repo.
Most of the times, it's because the maintainer of the package didn't add the license file in MANIFEST.in (which seems to be your case too). On those cases, PKG-INFO is mostly used, but it's not the preferred solution, so I suggest to send a PR for adding the license to MANIFEST.in
You can see an example from snmpclitools here:
https://github.com/etingof/snmpclitools/commit/d93597050f7e4708ce875cc47274c39a9e63da11

Quoted 15 lines
Quoted 12 lines · Marcin Niestroj
---
 DEVELOPERS                               |  1 +
 package/Config.in                        |  1 +
 package/python-xmodem/Config.in          |  6 ++++++
 package/python-xmodem/python-xmodem.hash |  3 +++
 package/python-xmodem/python-xmodem.mk   | 13 +++++++++++++
 5 files changed, 24 insertions(+)
 create mode 100644 package/python-xmodem/Config.in
 create mode 100644 package/python-xmodem/python-xmodem.hash
 create mode 100644 package/python-xmodem/python-xmodem.mk
Quoted 8 lines
Quoted 1 line

[snip]

--
Marcin Niestr?j
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Best regards,
Asaf.

#3 lore raw

PATCH 1/1 package/python-xmodem: new package

Hi Asaf,

Quoted 11 lines · Asaf Kahlon

Hello,

Quoted 6 lines · Marcin Niestr?j

Hi All!

The problem with this package is that there is no license file when we download from pypi. But there is one on github. Question is: what should we do about it?

Quoted 9 lines

We already have some python packages which don't include the license on the tarball, although it exists in the repo.
Most of the times, it's because the maintainer of the package didn't add the license file in MANIFEST.in (which seems to be your case too). On those cases, PKG-INFO is mostly used, but it's not the preferred solution, so I suggest to send a PR for adding the license to MANIFEST.in
You can see an example from snmpclitools here:
https://github.com/etingof/snmpclitools/commit/d93597050f7e4708ce875cc47274c39a9e63da11

Thanks for hints! If it takes reasonable time to merge, then I will post v2 with LICENSE. If not, then I will try PKG-INFO for the time before next package release.

Signature · 2 lines
Regards,
Marcin Niestr?j