Skip to contentSkip to conversation

package/thrift: disable qt for host build

PATCH New Fabrice Fontaine 3 participants 3 messages Mar 6, 2020 – Mar 15, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/thrift: disable qt for host build

host-thrift can fail if a broken Qt4 is found on host:

CMake Error in lib/cpp/CMakeLists.txt:
Imported target "Qt4::QtCore" includes non-existent path

"/nvmedata/autobuild/instance-4/output-1/host/usr/mkspecs/default"

in its INTERFACE_INCLUDE_DIRECTORIES. Possible reasons include:

* The path was deleted, renamed, or moved to another location.

* An install or uninstall procedure did not complete successfully.

* The installation package was faulty and references files it does not provide.

Fixes:
- http://autobuild.buildroot.org/results/57cad5313896c868e99b0b9534678f1c83a386f2

---
 package/thrift/thrift.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/thrift/thrift.mk +3 -1
index 6014bbfcdd..bef8bf6fac 100644
@@ -51,7 +51,9 @@ HOST_THRIFT_CONF_OPTS += -DTHRIFT_COMPILER_CSHARP=OFF \
 	-DTHRIFT_COMPILER_GO=OFF \
 	-DTHRIFT_COMPILER_D=OFF \
 	-DTHRIFT_COMPILER_LUA=OFF \
-	-DBUILD_C_GLIB=OFF
+	-DBUILD_C_GLIB=OFF \
+	-DWITH_QT4=OFF \
+	-DWITH_QT5=OFF
 
 # C bindings
 ifeq ($(BR2_PACKAGE_LIBGLIB2),y)
Signature · 1 line
2.25.0
#1 lore raw

PATCH 1/1 package/thrift: disable qt for host build

Hello Fabrice,

Quoted 29 lines · Fabrice Fontaine

host-thrift can fail if a broken Qt4 is found on host:

CMake Error in lib/cpp/CMakeLists.txt:
Imported target "Qt4::QtCore" includes non-existent path

"/nvmedata/autobuild/instance-4/output-1/host/usr/mkspecs/default"

in its INTERFACE_INCLUDE_DIRECTORIES. Possible reasons include:

* The path was deleted, renamed, or moved to another location.

* An install or uninstall procedure did not complete successfully.

* The installation package was faulty and references files it does not provide.

Fixes:
- http://autobuild.buildroot.org/results/57cad5313896c868e99b0b9534678f1c83a386f2

---
 package/thrift/thrift.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/thrift/thrift.mk +0 -0
index 6014bbfcdd..bef8bf6fac 100644

package/thrift/thrift.mk HOST_THRIFT_CONF_OPTS += -DTHRIFT_COMPILER_CSHARP=OFF \ · line 56

Quoted 7 lines
package/thrift/thrift.mk +3 -1
@@ -51,7 +51,9 @@ HOST_THRIFT_CONF_OPTS += -DTHRIFT_COMPILER_CSHARP=OFF \
 	-DTHRIFT_COMPILER_GO=OFF \
 	-DTHRIFT_COMPILER_D=OFF \
 	-DTHRIFT_COMPILER_LUA=OFF \
-	-DBUILD_C_GLIB=OFF
+	-DBUILD_C_GLIB=OFF \
+	-DWITH_QT4=OFF \
+	-DWITH_QT5=OFF

The option '-DWITH_QT5=OFF' should already be set by THRIFT_COMMON_CONF_OPTS, the option '-DWITH_QT4=OFF' should therefore go to THRIFT_COMMON_CONF_OPTS too...

Regards,
Peter

Quoted 3 lines
package/thrift/thrift.mk +0 -0
 # C bindings
 ifeq ($(BR2_PACKAGE_LIBGLIB2),y)
#2 lore raw

PATCH 1/1 package/thrift: disable qt for host build

In reply to Fabrice Fontaine
Quoted 14 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

host-thrift can fail if a broken Qt4 is found on host:
CMake Error in lib/cpp/CMakeLists.txt:
Imported target "Qt4::QtCore" includes non-existent path

"/nvmedata/autobuild/instance-4/output-1/host/usr/mkspecs/default"

in its INTERFACE_INCLUDE_DIRECTORIES. Possible reasons include:

* The path was deleted, renamed, or moved to another location.

* An install or uninstall procedure did not complete successfully.

Quoted 7 lines

* The installation package was faulty and references files it does not provide.

Fixes:
- http://autobuild.buildroot.org/results/57cad5313896c868e99b0b9534678f1c83a386f2

Committed to 2019.02.x and 2019.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard