Skip to contentSkip to conversation

package/busybox: fix S0{1sys, 2k}logd indentation

PATCH New Fabrice Fontaine 4 participants 5 messages Apr 15, 2019 – Apr 26, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/busybox: fix S0{1sys, 2k}logd indentation

---
 package/busybox/S01syslogd | 8 ++++----
 package/busybox/S02klogd   | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)
package/busybox/S01syslogd +4 -4
index 6e642a678a..15006bc06f 100644
@@ -44,12 +44,12 @@ restart() {
 }
 
 case "$1" in
-        start|stop|restart)
+	start|stop|restart)
 		"$1";;
 	reload)
 		# Restart, since there is no true "reload" feature.
 		restart;;
-        *)
-                echo "Usage: $0 {start|stop|restart|reload}"
-                exit 1
+	*)
+		echo "Usage: $0 {start|stop|restart|reload}"
+		exit 1
 esac
package/busybox/S02klogd +4 -4
index a4200cfb34..0677e1e5ca 100644
@@ -44,12 +44,12 @@ restart() {
 }
 
 case "$1" in
-        start|stop|restart)
+	start|stop|restart)
 		"$1";;
 	reload)
 		# Restart, since there is no true "reload" feature.
 		restart;;
-        *)
-                echo "Usage: $0 {start|stop|restart|reload}"
-                exit 1
+	*)
+		echo "Usage: $0 {start|stop|restart|reload}"
+		exit 1
 esac
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/busybox: fix S0{1sys, 2k}logd indentation

What?s wrong with the current indentation?

(Sorry for the top-posting. Answering from the phone).

Em 15 de abr de 2019, ?(s) 05:36, Fabrice Fontaine <[email protected]> escreveu:

Quoted 51 lines

---
package/busybox/S01syslogd | 8 ++++----
package/busybox/S02klogd | 8 ++++----

2 files changed, 8 insertions(+), 8 deletions(-)
package/busybox/S01syslogd +0 -0
index 6e642a678a..15006bc06f 100644
@@ -44,12 +44,12 @@ restart() {
 }
 

case "$1" in

package/busybox/S01syslogd +4 -4
-        start|stop|restart)
+    start|stop|restart)
       "$1";;
   reload)
       # Restart, since there is no true "reload" feature.
       restart;;
-        *)
-                echo "Usage: $0 {start|stop|restart|reload}"
-                exit 1
+    *)
+        echo "Usage: $0 {start|stop|restart|reload}"
+        exit 1

esac

package/busybox/S02klogd +0 -0
index a4200cfb34..0677e1e5ca 100644
@@ -44,12 +44,12 @@ restart() {
 }
 

case "$1" in

package/busybox/S02klogd +4 -4
-        start|stop|restart)
+    start|stop|restart)
       "$1";;
   reload)
       # Restart, since there is no true "reload" feature.
       restart;;
-        *)
-                echo "Usage: $0 {start|stop|restart|reload}"
-                exit 1
+    *)
+        echo "Usage: $0 {start|stop|restart|reload}"
+        exit 1

esac

Signature · 1 line
2.20.1
#2 lore raw

PATCH 1/1 package/busybox: fix S0{1sys, 2k}logd indentation

Hello Carlos,

Le lun. 15 avr. 2019 ? 12:36, Carlos Santos <[email protected]> a ?crit :

Quoted 2 lines

What?s wrong with the current indentation?

Current file indentation is mixing spaces with tabs. I removed spaces to use only tabs.

Quoted 48 lines

(Sorry for the top-posting. Answering from the phone).

Em 15 de abr de 2019, ?(s) 05:36, Fabrice Fontaine <[email protected]> escreveu:

Quoted 43 lines

---
package/busybox/S01syslogd | 8 ++++----
package/busybox/S02klogd | 8 ++++----

2 files changed, 8 insertions(+), 8 deletions(-)
package/busybox/S01syslogd +0 -0
index 6e642a678a..15006bc06f 100644
@@ -44,12 +44,12 @@ restart() {
 }
 

case "$1" in

package/busybox/S01syslogd +4 -4
-        start|stop|restart)
+    start|stop|restart)
       "$1";;
   reload)
       # Restart, since there is no true "reload" feature.
       restart;;
-        *)
-                echo "Usage: $0 {start|stop|restart|reload}"
-                exit 1
+    *)
+        echo "Usage: $0 {start|stop|restart|reload}"
+        exit 1

esac

package/busybox/S02klogd +0 -0
index a4200cfb34..0677e1e5ca 100644
@@ -44,12 +44,12 @@ restart() {
 }
 

case "$1" in

package/busybox/S02klogd +1 -3
-        start|stop|restart)
+    start|stop|restart)
       "$1";;
   reload)
       # Restart, since there is no true "reload" feature.
       restart;;
-        *)
-                echo "Usage: $0 {start|stop|restart|reload}"
Quoted 8 lines
Quoted 8 lines
package/busybox/S02klogd +3 -1
-                exit 1
+    *)
+        echo "Usage: $0 {start|stop|restart|reload}"
+        exit 1

esac
--
2.20.1

Best Regards,

Fabrice

#3 lore raw

PATCH 1/1 package/busybox: fix S0{1sys, 2k}logd indentation

In reply to Fabrice Fontaine
Quoted 1 line · Fabrice Fontaine

Applied to master, thanks.

Note that the other init scripts that were updated by Carlos have the same
issue (copy&paste, I guess):

package/rsyslog/S01rsyslogd
package/sysklogd/S01syslogd
package/sysklogd/S02klogd
package/syslog-ng/S01syslog-ng

Regards,
Arnout

Quoted 48 lines
---
 package/busybox/S01syslogd | 8 ++++----
 package/busybox/S02klogd   | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)
package/busybox/S01syslogd +4 -4
index 6e642a678a..15006bc06f 100644
@@ -44,12 +44,12 @@ restart() {
 }
 
 case "$1" in
-        start|stop|restart)
+	start|stop|restart)
 		"$1";;
 	reload)
 		# Restart, since there is no true "reload" feature.
 		restart;;
-        *)
-                echo "Usage: $0 {start|stop|restart|reload}"
-                exit 1
+	*)
+		echo "Usage: $0 {start|stop|restart|reload}"
+		exit 1
 esac
package/busybox/S02klogd +4 -4
index a4200cfb34..0677e1e5ca 100644
@@ -44,12 +44,12 @@ restart() {
 }
 
 case "$1" in
-        start|stop|restart)
+	start|stop|restart)
 		"$1";;
 	reload)
 		# Restart, since there is no true "reload" feature.
 		restart;;
-        *)
-                echo "Usage: $0 {start|stop|restart|reload}"
-                exit 1
+	*)
+		echo "Usage: $0 {start|stop|restart|reload}"
+		exit 1
 esac