Skip to contentSkip to conversation

tools: testing: selftests: Remove duplicate headers

PATCH In review Souptick Joarder 2 participants 5 messages Feb 23, 2019 – Mar 6, 2019

Subsystems (12)
Networking Network drivers x86 VFS +8 more subsystems
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools: testing: selftests: Remove duplicate headers

Remove duplicate headers which are included twice.

---
 tools/testing/selftests/gpio/gpio-mockup-chardev.c          | 1 -
 tools/testing/selftests/net/udpgso.c                        | 1 -
 tools/testing/selftests/powerpc/pmu/ebb/fork_cleanup_test.c | 1 -
 tools/testing/selftests/proc/proc-self-syscall.c            | 1 -
 tools/testing/selftests/rseq/rseq.h                         | 1 -
 tools/testing/selftests/timers/skew_consistency.c           | 1 -
 tools/testing/selftests/x86/mpx-dig.c                       | 2 --
 7 files changed, 8 deletions(-)
tools/testing/selftests/gpio/gpio-mockup-chardev.c +0 -1
index aaa1e9f..d587c81 100644
@@ -12,7 +12,6 @@
 #include <unistd.h>
 #include <stdio.h>
 #include <stdlib.h>
-#include <stdio.h>
 #include <errno.h>
 #include <string.h>
 #include <fcntl.h>
tools/testing/selftests/net/udpgso.c +0 -1
index e279051..b8265ee 100644
@@ -17,7 +17,6 @@
 #include <stdbool.h>
 #include <stdlib.h>
 #include <stdio.h>
-#include <stdlib.h>
 #include <string.h>
 #include <sys/ioctl.h>
 #include <sys/socket.h>
tools/testing/selftests/powerpc/pmu/ebb/fork_cleanup_test.c +0 -1
index 167135b..af1b802 100644
@@ -11,7 +11,6 @@
 #include <sys/wait.h>
 #include <unistd.h>
 #include <setjmp.h>
-#include <signal.h>
 
 #include "ebb.h"
 
tools/testing/selftests/proc/proc-self-syscall.c +0 -1
index 5ab5f48..3a4fec3 100644
@@ -20,7 +20,6 @@
 #include <sys/stat.h>
 #include <fcntl.h>
 #include <errno.h>
-#include <unistd.h>
 #include <string.h>
 #include <stdio.h>
 
tools/testing/selftests/rseq/rseq.h +0 -1
index c72eb70..6c1126e7 100644
@@ -16,7 +16,6 @@
 #include <errno.h>
 #include <stdio.h>
 #include <stdlib.h>
-#include <sched.h>
 #include <linux/rseq.h>
 
 /*
tools/testing/selftests/timers/skew_consistency.c +0 -1
index 022b711..8066be9 100644
@@ -32,7 +32,6 @@
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <fcntl.h>
-#include <stdlib.h>
 #include <string.h>
 #include <sys/wait.h>
 #include "../kselftest.h"
tools/testing/selftests/x86/mpx-dig.c +0 -2
index c13607e..880fbf6 100644
@@ -8,9 +8,7 @@
 #include <unistd.h>
 #include <stdio.h>
 #include <errno.h>
-#include <sys/types.h>
 #include <sys/stat.h>
-#include <unistd.h>
 #include <sys/mman.h>
 #include <string.h>
 #include <fcntl.h>
Signature · 1 line
1.9.1
#1 lore raw
Quoted 5 lines · Souptick Joarder

Remove duplicate headers which are included twice.

---

...

Quoted 1 line
 tools/testing/selftests/powerpc/pmu/ebb/fork_cleanup_test.c | 1 -

I took this hunk via the powerpc tree.

tools/testing/selftests/powerpc/pmu/ebb/fork_cleanup_test.c line 15

Quoted 11 lines
tools/testing/selftests/powerpc/pmu/ebb/fork_cleanup_test.c +0 -1
index 167135b..af1b802 100644
@@ -11,7 +11,6 @@
 #include <sys/wait.h>
 #include <unistd.h>
 #include <setjmp.h>
-#include <signal.h>
 
 #include "ebb.h"

cheers

#2 lore raw
Quoted 11 lines · Michael Ellerman
Quoted 5 lines · Souptick Joarder

Remove duplicate headers which are included twice.

---

...

Quoted 1 line
 tools/testing/selftests/powerpc/pmu/ebb/fork_cleanup_test.c | 1 -

I took this hunk via the powerpc tree.

How about taking this entirely through a single tree ? or Shall I send these changes in different patches ?

Quoted 15 lines

tools/testing/selftests/powerpc/pmu/ebb/fork_cleanup_test.c line 15

Quoted 12 lines
tools/testing/selftests/powerpc/pmu/ebb/fork_cleanup_test.c +0 -1
index 167135b..af1b802 100644
@@ -11,7 +11,6 @@
 #include <sys/wait.h>
 #include <unistd.h>
 #include <setjmp.h>
-#include <signal.h>
 
 #include "ebb.h"

cheers

#3 lore raw
Quoted 9 lines · Souptick Joarder
Quoted 7 lines · Michael Ellerman
Quoted 5 lines · Souptick Joarder

Remove duplicate headers which are included twice.

---

Quoted 7 lines
Quoted 4 lines

...

Quoted 1 line
 tools/testing/selftests/powerpc/pmu/ebb/fork_cleanup_test.c | 1 -

I took this hunk via the powerpc tree.

How about taking this entirely through a single tree ? or Shall I send these changes in different patches ?

If no comment, can we get this patch in queue for 5.1 ?

Quoted 16 lines
Quoted 16 lines

tools/testing/selftests/powerpc/pmu/ebb/fork_cleanup_test.c line 15

Quoted 13 lines
tools/testing/selftests/powerpc/pmu/ebb/fork_cleanup_test.c +0 -1
index 167135b..af1b802 100644
@@ -11,7 +11,6 @@
 #include <sys/wait.h>
 #include <unistd.h>
 #include <setjmp.h>
-#include <signal.h>
 
 #include "ebb.h"

cheers

#4 lore raw
Quoted 12 lines · Souptick Joarder
Quoted 10 lines · Souptick Joarder
Quoted 8 lines · Michael Ellerman
Quoted 5 lines · Souptick Joarder

Remove duplicate headers which are included twice.

---

...

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
 tools/testing/selftests/powerpc/pmu/ebb/fork_cleanup_test.c | 1 -

I took this hunk via the powerpc tree.

How about taking this entirely through a single tree ? or Shall I send these changes in different patches ?

If no comment, can we get this patch in queue for 5.1 ?

I will drop this patch as we have submitted these changes in different patches. ( Except the one picked by Michael).

Quoted 17 lines
Quoted 17 lines
Quoted 17 lines
Quoted 8 lines
tools/testing/selftests/powerpc/pmu/ebb/fork_cleanup_test.c +0 -0
index 167135b..af1b802 100644

tools/testing/selftests/powerpc/pmu/ebb/fork_cleanup_test.c line 15

Quoted 6 lines
tools/testing/selftests/powerpc/pmu/ebb/fork_cleanup_test.c +0 -1
@@ -11,7 +11,6 @@
 #include <sys/wait.h>
 #include <unistd.h>
 #include <setjmp.h>
-#include <signal.h>
 
 #include "ebb.h"

cheers