Skip to contentSkip to conversation

clk: armada-xp: fix refcount leak in axp_clk_init()

PATCH Applied Yangtao Li 3 participants 3 messages Dec 26, 2018 – Dec 28, 2018

Subsystems (2)
Common clk Arm/Marvell Kirkwood and Armada 370, 375, 38x, 39x, XP, 3700, 7K/8K, CN9130 SoC support
lore
Share & tools
lore

Yangtao Li

author
#0 lore raw

PATCH 1/1 clk: armada-xp: fix refcount leak in axp_clk_init()

The of_find_compatible_node() returns a node pointer with refcount incremented, but there is the lack of use of the of_node_put() when done. Add the missing of_node_put() to release the refcount.

Signed-off-by Yangtao Li <[email protected]>
---
 drivers/clk/mvebu/armada-xp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/clk/mvebu/armada-xp.c +3 -1
index e8f03293ec83..fa1568279c23 100644
@@ -226,7 +226,9 @@ static void __init axp_clk_init(struct device_node *np)
 
 	mvebu_coreclk_setup(np, &axp_coreclks);
 
-	if (cgnp)
+	if (cgnp) {
 		mvebu_clk_gating_setup(cgnp, axp_gating_desc);
+		of_node_put(cgnp);
+	}
 }
 CLK_OF_DECLARE(axp_clk, "marvell,armada-xp-core-clock", axp_clk_init);
Signature · 1 line
2.17.0
maintainer Reviewed-by on v1 1/1
#1 lore raw

Hi Yangtao,

Quoted 3 lines · Yangtao Li

The of_find_compatible_node() returns a node pointer with refcount incremented, but there is the lack of use of the of_node_put() when done. Add the missing of_node_put() to release the refcount.

Reviewed-by Gregory CLEMENT <[email protected]>

Thanks,

Gregory

Quoted 24 lines
Signed-off-by Yangtao Li <[email protected]>
---
 drivers/clk/mvebu/armada-xp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/clk/mvebu/armada-xp.c +3 -1
index e8f03293ec83..fa1568279c23 100644
@@ -226,7 +226,9 @@ static void __init axp_clk_init(struct device_node *np)
 
 	mvebu_coreclk_setup(np, &axp_coreclks);
 
-	if (cgnp)
+	if (cgnp) {
 		mvebu_clk_gating_setup(cgnp, axp_gating_desc);
+		of_node_put(cgnp);
+	}
 }
 CLK_OF_DECLARE(axp_clk, "marvell,armada-xp-core-clock", axp_clk_init);
Signature · 1 line
2.17.0
Signature · 3 lines
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
maintainer Applied
#2 lore raw
In reply to Yangtao Li

Quoting Yangtao Li (2018-12-26 05:42:26)

Quoted 6 lines

The of_find_compatible_node() returns a node pointer with refcount incremented, but there is the lack of use of the of_node_put() when done. Add the missing of_node_put() to release the refcount.

Signed-off-by Yangtao Li <[email protected]>

---

Applied to clk-next