drm/i915/pm: Warn if rpm frequencies are not set
Subsystems (2)
PATCH 1/1 drm/i915/pm: Warn if rpm frequencies are not set
We do end up setting ring frequencies on a hardware which is not yet there wrt runtime pm enablement.
Instead of ending up in an endless loop iterating through frequencies if min and max frequencies are still set to zero, warn and bail out early.
--- drivers/gpu/drm/i915/intel_pm.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/gpu/drm/i915/intel_pm.c +5 -0
@@ -6918,6 +6918,11 @@ static void gen6_update_ring_freq(struct drm_i915_private *dev_priv)/* convert DDR frequency from units of 266.6MHz to bandwidth */ min_ring_freq =mult_frac (min_ring_freq,8 ,3 ); +if (WARN_ON (rps->min_freq ==0 || + rps->max_freq ==0 || + min_ring_freq ==0 )) +return ; + min_gpu_freq = rps->min_freq; max_gpu_freq = rps->max_freq;if (IS_GEN9_BC (dev_priv) ||IS_CANNONLAKE (dev_priv)) {
Signature · 6 lines
2.14.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Mika Kuoppala (2018-03-20 13:58:42)
Quoted 6 lines
We do end up setting ring frequencies on a hardware which is not yet there wrt runtime pm enablement.
Instead of ending up in an endless loop iterating through frequencies if min and max frequencies are still set to zero, warn and bail out early.
Hmm, if you are hitting this in practice, I
would just go with
if (rps->max_freq <= rps->min_freq)
return;
I'm sure we have warnings else where for invalid min/max freq.
Don't worry about min_ring_freq unless you have a document that says otherwise.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 10 lines · Chris Wilson
Quoting Mika Kuoppala (2018-03-20 13:58:42)
Quoted 6 lines
We do end up setting ring frequencies on a hardware which is not yet there wrt runtime pm enablement.
Instead of ending up in an endless loop iterating through frequencies if min and max frequencies are still set to zero, warn and bail out early.
Hmm, if you are hitting this in practice, I
would just go with
I did.
Quoted 3 lines
if (
rps->max_freq<=rps->min_freq)return;
Ok, this is enough to fix the loop..
Quoted 2 lines
I'm sure we have warnings else where for invalid min/max freq.
but I didn't bump into any of these.
Quoted 3 lines
Don't worry about
min_ring_frequnless you have a document that says otherwise.
Yeah, different story for that one.
-Mika
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/pm: Warn if rpm frequencies are not set
In reply to Mika Kuoppala== Series Details ==
== Series Details ==
Series: drm/i915/pm: Warn if rpm frequencies are not set
URL : https://patchwork.freedesktop.org/series/40281/
State : success
== Summary ==
Series 40281v1 drm/i915/pm: Warn if rpm frequencies are not set
https://patchwork.freedesktop.org/api/1.0/series/40281/revisions/1/mbox/
---- Known issues:
Test debugfs_test:
Subgroup read_all_entries:
incomplete -> PASS (fi-snb-2520m) fdo#103713
Test gem_exec_suspend:
Subgroup basic-s3:
incomplete -> PASS (fi-skl-6700k2) fdo#104108
Test gem_mmap_gtt:
Subgroup basic-small-bo-tiledx:
fail -> PASS (fi-gdg-551) fdo#102575
Test kms_chamelium:
Subgroup dp-crc-fast:
pass -> DMESG-FAIL (fi-kbl-7500u) fdo#103841fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
fi-bdw-5557u total:285 pass:264 dwarn:0 dfail:0 fail:0 skip:21 time:430s fi-bdw-gvtdvm total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:442s fi-blb-e6850 total:285 pass:220 dwarn:1 dfail:0 fail:0 skip:64 time:381s fi-bsw-n3050 total:285 pass:239 dwarn:0 dfail:0 fail:0 skip:46 time:535s fi-bwr-2160 total:285 pass:180 dwarn:0 dfail:0 fail:0 skip:105 time:297s fi-bxt-dsi total:285 pass:255 dwarn:0 dfail:0 fail:0 skip:30 time:513s fi-bxt-j4205 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:512s fi-byt-j1900 total:285 pass:250 dwarn:0 dfail:0 fail:0 skip:35 time:514s fi-byt-n2820 total:285 pass:246 dwarn:0 dfail:0 fail:0 skip:39 time:502s fi-cfl-8700k total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:414s fi-cfl-s2 total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:573s fi-cfl-u total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:509s fi-cnl-drrs total:285 pass:254 dwarn:3 dfail:0 fail:0 skip:28 time:519s fi-elk-e7500 total:285 pass:225 dwarn:1 dfail:0 fail:0 skip:59 time:425s fi-gdg-551 total:285 pass:177 dwarn:0 dfail:0 fail:0 skip:108 time:321s fi-glk-1 total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:533s fi-hsw-4770 total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:405s fi-ilk-650 total:285 pass:225 dwarn:0 dfail:0 fail:0 skip:60 time:423s fi-ivb-3520m total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:478s fi-ivb-3770 total:285 pass:252 dwarn:0 dfail:0 fail:0 skip:33 time:427s fi-kbl-7500u total:285 pass:259 dwarn:1 dfail:1 fail:0 skip:24 time:474s fi-kbl-7567u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:468s fi-kbl-r total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:513s fi-pnv-d510 total:285 pass:219 dwarn:1 dfail:0 fail:0 skip:65 time:660s fi-skl-6260u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:442s fi-skl-6600u total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:549s fi-skl-6700hq total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:545s fi-skl-6700k2 total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:506s fi-skl-6770hq total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:498s fi-skl-guc total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:429s fi-skl-gvtdvm total:285 pass:262 dwarn:0 dfail:0 fail:0 skip:23 time:442s fi-snb-2520m total:285 pass:245 dwarn:0 dfail:0 fail:0 skip:40 time:566s fi-snb-2600 total:285 pass:245 dwarn:0 dfail:0 fail:0 skip:40 time:401s
89008ad5a75e8a1a55db9d6eec9797eb914a6306 drm-tip: 2018y-03m-20d-10h-51m-36s UTC integration manifest 5989765c2838 drm/i915/pm: Warn if rpm frequencies are not set
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8415/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.IGT: warning for drm/i915/pm: Warn if rpm frequencies are not set
In reply to Mika Kuoppala== Series Details ==
== Series Details ==
Series: drm/i915/pm: Warn if rpm frequencies are not set
URL : https://patchwork.freedesktop.org/series/40281/
State : warning
== Summary ==
---- Possible new issues:
Test kms_mmio_vs_cs_flip:
Subgroup setcrtc_vs_cs_flip:
pass -> SKIP (shard-snb)---- Known issues:
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-c:
incomplete -> PASS (shard-hsw) fdo#103375
Test perf:
Subgroup polling:
fail -> PASS (shard-hsw) fdo#102252fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
shard-apl total:3478 pass:1814 dwarn:1 dfail:0 fail:7 skip:1655 time:12918s shard-hsw total:3478 pass:1768 dwarn:1 dfail:0 fail:1 skip:1707 time:11690s shard-snb total:3478 pass:1356 dwarn:1 dfail:0 fail:2 skip:2119 time:7123s
Blacklisted hosts:
shard-kbl total:3478 pass:1938 dwarn:1 dfail:0 fail:9 skip:1530 time:9846s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8415/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx