Skip to contentSkip to conversation

pulseaudio: remove the ConsoleKit module

PATCH New Baruch Siach 2 participants 3 messages Dec 19, 2017 – Dec 27, 2017

lore
Share & tools
lore

Baruch Siach

author
#0 lore raw

PATCH 1/1 pulseaudio: remove the ConsoleKit module

The ConsoleKit module is loaded by default from the default.pa configuration file, but its initialization fails because Buildroot has no ConsoleKit package yet. This breaks per-user pulseaudio daemon. The default.pa configuration load module-console-kit only when it exists. Remove module-console-kit to fix pulseaudio per-user startup.

Signed-off-by Baruch Siach <[email protected]>
---
 package/pulseaudio/pulseaudio.mk | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
package/pulseaudio/pulseaudio.mk +7 -1
index b021fc93a4dd..a30d5401bae2 100644
@@ -140,11 +140,17 @@ else
 PULSEAUDIO_CONF_OPTS += --disable-x11
 endif
 
+# ConsoleKit module init failure breaks user daemon startup
+define PULSEAUDIO_REMOVE_CONSOLE_KIT
+	rm -f $(TARGET_DIR)/usr/lib/pulse-$(PULSEAUDIO_VERSION)/modules/module-console-kit.so
+endef
+
 define PULSEAUDIO_REMOVE_VALA
 	rm -rf $(TARGET_DIR)/usr/share/vala
 endef
 
-PULSEAUDIO_POST_INSTALL_TARGET_HOOKS += PULSEAUDIO_REMOVE_VALA
+PULSEAUDIO_POST_INSTALL_TARGET_HOOKS += PULSEAUDIO_REMOVE_VALA \
+	PULSEAUDIO_REMOVE_CONSOLE_KIT
 
 ifeq ($(BR2_PACKAGE_PULSEAUDIO_DAEMON),y)
 define PULSEAUDIO_USERS
Signature · 1 line
2.15.1
#1 lore raw

PATCH 1/1 pulseaudio: remove the ConsoleKit module

Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

The ConsoleKit module is loaded by default from the default.pa configuration file, but its initialization fails because Buildroot has no ConsoleKit package yet. This breaks per-user pulseaudio daemon. The default.pa configuration load module-console-kit only when it exists. Remove module-console-kit to fix pulseaudio per-user startup.

Signed-off-by Baruch Siach <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 pulseaudio: remove the ConsoleKit module

In reply to Baruch Siach
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

The ConsoleKit module is loaded by default from the default.pa configuration file, but its initialization fails because Buildroot has no ConsoleKit package yet. This breaks per-user pulseaudio daemon. The default.pa configuration load module-console-kit only when it exists. Remove module-console-kit to fix pulseaudio per-user startup.

Signed-off-by Baruch Siach <[email protected]>

Committed to 2017.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard