Skip to contentSkip to conversation

linux: fix name of config variable

PATCH New Yann E. MORIN 3 participants 4 messages Jun 4, 2017 – Jun 8, 2017

lore
Share & tools
lore

Yann E. MORIN

author
#0 lore raw

PATCH 1/1 linux: fix name of config variable

In 4c10eedc1 (systemd: enable required kernel features), we added setting a few required kernel features to ensure systemd works.

However, there was a typo for one of the variables: CONFIG_TMPFS_XATTR was written as CONFIG_TMPFS_POSIX_XATTR, which does not exist (and never ever existed, at least not since 2.6.12)...

Fixes #9926.

Reported-by Michael Heinemann <[email protected]>
Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Maxime Hadjinlian <[email protected]>
Cc Eric Le Bihan <[email protected]>
Cc Michael Heinemann <[email protected]>
---
 linux/linux.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
linux/linux.mk +1 -1
index e387c7dd44..9da7e9bec1 100644
@@ -278,7 +278,7 @@ define LINUX_KCONFIG_FIXUP_CMDS
 		$(call KCONFIG_ENABLE_OPT,CONFIG_FHANDLE,$(@D)/.config)
 		$(call KCONFIG_ENABLE_OPT,CONFIG_AUTOFS4_FS,$(@D)/.config)
 		$(call KCONFIG_ENABLE_OPT,CONFIG_TMPFS_POSIX_ACL,$(@D)/.config)
-		$(call KCONFIG_ENABLE_OPT,CONFIG_TMPFS_POSIX_XATTR,$(@D)/.config))
+		$(call KCONFIG_ENABLE_OPT,CONFIG_TMPFS_XATTR,$(@D)/.config))
 	$(if $(BR2_PACKAGE_SMACK),
 		$(call KCONFIG_ENABLE_OPT,CONFIG_SECURITY,$(@D)/.config)
 		$(call KCONFIG_ENABLE_OPT,CONFIG_SECURITY_SMACK,$(@D)/.config)
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 linux: fix name of config variable

Hello,

Quoted 8 lines · Yann E. MORIN

In 4c10eedc1 (systemd: enable required kernel features), we added setting a few required kernel features to ensure systemd works.

However, there was a typo for one of the variables: CONFIG_TMPFS_XATTR was written as CONFIG_TMPFS_POSIX_XATTR, which does not exist (and never ever existed, at least not since 2.6.12)...

Fixes #9926.

The patch looks good, but I'm not sure why you say it fixes #9926. It has been noticed as part of the #9926 discussion, but to me it doesn't fix this bug.

Could you clarify?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 linux: fix name of config variable

Thomas, All,

On 2017-06-05 11:54 +0200, Thomas Petazzoni spake thusly:

Quoted 8 lines · Yann E. MORIN
Quoted 7 lines

In 4c10eedc1 (systemd: enable required kernel features), we added setting a few required kernel features to ensure systemd works.

However, there was a typo for one of the variables: CONFIG_TMPFS_XATTR was written as CONFIG_TMPFS_POSIX_XATTR, which does not exist (and never ever existed, at least not since 2.6.12)...

Quoted 7 lines
Quoted 1 line

Fixes #9926.

The patch looks good, but I'm not sure why you say it fixes #9926. It has been noticed as part of the #9926 discussion, but to me it doesn't fix this bug.

Could you clarify?

OK, I mis-read the comment in #9926. I does not fix it.

Still, the patch is meaningful on its own.

Can you just drop the "Fixes #9926" part before applying, please? ;-)

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 1/1 linux: fix name of config variable

In reply to Yann E. MORIN
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

In 4c10eedc1 (systemd: enable required kernel features), we added setting a few required kernel features to ensure systemd works.

However, there was a typo for one of the variables: CONFIG_TMPFS_XATTR was written as CONFIG_TMPFS_POSIX_XATTR, which does not exist (and never ever existed, at least not since 2.6.12)...

Fixes #9926.

Committed to master, 2017.05.x and 2017.02.x after dropping the reference to #9926, thanks.

Signature · 1 line
Bye, Peter Korsgaard