Skip to contentSkip to conversation

ARM: dts: orion5x: fix number of sata port for linkstation ls-gl

PATCH New Roger Shimizu 2 participants 4 messages Dec 1, 2016 – Dec 5, 2016 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: orion5x: fix number of sata port for linkstation ls-gl

Bug report from Debian [0] shows there's minor changed model of Linkstation LS-GL that uses the 2nd SATA port of the SoC. So it's necessary to enable two SATA ports, though for that specific model only the 2nd one is used.

[0] https://bugs.debian.org/845611

Fixes b1742ffa9ddb ("ARM: dts: orion5x: add device tree for buffalo linkstation ls-gl")
---
 arch/arm/boot/dts/orion5x-linkstation-lsgl.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/orion5x-linkstation-lsgl.dts +4 -0
index 1cf644b..51dc734 100644
@@ -82,6 +82,10 @@
 	gpios = <&gpio0 9 GPIO_ACTIVE_HIGH>;
 };
 
+&sata {
+	nr-ports = <2>;
+};
+
 &ehci1 {
 	status = "okay";
 };
Signature · 1 line
2.10.2
#1 lore raw

PATCH 1/1 ARM: dts: orion5x: fix number of sata port for linkstation ls-gl

[CC Arnd Bergmann]

Quoted 31 lines · Roger Shimizu

Bug report from Debian [0] shows there's minor changed model of Linkstation LS-GL that uses the 2nd SATA port of the SoC. So it's necessary to enable two SATA ports, though for that specific model only the 2nd one is used.

[0] https://bugs.debian.org/845611

Fixes b1742ffa9ddb ("ARM: dts: orion5x: add device tree for buffalo linkstation ls-gl")
---
 arch/arm/boot/dts/orion5x-linkstation-lsgl.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/orion5x-linkstation-lsgl.dts +4 -1
index 1cf644b..51dc734 100644
@@ -82,6 +82,10 @@
        gpios = <&gpio0 9 GPIO_ACTIVE_HIGH>;
 };
 
+&sata {
+       nr-ports = <2>;
+};
+
 &ehci1 {
        status = "okay";
 };
--
Quoted 2 lines

2.10.2

Is there any chance to get this simple fix into v4.9 or next v4.10? Thank you!

Signature · 2 lines
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 4096R/6C6ACD6417B3ACB1
#2 lore raw

PATCH 1/1 ARM: dts: orion5x: fix number of sata port for linkstation ls-gl

Hi Roger,

Quoted 26 lines · Roger Shimizu

[CC Arnd Bergmann]

Quoted 23 lines · Roger Shimizu

Bug report from Debian [0] shows there's minor changed model of Linkstation LS-GL that uses the 2nd SATA port of the SoC. So it's necessary to enable two SATA ports, though for that specific model only the 2nd one is used.

[0] https://bugs.debian.org/845611

Fixes b1742ffa9ddb ("ARM: dts: orion5x: add device tree for buffalo linkstation ls-gl")
---
 arch/arm/boot/dts/orion5x-linkstation-lsgl.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/orion5x-linkstation-lsgl.dts +0 -0
index 1cf644b..51dc734 100644
@@ -82,6 +82,10 @@
        gpios = <&gpio0 9 GPIO_ACTIVE_HIGH>;
 };
 
Quoted 13 lines
Quoted 10 lines
arch/arm/boot/dts/orion5x-linkstation-lsgl.dts +4 -1
+&sata {
+       nr-ports = <2>;
+};
+
 &ehci1 {
        status = "okay";
 };
--

2.10.2

Is there any chance to get this simple fix into v4.9 or next v4.10? Thank you!

I can apply it on mvebu/fixes and make a pull request. But I don't know if Arnd or Olof will get it.

Let's see ahow it goes.

Gregory

Quoted 3 lines
Signature · 2 lines
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 4096R/6C6ACD6417B3ACB1
Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#3 lore raw

PATCH 1/1 ARM: dts: orion5x: fix number of sata port for linkstation ls-gl

In reply to Roger Shimizu

Hi Roger,

Quoted 11 lines · Roger Shimizu

Bug report from Debian [0] shows there's minor changed model of Linkstation LS-GL that uses the 2nd SATA port of the SoC. So it's necessary to enable two SATA ports, though for that specific model only the 2nd one is used.

[0] https://bugs.debian.org/845611

Fixes b1742ffa9ddb ("ARM: dts: orion5x: add device tree for buffalo linkstation ls-gl")

Applied on mvebu/fixes

Thanks,

Gregory

Quoted 22 lines
---
 arch/arm/boot/dts/orion5x-linkstation-lsgl.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/orion5x-linkstation-lsgl.dts +4 -0
index 1cf644b..51dc734 100644
@@ -82,6 +82,10 @@
 	gpios = <&gpio0 9 GPIO_ACTIVE_HIGH>;
 };
 
+&sata {
+	nr-ports = <2>;
+};
+
 &ehci1 {
 	status = "okay";
 };
Signature · 1 line
2.10.2
Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com