ipw2200: select CFG80211_WEXT

RFC PATCH Applied Paul Bolle 3 participants 8 messages Dec 22, 2014 – Dec 24, 2014

Subsystems (3)

Networking Network drivers Networking drivers (wireless)

lore

Share & tools

lore

Paul Bolle

author

2014-12-22 18:10 UTC #0 lore raw

RFC PATCH 1/1 ipw2200: select CFG80211_WEXT

Commit 24a0aa212ee2 ("cfg80211: make WEXT compatibility unselectable") made it impossible to depend on CFG80211_WEXT. It does still allow to select that symbol. (Yes, the commit summary is confusing.)

So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver can be built again.

Signed-off-by Paul Bolle <[email protected]>

---
Johannes,

Building v3.19-rc1 for an outdated ThinkPad X41 left me without the ipw2200 driver. It turns out this trivial patch is all that's needed to make ipw2200 buildable again.

(A similar patch would be needed for the drivers behind Kconfig symbol HERMES. Ie, orinico and friends.)

I must admit that I do not fully understand your commit. (How was CFG80211_WEXT "marked for deprecation and removal for a little more than two years"?) There's some terminology confusion: what you call "select" I tend to call "set". Anyhow, your commit basically disables building ipw2200 (and apparently orinoco and friends)?

Was that your intention?

 drivers/net/wireless/ipw2x00/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

drivers/net/wireless/ipw2x00/Kconfig +2 -1

index 91c0cb3c368e..21de4fe6cf2d 100644
@@ -65,7 +65,8 @@ config IPW2100_DEBUG
 
 config IPW2200
 	tristate "Intel PRO/Wireless 2200BG and 2915ABG Network Connection"
-	depends on PCI && CFG80211 && CFG80211_WEXT
+	depends on PCI && CFG80211
+	select CFG80211_WEXT
 	select WIRELESS_EXT
 	select WEXT_SPY
 	select WEXT_PRIV

Signature · 1 line

2.1.0

Johannes Berg

maintainer

2014-12-22 19:13 UTC #1 lore raw

Quoted 34 lines · Paul Bolle

Commit 24a0aa212ee2 ("cfg80211: make WEXT compatibility unselectable") made it impossible to depend on CFG80211_WEXT. It does still allow to select that symbol. (Yes, the commit summary is confusing.)
So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver can be built again.
Signed-off-by Paul Bolle <[email protected]>
---
Johannes,
Building v3.19-rc1 for an outdated ThinkPad X41 left me without the ipw2200 driver. It turns out this trivial patch is all that's needed to make ipw2200 buildable again.
(A similar patch would be needed for the drivers behind Kconfig symbol HERMES. Ie, orinico and friends.)
I must admit that I do not fully understand your commit. (How was CFG80211_WEXT "marked for deprecation and removal for a little more than two years"?) There's some terminology confusion: what you call "select" I tend to call "set". Anyhow, your commit basically disables building ipw2200 (and apparently orinoco and friends)?
Was that your intention?
 drivers/net/wireless/ipw2x00/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/wireless/ipw2x00/Kconfig +0 -0
index 91c0cb3c368e..21de4fe6cf2d 100644

drivers/net/wireless/ipw2x00/Kconfig config IPW2100_DEBUG · line 70

Quoted 7 lines

drivers/net/wireless/ipw2x00/Kconfig +2 -1

@@ -65,7 +65,8 @@ config IPW2100_DEBUG
 
 config IPW2200
 	tristate "Intel PRO/Wireless 2200BG and 2915ABG Network Connection"
-	depends on PCI && CFG80211 && CFG80211_WEXT
+	depends on PCI && CFG80211
+	select CFG80211_WEXT
 	select WIRELESS_EXT

I didn't realize that this driver actually depended on this symbol - I had been under the impression that those would still use regular wext (WIRELESS_EXT) only.

So yeah - this makes sense. FWIW, by "selectable" I meant by the user.

johannes

Kalle Valo

2014-12-23 06:52 UTC #2 lore raw

In reply to Paul Bolle

Quoted 6 lines · Paul Bolle

Commit 24a0aa212ee2 ("cfg80211: make WEXT compatibility unselectable") made it impossible to depend on CFG80211_WEXT. It does still allow to select that symbol. (Yes, the commit summary is confusing.)
So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver can be built again.

I think the last sentence is a bit misleading (this isn't a compilation error, right?) and I would like to clarify it like this:

"So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver can be enabled in config again."

Does that look ok?

Signature · 1 line

Kalle Valo

Paul Bolle

author

2014-12-23 10:20 UTC #3 lore raw

Quoted 11 lines · Kalle Valo

Quoted 6 lines · Paul Bolle
Commit 24a0aa212ee2 ("cfg80211: make WEXT compatibility unselectable") made it impossible to depend on CFG80211_WEXT. It does still allow to select that symbol. (Yes, the commit summary is confusing.)
So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver can be built again.
I think the last sentence is a bit misleading (this isn't a compilation error, right?)

No, it's not a compilation error.

The reasoning here is that all code hidden behind a Kconfig symbol that cannot be set will, in practice, never be built. Sure, there are hoops one can jump through to try to bypass the generated .config, but no one should have to do that.

Quoted 6 lines

and I would like to clarify it like this:
"So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver can be enabled in config again."
Does that look ok?

I understand the confusion my text might cause, so I'm fine with your amendment.

Thanks,

Paul Bolle

Kalle Valo

2014-12-23 10:50 UTC #4 lore raw

Quoted 22 lines · Paul Bolle

Quoted 11 lines · Kalle Valo
Quoted 6 lines · Paul Bolle
Commit 24a0aa212ee2 ("cfg80211: make WEXT compatibility unselectable") made it impossible to depend on CFG80211_WEXT. It does still allow to select that symbol. (Yes, the commit summary is confusing.)
So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver can be built again.
I think the last sentence is a bit misleading (this isn't a compilation error, right?)
No, it's not a compilation error.
The reasoning here is that all code hidden behind a Kconfig symbol that cannot be set will, in practice, never be built. Sure, there are hoops one can jump through to try to bypass the generated .config, but no one should have to do that.
Quoted 2 lines
and I would like to clarify it like this:

Quoted 7 lines

Quoted 4 lines
"So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver can be enabled in config again."
Does that look ok?
I understand the confusion my text might cause, so I'm fine with your amendment.

Thanks for checking. I'll modify the commit log and apply it to wireless-drivers.git.

Signature · 1 line

Kalle Valo

Johannes Berg

maintainer

2014-12-23 10:28 UTC #5 lore raw

In reply to Paul Bolle

Quoted 11 lines · Paul Bolle

Commit 24a0aa212ee2 ("cfg80211: make WEXT compatibility unselectable") made it impossible to depend on CFG80211_WEXT. It does still allow to select that symbol. (Yes, the commit summary is confusing.)
So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver can be built again.
Signed-off-by Paul Bolle <[email protected]>
---
Johannes,

Quoted 6 lines

Building v3.19-rc1 for an outdated ThinkPad X41 left me without the ipw2200 driver. It turns out this trivial patch is all that's needed to make ipw2200 buildable again.
(A similar patch would be needed for the drivers behind Kconfig symbol HERMES. Ie, orinico and friends.)

Yeah, config HERMES needs the same change.

Kalle, do you want to take those through your tree, or should I fix it seeing that I introduced the bug in a sense?

johannes

Kalle Valo

2014-12-23 10:55 UTC #6 lore raw

Quoted 16 lines · Johannes Berg

Quoted 15 lines · Paul Bolle
Commit 24a0aa212ee2 ("cfg80211: make WEXT compatibility unselectable") made it impossible to depend on CFG80211_WEXT. It does still allow to select that symbol. (Yes, the commit summary is confusing.)
So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver can be built again.
Signed-off-by Paul Bolle <[email protected]>
---
Johannes,
Building v3.19-rc1 for an outdated ThinkPad X41 left me without the ipw2200 driver. It turns out this trivial patch is all that's needed to make ipw2200 buildable again.

Quoted 7 lines

Quoted 2 lines
(A similar patch would be needed for the drivers behind Kconfig symbol HERMES. Ie, orinico and friends.)
Yeah, config HERMES needs the same change.
Kalle, do you want to take those through your tree, or should I fix it seeing that I introduced the bug in a sense?

To keep things simple I would prefer to take this through wireless-drivers.git, if it's ok for you.

Signature · 1 line

Kalle Valo

Kalle Valo

Applied

2014-12-24 13:18 UTC #7 lore raw

In reply to Paul Bolle

Quoted 8 lines · Paul Bolle

Commit 24a0aa212ee2 ("cfg80211: make WEXT compatibility unselectable") made it impossible to depend on CFG80211_WEXT. It does still allow to select that symbol. (Yes, the commit summary is confusing.)
So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver can be built again.
Signed-off-by Paul Bolle <[email protected]>

Thanks, applied to wireless-drivers.git.

Signature · 1 line

Kalle Valo