Skip to contentSkip to conversation

hdparm: prevent package makefile from stripping the hdparm binary

PATCH New Thomas Petazzoni 3 participants 3 messages Jun 11, 2014

lore
Share & tools
lore

Thomas Petazzoni

author
#0 lore raw

PATCH 1/1 hdparm: prevent package makefile from stripping the hdparm binary

Packages shouldn't strip executables by themselves, so that Buildroot controls whether stripping should occur or not. This also fixes the build on Blackfin FLAT where stripping actually doesn't work because stripping FLAT binaries is not supported.

Fixes:

http://autobuild.buildroot.org/results/7d4/7d4e59c96928a06db5091235bf2eacf462ba8a21/

Signed-off-by Thomas Petazzoni <[email protected]>
---
 package/hdparm/hdparm.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/hdparm/hdparm.mk +2 -1
index 1a200fb..0ca3c39 100644
@@ -12,7 +12,8 @@ HDPARM_LICENSE_FILES = LICENSE.TXT
 define HDPARM_BUILD_CMDS
 	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) \
 		CFLAGS="$(TARGET_CFLAGS)" \
-		LDFLAGS="$(TARGET_LDFLAGS)"
+		LDFLAGS="$(TARGET_LDFLAGS)" \
+		STRIP=/bin/true
 endef
 
 define HDPARM_INSTALL_TARGET_CMDS
Signature · 1 line
2.0.0
#1 lore raw

PATCH 1/1 hdparm: prevent package makefile from stripping the hdparm binary

Thomas, All,

On 2014-06-11 22:46 +0200, Thomas Petazzoni spake thusly:

Quoted 10 lines

Packages shouldn't strip executables by themselves, so that Buildroot controls whether stripping should occur or not. This also fixes the build on Blackfin FLAT where stripping actually doesn't work because stripping FLAT binaries is not supported.

Fixes:

http://autobuild.buildroot.org/results/7d4/7d4e59c96928a06db5091235bf2eacf462ba8a21/

Signed-off-by Thomas Petazzoni <[email protected]>
Reviewed-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 25 lines
---
 package/hdparm/hdparm.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/hdparm/hdparm.mk +2 -1
index 1a200fb..0ca3c39 100644
@@ -12,7 +12,8 @@ HDPARM_LICENSE_FILES = LICENSE.TXT
 define HDPARM_BUILD_CMDS
 	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) \
 		CFLAGS="$(TARGET_CFLAGS)" \
-		LDFLAGS="$(TARGET_LDFLAGS)"
+		LDFLAGS="$(TARGET_LDFLAGS)" \
+		STRIP=/bin/true
 endef
 
 define HDPARM_INSTALL_TARGET_CMDS
Signature · 6 lines
2.0.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 hdparm: prevent package makefile from stripping the hdparm binary

In reply to Thomas Petazzoni
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Packages shouldn't strip executables by themselves, so that Buildroot controls whether stripping should occur or not. This also fixes the build on Blackfin FLAT where stripping actually doesn't work because stripping FLAT binaries is not supported.

Quoted 5 lines

Fixes:

http://autobuild.buildroot.org/results/7d4/7d4e59c96928a06db5091235bf2eacf462ba8a21/

Signed-off-by Thomas Petazzoni <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard