Skip to contentSkip to conversation

luajit: pass LDCONFIG=true to make sure dynamic library links are created

PATCH New Thomas Petazzoni 2 participants 2 messages Feb 26, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 luajit: pass LDCONFIG=true to make sure dynamic library links are created

To install its shared library, the luajit Makefile does:

        cd src && test -f $(FILE_SO) && \
          $(INSTALL_X) $(FILE_SO) $(INSTALL_DYN) && \
          $(LDCONFIG) $(INSTALL_LIB) && \
          $(SYMLINK) $(INSTALL_SONAME) $(INSTALL_SHORT1) && \
          $(SYMLINK) $(INSTALL_SONAME) $(INSTALL_SHORT2) || :

This means that if ldconfig doesn't work or isn't available on the system, it won't create the libluajit-5.1.so -> libluajit-5.1.so.5.2.0 symbolic link.

Not having this symbolic link prevents lua-ev from finding the shared version of the luajit library, and it fallbacks to using the libluajit.a static library. However, this static library is not built with -fPIC, so using it within a shared library doesn't work, and leads to build failures on architectures that really do want to have non-fPIC code into a shared library, such as x86-64.

By passing LDCONFIG=true during the installation steps of luajit, we ensure that the symbolic links are created, which allows lua-ev to detect the shared library properly, making everybody happy.

Investigation conducted with Samuel Martin. Thanks!

Fixes:

http://autobuild.buildroot.org/results/41c/41c8bb9cf91a86908a150dae27726136cb56f5b7/

---
 package/luajit/luajit.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/luajit/luajit.mk +2 -2
index 529d3c2..4122d0a 100644
@@ -48,11 +48,11 @@ define LUAJIT_BUILD_CMDS
 endef
 
 define LUAJIT_INSTALL_STAGING_CMDS
-	$(MAKE) PREFIX="/usr" DESTDIR="$(STAGING_DIR)" -C $(@D) install
+	$(MAKE) PREFIX="/usr" DESTDIR="$(STAGING_DIR)" LDCONFIG=true -C $(@D) install
 endef
 
 define LUAJIT_INSTALL_TARGET_CMDS
-	$(MAKE) PREFIX="/usr" DESTDIR="$(TARGET_DIR)" -C $(@D) install
+	$(MAKE) PREFIX="/usr" DESTDIR="$(TARGET_DIR)" LDCONFIG=true -C $(@D) install
 endef
 
 $(eval $(generic-package))
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 luajit: pass LDCONFIG=true to make sure dynamic library links are created

Quoted 24 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

To install its shared library, the luajit Makefile does:

        cd src && test -f $(FILE_SO) && \
          $(INSTALL_X) $(FILE_SO) $(INSTALL_DYN) && \
          $(LDCONFIG) $(INSTALL_LIB) && \
          $(SYMLINK) $(INSTALL_SONAME) $(INSTALL_SHORT1) && \
          $(SYMLINK) $(INSTALL_SONAME) $(INSTALL_SHORT2) || :

This means that if ldconfig doesn't work or isn't available on the system, it won't create the libluajit-5.1.so -> libluajit-5.1.so.5.2.0 symbolic link.

Not having this symbolic link prevents lua-ev from finding the shared version of the luajit library, and it fallbacks to using the libluajit.a static library. However, this static library is not built with -fPIC, so using it within a shared library doesn't work, and leads to build failures on architectures that really do want to have non-fPIC code into a shared library, such as x86-64.

By passing LDCONFIG=true during the installation steps of luajit, we ensure that the symbolic links are created, which allows lua-ev to detect the shared library properly, making everybody happy.

Quoted 7 lines

Investigation conducted with Samuel Martin. Thanks!

Fixes:

http://autobuild.buildroot.org/results/41c/41c8bb9cf91a86908a150dae27726136cb56f5b7/

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard