Skip to contentSkip to conversation

pipe: skip file_update_time on frozen fs

PATCH New Dmitry Monakhov 1 participant 1 message Nov 26, 2013 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pipe: skip file_update_time on frozen fs

Pipe has no data associated with fs so it is not good idea to block pipe_write() if FS is frozen, but we can not update file's time on such filesystem. Let's use same idea as we use in touch_atime().

https://bugzilla.kernel.org/show_bug.cgi?id=65701

---
 fs/pipe.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
fs/pipe.c +2 -1
index d2c45e1..a9acd9a 100644
@@ -663,10 +663,11 @@ out:
 		wake_up_interruptible_sync_poll(&pipe->wait, POLLIN | POLLRDNORM);
 		kill_fasync(&pipe->fasync_readers, SIGIO, POLL_IN);
 	}
-	if (ret > 0) {
+	if (ret > 0 && sb_start_write_trylock(file_inode(filp)->i_sb)) {
 		int err = file_update_time(filp);
 		if (err)
 			ret = err;
+		sb_end_write(file_inode(filp)->i_sb);
 	}
 	return ret;
 }
Signature · 1 line
1.7.1