Skip to contentSkip to conversation

omniorb: add COS Naming Service

PATCH Superseded Matt Weber 5 participants 13 messages Nov 12, 2013 – Nov 13, 2013

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Matt Weber

author
#0 lore raw

PATCH 1/1 omniorb: add COS Naming Service

---
 package/omniorb/Config.in  |    9 +++++++++
 package/omniorb/omniorb.mk |    8 ++++++++
 2 files changed, 17 insertions(+), 0 deletions(-)
package/omniorb/Config.in +9 -0
index 6326688..22527fc 100644
@@ -10,5 +10,14 @@ config BR2_PACKAGE_OMNIORB
 
 	  http://omniorb.sourceforge.net/
 
+if BR2_PACKAGE_OMNIORB
+
+config BR2_PACKAGE_OMNIORB_WITH_SERVICES
+        bool "COS Naming Service"
+        default y
+        help
+          omniORB COS Naming Service
+endif
+
 comment "omniORB needs a toolchain w/ C++"
 	depends on !BR2_INSTALL_LIBSTDCPP
package/omniorb/omniorb.mk +8 -0
index 490ff93..cad50f8 100644
@@ -24,6 +24,14 @@ OMNIORB_INSTALL_TARGET = YES
 OMNIORB_CONF_OPT += --disable-longdouble
 HOST_OMNIORB_CONF_OPT += --disable-longdouble
 
+define OMNIORB_ENABLE_SERVICES
+	$(SED) 's:SUBDIRS += lib:SUBDIRS += lib services:g' $(@D)/src/dir.mk
+endef
+
+ifeq ($(BR2_PACKAGE_OMNIORB_WITH_SERVICES),y)
+	OMNIORB_POST_CONFIGURE_HOOKS += OMNIORB_ENABLE_SERVICES
+endif
+
 # omniORB is not completely cross-compile friendly and has some
 # assumptions where a couple host tools must be built and then
 # used by the target build.  The host tools generate code from
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 omniorb: add COS Naming Service

Hi Matt,

Quoted 24 lines · Matt Weber

---

package/omniorb/Config.in  |    9 +++++++++
package/omniorb/omniorb.mk |    8 ++++++++
2 files changed, 17 insertions(+), 0 deletions(-)
package/omniorb/Config.in +9 -0
index 6326688..22527fc 100644
@@ -10,5 +10,14 @@ config BR2_PACKAGE_OMNIORB
 
 	  http://omniorb.sourceforge.net/
 
+if BR2_PACKAGE_OMNIORB
+
+config BR2_PACKAGE_OMNIORB_WITH_SERVICES
+        bool "COS Naming Service"
+        default y
+        help
+          omniORB COS Naming Service
+endif
+
Quoted 2 lines

comment "omniORB needs a toolchain w/ C++"
depends on !BR2_INSTALL_LIBSTDCPP

I think it makes more sense to keep this comment close to the config option it applies to, thus moving the new cos option below it. I know that many packages do not follow this, but I'm planning on fixing that...

Best regards,
Thomas

#2 lore raw

PATCH 1/1 omniorb: add COS Naming Service

Thomas De Schampheleire <[email protected]> wrote on 11/12/2013 02:54:50 PM:

Quoted 40 lines

From: Thomas De Schampheleire <[email protected]>
To: Matt Weber <[email protected]>, buildroot at busybox.net
Date: 11/12/2013 02:55 PM
Subject: Re: [Buildroot] [PATCH 1/1] omniorb: add COS Naming Service

Hi Matt,

Quoted 24 lines · Matt Weber

---

package/omniorb/Config.in  |    9 +++++++++
package/omniorb/omniorb.mk |    8 ++++++++
2 files changed, 17 insertions(+), 0 deletions(-)
package/omniorb/Config.in +9 -0
index 6326688..22527fc 100644
@@ -10,5 +10,14 @@ config BR2_PACKAGE_OMNIORB
 
     http://omniorb.sourceforge.net/
 
+if BR2_PACKAGE_OMNIORB
+
+config BR2_PACKAGE_OMNIORB_WITH_SERVICES
+        bool "COS Naming Service"
+        default y
+        help
+          omniORB COS Naming Service
+endif
+
Quoted 2 lines

comment "omniORB needs a toolchain w/ C++"
depends on !BR2_INSTALL_LIBSTDCPP

I think it makes more sense to keep this comment close to the config option it applies to, thus moving the new cos option below it. I know that many packages do not follow this, but I'm planning on fixing that...

Quoted 3 lines

Best regards,
Thomas

Sure that works. I noticed the indenting of the new cfg option doesn't seem
to happen in the menuconfig if I move that comment below the original package.
I'll have to dig into why that happens.

Thanks,
Matt

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20131112/c1fd93e8/attachment.html>

#3 lore raw

PATCH 1/1 omniorb: add COS Naming Service

In reply to Thomas De Schampheleire
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas De Schampheleire <[email protected]> writes:

Hi,

Quoted 8 lines
Quoted 8 lines
package/omniorb/Config.in +8 -0
+if BR2_PACKAGE_OMNIORB
+
+config BR2_PACKAGE_OMNIORB_WITH_SERVICES
+        bool "COS Naming Service"
+        default y
+        help
+          omniORB COS Naming Service
+endif
Quoted 8 lines
Quoted 3 lines

+
comment "omniORB needs a toolchain w/ C++"
depends on !BR2_INSTALL_LIBSTDCPP

I think it makes more sense to keep this comment close to the config option it applies to, thus moving the new cos option below it. I know that many packages do not follow this, but I'm planning on fixing that...

Careful, kconfig needs sub options to be directly under the main option, otherwise they don't get indented correctly in menuconfig, so your options are either:

- Comment before main option
- Comment after all the sub options

Signature · 1 line
Bye, Peter Korsgaard
#4 lore raw

PATCH 1/1 omniorb: add COS Naming Service

Peter Korsgaard <[email protected]> wrote on 11/12/2013 04:24:10 PM:

Quoted 8 lines

From: Peter Korsgaard <[email protected]>
To: Thomas De Schampheleire <[email protected]>
Cc: Matt Weber <[email protected]>, buildroot at busybox.net
Date: 11/12/2013 04:24 PM
Subject: Re: [PATCH 1/1] omniorb: add COS Naming Service Sent by: Peter Korsgaard <[email protected]>

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas De Schampheleire <[email protected]>

Quoted 20 lines · writes:

Hi,

Quoted 8 lines
Quoted 8 lines
package/omniorb/Config.in +8 -0
+if BR2_PACKAGE_OMNIORB
+
+config BR2_PACKAGE_OMNIORB_WITH_SERVICES
+        bool "COS Naming Service"
+        default y
+        help
+          omniORB COS Naming Service
+endif
Quoted 8 lines
Quoted 3 lines

+
comment "omniORB needs a toolchain w/ C++"
depends on !BR2_INSTALL_LIBSTDCPP

I think it makes more sense to keep this comment close to the config option it applies to, thus moving the new cos option below it. I know that many packages do not follow this, but I'm planning on fixing that...

Quoted 3 lines

Careful, kconfig needs sub options to be directly under the main option, otherwise they don't get indented correctly in menuconfig, so your options are either:

Thanks for the clarification, I was wondering if that was needed. I just tested moving it above and that seems to be more readable then below.

Thanks,
Matt
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20131112/bcb5fdd1/attachment.html>

#5 lore raw

PATCH 1/1 omniorb: add COS Naming Service

In reply to Peter Korsgaard
Quoted 21 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas De Schampheleire <[email protected]> writes:

Hi,

Quoted 8 lines
Quoted 8 lines
package/omniorb/Config.in +8 -0
+if BR2_PACKAGE_OMNIORB
+
+config BR2_PACKAGE_OMNIORB_WITH_SERVICES
+        bool "COS Naming Service"
+        default y
+        help
+          omniORB COS Naming Service
+endif
Quoted 8 lines
Quoted 3 lines

+
comment "omniORB needs a toolchain w/ C++"
depends on !BR2_INSTALL_LIBSTDCPP

I think it makes more sense to keep this comment close to the config option it applies to, thus moving the new cos option below it. I know that many packages do not follow this, but I'm planning on fixing that...

Quoted 7 lines

Careful, kconfig needs sub options to be directly under the main option, otherwise they don't get indented correctly in menuconfig, so your options are either:

- Comment before main option
- Comment after all the sub options

Yuk, that's a pity...
In this case my preference is to have the comment before the main option (so as close as possible), rather than after all sub options.

What is your opinion?

Thanks,
Thomas

#6 lore raw

PATCH 1/1 omniorb: add COS Naming Service

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas De Schampheleire <[email protected]> writes:

Hi,

Quoted 5 lines

Yuk, that's a pity...
In this case my preference is to have the comment before the main option (so as close as possible), rather than after all sub options.

What is your opinion?

I don't have a stong opion about it, but that's fine by me as well. For simple packages (most), it imho is a bit more logical to have it after the option though (and it's what we are currently doing most places).

Signature · 1 line
Bye, Peter Korsgaard
#7 lore raw

PATCH 1/1 omniorb: add COS Naming Service

Quoted 8 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas De Schampheleire <[email protected]> writes:

Hi,

Quoted 3 lines

Yuk, that's a pity...
In this case my preference is to have the comment before the main option (so as close as possible), rather than after all sub options.

Quoted 6 lines
Quoted 1 line

What is your opinion?

I don't have a stong opion about it, but that's fine by me as well. For simple packages (most), it imho is a bit more logical to have it after the option though (and it's what we are currently doing most places).

As long as there are no suboptions that is indeed more logical. However, when suboptions are added the comment moves down, and depending on where new suboptions are added this may not be apparent from the diff output alone. So one way is to use one 'rule' which would be the comment above, or we keep simple packages without suboptions with the comment below, and make sure the comment is moved to the top when suboptions are added. The first alternative is easier to maintain, but less beautiful for the simple packages without suboptions.

If I had to pick, I'd pick the first alternative, for easier maintainability and uniformity.

Best regards,
Thomas

#8 lore raw

PATCH 1/1 omniorb: add COS Naming Service

Thomas De Schampheleire <[email protected]> wrote on 11/13/2013 03:59:43 AM:

Quoted 8 lines

From: Thomas De Schampheleire <[email protected]>
To: Peter Korsgaard <[email protected]>
Cc: Matt Weber <[email protected]>, buildroot <[email protected]>
Date: 11/13/2013 03:59 AM
Subject: Re: [PATCH 1/1] omniorb: add COS Naming Service

On Wed, Nov 13, 2013 at 10:50 AM, Peter Korsgaard <[email protected]>

Quoted 5 lines · wrote:
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas De Schampheleire

Quoted 3 lines · <[email protected]> writes:

Hi,

Quoted 7 lines
Quoted 7 lines
Quoted 5 lines

Yuk, that's a pity...
In this case my preference is to have the comment before the main option (so as close as possible), rather than after all sub options.

What is your opinion?

I don't have a stong opion about it, but that's fine by me as well.

For

Quoted 14 lines
Quoted 3 lines

simple packages (most), it imho is a bit more logical to have it after the option though (and it's what we are currently doing most places).

As long as there are no suboptions that is indeed more logical. However, when suboptions are added the comment moves down, and depending on where new suboptions are added this may not be apparent from the diff output alone. So one way is to use one 'rule' which would be the comment above, or we keep simple packages without suboptions with the comment below, and make sure the comment is moved to the top when suboptions are added. The first alternative is easier to maintain, but less beautiful for the simple packages without suboptions.

Quoted 2 lines

If I had to pick, I'd pick the first alternative, for easier maintainability and uniformity.

I agree, I would have liked to keep it right below the main option, but above is a reasonable location, since if it was placed below all suboptions I could see it get confusing.

Thanks,
Matt

Quoted 3 lines

Best regards,
Thomas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20131113/fa8f7234/attachment.html>

#9 lore raw

PATCH 1/1 omniorb: add COS Naming Service

In reply to Matt Weber
Quoted 31 lines · Matt Weber
---
  package/omniorb/Config.in  |    9 +++++++++
  package/omniorb/omniorb.mk |    8 ++++++++
  2 files changed, 17 insertions(+), 0 deletions(-)
package/omniorb/Config.in +9 -0
index 6326688..22527fc 100644
@@ -10,5 +10,14 @@ config BR2_PACKAGE_OMNIORB
 
  	  http://omniorb.sourceforge.net/
 
+if BR2_PACKAGE_OMNIORB
+
+config BR2_PACKAGE_OMNIORB_WITH_SERVICES
+        bool "COS Naming Service"
+        default y
+        help
+          omniORB COS Naming Service
+endif
+
  comment "omniORB needs a toolchain w/ C++"
  	depends on !BR2_INSTALL_LIBSTDCPP
package/omniorb/omniorb.mk +0 -0
index 490ff93..cad50f8 100644

package/omniorb/omniorb.mk OMNIORB_INSTALL_TARGET = YES · line 32

Quoted 9 lines
package/omniorb/omniorb.mk +6 -0
@@ -24,6 +24,14 @@ OMNIORB_INSTALL_TARGET = YES
  OMNIORB_CONF_OPT += --disable-longdouble
  HOST_OMNIORB_CONF_OPT += --disable-longdouble
 
+define OMNIORB_ENABLE_SERVICES
+	$(SED) 's:SUBDIRS += lib:SUBDIRS += lib services:g' $(@D)/src/dir.mk
+endef
+
+ifeq ($(BR2_PACKAGE_OMNIORB_WITH_SERVICES),y)
+	OMNIORB_POST_CONFIGURE_HOOKS += OMNIORB_ENABLE_SERVICES

We normally don't indent variable assignments within conditions (the
indentation of the sed statement is OK, because that's a shell command).

Also, wouldn't it be better to do this as post-patch hook?

Regards,
Arnout

Quoted 6 lines
package/omniorb/omniorb.mk +2 -0
+endif
+
  # omniORB is not completely cross-compile friendly and has some
  # assumptions where a couple host tools must be built and then
  # used by the target build.  The host tools generate code from
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#10 lore raw

PATCH 1/1 omniorb: add COS Naming Service

Arnout Vandecappelle <[email protected]> wrote on 11/12/2013 03:25:40 PM:

Quoted 8 lines

From: Arnout Vandecappelle <[email protected]>
To: Matt Weber <[email protected]>
Cc: buildroot at busybox.net
Date: 11/12/2013 03:25 PM
Subject: Re: [Buildroot] [PATCH 1/1] omniorb: add COS Naming Service

Quoted 1 line · Matt Weber

<snip>

Quoted 3 lines

Review

Quoted 3 lines
(quoted diff) +2 -0
+define OMNIORB_ENABLE_SERVICES
+   $(SED) 's:SUBDIRS += lib:SUBDIRS += lib services:g' 

$(@D)/src/dir.mk

Quoted 8 lines

package/omniorb/omniorb.mk OMNIORB_INSTALL_TARGET = YES · line 32

Quoted 4 lines
package/omniorb/omniorb.mk +4 -0
+endef
+
+ifeq ($(BR2_PACKAGE_OMNIORB_WITH_SERVICES),y)
+   OMNIORB_POST_CONFIGURE_HOOKS += OMNIORB_ENABLE_SERVICES

We normally don't indent variable assignments within conditions (the
indentation of the sed statement is OK, because that's a shell command).

Sure, I'll clean those up.

Quoted 1 line

Also, wouldn't it be better to do this as post-patch hook?

In this case, yes. The file is not modified during configure. I'll update.

Thanks!
Matt Weber
mlweber1 at rockwellcollins.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20131112/6e73bca7/attachment.html>

#11 lore raw

PATCH 1/1 omniorb: add COS Naming Service

In reply to Matt Weber

Dear Matt Weber,

Quoted 12 lines · Matt Weber
---
 package/omniorb/Config.in  |    9 +++++++++
 package/omniorb/omniorb.mk |    8 ++++++++
 2 files changed, 17 insertions(+), 0 deletions(-)
package/omniorb/Config.in +0 -0
index 6326688..22527fc 100644

package/omniorb/Config.in config BR2_PACKAGE_OMNIORB · line 19

Quoted 10 lines
package/omniorb/Config.in +7 -0
@@ -10,5 +10,14 @@ config BR2_PACKAGE_OMNIORB
 
 	  http://omniorb.sourceforge.net/
 
+if BR2_PACKAGE_OMNIORB
+
+config BR2_PACKAGE_OMNIORB_WITH_SERVICES
+        bool "COS Naming Service"
+        default y
+        help
+          omniORB COS Naming Service

Use tab for indentation (and one tab + two spaces for the help text).

package/omniorb/Config.in config BR2_PACKAGE_OMNIORB

Quoted 7 lines
package/omniorb/Config.in +7 -0
+define OMNIORB_ENABLE_SERVICES
+	$(SED) 's:SUBDIRS += lib:SUBDIRS += lib services:g' $(@D)/src/dir.mk
+endef
+
+ifeq ($(BR2_PACKAGE_OMNIORB_WITH_SERVICES),y)
+	OMNIORB_POST_CONFIGURE_HOOKS += OMNIORB_ENABLE_SERVICES
+endif

This is kind of weird, because the "services" directory is built in some condition:

ifndef EmbeddedSystem
SUBDIRS += appl services
endif

but you define EmbeddedSystem=1 in Buildroot:

echo "EmbeddedSystem=1" >> $(@D)/mk/beforeauto.mk

Is there a reason for defining EmbeddedSystem=1 ? The only difference will be that it's going to build the stuff in src/appl/, but looking at this directory, it doesn't seem like a huge amount of code compared to the overall size of omniORB.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#12 lore raw

PATCH 1/1 omniorb: add COS Naming Service

Thomas Petazzoni <[email protected]> wrote on 11/12/2013 03:54:56 PM:

Quoted 24 lines

From: Thomas Petazzoni <[email protected]>
To: Matt Weber <[email protected]>
Cc: buildroot at busybox.net
Date: 11/12/2013 03:55 PM
Subject: Re: [Buildroot] [PATCH 1/1] omniorb: add COS Naming Service

Dear Matt Weber,

Quoted 15 lines · Matt Weber
---
 package/omniorb/Config.in  |    9 +++++++++
 package/omniorb/omniorb.mk |    8 ++++++++
 2 files changed, 17 insertions(+), 0 deletions(-)
package/omniorb/Config.in +0 -0
index 6326688..22527fc 100644
@@ -10,5 +10,14 @@ config BR2_PACKAGE_OMNIORB
 
      http://omniorb.sourceforge.net/
 
Quoted 9 lines

package/omniorb/Config.in config BR2_PACKAGE_OMNIORB · line 19

Quoted 7 lines
package/omniorb/Config.in +7 -0
+if BR2_PACKAGE_OMNIORB
+
+config BR2_PACKAGE_OMNIORB_WITH_SERVICES
+        bool "COS Naming Service"
+        default y
+        help
+          omniORB COS Naming Service

Use tab for indentation (and one tab + two spaces for the help text).

Ack

Quoted 3 lines

package/omniorb/Config.in config BR2_PACKAGE_OMNIORB · line 21

Quoted 3 lines
package/omniorb/Config.in +2 -0
+define OMNIORB_ENABLE_SERVICES
+   $(SED) 's:SUBDIRS += lib:SUBDIRS += lib services:g' 

$(@D)/src/dir.mk

Quoted 13 lines

package/omniorb/Config.in config BR2_PACKAGE_OMNIORB

Quoted 5 lines
package/omniorb/Config.in +5 -0
+endef
+
+ifeq ($(BR2_PACKAGE_OMNIORB_WITH_SERVICES),y)
+   OMNIORB_POST_CONFIGURE_HOOKS += OMNIORB_ENABLE_SERVICES
+endif

This is kind of weird, because the "services" directory is built in some condition:

ifndef EmbeddedSystem
SUBDIRS += appl services
endif

Quoted 8 lines

but you define EmbeddedSystem=1 in Buildroot:

echo "EmbeddedSystem=1" >> $(@D)/mk/beforeauto.mk

Is there a reason for defining EmbeddedSystem=1 ? The only difference will be that it's going to build the stuff in src/appl/, but looking at this directory, it doesn't seem like a huge amount of code compared to the overall size of omniORB.

Yeah, the EmbeddedSystems option trims down the build and doesn't build a bunch of host tools, extra libs, and apps that aren't required on the target.
So for majority of the configuration it seems like the best option (used to trim
down src/, src/lib, src/lib/omniORB). It also removed the example apps that
don't cross-compile...
So to add this option we just added back in the COS Naming service as an option instead of doing a complete build to get the app/lib.

Thanks,
Matt
mlweber1 at rockwellcollins.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20131112/8f17f651/attachment.html>